From 833e246f8aabffd8ee02faa290dca180eab92ba3 Mon Sep 17 00:00:00 2001 From: Sarbbottam Bandyopadhyay Date: Wed, 11 May 2016 10:40:05 -0700 Subject: [PATCH] fix(a11y): using button instead of div div can be styled to look like a button, but it does not behave as a button semantically --- server/views/challenges/showStep.jade | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/views/challenges/showStep.jade b/server/views/challenges/showStep.jade index d276c836c82..732c0fb988e 100644 --- a/server/views/challenges/showStep.jade +++ b/server/views/challenges/showStep.jade @@ -19,12 +19,12 @@ block content if index === 0 .col-sm-4.hidden-xs   else - .btn.btn-primary.btn-primary-ghost.col-sm-4.col-xs-12.challenge-step-btn-prev.btn-lg(id='#{index - 1}') Go to my previous step + button.btn.btn-primary.btn-primary-ghost.col-sm-4.col-xs-12.challenge-step-btn-prev.btn-lg(id='#{index - 1}') Go to my previous step .challenge-step-counter.large-p.col-sm-4.col-xs-12.text-center (#{index + 1} / #{description.length}) if index + 1 === description.length - .btn.btn-primary.col-sm-4.col-xs-12.challenge-step-btn-finish.btn-lg(id='last' class=step[3] && !isCompleted ? 'disabled' : '') Finish challenge + button.btn.btn-primary.col-sm-4.col-xs-12.challenge-step-btn-finish.btn-lg(id='last' class=step[3] && !isCompleted ? 'disabled' : '') Finish challenge else - .btn.btn-primary.col-sm-4.col-xs-12.challenge-step-btn-next.btn-lg(id='#{index}' class=step[3] && !isCompleted ? 'disabled' : '') Go to my next step + button.btn.btn-primary.col-sm-4.col-xs-12.challenge-step-btn-next.btn-lg(id='#{index}' class=step[3] && !isCompleted ? 'disabled' : '') Go to my next step .clearfix .spacer #challenge-step-modal.modal(tabindex='-1')