Move event method calls out of action creator

pull/7430/head
Berkeley Martinez 2016-06-04 21:37:11 -07:00
parent 3086e27681
commit 7c2053f139
2 changed files with 14 additions and 14 deletions

View File

@ -67,7 +67,12 @@ export default class extends React.Component {
eventKey={ 1 }
to='/map'>
<NavItem
onClick={ toggleMapDrawer }
onClick={ e => {
if (!(e.ctrlKey || e.metaKey)) {
e.preventDefault();
toggleMapDrawer();
}
}}
target='/map'
>
Map
@ -81,7 +86,12 @@ export default class extends React.Component {
<NavItem
eventKey={ 2 }
href='//gitter.im/freecodecamp/freecodecamp'
onClick={ toggleMainChat }
onClick={ e => {
if (!(e.ctrlKey || e.metaKey)) {
e.preventDefault();
toggleMainChat();
}
}}
target='_blank'
>
Chat

View File

@ -49,18 +49,8 @@ export const createErrorObservable = error => Observable.just({
// drawers
export const toggleMapDrawer = createAction(
types.toggleMapDrawer,
e => e.preventDefault()
);
export const toggleMapDrawer = createAction(types.toggleMapDrawer);
export const toggleWikiDrawer = createAction(types.toggleWikiDrawer);
// chat
export const toggleMainChat = createAction(
types.toggleMainChat,
e => {
if (!(e.ctrlKey || e.metaKey)) {
e.preventDefault();
}
}
);
export const toggleMainChat = createAction(types.toggleMainChat);