greatbody
/
freeCodeCamp
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Revert "feat(client): add linkedIn credential id to share btn (#54346)" (#54373)

pull/54294/head
Oliver Eyton-Williams 2024-04-12 15:11:55 +02:00 committed by GitHub
parent 559626814e
commit 83d739951b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 5 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
client/src/client-only-routes/show-certification.tsx
View File

@ -35,10 +35,8 @@ import {
import { PaymentContext } from '../../../shared/config/donation-settings';
import ribbon from '../assets/images/ribbon.svg';
import {
CertSlug,
certTypes,
certTypeTitleMap,
linkedInCredentialIds
certTypeTitleMap
} from '../../../shared/config/certification-settings';
import MultiTierDonationForm from '../components/Donation/multi-tier-donation-form';
import callGA from '../analytics/call-ga';
@ -50,7 +48,7 @@ const localeCode = getLangCode(clientLocale);
type Cert = {
username: string;
name: string;
certSlug: CertSlug;
certName: string;
certTitle: string;
completionTime: number;
date: number;
@ -220,7 +218,6 @@ const ShowCertification = (props: ShowCertificationProps): JSX.Element => {
name: userFullName = null,
username,
certTitle,
certSlug,
completionTime
} = cert;
@ -289,7 +286,6 @@ const ShowCertification = (props: ShowCertificationProps): JSX.Element => {
);
const urlFriendlyCertTitle = encodeURIComponent(certTitle);
const linkedInCredentialId = `${username}-${linkedInCredentialIds[certSlug]}`;
const shareCertBtns = (
<Row className='text-center'>
@ -300,7 +296,7 @@ const ShowCertification = (props: ShowCertificationProps): JSX.Element => {
variant='primary'
href={`https://www.linkedin.com/profile/add?startTask=CERTIFICATION_NAME&name=${urlFriendlyCertTitle}&organizationId=4831032&issueYear=${certYear}&issueMonth=${
certMonth + 1
}&certUrl=${certURL}&certId=${linkedInCredentialId}`}
}&certUrl=${certURL}`}
target='_blank'
data-playwright-test-label='linkedin-share-btn'
>

4
e2e/certification.spec.ts
View File

@ -55,7 +55,7 @@ test.describe('Certification page - Non Microsoft', () => {
await expect(linkedinLink).toBeVisible();
await expect(linkedinLink).toHaveAttribute(
'href',
`https://www.linkedin.com/profile/add?startTask=CERTIFICATION_NAME&name=Responsive%20Web%20Design&organizationId=4831032&issueYear=2018&issueMonth=8&certUrl=https://freecodecamp.org/certification/certifieduser/responsive-web-design&certId=certifieduser-rwd`
`https://www.linkedin.com/profile/add?startTask=CERTIFICATION_NAME&name=Responsive%20Web%20Design&organizationId=4831032&issueYear=2018&issueMonth=8&certUrl=https://freecodecamp.org/certification/certifieduser/responsive-web-design`
);
const twitterLink = certLink.getByTestId('twitter-share-btn');
@ -191,7 +191,7 @@ test.describe('Certification page - Microsoft', () => {
await expect(linkedinLink).toBeVisible();
await expect(linkedinLink).toHaveAttribute(
'href',
'https://www.linkedin.com/profile/add?startTask=CERTIFICATION_NAME&name=Foundational%20C%23%20with%20Microsoft&organizationId=4831032&issueYear=2023&issueMonth=9&certUrl=https://freecodecamp.org/certification/certifieduser/foundational-c-sharp-with-microsoft&certId=certifieduser-fcswm'
'https://www.linkedin.com/profile/add?startTask=CERTIFICATION_NAME&name=Foundational%20C%23%20with%20Microsoft&organizationId=4831032&issueYear=2023&issueMonth=9&certUrl=https://freecodecamp.org/certification/certifieduser/foundational-c-sharp-with-microsoft'
);
const twitterLink = certLink.getByTestId('twitter-share-btn');

10
shared/config/certification-settings.test.ts
View File

@ -1,10 +0,0 @@
import { Certification, linkedInCredentialIds } from './certification-settings';
describe('linkedInCredentialIds', () => {
it('should contain a value for all certifications', () => {
const allCertifications = Object.values(Certification).sort();
const linkedInCredentialIdsKeys = Object.keys(linkedInCredentialIds).sort();
expect(linkedInCredentialIdsKeys).toEqual(allCertifications);
});
});

26
shared/config/certification-settings.ts
View File

@ -255,30 +255,4 @@ export const certTypeTitleMap = {
'JavaScript Algorithms and Data Structures (Beta)'
};
export type CertSlug = (typeof Certification)[keyof typeof Certification];
export const linkedInCredentialIds = {
[Certification.LegacyFrontEnd]: 'lfe',
[Certification.LegacyBackEnd]: 'lbe',
[Certification.LegacyDataVis]: 'ldv',
[Certification.LegacyInfoSecQa]: 'lisaqa',
[Certification.LegacyFullStack]: 'lfs',
[Certification.RespWebDesign]: 'rwd',
[Certification.FrontEndDevLibs]: 'fedl',
[Certification.JsAlgoDataStruct]: 'ljaads',
[Certification.DataVis]: 'dv',
[Certification.BackEndDevApis]: 'bedaa',
[Certification.QualityAssurance]: 'qa',
[Certification.InfoSec]: 'is',
[Certification.SciCompPy]: 'scwp',
[Certification.DataAnalysisPy]: 'dawp',
[Certification.MachineLearningPy]: 'mlwp',
[Certification.RelationalDb]: 'rd',
[Certification.CollegeAlgebraPy]: 'cawp',
[Certification.FoundationalCSharp]: 'fcswm',
[Certification.UpcomingPython]: 'up',
[Certification.JsAlgoDataStructNew]: 'jaads',
[Certification.A2English]: 'a2efd'
};
export const oldDataVizId = '561add10cb82ac38a17513b3';