From 19c24083488a4232e21cab0759f627f3e98d823e Mon Sep 17 00:00:00 2001 From: biellls Date: Mon, 27 Jul 2015 20:37:39 +0200 Subject: [PATCH 1/6] Change order of subarrays to cover all cases Since in all tests each subarray has a larger max than the previous subarray, if the user does not reset max for each subarray, the tests still pass. --- seed/challenges/basic-bonfires.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/seed/challenges/basic-bonfires.json b/seed/challenges/basic-bonfires.json index b2a49c8ce3c..aae7c5ad2ea 100644 --- a/seed/challenges/basic-bonfires.json +++ b/seed/challenges/basic-bonfires.json @@ -308,7 +308,7 @@ ], "tests": [ "expect(largestOfFour([[4, 5, 1, 3], [13, 27, 18, 26], [32, 35, 37, 39], [1000, 1001, 857, 1]])).to.be.a('array');", - "(largestOfFour([[4, 5, 1, 3], [13, 27, 18, 26], [32, 35, 37, 39], [1000, 1001, 857, 1]])).should.eql([5,27,39,1001]);", + "(largestOfFour([[13, 27, 18, 26], [4, 5, 1, 3], [32, 35, 37, 39], [1000, 1001, 857, 1]])).should.eql([27,5,39,1001]);", "assert(largestOfFour([[4, 9, 1, 3], [13, 35, 18, 26], [32, 35, 97, 39], [1000000, 1001, 857, 1]]).should.eql([9,35,97,1000000]));" ], "MDNlinks": [ From e67d843f48bffeb3e0559932ec0f2ea38043708a Mon Sep 17 00:00:00 2001 From: TCYRUS Date: Tue, 28 Jul 2015 13:17:05 -0400 Subject: [PATCH 2/6] Fix Issue #1015 Fix two of the tests in "Waypoint: Create an Ordered List" --- seed/challenges/html5-and-css.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/seed/challenges/html5-and-css.json b/seed/challenges/html5-and-css.json index dbb0f037fef..70dbddd5c4c 100644 --- a/seed/challenges/html5-and-css.json +++ b/seed/challenges/html5-and-css.json @@ -1478,8 +1478,8 @@ "tests": [ "assert($('ul').length > 0, 'You should have an ul element on your page.')", "assert($('ol').length > 0, 'You should have an ol element on your page.')", - "assert($('li').length > 5, 'You should have three li elements within your ul element.')", - "assert($('li').length > 5, 'You should have three li elements within your ol element.')", + "assert($('ul li').length > 5, 'You should have three li elements within your ul element.')", + "assert($('ol li').length > 5, 'You should have three li elements within your ol element.')", "assert(editor.match(/<\\/ul>/g) && editor.match(/<\\/ul>/g).length === editor.match(/