fix: Decode HTML entities in the test output (#111)

pull/18188/head
Todd Chaffee 2018-06-18 10:45:22 -03:00 committed by Mrugesh Mohapatra
parent caf85cc353
commit 8de3a4c766
2 changed files with 30 additions and 1 deletions

View File

@ -32,6 +32,8 @@ import {
import './classic.css'; import './classic.css';
import decodeHTMLEntities from '../../../../utils/decodeHTMLEntities';
const mapStateToProps = createSelector( const mapStateToProps = createSelector(
challengeFilesSelector, challengeFilesSelector,
challengeTestsSelector, challengeTestsSelector,
@ -200,7 +202,7 @@ class ShowClassic extends PureComponent {
* Your test output will go here. * Your test output will go here.
*/ */
`} `}
output={output} output={decodeHTMLEntities(output)}
/> />
</ReflexElement> </ReflexElement>
) : null} ) : null}

View File

@ -0,0 +1,27 @@
/*
* Converts HTML entity codes in a string to the characters they represent.
*
* Example:
* `decodeHTMLEntities('Beets &amp; carrots');`
* will return "Beets & carrots".
*
* The regex makes sure we only replace the HTML entities in the string.
* For example, the regex would match "&lt;" as well as "&#58;".
* The decoding works by setting the innerHTML of a dummy element and then
* retrieving the innerText. Per the spec, innerText is a property that
* represents the "rendered" text content of an element.
*
* See:
* https://developer.mozilla.org/en-US/docs/Web/API/Node/innerText
* https://developer.mozilla.org/en-US/docs/Glossary/Entity
*
*/
const decodeHTMLEntities = str => {
const el = document.createElement('div');
return str.replace(/\&[#0-9a-z]+;/gi, enc => {
el.innerHTML = enc;
return el.innerText;
});
};
export default decodeHTMLEntities;