greatbody
/
freeCodeCamp
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: correct cert date for legacy data visualization (#35728) 

Closes #34890
Closes #17424
pull/35741/head
Ahmad Abdolsaheb 2019-04-02 21:04:14 +03:00 committed by mrugesh mohapatra
parent e5d0597f3e
commit b4d3e6d6bb
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
api-server/server/boot/certificate.js
View File

@ -430,8 +430,25 @@ function createShowCert(app) {
if (user[certType]) {
const { completedChallenges = [] } = user;
const { completedDate = new Date() } =
_.find(completedChallenges, ({ id }) => certId === id) || {};
const certChallenge = _.find(
completedChallenges,
({ id }) => certId === id
);
let { completedDate = new Date() } = certChallenge || {};
// the challange id has been rotated for isDataVisCert
// so we need to check for id 561add10cb82ac38a17513b3
if (certType === 'isDataVisCert' && !certChallenge) {
console.log('olderId');
let oldDataVisIdChall = _.find(
completedChallenges,
({ id }) => '561add10cb82ac38a17513b3' === id
);
if (oldDataVisIdChall) {
completedDate = oldDataVisIdChall.completedDate || completedDate;
}
}
const { username, name } = user;
return res.json({