greatbody
/
freeCodeCamp
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #12152 from FlameFractal/fix/contributing-doc 

Add instructions in Contributing to not put issue # in commit msgs
pull/12156/head
Dylan 2016-12-21 09:20:44 -06:00 committed by GitHub
parent c5c4f6b5e6 b26f11fc67
commit c4a3164d10
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CONTRIBUTING.md
View File

@ -319,7 +319,7 @@ nothing to commit, working directory clean
add .` to add all unstaged files. Take care, though, because you can add .` to add all unstaged files. Take care, though, because you can
accidentally add files you don't want added. Review your `git status` first. accidentally add files you don't want added. Review your `git status` first.
6. Commit your edits: `git commit -m "Brief Description of Commit"` 6. Commit your edits: `git commit -m "Brief Description of Commit"`. Do not add the issue number in the commit message.
7. Squash your commits, if there are more than one. 7. Squash your commits, if there are more than one.
@ -352,7 +352,7 @@ for further information
4. The title (also called the subject) of your PR should be descriptive of your 4. The title (also called the subject) of your PR should be descriptive of your
changes and succinctly indicates what is being fixed. changes and succinctly indicates what is being fixed.
- **Do not add the issue number in the PR title**. - **Do not add the issue number in the PR title or commit message.**
- Examples: `Add Test Cases to Bonfire Drop It` `Correct typo in Waypoint - Examples: `Add Test Cases to Bonfire Drop It` `Correct typo in Waypoint
Size Your Images` Size Your Images`