greatbody
/
freeCodeCamp
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Prevent scrolling on initial challenge run 

- Add additional parameter to function displayTestResults

Correction to errors: Line exceeds the maximum line length of 80   max-len

Do not scroll on JS challenges
pull/9258/head
HelderSepu 2016-06-20 22:05:15 -04:00
parent b4cf1037d5
commit e6542fa00e
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
client/commonFramework/display-test-results.js
View File

@ -1,6 +1,6 @@
window.common = (function({ $, common = { init: [] }}) {
common.displayTestResults = function displayTestResults(data = []) {
common.displayTestResults = function displayTestResults(data = [], down) {
$('#testSuite').children().remove();
$('#testSuite').fadeIn('slow');
data.forEach(({ err = false, text = '' }) => {
@ -21,7 +21,11 @@ window.common = (function({ $, common = { init: [] }}) {
`)
.appendTo($('#testSuite'));
});
$('#scroll-locker').animate({ scrollTop: $(document).height() }, 'slow');
if (down) {
$('#scroll-locker').animate(
{ scrollTop: $(document).height() }, 'slow'
);
}
return data;
};

6
client/commonFramework/end.js
View File

@ -110,7 +110,7 @@ $(document).ready(function() {
return common.updateOutputDisplay('' + err);
}
common.updateOutputDisplay(output);
common.displayTestResults(tests);
common.displayTestResults(tests, true);
if (solved) {
common.showCompletion();
}
@ -140,7 +140,7 @@ $(document).ready(function() {
}
return common.updateOutputDisplay('' + err);
}
common.displayTestResults(tests);
common.displayTestResults(tests, false);
return null;
},
({ err }) => {
@ -164,7 +164,7 @@ $(document).ready(function() {
return common.updateOutputDisplay('' + err);
}
common.codeStorage.updateStorage(challengeName, originalCode);
common.displayTestResults(tests);
common.displayTestResults(tests, false);
return null;
},
(err) => {