Commit Graph

25 Commits (0073a15455d38109ea4602fc6aa9a9d1d69a9309)

Author SHA1 Message Date
Oliver Eyton-Williams e118dda13a
fix: order imports and remove circular dependencies (#41824)
* fix: remove circular dependency

redux depended on templates/Challenges/redux and vice versa.  This
meant that import order mattered and confusing bugs could arise.

(cherry picked from commit 7d67a4e70922bbb3051f2f9982dcc69e240d43dc)

* feat: require imports to be in alphabetical order

Import order generally does not matter, but there are edge cases
(circular  imports and css imports, for example) where changing order
changes behaviour

(cherry picked from commit b8d1393a91ec6e068caf8e8498a5c95df68c2b2c)

* chore: order imports

* fix: lift up challenge description + title comps

This brings the classic Show closer to the others as they
now all create the description and title components

* fix: remove donation-saga/index circular import

(cherry picked from commit 51a44ca668a700786d2744feffeae4fdba5fd207)

* refactor: extract action-types from settings

(cherry picked from commit 25e26124d691c84a0d0827d41dafb761c686fadd)

* fix: lint errors

* feat: prevent useless renames
2021-08-02 08:39:40 -05:00
Oliver Eyton-Williams 1ba9d03cb5
feat: remove csrf from the client (#42242) 2021-07-16 10:49:47 -05:00
ABHINAV SHARMA e2ca65c803
feat(client): ts-migrate layoutSelector component (#42748) 2021-07-12 14:05:01 +07:00
ABHINAV SHARMA 4f179ec8e1
feat(client) ts-migrate AppMountNotifier Component (#42585)
* feat(client) Renamed AppMountNotifier.js to app-mount-notifier.tsx

* feat(client) ts-migrate AppMountNotifier Component

* remove type package from root

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-06-30 20:50:56 +05:30
Mrugesh Mohapatra 83943de719
chore: rollback CSRF token generation (#42082)
This reverts commit e1c00138a9.
2021-05-11 00:27:08 +05:30
Oliver Eyton-Williams e1c00138a9
fix: generate csrf tokens on server (#41968)
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2021-05-10 21:40:42 +05:30
Tom 3978c6be28 feat: i18n user interface (#40306)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-01-31 12:15:32 +05:30
Ahmad Abdolsaheb 09eebd8598 fix: save the fonts locally 2019-10-16 19:29:48 +09:00
Ahmad Abdolsaheb e6d55fd086 feat: add fonts locally 2019-10-14 20:31:58 +09:00
Bouncey 15f18d1cda fix: Dedupe layout selection logic 2019-06-08 03:16:28 +05:30
Oliver Eyton-Williams 1e1cbdfe06 fix(client): Remove redundant prop and allow navigationMenu to be und… (#36134) 2019-05-26 22:28:40 +03:00
Oliver Eyton-Williams 17e112d25e fix(client): make top navigation menu replaceable (#35943)
* fix(client): Stop using react-responsive and use media queries to display menu

* Change guide to show menu

* DRYed out a bit

* Restore main, top-right nav to guide

* fix: Separate guide and top menu state

* Update client/src/components/Header/index.js

Co-Authored-By: Valeriy <ValeraS@users.noreply.github.com>

* Update client/src/components/Header/index.js

Co-Authored-By: Valeriy <ValeraS@users.noreply.github.com>

* Update client/src/components/Header/index.js

Co-Authored-By: Valeriy <ValeraS@users.noreply.github.com>

* Update client/src/components/Header/index.js

Co-Authored-By: Valeriy <ValeraS@users.noreply.github.com>

* fix: Refactor menu button and links

* feat(client): make top navigation menu replaceable

* fix: Refactor nav menu logic out of Header

* fix(client): use default nav menu in header and use landingPage props instead of disableSettings
2019-05-26 20:36:23 +03:00
Valeriy 4994cd828e fix(ui): top nav menu behavior on guide 2019-03-14 19:06:18 +05:30
Valeriy 3a2db4744d fix(client): disable core prefetching due to scrolling performance in the map (#35512)
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.

Closes #35418

It disables only prefetching on link become visible, other prefetching strategies like prefetching on link hover still work.
2019-03-06 12:30:19 +05:30
Ahmad Abdolsaheb b5b3482d0e fix: wire menu to redux and add change meanu breakpoint for guide 2019-03-01 13:02:29 +00:00
Ahmad Abdolsaheb 357b824033 fix: custom menu for guide 2019-03-01 13:02:29 +00:00
mrugesh mohapatra 293e58cc23 fix(certs): remove footer and nav from certs (#35333)
* fix(certs): remove footer and nav from certs

* fix: revert spacing on cert
2019-02-22 18:06:47 +03:00
Valeriy fc8c71ad16 feat: use eslint with prettier to format code 2019-02-19 14:30:27 +05:30
Valeriy 1a889d9f3f fix(footer): change nonLearnPage to showFooter 2019-02-18 14:39:56 +00:00
Mrugesh Mohapatra 71cf52144e fix(footer): show only on non-learn pages 2019-02-18 14:39:56 +00:00
Valeriy a44935a520 fix(client): do not unmount Guide Layout on navigate 2019-01-28 12:02:45 +00:00
Valeriy 28ee458ceb fix(client): do not unmount default layout on navigate 2019-01-28 12:02:45 +00:00
Stuart Taylor 7da04a348b fix: Update packages and fix local dev (#26907)
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
2018-10-23 18:48:46 +05:30
Bouncey 6e728ce16d feat(guide): Import guide in to the client app 2018-10-05 15:58:12 +01:00
Bouncey e59ad6ebda chore(client): Move client app to /client 2018-09-03 17:47:48 +05:30