Commit Graph

603 Commits (01b8030bbe51b954d55c2d5260ebca0402adac51)

Author SHA1 Message Date
Carlos Pulido e7718db53e Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.spanish.md (#31200) 2019-02-23 23:49:23 +01:00
Chad a288e1d71a Correct footer and header order description (#34473)
* Correct test text

Header & footer swapped to refer to top and bottom respectively

* line 24 "footer and header" to "header and footer"
2019-02-22 11:30:33 -08:00
Randell Dawson bc99876f9e [Fix] allow line breaks between method calls for several Data Visualization challenges (#35093)
* fix: allow spaces between lines breaks a function arguments

* fix: allow line breaks between method calls
2019-02-22 12:18:10 -07:00
Octabond 603585e39e Update tests and challenge seeds (#25588)
Update tests and challenge seeds with spanish instructions
2019-02-22 20:05:09 +01:00
Lewis Horwood 9cf283aab9 Add tests reflecting #19390 (#19477)
* Add test reflecting #19390

Added two tests to prevent checking only `Alan`.

* Split into 4 tests for each prop

Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace
2019-02-23 00:16:06 +05:30
Beau Carnes 2bb171ef30 fix: update color hex values and description of orange (#35316)
* fix: update color hex values and description of orange

* fix: Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/learn-about-tertiary-colors.english.md

Co-Authored-By: beaucarnes <beaucarnes@gmail.com>

* fix: add test that no color names are used
2019-02-22 10:37:57 -08:00
Ignacio Garcia a21e287b00 Translated commented section of Solución (#22746) 2019-02-22 18:48:57 +01:00
Rodolfo b032399525 Update create-a-bulleted-unordered-list.spanish.md (#22712)
Added a "de" connector to correct translation
2019-02-22 18:44:56 +01:00
Rodolfo 1d1064c83b Update check-radio-buttons-and-checkboxes-by-default.spanish.md (#22710)
Removed instance of snippet that was present 2 consecutive times in a sentence (and in the english version is only one time)
2019-02-22 18:44:15 +01:00
Rodolfo 8a2481282e Update add-placeholder-text-to-a-text-field.spanish.md (#22704)
Removed instance of snippet that was present 2 consecutive times in a sentence (and in the english version is only one time)
2019-02-22 18:42:44 +01:00
TristanSeabrook ce2b46926f removed ungrammatical apostrophe (#35355)
changed "it's" to "its"
2019-02-22 03:14:30 -08:00
TristanSeabrook d8c8ee73a3 added apostrophe (#35354)
changed "keys" to "key's"
2019-02-22 03:12:23 -08:00
TristanSeabrook 7d9ef880c2 removed ungrammatical apostrophe (#35353)
Changed "array's" to "arrays".
2019-02-22 03:12:12 -08:00
Randell Dawson 37aa3172ea fix: added missing &amp; in text of tests (#35341) 2019-02-22 00:28:05 -05:00
Almaz Kunpeissov 4a7571492d #35176 Remove reference to "backspace" regex (#35186)
Remove reference to "backspace" regex in example #35176
2019-02-22 10:50:51 +08:00
Niraj Nandish cb35d49a21 fix(challenges): Fix broken links in English challenges (#35125) 2019-02-21 17:58:31 -05:00
Fordco 63c5423e4a fix(curriculum): iterate with javascript do...while loops (#35214) 2019-02-21 17:25:54 -05:00
olga1blinova 3b6f0f8ef4 Translation improvements. (#28491) 2019-02-21 15:22:42 +04:00
Theodoros Gkortsilas a17b123510 Added curly brackets to comment in JSX element (#34694)
Added curly brackets to comment in JSX element to hide it from the rendered DOM
2019-02-21 03:24:27 -05:00
rupali317 5f6595b7dc fix: use correct variables for challenge (#34935)
Deleted the sentence which refers a.start.x as an object, as it is not an
object
2019-02-20 22:00:21 -08:00
Lee 6e44ec362c ADD: transform affects DIV child contents (#35257)
* ADD: transform affects DIV child contents

After spending some time figuring out how to prevent text in a div being skewed as well as the div, I think it is worth mentioning that applying a transform to a div element will also affect elements contained inside of it. Perhaps the transform challenge pages could include how to negate the effects of the transform on child elements of divs.

* Fix: moved my commit to Description 

Moved my commit text into the Description section as suggested.

* Fix: Changed </div> to </code>

Changed the closing </div> tag to </code> as suggested.

* Fix: Changed markdown ** to <strong>

As advised on a previous pull request, I have removed the markdown ** ** and replaced it with HTML <strong></strong>.
2019-02-20 20:25:16 -08:00
Breno Xavier acab326f8a Fix text to follow portuguese language syntax (#19077)
Change the positions of some words to be in accordance with the syntax rules of the Portuguese language.
2019-02-20 11:14:53 -03:00
Andrey Leontev e68e75639c fix syntax and lexical errors in ES6 1-4 les (#26726)
* fix syntax and lexical errors

* fix syntax errors  in Create an Export Fallback

* fix syntax and lexical errors in Template Literals

* fix syntax and lexical errors in es6 const declare

* Improved 'Russian' translation
2019-02-20 12:56:36 +04:00
Lee 551c97feb1 Update: Added info re uppercase and lowercase (#35094)
* Update: Added info re uppercase and lowercase

Included information to explain that lowercase and camelCase can be used for const identifiers.

* Fix: corrected mutable to immutable

I corrected the error that uppercase is used for mutable values.

* Fix: changed ** ** to <strong></strong>

I changed the markdown **  ** to <strong></strong>, as I was informed that ** didin't work.
2019-02-19 23:12:46 -05:00
Aditya 46be1e2ed1 fix: React: Give Sibling Elements a Unique Key Attribute (#34648)
* feat: added additional test

Added additional test, formatted description and updated instructions and solution

* fix: removed unnecessary linebreaks
2019-02-19 14:29:06 -05:00
Aravind V. Nair 35b0bd8fdd chore: normalize freeCodeCamp in english (#35258)
Co-authored-by: The Coding Aviator <34807532+thecodingaviator@users.noreply.github.com>
Co-authored-by: mrugesh mohapatra <1884376+raisedadead@users.noreply.github.com>
2019-02-19 15:19:49 +05:30
Valeriy fc8c71ad16 feat: use eslint with prettier to format code 2019-02-19 14:30:27 +05:30
Valeriy be36915605 feat: use prettier with eslint 2019-02-19 14:30:27 +05:30
Bouncey b13e5fb41a feat: Use prettier-eslint to format code 2019-02-19 14:30:27 +05:30
Bouncey 1ba67c4e2b chore: Clean up linting from child package.json's 2019-02-19 14:30:27 +05:30
Bouncey 74e6e6ffc1 chore: Apply linting fixes 2019-02-19 14:30:27 +05:30
Bouncey 25fd85b321 chore: Remove unrequired files/deps/scripts 2019-02-19 14:30:27 +05:30
Randell Dawson 772d775fe3 fix: removed guideUrl from frontmatter non-English 2019-02-19 11:34:27 +03:00
Randell Dawson aa621a20b5 fix: removed unecessary guideUrl from frontmatter 2019-02-19 11:34:27 +03:00
Misha Fabrikov c9ba864d58 Improved translation (#28107) 2019-02-18 20:47:55 +04:00
Misha Fabrikov dbc4e478cf Improved Russian translation (#28101) 2019-02-18 15:43:03 +04:00
Kamirush 3fe8d733d2 Fixing of translation (#27459) 2019-02-18 15:41:39 +04:00
Dana Ottaviani 9562bf0baa Solution to implementing an accessible date picker (#35262)
* feat: add challenge solution

* fix: remove whitespace and filler comments
2019-02-17 17:25:41 -08:00
Aditi Joshi 2e388035ca Fix/update challenges for basic html and html5 (#35234)
* fix: challenge for basic html and html5 - test

* Delete use-if-and-else-to-add-logic-to-your-styles.english.md

* fix: Resolving merge conflict

* fix: basic-html-and html5 challenge - test
2019-02-18 01:49:21 +05:30
Riyaad Azad 2f27b6e687 Fix typo in description (#34413)
Change "giving" in the Description section to "given"
2019-02-18 00:53:36 +05:30
The Coding Aviator 54264157ee Added more clarification on how to use z-index (#34934)
* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md

* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md

* Update change-the-position-of-overlapping-elements-with-the-z-index-property.english.md
2019-02-18 00:46:14 +05:30
kevindelsh 93c8badfeb Minor rephrasing of the lesson's description (#34787)
* Minor rephrasing of the lesson's description

Since we already said in the last lesson that bootstraps col-xs-* classes can be used on all form elements it sounds silly to repeat the exact same phrase in this lesson too.

* Corrections to conform to style guide

1- Changed use of passive voice to active voice.
2- Changed use of first person to second person.

* Moved challenge instruction to Instructions section
2019-02-18 00:43:47 +05:30
Diego Arias García 02a20f4a62 Fixed Grammar Errors (#22635) 2019-02-17 19:34:52 +01:00
Jaka Kranjc daa7489b88
build-a-light-bright-app.spanish.md: spanish revision (#35263) 2019-02-17 19:33:22 +01:00
Bannon Tanner 4734ff4154 nest anchor within paragraph instructions modification (#26441)
* modified wording to be more clear

wording on challenge instructions may have been unclear to some campers
changes "your" to "the" existing <code>a</code> element to make it more clear

* fix: removed change not needed
2019-02-17 23:54:13 +05:30
Aashis kumar 80d66a9808 Update check-for-all-or-none.english.md (#34758)
Added Solution to the problem Change the regex favRegex to match both the American English (favorite) and the British English (favourite) version of the word.
2019-02-17 11:44:19 -05:00
Nelson Wu 6128976cc5 Added a solution to fix stub (#34813)
I am brand new to FCC and contributing on Github. I read the guide from FCC on best contributing practices, but this is all still very overwhelming to me.  If I did something incorrectly in my first attempt at a pull request, please let me know.
2019-02-17 11:41:48 -05:00
Gökhan Gurbetoğlu 16eb18954e Small change: remove unintentional whitespace (#34418)
On other challenges, only the affected places would have a placeholder whitespace, if there is one. Removed the unnecessary ones from this challenge.
2019-02-17 04:52:52 -05:00
Melkisedek Hamakali a0c00de32b Use correct spelling of navigable (#34817) 2019-02-17 01:52:19 -08:00
Almaz Kunpeissov 79af29dd2b Adding code styling to property value. (#34463)
Adding <code> styling for property value infinite in the ## Instructions.
2019-02-16 22:02:33 -08:00