Commit Graph

241 Commits (0551a6a57f043ed9157eb5018fdbfda79e1eb407)

Author SHA1 Message Date
Omar Dabour b59f72961f Fix Typo (#37557) 2019-10-26 16:48:06 -04:00
burrowsdt dd8168133f Added escape characters to the javascript comment curriculum (#37518) 2019-10-25 13:41:42 -05:00
Chayanon Tonsai 8b082995b5 Change test method from string.test(regex) to regex.test(string) (#37458) 2019-10-23 09:32:17 -05:00
Tom 69d4d4fe2f fix: recursion test (#37419)
* fix(challenge): recursion test

* fix(challenge): replace regex s flag with g
2019-10-23 00:18:40 +05:30
shrobbins a13bb1b96f fix: missing semi-colon (#37454) 2019-10-21 20:50:51 -04:00
nemogoc 23a3287d8f update test wording for undefined fn returns (#36804)
* update test wording for undefined fn returns, bring code out of after test section and check that the function does what it says it does (rather than just checking the result), update seed, example, and solution
2019-10-08 19:16:36 +09:00
Randell Dawson 8225ce7572 fix: added 3 new tests to mutations challenge (#36857) 2019-09-30 16:33:57 -04:00
Ent Wickler d08f009bd1 fix(curriculum): Add tests for setter, getter and setting a temperature (es6 tests) (#36620)
* add testing for setter, getter and setting a temperature according to some of feedbacks into the issues 17403

* bugfix: temperature is not a function
2019-09-23 17:13:32 +02:00
Jasper Pilgrim 191f915e94 fix(curriculum): grammar, add period (#36785) 2019-09-12 18:48:28 +05:30
Huyen Nguyen 087640d020 fix(curriculum): Make challenge instruction clearer (#36771) 2019-09-11 14:18:28 +05:30
Tom 91dc86fbf0 fix(curriculum): update debugging challenge (fcc vs browser console) (#36703)
* fix: debugging-challege+difference-in-consoles

* fix: grammar

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix/remove-comments-for-first-test
2019-08-30 15:31:57 -07:00
Sahil Bondre 335600d91c fix: change the explanation of splice function (#36721) 2019-08-30 13:59:56 +02:00
Tom 07b38d02b3 fix(challenge-test): make semi-colon optional (#36704) 2019-08-28 06:22:47 +05:30
Randell Dawson 316503bfaa fix: added forumTopicId to new challenge (#36609) 2019-08-21 11:20:05 -05:00
Lauren Van Sloun 4507a6b254 Minor grammar fixes (#36643)
* Minor grammar fix
2019-08-20 14:36:22 +01:00
rns350 1ad3abd50f feat(curriculum); added another challenge to help teach recursion (#35966)
* Squashed the removal of the before test section

* fix: changed blockquote triple backtick syntax

* fix: removed recursion explanation

* fix: changed meta title and thru to through

* fix: capitalize "after" in several strings
2019-08-15 20:07:15 +09:00
joelzehring 992fc8f1bf Update generate-an-array-of-all-object-keys-with-object.keys.english.md (#36578)
Method should act on any passed parameter rather than the specific object named in this problem.
2019-08-11 11:42:19 -05:00
enrider 76bd5f4fc3 Issue #36564 update regex for spread operator (#36565)
* Issue #36564 update regex for spread operator

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-the-spread-operator-to-evaluate-arrays-in-place.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-08-06 14:56:48 -07:00
Randell Dawson 568f00e02a fix(curriculum): Added forumTopicId to remaining 1200 challeng… (#36558) 2019-08-05 22:14:37 +05:30
Randell Dawson 3ec1fe8ea7 feat: add forumTopicId to challenge frontmatter [pre-existing]
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
lasjorg 881be7121e fix(challenge): remove type coercion check for true and false return (#36519)
* fix(challenge): remove type coercion check for true and false return

* fix(challenge): use Chai methods for false/true check
2019-07-30 08:33:37 -05:00
mrugesh 91df817cfe
fix(guide) add stubs, update spellings and prepare for move (#36531)
* fix(guide) add stubs and correct file path misspellings and pr… (#36528)

* fix: corrected file path to match curriculum

* fix: renamed to newer challenge name

* fix: added solutions to articles from challenge files

* fix: added missing .english to file name

* fix: added missing title to guide article

* fix: correct solution for guide article

* fix: replaced stub with hint

* fix: added space in Hint headers

* fix: added solution to guide article

* fix: added solution to guide article

* test: replaced stub with hint and solution

* fix: add Problem number: to title

* fix: changed generatorexponential to correct name

* fix: renamed knight's tour to knights-tour

* fix: updated guide article
2019-07-30 00:25:58 +05:30
Randell Dawson ba6ae7154c fix: removed more assert msg arguments (#36439) 2019-07-28 05:16:04 +01:00
Randell Dawson d0d8282f86 fix(curriculum): Remove additional unnecessary assert message argument wrapped in double quotes from various curriculum sections (#36457)
* fix: remove double quoted assert msg arg - responsive

* fix: remove double quoted assert msg arg - js

* fix: remove double quoted assert msg arg - libraries

* fix: remove double quoted assert msg arg - coding interview
2019-07-24 13:06:12 +01:00
Randell Dawson 1fa0dcb1e1 fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 04 (#36404)
* fix: rm assert msg OOP

* fix: rm assert msg regular expressions
2019-07-24 11:32:04 +02:00
Randell Dawson d78168f7db fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 03 (#36403)
* fix: rm assert msg basic-data-structures

* fix: rm assert msg intermed-algo-scripting

* fix: rm assert msg data-structures projects
2019-07-24 10:56:38 +02:00
Randell Dawson 5bf8527523 fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 02 (#36402)
* fix: rm assert msg basic-algorithm-scripting

* fix: rm assert msg debugging

* fix: rm assert msg es6

* fix: rm assert msg functional-programming
2019-07-24 10:47:32 +02:00
Oliver Eyton-Williams 6078081a3f feat: Add guide article and update its challenge (#36371)
* feat: Add guide article and update its challenge

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Stop hints from being hidden

* fix: Improve the wording.

* Update index.md

Fixed per suggestion

* Update index.md

Fixed per suggestion
2019-07-19 16:14:28 -05:00
Oliver Eyton-Williams b8593326b0 fix: remove guide linting and fix failing challenges 2019-07-19 15:30:17 +05:30
Oliver Eyton-Williams 7d4dc382b4 fix(curriculum): format challenge markdown as per linting rules (#36326)
* fix: Format challenge markdown according to linting rules

* fix: Put spaces after section tags
2019-07-19 15:30:17 +05:30
Randell Dawson c387873640 fix(curriculum): added extra line before </section> tag - Engl… (#36278) 2019-07-19 15:30:17 +05:30
Ashrith Reddy 8e9014214a made semi-colon on basic-javascript challenge optional. (#36465)
* made closing operator optional.

* truncated unnecessary regex
2019-07-18 08:07:17 -07:00
Randell Dawson e9212c61d2 fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 01 (#36401)
* fix: rm assert msg basic-javascript

* fix: removed more assert msg args

* fix: fixed verbiage

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-07-13 08:07:53 +01:00
moT01 9ce8bbb4c0 fix/add-suggested-grammar-and-punctuation 2019-07-12 22:44:23 +09:00
moT01 d3cf6f42dd fix/grammar+punctuation 2019-07-12 22:44:23 +09:00
moT01 fa365a7f77 fix/capitalization-in-title 2019-07-12 22:44:23 +09:00
moT01 832cbc91b1 fix/the-mess-I-made 2019-07-12 22:44:23 +09:00
moT01 da254743cd feat/new-lessons-on-js-promises 2019-07-12 22:44:23 +09:00
Randell Dawson 73bdff45fd fix(curriculum): Added a Recursion challenge to the Basic JavaScript section (#35968)
* fix: added a recursion challenge

* fix: changed blockquote to triple backtick syntax

* fix: added an extra line to separate code section

* fix: renamed challenge and improved verbiage

* fix: added full path to challenge

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: improved wording

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added closing )

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added missing comma and the word at

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added missing text for test case

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added note regarding startNum and endNum being same

* fix: wrapped parameter names with code tags
2019-07-12 13:40:50 +02:00
lasjorg f03f05d53d fix(challenge): rename challenge, change fields to properties, fix test (#36338)
* fix(challenge): rename challenge, change fields to properties, fix test

* fix(challenge): update challenge name in meta.json

* fix(challenge): update test and assertion message

* fix(challenge): update second assert message

* fix(challenge): remove the word Person from text
2019-07-10 10:31:15 +02:00
organicdude f65eea3dd6 Increase language clarity in challenge "Basic Javascript: Iterate Through an Array with a For Loop" (#36081)
* Increase language clarity in the challenge.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix/make-suggested-changes-on-behalf-of-author

* fix/add-empty-line-back-in
2019-07-03 15:13:25 +05:30
Tom 50b45b9379 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/create-an-export-fallback-with-export-default.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-28 16:04:59 +08:00
moT01 2e49aa02df fix/add-anonymous-function-example 2019-06-28 16:04:59 +08:00
moT01 9c1b83dd0c fix/add-tests+note-in-import-lesson 2019-06-28 16:04:59 +08:00
moT01 9199319ae1 fix/build-error 2019-06-28 16:04:59 +08:00
moT01 9c249bf8be fix/build-error 2019-06-28 16:04:59 +08:00
moT01 d68475e7ea fix/build-error 2019-06-28 16:04:59 +08:00
moT01 61895e05f7 fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
moT01 f14f1bf750 fix/rename-lessons 2019-06-28 16:04:59 +08:00
moT01 23d723a71f fix/add-tests 2019-06-28 16:04:59 +08:00