Michał Kozłowski
e05e17ce31
fix regexp to match require statement without .js extension ( #36293 )
2019-07-02 01:51:41 +05:30
Steven Failla
438e7d4c51
fixed testString to disallow any extra characters from passing. Also … ( #35987 )
...
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
Co-Authored-By: Stevo99 <Sfailla1983@gmail.com>
* fixed test so it won't pass if datetime attr is left blank
* fixed test so it will not pass if datetime attribute is left empty
* fixed error in testString where test would pass if user runs test right away
* added tear-down div to make test code look cleaner
* fixed merge conflict. added tear-down div to make code look cleaner
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
improvement to test case where element should have closing tag.
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fixed conflict in git
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
removed unnecessary test
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
removed unnecessary test
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-28 18:49:00 -04:00
Tom
50b45b9379
Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/create-an-export-fallback-with-export-default.english.md
...
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-28 16:04:59 +08:00
moT01
2e49aa02df
fix/add-anonymous-function-example
2019-06-28 16:04:59 +08:00
moT01
9c1b83dd0c
fix/add-tests+note-in-import-lesson
2019-06-28 16:04:59 +08:00
moT01
9199319ae1
fix/build-error
2019-06-28 16:04:59 +08:00
moT01
9c249bf8be
fix/build-error
2019-06-28 16:04:59 +08:00
moT01
d68475e7ea
fix/build-error
2019-06-28 16:04:59 +08:00
moT01
61895e05f7
fix/final-draft-before-reviews
2019-06-28 16:04:59 +08:00
moT01
f14f1bf750
fix/rename-lessons
2019-06-28 16:04:59 +08:00
moT01
23d723a71f
fix/add-tests
2019-06-28 16:04:59 +08:00
moT01
2e6cb9181a
fix/revise-es6-import-export-lessons
2019-06-28 16:04:59 +08:00
moT01
6e8bbd169b
fix/final-draft-before-reviews
2019-06-28 16:04:59 +08:00
moT01
956212cdc0
fix/rename-lessons
2019-06-28 16:04:59 +08:00
moT01
8b5cc6d277
fix/add-tests
2019-06-28 16:04:59 +08:00
moT01
8a579210e3
fix/revise-es6-import-export-lessons
2019-06-28 16:04:59 +08:00
moT01
00b5ce97e3
fix/verbiage
2019-06-27 15:48:07 +08:00
Tom
72cb38a839
Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
...
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-27 15:48:07 +08:00
moT01
3b96f3e60d
fix/terminology
2019-06-27 15:48:07 +08:00
Tom
81758eeea6
Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
...
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom
d2c5cc7ff3
Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
...
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom
9f4799bba1
Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
...
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom
e58c512052
Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
...
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
moT01
d0e5405e5c
fix/make-tests-more-robust
2019-06-27 15:48:07 +08:00
moT01
21b411b855
fix/bad-solution
2019-06-27 15:48:07 +08:00
moT01
246ca16f32
fix/es6-destructuring-reword+new-lesson
2019-06-27 15:48:07 +08:00
Kris Koishigawa
1028310819
Changed bold to strong or code tags where possible
2019-06-26 17:34:03 +08:00
Kris Koishigawa
3ce97bbd81
Fixing other problems from comments
2019-06-26 17:34:03 +08:00
Kris Koishigawa
0544554b00
Fix curly quotes
2019-06-26 17:34:03 +08:00
Kris Koishigawa
a6ed1e51b7
Change links from http to https
2019-06-26 17:34:03 +08:00
Kris Koishigawa
32b24a3a20
Fixing merge conflicts
2019-06-26 17:34:03 +08:00
Kris Koishigawa
ae49dfd376
fix(challenges): Fix merge conflicts convert seconds and towers of hanoi
2019-06-26 17:34:03 +08:00
Kris Koishigawa
14bcbac669
fix(challenges): Added blockquote to department numbers and fixed fractions in fractran
2019-06-26 17:34:03 +08:00
Kris Koishigawa
aeb0dccb15
fix(challenges): Added left margin to blockquote footer in Babbage Problem
2019-06-26 17:34:03 +08:00
Kris Koishigawa
12d84e83a8
fix(challenges): Y problem
2019-06-26 17:34:03 +08:00
Kris Koishigawa
723ee2cfa5
W problem
2019-06-26 17:34:03 +08:00
Kris Koishigawa
a0e68a39a7
fix(challenges): V problems
2019-06-26 17:34:03 +08:00
Kris Koishigawa
74f70c19d8
fix(challenges): T problems
2019-06-26 17:34:03 +08:00
Kris Koishigawa
539e93d01b
fix(challenges): The rest of the S problems
2019-06-26 17:34:03 +08:00
Kris Koishigawa
442c9c291d
fix(challenges): More S problems
2019-06-26 17:34:03 +08:00
Kris Koishigawa
c752d57611
Added sorting algorithms
2019-06-26 17:34:03 +08:00
Kris Koishigawa
2053e99cd5
S problems
2019-06-26 17:34:03 +08:00
Kris Koishigawa
df88daa482
fix(challenges): J problems
2019-06-26 17:34:03 +08:00
Kris Koishigawa
263d2c496b
fix(challenges): I problems
2019-06-26 17:34:03 +08:00
Kris Koishigawa
a3fd1aa284
fix(challenges): H problems
2019-06-26 17:34:03 +08:00
Kris Koishigawa
537d1ed642
fix(challenges): G problems
2019-06-26 17:34:03 +08:00
Kris Koishigawa
abbfee1189
fix(challenges): Formatted F challenges
2019-06-26 17:34:03 +08:00
Kris Koishigawa
1a56a5b0ae
fix(challenges): Minor changes to D challenges. Add E challenges
2019-06-26 17:34:03 +08:00
Kris Koishigawa
461155f7ef
fix(challenges): Replaced image with svg in Cut a Rectangle
2019-06-26 17:34:03 +08:00
Kris Koishigawa
da4999cb46
fix(challenges): Moved challenge instructions to instructions section
2019-06-26 17:34:03 +08:00
Kris Koishigawa
3a7ac2c0c0
fix(challenges): Forgot to remove the space between the function name and first parenthesis
2019-06-26 17:34:03 +08:00
Kris Koishigawa
bc1d2be822
fix(challenges): Added all D problems except Department Numbers
2019-06-26 17:34:03 +08:00
Kris Koishigawa
d024b96a92
fix(challenges): Went back and fixed a missing A problem. Fixed C problems.
2019-06-26 17:34:03 +08:00
Kris Koishigawa
f9f4048258
fix(challenges): Revert 24 game due to another PR being submitted
2019-06-26 17:34:03 +08:00
Kris Koishigawa
201c383148
fix(challenges): Fixed formatting for numbered and challenges starting with A
2019-06-26 17:34:03 +08:00
Tom
51b5defb7e
fix/regex-upper-and-lower-bounds-tests ( #36059 )
...
* fix/regex-upper-and-lower-bounds-tests
* fix/add-solution-back
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/specify-upper-and-lower-number-of-matches.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-25 14:45:20 -07:00
Randell Dawson
3fa14df925
fix: renamed folder without starting dash ( #36124 )
2019-06-21 18:05:33 -04:00
Randell Dawson
f53ca79890
fix: changed tests to allow other valid solutions ( #36210 )
2019-06-21 18:04:30 -04:00
Randell Dawson
63a0fa745b
fix: improved tests to allow more valid solutions ( #36193 )
2019-06-20 17:09:46 -04:00
Randell Dawson
a6afaf1eb6
fix(curriculum) - added new tests to prevent invalid solutions in the Remove Elements from a Linked List by Index challenge ( #36168 )
...
* fix: added new tests to prevent invalid solutions
* fix: corrected tests and added solution
* fix: added linked word
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* fix: added by one
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* fix: removed duplicate code
* fix: changed verbiage
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
* fix: added extra line to avoid linting errors
2019-06-20 13:34:08 -04:00
Stan Choi
a13d116aab
fix(learn): Added solution for invert binary tree data structures challenge ( #35922 )
...
* fix: add solution for invert binary tree
* Fixed errors
* Used 2 spaces per request
* deleted images
* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: added extra line to avoid linting errors
2019-06-20 13:28:37 -04:00
Andrew Zaw
6f4a9ed721
Reorganized instruction text on multiple challenges ( #35912 )
...
* Reorganized instruction text on multiple challenges
* Fixed spaces
* Fixed spaces again
* Update curriculum/challenges/english/08-coding-interview-prep/data-structures/add-elements-at-a-specific-index-in-a-linked-list.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Update curriculum/challenges/english/08-coding-interview-prep/data-structures/find-the-minimum-and-maximum-height-of-a-binary-search-tree.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: added code tags
2019-06-20 13:16:31 -04:00
Daniel Simeonov
81d7127a5d
Added solution for English/Data-Visualization/Hover-tod3-element ( #36220 )
...
* Added solution for English/Data-Visualization/Hover-tod3-element
* Added full solution for Data-Visualization-D3/Hover-effect-to-d3-element
* fix: added extra line to prevent linting errors
2019-06-20 09:49:47 -07:00
Stan Choi
204ece1c70
fix: Add Solution in Curriculum/Challenges/English/08/CodingInterviewProblems/DataStructures/CREATE_LINKED_LIST_CLASS.md ( #35819 )
...
* fix: add solution create linked list class
* fix: added extra line to avoid linting error
* fix: renamed some variables
2019-06-20 10:11:26 -05:00
Tina Wang
f203273e3a
Solutions for sorting algorithm challenges in Coding Interview Prep/Algorithms ( #35905 )
...
* added bubbleSort solution
* added insertionSort
* fixed spacing in bubbleSort
* added selectionSort
* added a test
* Fixed a reference to the array with the wrong array name in the solution
* fix: added extra lines to avoid linting errors
* fix: added comments back into seed
2019-06-20 10:03:31 -05:00
Oliver Eyton-Williams
2024e238fa
feat(curriculum): Add basic recursion lesson ( #36200 )
...
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-06-19 23:50:44 +05:30
leodaher
0be75e4b39
feat(curriculum): Add fetch challenge to the current curriculum. ( #36033 )
...
* Add fetch challenge for the current curriculum
2019-06-18 00:19:33 +02:00
Michał Kozłowski
8b40da02a3
multiple ternary operator challenge - add note about code readability ( #36269 )
...
* fix multiple ternary operator challenge
* Fix a typo in multiple ternary operator challenger
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
* Fix a typo in multiple ternary operator challenge #2
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-15 19:06:56 +01:00
adamthahir
acbc07e0ff
Fixed typo addressed in #36225 ( #36227 )
...
* Fixed typo addressed in #36225
* Updated as per discussion.
2019-06-15 13:02:01 +07:00
Mahesh Jaganiya
72aaddfc12
Improve Regex ( #36078 )
...
* Updated assert.match() to assert.equal()
2019-06-11 10:43:08 +02:00
anthonykyi
97f6b73a0e
Added Binary Search Tree Challenge ( #35907 )
...
* Added Binary Search Tree Challenge
* fix yaml, fix solutions, fix tests
* Fixed recommended fixes
2019-06-10 23:35:21 -04:00
RIHANE ZAKARIA
d86951f9c1
Added solutions for 3 challenges in English / data-structures ( #35825 )
...
* Solution for add-elements-at-a-specific-index-in-a-linked-list.english.md
* Solution check-if-an-element-is-present-in-a-binary-search-tree.english.md
* Solution for remove-elements-from-a-linked-list-by-index.english.md
* change indent level to 2 space for each level
* change indent level to 2 space
* change indent level to 2 space
* delete unnecessary new lines
* keep the same seed format , and delete unnecessary new lines
* delete unnecessary new lines
* fix: added review suggestions
* fix: Added link and code tags
2019-06-10 18:17:11 -04:00
Ugur Yilmaz
2a18b1a308
Consistency Update for label and input elements for last lessons ( #36192 )
...
* Updated to reflect the relationship between label and input elements
* Updated to reflect the relationship between label and input elements
2019-06-09 20:47:50 +01:00
Weibin Luo
8cb540fe85
fix: use lowercase for 'article' tag ( #36222 )
2019-06-09 07:47:09 -07:00
Oliver Eyton-Williams
43fa451a38
fix(curriculum): Change wording to talk about inheritance not cascade ( #36110 )
2019-06-08 19:09:00 -07:00
Kristofer Koishigawa
8f633299ef
fix(challenges): Replace camper leaderboard project ( #35763 )
2019-06-09 05:23:28 +05:30
Siddhant Shekhar
c1d3817732
fix : replaced test cases' string to make more sense ( #36170 )
2019-06-06 15:53:31 -07:00
Fabricio Asfora Lira
2da9d631ef
fix: update "Note" formatting in "Remove Elements from a Linked List" challenge ( #36173 )
...
* fix: update note format
* fix: moved note to same line
2019-06-06 14:27:58 -05:00
Courtney Landau
f70bcce463
spelling and grammar fixes ( #36061 )
...
* spelling and grammar fixes
* Update curriculum/challenges/english/06-information-security-and-quality-assurance/advanced-node-and-express/send-and-display-chat-messages.english.md
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-06-04 16:22:23 -04:00
Randell Dawson
5a06b71ac4
fix: modified tests text ( #36169 )
2019-06-04 16:14:52 -04:00
Randell Dawson
da610150ad
fix(curriculum): added new test and corrected existing solution for Remove Elements from a Linked List challenge ( #36121 )
...
* fix: added new test and corrected solution
* fix: corrected test
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: corrected test
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: allow last element to be removed
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-04 14:55:50 -04:00
Val Lipat
6feda1badb
Improve capitalization ( #36166 )
2019-06-04 07:52:52 -07:00
Randell Dawson
0303da3677
fix(curriculum): Convert blockquote elements to triple backtick syntax for Coding Interview Prep ( #35998 )
...
* fix: converted blockquotes
* fix: reverted several code blocks to blockquotes
2019-06-04 08:07:22 +01:00
Oliver Eyton-Williams
6745009490
fix(curriculum): Add more valid triples to the test ( #35870 )
2019-05-26 14:02:20 -07:00
Natalie Cardot
db1b435775
Fix spelling ( #36111 )
...
"hachedEgg" -> "hatchedEgg"
2019-05-22 17:42:44 -05:00
Varun
3a4402434b
fix(curriculum): Update challenge instructions ( #36104 )
2019-05-21 15:07:50 -07:00
Natalie Cardot
545b8a6f34
Modify if statement ( #36088 )
...
* Modify if statement
Change the solution so an empty string is returned when num is less than 1 rather than less than 0 for consistency with instructions.
* Add test
New test checks that if num is 0, an empty string is returned
* Fix test
Fixing errors in newly proposed test that checks that empty string is returned when num is 0
* Modify intermediate solution
Changing if statement in intermediate solution to check whether num is less than 1 rather than less than 0. (Also adding curly brackets to that solutions if/else statements.)
* fix: removed unnecessary assert message arguments
2019-05-20 21:08:20 -04:00
Natalie Cardot
39c43dbe8a
Alter instructions ( #36099 )
...
Removing the word "below" since the object's properties are shown to the right of, not below, the challenge description/instructions.
2019-05-20 19:11:17 -04:00
Ahmad Abdolsaheb
8b4fb5a452
fix: imgur to s3 for various files without conflict ( #36057 )
2019-05-20 23:58:20 +05:30
Tom
21118bc26a
fix/regex-lower-number-of-matches ( #36004 )
...
* fix/regex-lower-number-of-matches
* fix/update-guide
* fix/convert-blockquote-to-backticks
2019-05-17 23:53:00 +01:00
Mahesh Jaganiya
e877d9c7d5
Semantic versioning required ( #36074 )
...
Node build fails for "1.2"
2019-05-17 09:07:16 -07:00
Randell Dawson
05f73ca409
fix(curriculum): Convert blockquote elements to triple backtick syntax for JavaScript Algorithms and Data Structures ( #35992 )
...
* fix: convert js algorithms and data structures
* fix: revert some blocks back to blockquote
* fix: reverted comparison code block to blockquotes
* fix: change js to json
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: convert various section to triple backticks
* fix: Make the formatting consistent for comparisons
2019-05-17 08:20:30 -05:00
Randell Dawson
4b4762716c
fix(curriculum): Rewrote the Write Higher-Order Arrow Functions challenge and moved to Functional Programming section ( #35954 )
...
* fix: reworded and moved challenge
* fix: removed extra line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix; removed extra line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: reworded sentence
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-15 11:12:17 -05:00
Kyle Cheung
937dc23b5d
fixed typos in custom css-variable challenge #36038 ( #36041 )
...
* fixed typos in custom css-variable challenge
* fix: Remove extra line
2019-05-14 20:31:03 +07:00
Randell Dawson
dd6011b2cc
fix(curriculum): Convert blockquote elements to triple backtick syntax for Data Visualization ( #35995 )
...
* fix: convert data visualization
* fix: reverted to blockquote
* fix: changed js to json
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: cleaned up code
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-05-14 07:04:05 -05:00
Randell Dawson
933350c148
fix(curriculum): Convert blockquote elements to triple backtick syntax for Front End Libraries ( #35994 )
...
* fix: converted blockquotes for react/redux
* fix: converted blockquotes for sass
* fix: changed jsx to js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: changed jsx to js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-05-14 07:01:32 -05:00
Randell Dawson
4dbd496b49
fix(curriculum): Convert blockquote elements to triple backtick syntax for Apis And Microservices ( #35996 )
...
* fix: converted blockquotes
* fix: revert to blockquote
* fix: changed js to http
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: reverted back to blockquote
* fix: reverted back to blockquote
* fix: reverted back to blockquote
2019-05-14 07:00:06 -05:00
Randell Dawson
46411ca1cd
fix(curriculum): Convert blockquote elements to triple backtick syntax for Information Security And Quality Assurance ( #35997 )
...
* fix: converted blockquotes
* fix: added extra line before triple backtick syntax
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: corrected misc issues
* fix: properly closed em element
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-05-14 06:58:09 -05:00
Randell Dawson
df8659ab8c
fix(curriculum): Convert blockquote elements to triple backtick syntax for Responsive Web Design ( #35993 )
...
* fix: converted blockquotes to code fences
2019-05-14 10:11:58 +02:00
Matt Schlosser
08c4807b09
Added missing `</code>` in test text string ( #36040 )
2019-05-14 10:06:55 +02:00
Huyen Nguyen
791e589c93
Remove tag characters ( #36037 )
2019-05-14 00:14:16 +05:30
Courtney
860cc14894
fix to spelling error "instantiated" ( #36032 )
...
* fix to spelling error
* Update curriculum/challenges/english/06-information-security-and-quality-assurance/advanced-node-and-express/set-up-the-environment.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-13 10:00:07 -05:00
Tom
fc547999fd
fix/record-collection ( #36002 )
...
* fix/record-collection
* fix/remove-old-assert-messages
* fix/attempt-to-fix-build-error
* fix/attempt-to-fix-build-error
* fix/change-verbiage-and-tidy-up
* fix/remove-brackets-in-regex
2019-05-12 23:45:18 -04:00
Randell Dawson
48884f3a4a
fix: changed to h4 > s in selector ( #36023 )
2019-05-11 19:09:08 -05:00
Randell Dawson
7437145bb4
fix: improved existing tests ( #35801 )
2019-05-09 09:01:50 -04:00
Yoelvis Jiménez
fdb49ba89a
Fix "ReferenceError: url is not defined" in challenge ( #35415 )
...
* Fix "ReferenceError: url is not defined" in challenge
I fix the challenge because issue #14002
- The `url` variable is set to external resource `https://jsonplaceholder.typicode.com/posts `
- I replaced .textContent instead of .innerHTML (better practice)
- Checking for HTTP status of 201 instead of 200
All these suggestions by @HarplingeTom and "approved" by @QuincyLarson. See the issue comments.
I test the code locally in my computer and this works 👍
I modified and verify the tests according the new assessment.
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md
Minor typo: `<code>` to `</code>`
Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>
* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md
new declared as const
Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>
2019-05-08 20:07:36 -05:00
duytrinhvn
534824e232
Fix spelling error ( #35925 )
...
* Fix spelling error
* fix: changed be conformed to conform
2019-05-08 19:54:32 -05:00
Kyle Scheuerlein
3b5fbe3edb
Improve formatting of Challenge Seed ( #35854 )
2019-05-08 18:32:01 -05:00
Deanna Tran
338d7ee8a7
Change "rest operator" to say "rest parameter" in challenges and guide ( #35496 )
...
* change es6 challenges rest operator to param
* fix rest parameter typos
* change rest operator to parameter in guide
* fix casing
* change rest operator to rest parameter in guide
* change rest operator to rest parameter in curriculum
* remove extra whitespace
* remove whitespaces
* remove whitespace
* fix: removed arabic file
* fix: removed chinese file
2019-05-08 16:30:24 +02:00
Tom
4f73b5a7f3
Fix/manage state locally tests ( #35980 )
...
* fix/manage-state-locally-test
* fix/update-test-words
* fix/update-test
2019-05-08 10:17:54 -04:00
Tom
93e5554615
fix: added semi-colon not in original code
...
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-07 10:43:43 -07:00
Randell Dawson
5cfff58c7b
fix: added all js to end of 3 backticks
2019-05-07 10:43:43 -07:00
Randell Dawson
5cf039e5fd
fix: performed first conversions
2019-05-07 10:43:43 -07:00
Randell Dawson
1cb6092dd9
fix: performed first conversions
2019-05-07 10:43:43 -07:00
RIHANE ZAKARIA
a40451feaa
Define the Head and Body of an HTML Document for challenge solution ( #35826 )
...
* Define the Head and Body of an HTML Document for challenge solution
* edit on check the body tag contain h1 and p tags
2019-05-06 16:44:57 +02:00
Oliver Eyton-Williams
cde8035b79
fix: add test for and slight rewrite to hazards of imperative ( #35331 )
...
* fix: add test for and slight rewrite to hazards of imperative
* fix: Resolve merge conflict
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/understand-the-hazards-of-using-imperative-code.english.md
Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
* fix: Make the only mistake in seed the use of splice
2019-05-06 07:27:38 -05:00
Randell Dawson
a092c76688
fix: added 22 missing solutions ( #35747 )
2019-05-03 12:05:26 +02:00
The Coding Aviator
79b5749c57
curriculum: Change pre and code to blockquote in Advanced Node and Express challenges ( #35713 )
...
* curriculum: Change pre and code to blockquote in Advanced Node and Express challenge
2019-05-02 12:19:07 +02:00
Manish Giri
b579317e11
fix(curriculum): Add solutions to Bootstrap challenges ( #35789 )
...
* fix(curriculum): Add solutions to Bootstrap challenges
2019-05-02 11:24:38 +02:00
Valeriy
5edaee4269
fix(curriculum): throws is not defined
2019-05-02 01:01:00 -07:00
Randell Dawson
f51f262104
fix(curriculum): Increased starting font size to fix a bug on Chrome browser for Sass Apply a Style Until a Condition is Met with @while challenge ( #35935 )
...
* fix: increased starting font size for Chrome
* fix: slight verbiage change
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix/remove-extra-space
2019-05-01 09:08:38 -05:00
Randell Dawson
409aa30b0a
fix(curriculum): add new test to use calculated space for Use grid-column to Control Spacing challenge ( #35893 )
...
* fix: use calculated space for test
* fix: reworded comment
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: changed After Test to Before Test
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-01 14:08:35 +05:30
Randell Dawson
365ce2ddc7
fix(curriculum): Added test and corrected solution for Restrict Possible Usernames challenge ( #35847 )
...
* fix: added test and corrected solution
* fix: removed redundant regex
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-04-30 20:40:38 -05:00
Randell Dawson
3bff4151cf
fix: rewrote challenge instructions and tests ( #35899 )
2019-04-30 20:19:06 -05:00
Randell Dawson
7d7a1127a7
fix: remove comments before tests ( #35906 )
2019-04-30 19:26:07 -05:00
Randell Dawson
66398a9300
fix(curriculum): Improved the tests for Find the length of a String challenge ( #35940 )
...
* fix: split tests into two requests
* fix: removed typeof number check
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: remove unneeded After Test section
2019-04-30 19:12:22 -05:00
Oliver Eyton-Williams
e3529a8449
fix: Add solutions for Sass challenges ( #35777 )
2019-04-30 18:55:22 -05:00
RIHANE ZAKARIA
6630b2be7a
bug fix / test of Spread Operator javascript challenge / english ( #35856 )
...
* bug fix test with the Spread Operator
* test of Spread Operator javascript challenge / english / change test and add a helper function
2019-04-30 18:37:26 -05:00
The Coding Aviator
a2a278e937
fix: Moved instruction to proper place and removed assert text in Font Awesome challenges ( #35928 )
...
* fix: Moved instruction to proper place and removed assert text
* Add suggestion about making note strong
Co-Authored-By: thecodingaviator <34807532+thecodingaviator@users.noreply.github.com>
2019-04-29 15:51:03 +02:00
Manish Giri
1015f1ec6e
fix(curriculum): Add solution to jQuery challenges ( #35776 )
2019-04-28 12:28:47 -07:00
Huyen Nguyen
5b32e98c4a
fix(curriculum): Add solutions to Applied Visual Design challenges ( #35815 )
...
* fix: add solutions to Applied Visual Design challenges
* fix: remove extra opening style tag
2019-04-28 13:13:38 -05:00
Tina Wang
bc986a4728
Moved font-awesome challenges to Font Awesome v5.8.1 ( #35813 )
...
* update font awesome challenge to font awesome 5
* v5 syntax changed
2019-04-28 15:00:27 +05:30
Randell Dawson
102c2b829a
fix: added 15 missing solutions ( #35745 )
2019-04-28 14:31:14 +05:30
Aly Pilkons
dae22c95c3
Edit Instructions Text To Make Goal Clearer ( #35887 )
...
* Edit Instructions Text To Make Goal Clearer
The instructions end with "using the object provided" which is unclear since the user is expected to create their own name for the object. Users may think they need to reference an object name and be confused when they do not find it. Reiterating that the user needs to create the name for the object themselves makes the task clearer.
* Updated commit based on comments
2019-04-26 18:33:04 +05:30
Ian Effendi
cf86246866
fix(curriculum): Add solutions to 16 Applied Accessibility challenges #35751 ( #35809 )
...
This commit adds 16 full working solutions to the responsive web design
principles dealing with applied accessibility.
2019-04-24 19:12:46 +05:30
BSi
f8555c2f8b
Added the semicolon in the example provided ( #35898 )
2019-04-23 19:26:50 -04:00
Manish Giri
722b65d80f
fix(curriculum): Add solutions to HTML challenges ( #35766 )
...
* fix(curriculum): Add solutions to HTML challenges
* Remove extra anchor element
2019-04-22 11:37:05 +05:30
Fordco
5fb179a6ef
fix: missing ! in final test case. Fixes issue #34725 ( #35033 )
2019-04-22 11:31:17 +05:30
Manish Giri
e736179720
fix(curriculum): Add solutions to CSS challenges ( #35873 )
2019-04-22 11:27:43 +05:30
Catalina
ffcb092bf1
Fixed CSS Challenge English version ( #35849 )
2019-04-20 09:49:23 -07:00
Tom
f1bcd5f0de
fix/add-full-solutions-to-flexbox ( #35760 )
2019-04-20 09:45:18 -07:00
ranched
9899035f34
fix(cirriculum): Expand instructions for Chai Assertion challenges ( #35724 )
...
* Expand instructions for Chai Assertion challenges
* Seperate instructions/descriptions and remove some quotes
* Add detail to descriptions in truthiness and isOk challenges
* Update formatting in instructions
2019-04-19 18:34:53 +05:30
Randell Dawson
54bc113721
fix(curriculum): Added 9 missing solutions to challenges in the Debugging section ( #35750 )
...
* fix: add 9 solutions to challenges
* fix: remove extra line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-04-19 00:14:20 +05:30
Astrid
9ee8b4fa57
fix: minor grammar mistake in 'applied visual design' challenge ( #35839 )
...
fix: revert changes to package-lock.json
2019-04-15 14:05:30 +05:30
Beau Carnes
63fc21f702
Update videoURL for HTML5 Elements challenge ( #35802 )
2019-04-14 09:20:36 -07:00
Benjamin Herrchen
20f71fd22e
correct usage of Math.random() to give equal 50/50 results ( #35840 )
...
* Update render-conditionally-from-props.english.md
* Update render-conditionally-from-props.english.md
2019-04-13 18:06:01 -04:00
Paul Gamble
bddcda5559
added html solution for testing - responsive-web-design/applied-visual-design/decrease-the-opacity-of-an-element ( #35516 )
...
* added html solution for testing
* fix: corrected invalid solution
2019-04-12 18:17:12 +02:00
Aditi Joshi
ebdd8632fc
Fix/update challenges for responsive-web-design-principles ( #35804 )
...
* Fix/update challenges for responsive-web-design-principles
* fix/update fix some minor mistakes
* fix/update remove extra line
* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/create-a-media-query.english.md
Co-Authored-By: aditijoshi14 <aditijoshi1997@hotmail.com>
* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/create-a-media-query.english.md
Co-Authored-By: aditijoshi14 <aditijoshi1997@hotmail.com>
2019-04-10 17:26:56 -04:00
Beau Carnes
7e522dc473
fix: add new scrimbas ( #35803 )
2019-04-10 09:23:12 -07:00
Ian Effendi
f74d507434
fix(curriculum): replace js with full solution in accessibility challenge ( #35810 )
...
* fix(curriculum): add full, working solution for accessibility challenge.
This commit replaces a JavaScript only solution where a full, working
solution should have been written.
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
Co-Authored-By: rimij405 <effendiian@gmail.com>
2019-04-10 17:55:16 +02:00