Commit Graph

54 Commits (07c552bffee2dd9cc62ba4cb5a5bf46d48ecfcc0)

Author SHA1 Message Date
Jasper Pilgrim 191f915e94 fix(curriculum): grammar, add period (#36785) 2019-09-12 18:48:28 +05:30
Huyen Nguyen 087640d020 fix(curriculum): Make challenge instruction clearer (#36771) 2019-09-11 14:18:28 +05:30
Tom 07b38d02b3 fix(challenge-test): make semi-colon optional (#36704) 2019-08-28 06:22:47 +05:30
Randell Dawson 316503bfaa fix: added forumTopicId to new challenge (#36609) 2019-08-21 11:20:05 -05:00
rns350 1ad3abd50f feat(curriculum); added another challenge to help teach recursion (#35966)
* Squashed the removal of the before test section

* fix: changed blockquote triple backtick syntax

* fix: removed recursion explanation

* fix: changed meta title and thru to through

* fix: capitalize "after" in several strings
2019-08-15 20:07:15 +09:00
Randell Dawson 568f00e02a fix(curriculum): Added forumTopicId to remaining 1200 challeng… (#36558) 2019-08-05 22:14:37 +05:30
Randell Dawson 3ec1fe8ea7 feat: add forumTopicId to challenge frontmatter [pre-existing]
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
Randell Dawson ba6ae7154c fix: removed more assert msg arguments (#36439) 2019-07-28 05:16:04 +01:00
Oliver Eyton-Williams 6078081a3f feat: Add guide article and update its challenge (#36371)
* feat: Add guide article and update its challenge

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Stop hints from being hidden

* fix: Improve the wording.

* Update index.md

Fixed per suggestion

* Update index.md

Fixed per suggestion
2019-07-19 16:14:28 -05:00
Randell Dawson c387873640 fix(curriculum): added extra line before </section> tag - Engl… (#36278) 2019-07-19 15:30:17 +05:30
Ashrith Reddy 8e9014214a made semi-colon on basic-javascript challenge optional. (#36465)
* made closing operator optional.

* truncated unnecessary regex
2019-07-18 08:07:17 -07:00
Randell Dawson e9212c61d2 fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 01 (#36401)
* fix: rm assert msg basic-javascript

* fix: removed more assert msg args

* fix: fixed verbiage

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-07-13 08:07:53 +01:00
Randell Dawson 73bdff45fd fix(curriculum): Added a Recursion challenge to the Basic JavaScript section (#35968)
* fix: added a recursion challenge

* fix: changed blockquote to triple backtick syntax

* fix: added an extra line to separate code section

* fix: renamed challenge and improved verbiage

* fix: added full path to challenge

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: improved wording

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added closing )

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added missing comma and the word at

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added missing text for test case

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added note regarding startNum and endNum being same

* fix: wrapped parameter names with code tags
2019-07-12 13:40:50 +02:00
organicdude f65eea3dd6 Increase language clarity in challenge "Basic Javascript: Iterate Through an Array with a For Loop" (#36081)
* Increase language clarity in the challenge.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix/make-suggested-changes-on-behalf-of-author

* fix/add-empty-line-back-in
2019-07-03 15:13:25 +05:30
Oliver Eyton-Williams 2024e238fa feat(curriculum): Add basic recursion lesson (#36200)
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-06-19 23:50:44 +05:30
Michał Kozłowski 8b40da02a3 multiple ternary operator challenge - add note about code readability (#36269)
* fix multiple ternary operator challenge

* Fix a typo in multiple ternary operator challenger

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Fix a typo in multiple ternary operator challenge #2

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-15 19:06:56 +01:00
Varun 3a4402434b fix(curriculum): Update challenge instructions (#36104) 2019-05-21 15:07:50 -07:00
Randell Dawson 05f73ca409 fix(curriculum): Convert blockquote elements to triple backtick syntax for JavaScript Algorithms and Data Structures (#35992)
* fix: convert js algorithms and data structures

* fix: revert some blocks back to blockquote

* fix: reverted comparison code block to blockquotes

* fix: change js to json

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: convert various section to triple backticks

* fix: Make the formatting consistent for comparisons
2019-05-17 08:20:30 -05:00
Tom fc547999fd fix/record-collection (#36002)
* fix/record-collection

* fix/remove-old-assert-messages

* fix/attempt-to-fix-build-error

* fix/attempt-to-fix-build-error

* fix/change-verbiage-and-tidy-up

* fix/remove-brackets-in-regex
2019-05-12 23:45:18 -04:00
Randell Dawson 66398a9300 fix(curriculum): Improved the tests for Find the length of a String challenge (#35940)
* fix: split tests into two requests

* fix: removed typeof number check

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: remove unneeded After Test section
2019-04-30 19:12:22 -05:00
Randell Dawson d5798c38de fix: rewrite of word blanks challenge (#35779) 2019-04-10 01:48:01 -04:00
Amy Lam 914a7c522d Copy edits (#35536)
* Copy edits to Basic JavaScript section

* Copy edits to ES6 section

* Update index.md
2019-03-29 22:06:58 +05:30
Hrishit Prasad Biswas 4eb4afe53b Fixed bug in 2nd test for Access Multi-Dimensional Arrays With Indexe… (#35666)
* Fixed bug in 2nd test for Access Multi-Dimensional Arrays With Indexes Challenge

* Fix for issue #35665

Fixed Bug In 2nd test case for Access Multi Dimensional Arrays With Indexes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-multi-dimensional-arrays-with-indexes.english.md

Co-Authored-By: Artistic18 <hrishitbiswas20@gmail.com>

* fix: added missing ) for assert statement
2019-03-25 15:42:21 -05:00
Timur cab064a183 Fix tests for Basic JavaScript: Write Reusable JavaScript with Functions (#34345)
* Fix tests

- fix original log() method restoration

- fix case that other userscripts(or extensions) can affect console output and therefore can ruin the test

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/write-reusable-javascript-with-functions.english.md

allow function calling without semicolon

Co-Authored-By: T1mL3arn <T1mL3arn@users.noreply.github.com>
2019-03-21 11:50:23 +05:30
NITIN BISHT 228d873dd3 Fix: remove quote from challenge where not needed [english] (#35493) 2019-03-19 15:04:03 +05:30
Lauren Van Sloun ef86d7bd61 Fixed typo in JavaScript curriculum (#34820)
* Fixed typo in JavaScript curriculum

* Added missing period at end of sentence
2019-03-12 15:05:22 -07:00
Randell Dawson 8e5b99b8ca fix(curriculum) Prevent 5th test from allowing invalid solution in Escape Sequences in Strings challenge (#35367)
* fix: prevent 5th test from allowing invalid code

* fix: added new test to not allow extra characters
2019-03-05 07:57:48 -06:00
Randell Dawson 99c7f28530 fix: remove <code> tags around word queue (#35393) 2019-03-04 09:12:29 -06:00
Christopher McCormack 421c097f17 feat: cleaned up grammar and formatting (#35364) 2019-03-02 00:25:09 +05:30
Niraj Nandish 769ec3cb63 Make code consistent in challenge (#19054) 2019-02-26 16:38:46 -05:00
Randell Dawson b83ab53047 [Fix] Corrected bug found in Shopping List challenge (#35017)
* fix: corrected bug found in issue #16044

* fix: account for empty strings

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: corrected wrong logic
2019-02-24 13:28:55 +05:30
Almaz Kunpeissov 4a7571492d #35176 Remove reference to "backspace" regex (#35186)
Remove reference to "backspace" regex in example #35176
2019-02-22 10:50:51 +08:00
Niraj Nandish cb35d49a21 fix(challenges): Fix broken links in English challenges (#35125) 2019-02-21 17:58:31 -05:00
Fordco 63c5423e4a fix(curriculum): iterate with javascript do...while loops (#35214) 2019-02-21 17:25:54 -05:00
Randell Dawson aa621a20b5 fix: removed unecessary guideUrl from frontmatter 2019-02-19 11:34:27 +03:00
Beau Carnes 409c39abf1 feat(curriculum): Add Basic JS Scrimba links (#34789)
* feat(curriculum): Add Basic JS Scrimba links

* Fix: Add missing video url.

* fix: update videoUrl
2019-02-14 09:24:02 -08:00
Chelsea Marie Hicks 8d7bd3906c Grammar change and readability of example (#30507) 2019-02-05 21:14:05 +05:30
rupali317 42bf229f59 fix: modified the test case such that the variable is a local scope o… (#34959)
* fix: modified the test case such that the variable is a local scope of the function

* fix: make test inclusive
2019-02-05 09:40:58 +03:00
Pepijnk12 ab4367a751 Update URL for 404 error (#35042)
* Update URL for 404 error

* fix: correct url
2019-02-04 13:34:47 +03:00
Casey Bennington 7f9cbe982b Add the solution (#28899)
* Add the solution

* Update divide-one-decimal-by-another-with-javascript.english.md

The solution was not passing. Change should pass now.

* Update divide-one-decimal-by-another-with-javascript.english.md


Co-authored-by: Paul Gamble <pgamble@gmail.com>
2019-01-25 11:10:44 -05:00
Ben Brown 929e0db633 fix(challenge): use-the-conditional-ternary-operator (#19535) 2018-12-03 14:19:57 +05:30
Ariel 2f23fb544d Fixes minor typo (#34326)
"should not be be" changed to "should not be"
2018-11-29 02:28:48 +05:30
Mike Perry Yeboah Attara 74a5c8d15a Fix inconsistent formatting of the welcomeToBooleans function (#34373)
fix the inconsistency in the formatting of the function and also fix issue #34367
2018-11-18 22:05:08 +05:30
mail-liam 86be0947b5 Updated tests for 'Iterate through an array with a for loop' to ES6 (#19722) 2018-11-08 22:02:21 +09:00
Eric Kao 8b21132cac Fix line for Example (#20713)
* Fix line for Example

Bolded Example is inline with description. Added new line so that Example will have its own line (right before the actual example)

* Add line break after Description
2018-11-04 07:18:50 +05:30
Valeriy 79d9012432 fix(curriculum): quotes in tests (#18828)
* fix(curriculum): tests quotes

* fix(curriculum): fill seed-teardown

* fix(curriculum): fix tests and remove unneeded seed-teardown
2018-10-20 23:32:47 +05:30
Prabhat Kumar Sahu 6cb1a95c72 Solution use-multiple-conditional-ternary-operators.english.md (#18750)
* Update use-multiple-conditional-ternary-operators.english.md

* Update use-multiple-conditional-ternary-operators.english.md

* Improve JavaScript code style
2018-10-15 20:46:43 -03:00
Prabhat Kumar Sahu 459b8340f0 Solution use-the-conditional-ternary-operator.english.md (#18747)
* Update use-the-conditional-ternary-operator.english.md

* Use strict equals
2018-10-15 20:41:38 -03:00
Prabhat Kumar Sahu 7b8a6e7385 Solution use-the-parseint-function-with-a-radix.english.md (#18746)
* Update use-the-parseint-function-with-a-radix.english.md

* Improved JavaScript formatting
2018-10-15 20:40:05 -03:00
Prabhat Kumar Sahu 1f9e26c7fe Solution use-the-parseint-function.english.md (#18743)
* Update use-the-parseint-function.english.md

* Removed blank line
2018-10-15 20:38:37 -03:00