Commit Graph

26 Commits (07c552bffee2dd9cc62ba4cb5a5bf46d48ecfcc0)

Author SHA1 Message Date
Randell Dawson 568f00e02a fix(curriculum): Added forumTopicId to remaining 1200 challeng… (#36558) 2019-08-05 22:14:37 +05:30
Randell Dawson 3ec1fe8ea7 feat: add forumTopicId to challenge frontmatter [pre-existing]
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
Randell Dawson ba6ae7154c fix: removed more assert msg arguments (#36439) 2019-07-28 05:16:04 +01:00
Randell Dawson d0d8282f86 fix(curriculum): Remove additional unnecessary assert message argument wrapped in double quotes from various curriculum sections (#36457)
* fix: remove double quoted assert msg arg - responsive

* fix: remove double quoted assert msg arg - js

* fix: remove double quoted assert msg arg - libraries

* fix: remove double quoted assert msg arg - coding interview
2019-07-24 13:06:12 +01:00
Randell Dawson 1fa0dcb1e1 fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 04 (#36404)
* fix: rm assert msg OOP

* fix: rm assert msg regular expressions
2019-07-24 11:32:04 +02:00
Oliver Eyton-Williams 7d4dc382b4 fix(curriculum): format challenge markdown as per linting rules (#36326)
* fix: Format challenge markdown according to linting rules

* fix: Put spaces after section tags
2019-07-19 15:30:17 +05:30
Natalie Cardot db1b435775 Fix spelling (#36111)
"hachedEgg" -> "hatchedEgg"
2019-05-22 17:42:44 -05:00
Natalie Cardot 39c43dbe8a Alter instructions (#36099)
Removing the word "below" since the object's properties are shown to the right of, not below, the challenge description/instructions.
2019-05-20 19:11:17 -04:00
Randell Dawson 05f73ca409 fix(curriculum): Convert blockquote elements to triple backtick syntax for JavaScript Algorithms and Data Structures (#35992)
* fix: convert js algorithms and data structures

* fix: revert some blocks back to blockquote

* fix: reverted comparison code block to blockquotes

* fix: change js to json

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: convert various section to triple backticks

* fix: Make the formatting consistent for comparisons
2019-05-17 08:20:30 -05:00
lasjorg 88a5d46ccb fix(challenge): add support for IIFE arrow function (#35573)
* fix(challenge): add support for IIFE arrow function

* fix(challenge): update regex
2019-03-19 08:39:43 -07:00
NITIN BISHT 228d873dd3 Fix: remove quote from challenge where not needed [english] (#35493) 2019-03-19 15:04:03 +05:30
Randell Dawson 9051ad2eb5 Fixed bug allowing versions of Object.keys method and hard coding of ownProps array (#35021)
* fix: disallow variants of Object.keys method

* fix: added new test to help prevent hardcoding array

* fix: refactored regex
2019-03-17 18:47:41 -04:00
lasjorg 494687f75e fix: correct inconsistency in formatting (#34721)
* fix: correct inconsistency in formatting

* fix: remove space before parentheses
2019-03-12 13:49:54 -07:00
Aditya 665c9cb47f fix: Object Oriented Programming: Use Dot Notation to Access the Properties of an Object (#34675)
* fix: typos

* fix: removed unnecessary assert message
2019-02-25 22:24:06 -05:00
lasjorg 9341aadb5b Fix/remove property references and update tests (#35109)
* fix(challenges): Update challenge text and assertion test

* fix(challenges): update assert test regex

* fix(challenges): update regex, fix inline comment in code example

* fix: corrected regex
2019-02-09 00:47:53 -05:00
Julien Galibois Sauvageau e8b7b2eb6f Fixed typo (#34848)
Original wording: getHachedEggCount
New wording: getHatchedEggCount
2019-02-08 13:59:04 -08:00
Aditya 85eca8ef36 [fix]: Object Oriented Programming: Inherit Behaviors from a Supertype (#35063)
* fix: revert semicolon check

* fix: test name
2019-02-06 08:23:47 +03:00
Dom Coleman 9a4e13954a Tests for OOP: Inherit Behaviors from a Supertype (#34938)
* Tests for OOP: Inherit Behaviors from a Supertype

Fixes issue #34905

* fix: make test inclusive
2019-02-05 20:44:53 +03:00
John Sprunger 7ae6577cda Change for second test case (#34785)
Original: "Your code should create a method in Bird called getWeight that returns the weight".
New: "Your code should create a method in Bird called getWeight that returns the weight 15".

Since 15 is the only current passing value I feel it should be plainly stated instead in the test case.
2019-02-05 21:07:17 +05:30
Aditya 56ded4174c [Fix] Object Oriented Programming: Remember to Set the Constructor Property when Changing the Prototype (#34569) 2018-12-14 19:59:35 +09:00
Valeriy 79d9012432 fix(curriculum): quotes in tests (#18828)
* fix(curriculum): tests quotes

* fix(curriculum): fill seed-teardown

* fix(curriculum): fix tests and remove unneeded seed-teardown
2018-10-20 23:32:47 +05:30
jefferson2z abc6c3c208 Fix typo on OOP challenge (#18616)
* Fix type on OOP as requested on issue #18091

fix: 
numLegs: 2 to numLegs: 4 

on challenge:
 Remember to Set the Constructor Property when Changing the Prototype

* Update remember-to-set-the-constructor-property-when-changing-the-prototype.english.md
2018-10-14 04:34:41 +05:30
Bouncey ee9f6b2d72 chore(meta): Move challenge meta to challenges root 2018-10-11 02:15:05 +05:30
Lauren Van Sloun 0d5fec5e21 Fixed typo issue in Iterate Over All Properties 2018-10-09 02:54:25 +05:30
Bouncey a859035023 fix(challenge-md): Fix quotes that failed in the transform 2018-10-08 11:38:26 +05:30
Bouncey 8f39bc1288 chore(curriculum): Remove files in wrong format 2018-10-05 15:58:12 +01:00