Commit Graph

1969 Commits (0a0fe2bae5096341e755baf21679c464398d65e5)

Author SHA1 Message Date
Walter Palagi 3d7af80047
fix(learn): React propTypes challenge, improve test text (#39682)
* In React propTypes challenge, improve test text

Fixes #39204

* Remove code tags around "number"

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-24 23:11:05 -07:00
Walter Palagi 104a8068e3
fix(learn): in ES6 spread operator challenge test for arr2 length > 0 (#39680)
* fix(learn): in ES6 spread operator challenge test for arr2 length > 0 too

Fixes #39662

* Accept correction

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2020-09-24 16:14:44 -07:00
Menno 9d2e89984c
fix(learn): add notMatch method to instructions (#39655)
update use regular expressions to test a string with the notMatch method
2020-09-24 22:32:55 +01:00
Nicholas Carrigan 6ccd0d21a1
fix(learn): Update test text in Profile Lookup (#39678) 2020-09-25 00:38:40 +05:30
Nicholas Carrigan d33f5f82a7
fix(learn): Consistent Styling in `Set up a Template Engine` (#39657)
* Replace bold with code

* Typo

* Apply suggested verbiage change.

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* remove code tags from render

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-24 07:10:29 -07:00
Mrugesh Mohapatra 5eed1f6ea1 chore(curriculum): spring cleaning, bump pupeeter 2020-09-24 16:29:55 +05:30
Mrugesh Mohapatra 977d411a97 chore:(deps): apply npm audit fix to all packages 2020-09-24 16:29:55 +05:30
Mrugesh Mohapatra b6ad4d347b chore:(deps): curriculum - update minor and patch 2020-09-24 16:29:55 +05:30
Nicholas Carrigan f132f5157c
feat(learn): Add test for file metadata project (#39625)
* Add tests

* Switch from local file to CDN

* remove extraneous declaration

* Apply review suggestions
2020-09-23 20:21:09 -07:00
Konstantinos Lamogiannis 82c8d6d3de
fix(curriculum): update db method used in implementation-of-social-authentication-iii (#39651)
* fix: update method used from findAndModify to findOneAndUpdate

Updating the method used at implementation-of-social-authentication-iii, both for english and chinese

* fix: changed text findAndModify to findOneAndUpdate

* fix: removed chinese file

* Update curriculum/challenges/english/06-quality-assurance/advanced-node-and-express/implementation-of-social-authentication-iii.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-23 15:21:26 +00:00
Darren Stoll 2f4d1c2804
fix(learn): correct typo in description (#39653)
Remove hyphen in word 'view engine'
2020-09-23 06:59:23 +00:00
Nicholas Carrigan 3969f651b8
Remove helmet test instructions (#39613) 2020-09-22 14:42:25 -05:00
Randell Dawson b976225602 fix(curriculum): remove isRequired from russian 2020-09-21 20:51:46 +05:30
Randell Dawson 4eac81d616 fix(curriculum): remove isRequired from spanish 2020-09-21 20:51:46 +05:30
Randell Dawson a4437e5a98 fix(curriculum): remove isRequired from portuguese 2020-09-21 20:51:46 +05:30
Randell Dawson 8fdcf773a7 fix(curriculum): remove isRequired from chinese 2020-09-21 20:51:46 +05:30
Randell Dawson 63b1bee78f fix(curriculum): remove isRequired from arabic 2020-09-21 20:51:46 +05:30
Sky020 a86b220eb7 chore: remove isRequired from curriculum files 2020-09-21 20:51:46 +05:30
Tom 181713aa10
Fix/remove broken scrimba (#39619)
* fix: remove broken scrimba video link

* fix: revert file structure
2020-09-18 17:38:37 -07:00
Joseph Mawa d8e8da36a0
Fixed tests for JS Basic Algorithms: Slice and Splice challenge as suggested in issue #39560 (#39610) 2020-09-18 11:30:56 -07:00
Joseph Mawa d5000b5d0f
Removed note about promise chaining as suggested in issue #39487 (#39609) 2020-09-18 10:30:37 -05:00
Gaurav Khairnar a338d4b79d
fix(learn): clear instructions for basic JavaScript: Appending Variables to Strings lesson (#39587) 2020-09-17 13:00:58 -05:00
ZhichengChen 6021a32de9
fix(i18n): update Chinese translation of react (#38657)
Co-authored-by: Zhicheng Chen <chenzhicheng@dayuwuxian.com>
2020-09-17 21:43:42 +05:30
ZhichengChen 4605ec5ec6
fix(i18n): update Chinese translation of data visualization with d3 (#38847) 2020-09-17 21:43:05 +05:30
ZhichengChen 8e0c063298
fix(i18n): update Chinese translation of managing packages with npm (#38888)
* fix(i18n): update Chinese translation of managing packages with npm

* address comments

Co-authored-by: S1ngS1ng <liuxing0514@gmail.com>
2020-09-17 21:42:32 +05:30
ZhichengChen 27b0af120a
fix(i18n): update Chinese translation of apis and microservices projects (#38909)
Co-authored-by: S1ngS1ng <liuxing0514@gmail.com>
2020-09-17 21:41:18 +05:30
Hassaan Pasha 80438cac3e
feat(client, learn): add helper functions for common validation operations (#38605)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-17 19:38:01 +05:30
Xing Liu 3c223c2c7a
feat(i18n/Chinese): add translation of install and set up mongoose (1/4) (#39539) 2020-09-17 16:23:54 +05:30
Xing Liu 7865d0d0f0
feat(i18n/Chinese): add translation of Information Security with HelmetJS (2/4) (#39540) 2020-09-17 16:23:22 +05:30
Xing Liu 585c88f01d
feat(i18n/Chinese): add translation of Quality Assurance and Testing with Chai (3/4) (#39541)
with Chai
2020-09-17 16:20:23 +05:30
Xing Liu ab4a4a0697
feat(i18n/Chinese): add translation of Advanced Node and Express (4/4) (#39543) 2020-09-17 16:19:58 +05:30
Randell Dawson 85925b5a30 chore: move to tools/challenge-helper-scripts 2020-09-17 16:17:37 +05:30
Randell Dawson 258bb3a10f fix: added triple backticks to close code section
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-09-17 16:17:37 +05:30
Randell Dawson affff68bca fix: get curriculum path relative to tools folder 2020-09-17 16:17:37 +05:30
Randell Dawson 282e7d922b feat: create script to add step between two steps 2020-09-17 16:17:37 +05:30
Ajeeth thangarasu 8223903aac
Removed 'videoUrl' (#39601) 2020-09-16 19:04:58 -07:00
Ajeeth thangarasu 8db3fc2df4
removed videoUrl (#39600) 2020-09-16 19:01:47 -07:00
Randell Dawson 30c61b808b
fix: consolidate misc comments (#39583) 2020-09-16 13:29:50 -05:00
Oliver Eyton-Williams 078b06e462 fix(curriculum): isUpcomingChange: true for new projects 2020-09-16 11:54:14 +05:30
Oliver Eyton-Williams 7bed07ee8a fix(tools): update parser for multi-file editor 2020-09-16 11:54:13 +05:30
Randell Dawson 06da30e48a feat(learn): Basic CSS Cafe Menu instructions and hints/tests (v7) (#39407)
* feat: created step instructions for cafe menu

fix: added instructions to steps 1-31

fix: changed steps 29-31

fix: added instructions for steps 32-42

fix: changed prototype class definition

fix: padded file names

fix: added instructions for steps 43-61

fix: add object id to final.md and final prototype to meta.json

fix: correct typos in steps 26 and 27

fix: misc wording changes

fix: added forward slash to closing html tag

fix: added instructions for steps 62-75

feat: added instructions to steps 76-79

fix: added FOOTER comment for steps 68-75

fix: add steps 68a and 68b

fix: add steps 69a and reorder steps

fix: added instructions to the final steps

* fix: remove final.md

* fix: fixed typo of menue to menu

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed wording to improve readability

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed wording to improve readability

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed wording to improve readability

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: combined two lines into same paragraph

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-09-16 11:54:13 +05:30
Randell Dawson 7abf0fde34 fix: correct filenames in d3 dashboard project 2020-09-16 11:54:12 +05:30
Randell Dawson 7565849d7d feat(learn): Added project-based curriculum tools (#39448)
* feat: added project-based curriculum tools

* fix: allow script to work /w or /wo npm run

* fix: moved console.log to reorder-steps function

* fix: integrated bson-objectid library
2020-09-16 11:54:12 +05:30
Randell Dawson b9c9a95223 chore(learn): Renamed all project-based curriculum project step filenames to use 3-digit format of part-ddd.md (#39463)
* fix: renamed basic html cat photo app steps

* fix: renamed css-variables project steps

* fix: renamed d3-dashboard filenames

* fix: renamed rpg-game filenames

* fix: renamed functional-progamming-spreadsheet filenames

* fix: renamed calorie-counter project filenames
2020-09-16 11:54:12 +05:30
Oliver Eyton-Williams 9df098953d Feat: editable dom element (#39341)
* feat: __testEditable allows editable region tests

It's not entirely isolated, but it makes it possible to select only the
element with id 'editable-only' which is built solely from code inside
the editable region.

* fix(client): missing editableContents -> ''

Previously it was added as the string 'undefined'

* fix: more informative error messages

* fix: DRY, correct and test getLines
2020-09-16 11:54:11 +05:30
Randell Dawson 69e3e138f6 fix: added missing ERMs to challenge seed 2020-09-16 11:54:11 +05:30
Randell Dawson 3b8e257643 fix: corrected freecatphotoapp.com link 2020-09-16 11:54:09 +05:30
Randell Dawson fd6f8b5cd4 feat(learn): Update Basic HTML Cat Photo App project descriptions and hints and tests (v7) (#39131)
* feat: added Cat Photo App project

Added new steps

feat: add tests + targetted hints for demo

simplify wording and combine some tests

feat: update text and add tests/hints

fix: changed descriptions and tests

feat: added tests for part 11 - 15

fix: reworded description for steps 2 and 10

fix: changed isBeta to isHidden

fix: temporarily remove fcc-editable strings

fix: added project to challengeTypes.js

fix: added missing parentheses

fix: test text improvements

fix: changes to tests and text discussed in meeting

fix: adjust logic for detecting indentation in part 07

fix: missing regex characters and made last test more permissive for part 04

feat: add steps 25 to 55 and notes

fix: added h1 element back to steps 5-24

fix: h1 and h2 elements from steps 25 to 50

fix: added missing DOCTYPE declaration steps 20-24

fix: miscellaneous text edits

fix: break up part 28, change local paths for images to short s3 cdn URLs

fix: part 01 and 02 descriptions and tests

feat: pull in changes from #39145 and remove solution sections

fix: adjust descriptions and break up steps 33 and 35

fix: break up more steps and adjust text

feat: add tests for parts 25 - 30

* fix: ran reorder-steps.js

* fix: added editable region markers

* fix: standardize opening tag hint text

* fix: remove trailing periods from descriptions and hints and adjust tests

* fix: remove unnecessary instructions sections

* fix: added test to check for only one h1 element

* fix: removed comma

* fix: changed paragraph element to `p` element

* fix: added test for extra h1 element

* fix: test to validate only one img element exists

* fix: replaced code tags with backticks

* fix: reworded description

* fix: reworded step description

* fix: changed tests for first step

* fix: change last two alt values to sentences

* fix: check for spaces in text strings

* fix: removed extra dot before replace method

* fix: moved example before instruction

* fix: rearranged step 6 tests

* fix: capitalized p in paragraph

* fix: rewored step 7's description and a test text

* fix: corrected test for step 8

* fix: improved step 9 tests

* fix: moved example above instruction

* fix: corrected step 9 test wording

* fix: rearrange test order for step 10

* fix: moved example before instructions for step 11

* fix: improved step 12 descripton and tests

* fix: corrected tests for steps 9, 10, 11, 13, 14

* fix: added ERMs to steps 4-14

* fix: minor typos

* fix: reword steps so examples are above instructions

* fix: introduce inline and block elements and use divs instead of br

* fix: add or adjust tests for steps 15 - 27

* fix: moved ERM up one line

* fix: removed unnecessary quotes in tests' text

* fix: added dfn tags for step 45

* fix: removed adding # to href step

* fix: tests 15 - 16

* fix: reword descriptions so they're not as hand holdy

* fix: reorder/reword steps 58 - 60

* feat: simplify radio button steps

* fix: wording and add demo step

* fix: remove doctype and teach in last step

* fix: update part-demo

* fix: added some more step 15 hints

* fix: added step to introduce section elems

* fix: added section elements to project

* fix: update final code

* fix: update tests for 15a and 16

* fix: add section elements to parts 45 to 61

* fix: change p elements to h3, update tests and text

* fix: added new test for step 9

* fix: fixed/added tests for steps 15-30a

* fix: use fieldset elements instead of divs in the form

* fix: added new test to setp 30a

* fix: changed `main` to `section`

* fix: corrected/added tests for step 31

* feat: add tests 32 - 36

* fix: revert change to js rpg game

* fix: simplify tests 32 - 36

* fix: updated submit-cat-form url

fix: changed submit-cat-form url

* fix: added/rearranged tests steps 32-36

* fix: added tests for step 36a

* fix: used hasAttribute where applicable

* fix: misc edits for steps 10 and 35-36a

* fix: add tests to step 37

* fix: reworded step 37

* fix: added more verbiage to steps 35 and 36

* fix: modified step 38 desc and added tests

* fix: added hints/tests for step 40

* fix: added hints/tests for step 41

* fix: added hints/tests for steps 42 and 43

* fix: made attribute values match exactly

* fix: change wording from text input to text field

* fix: rearrange name attribute lessons

* feat: tests for 44 - 44b

* fix: added a step  35a

* fix: added name="catphotourl" to steps 36-61

* fix: reworded steps 41 and 43

* fix: removed intro to for attribute

* fix: rewrite of step 44b's desc and tests

* fix: added step 45 hints/tests

fix

* fix: removed for attribute from steps 45a-61

* fix: removed extra )

* fix: wrapped "section" with backticks

* fix: added test for steps 45a and 45b

* fix: adjust position of label steps 55-61

* fix: removed conole.log statements

* fix: added tests to step 45c

* fix: renamed step 49 to step 46a

* fix: moved label element for steps 48-53

* fix: reworded step 47 description and instructions

* fix: typos in description and test text

* feat: add tests 46-48

* fix: wording

* fix: remove case insensitivity from a couple of tests

* fix: wording and add erms

* fix: add additional test for step 48

* fix: added hints/tests for step 50

* fix: added hints/tests for step 51

* fix: added hints/tests to step 53

* fix: added hints/tests for step 55

* fix: added hints/tests for step 56

* feat: tests for 57-61

* fix: removed duplicate test in step 55

* fix: adjusted 1st test for step 57

* fix: simplified test for title text

* fix: improved tests for step 60-61

* fix: removed demo.md file

* fix: ran reorder-steps.js

* fix: part 10 description

* fix: part 14 description

* fix: part 24 - move ERMs

* fix: part 05 description

* fix: part 54 test text

* fix: part 06 - wording and add test for p and main closing tag order

* fix: part 50 - add test to check for order of fieldset elements

* feat: value attribute for radio buttons step and seed changes

* feat: value attribute for checkboxes step and seed changes

* fix: update part 14 description

* fix: revert ERMs for part 24

* fix: remove last test in part 06

* fix: text and typos for new radio and checkbox lessons

* fix: text and typos for new radio and checkbox lessons

* fix: add test to part 01

* fix: ran reorder-steps.js

Co-authored-by: Kris Koishigawa <scissorsneedfoodtoo@gmail.com>
2020-09-16 11:54:09 +05:30
Oliver Eyton-Williams 68b223322f feat: make editable code available in tests 2020-09-16 11:54:09 +05:30
Oliver Eyton-Williams 0f3f27287d fix: unify single and multifile testing 2020-09-16 11:54:08 +05:30