* Modify if statement
Change the solution so an empty string is returned when num is less than 1 rather than less than 0 for consistency with instructions.
* Add test
New test checks that if num is 0, an empty string is returned
* Fix test
Fixing errors in newly proposed test that checks that empty string is returned when num is 0
* Modify intermediate solution
Changing if statement in intermediate solution to check whether num is less than 1 rather than less than 0. (Also adding curly brackets to that solutions if/else statements.)
* fix: removed unnecessary assert message arguments
* fix: convert js algorithms and data structures
* fix: revert some blocks back to blockquote
* fix: reverted comparison code block to blockquotes
* fix: change js to json
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: convert various section to triple backticks
* fix: Make the formatting consistent for comparisons
* fix: reworded and moved challenge
* fix: removed extra line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix; removed extra line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: reworded sentence
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: add test for and slight rewrite to hazards of imperative
* fix: Resolve merge conflict
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/understand-the-hazards-of-using-imperative-code.english.md
Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
* fix: Make the only mistake in seed the use of splice
* fix: split tests into two requests
* fix: removed typeof number check
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: remove unneeded After Test section
* Edit Instructions Text To Make Goal Clearer
The instructions end with "using the object provided" which is unclear since the user is expected to create their own name for the object. Users may think they need to reference an object name and be confused when they do not find it. Reiterating that the user needs to create the name for the object themselves makes the task clearer.
* Updated commit based on comments
Fixes#35793
I rearranged the variables in one of the tests.
I just changed the english file. Should I change the rest of the languages as well?
Note: I did this change through github's API, because I couldn't run the project locally so I haven't actually tested it.
* Update use-arrow-functions-to-write-concise-anonymous-functions.english.md
* refactor: fix the assert messages to make them more like all the rest in the curriculum (i.e. using `should`)
Co-Authored-By: iliyaZelenko <iliyazelenkog@gmail.com>
* Fix(Curriculum): Constructor function not explained before ES6 #17865
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md
Co-Authored-By: hilliarj <hilliarj@dickinson.edu>
* Update to #17865 PR
Fix(Curriculum): Constructor function not explained before ES6. Used an unordered list and the syntax that others recommended.
* fix/update-es6-destructor-challenge: Added test
- Added test incase during destructuring somebody pass and extra key
* fix/update-es6-destructor-challenge: Fixed the test case per review comments
-Cleaned up regex
- Setup two cases one where additional assignment of variables before and then after
- Did not put uppercase case CONSTANT checks because not related to question
* fix: corrected tests
* Fixed bug in 2nd test for Access Multi-Dimensional Arrays With Indexes Challenge
* Fix for issue #35665
Fixed Bug In 2nd test case for Access Multi Dimensional Arrays With Indexes
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-multi-dimensional-arrays-with-indexes.english.md
Co-Authored-By: Artistic18 <hrishitbiswas20@gmail.com>
* fix: added missing ) for assert statement
* Update description of tests pig-latin.english.md
The last two tests "Should handle words where the first vowel comes in the end of the word." and "Should handle words without vowels." are too vague without examples of what is meant by that.
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/pig-latin.english.md
Co-Authored-By: beansprout <christinegierer@gmail.com>
* Fix tests
- fix original log() method restoration
- fix case that other userscripts(or extensions) can affect console output and therefore can ruin the test
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/write-reusable-javascript-with-functions.english.md
allow function calling without semicolon
Co-Authored-By: T1mL3arn <T1mL3arn@users.noreply.github.com>
* Added example Input/Output to challenge
Input/Output example will make it clear what the challenge is asking the camper to do.
* Formatting changes made to file
* Made minor changes in formatting
Added <code> tag to single line code.
* Formatting update
* Added requested formatting changes
* Refactored sentence and removed earlier example
* fix(coding): uncomment destructuring test and add solution
the test that ensured destructuring was being used had been left commented out and there was no solution offered. I uncommented the test and verified it worked as well as added the solution.
* fix: corrected partial solution to full
* fix: update text of Write Higher Order Arrow to be more instructive
* fix: update tests and code to be more simple. Edit typos in text part. Prepare for PR
* fix: further changes to PR
* fix: checkout old head. Merge later commit with older commits
* fix: add MDN links to arrow-functions guide
* fix: re-add removed log and change working in guide wording
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md
Yep
Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md
Removing unneeded line for clarity
Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
* Add test reflecting #19390
Added two tests to prevent checking only `Alan`.
* Split into 4 tests for each prop
Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace
* Update: Added info re uppercase and lowercase
Included information to explain that lowercase and camelCase can be used for const identifiers.
* Fix: corrected mutable to immutable
I corrected the error that uppercase is used for mutable values.
* Fix: changed ** ** to <strong></strong>
I changed the markdown ** ** to <strong></strong>, as I was informed that ** didin't work.
Added Solution to the problem Change the regex favRegex to match both the American English (favorite) and the British English (favourite) version of the word.
* Correct seed code errors
Corrects the problems raised in issue #13157 - campers can focus on solving the challenge rather than fixing bugs; functions have the correct return value now.
* Add single quotes to correct new assertion statements
* Fix incorrect usage of splice
Changed the parameters passed to bookList.splice in the remove function
* Remove extraneous tests
* fix(challenges): Update challenge text and assertion test
* fix(challenges): update assert test regex
* fix(challenges): update regex, fix inline comment in code example
* fix: corrected regex
Original: "Your code should create a method in Bird called getWeight that returns the weight".
New: "Your code should create a method in Bird called getWeight that returns the weight 15".
Since 15 is the only current passing value I feel it should be plainly stated instead in the test case.
* Add the solution
* Update divide-one-decimal-by-another-with-javascript.english.md
The solution was not passing. Change should pass now.
* Update divide-one-decimal-by-another-with-javascript.english.md
Co-authored-by: Paul Gamble <pgamble@gmail.com>
* added explanation of private variable naming convention
* Added "Note:" to the front of the explanation
* Added solution
* Moved "Note:" to it's own line and made it bold
* fix: moved note block at the bottom
(?=\D*\d) is looking for a non-number to precede a number. If '12Three' was passed in to test, it would not match though it matches the stated criteria of 5 character minimum length and two consecutive numbers.
* Update compare-scopes-of-the-var-and-let-keywords.english.md
* Updated line
Co-Authored-By: thecodingaviator <34807532+thecodingaviator@users.noreply.github.com>
* Format the document
* Fix line for Example
Bolded Example is inline with description. Added new line so that Example will have its own line (right before the actual example)
* Add line break after Description
* added note about UpperCamelCase for ES6 classes
proposed note in issue #17864
* added note as a new heading
changed from note as a sentence to note as a heading plus the actual note
* added <code> around SpaceShuttle
* removed markdown and added <strong> tag
Modification in the sort function to implement the better practice of returning 0 for the same elements. Not implementing the practice can break the function in new browsers.
* fix: removed all ​ from tests verbiage
* fix: added single quote to start text string
* remove single quote from text line
* fix: removed the hidden chars in the testStrings
* fix: removed hidden chars from testString section
* fix: removed hidden chars form testString part
* fix: removed hidden chars from testString part
* fix: removed hidden chars from testString part
* feat: Update intro to currying
- Add solutions
- Add ES6 examples
* feat: Add solution to FP mutations
* feat: Add solution to function-programming map
- Add solutions, both vanilla and ES6 arrow functions
- Add JSON.stringify to console.log, makes it easier to see what the resulting output is rather than showing
e.g. [object, object, object]
* update: used the contributor's ES6 solution
Contributor originally had a non-ES6 solution and an ES6 solution. I removed the non-ES6 solution.
A test that featured nested arrays just happens to work, but nested arrays will not be removed if they’re duplicates by the current solution of this challenge. See issue #18265
* Fix type on OOP as requested on issue #18091
fix:
numLegs: 2 to numLegs: 4
on challenge:
Remember to Set the Constructor Property when Changing the Prototype
* Update remember-to-set-the-constructor-property-when-changing-the-prototype.english.md
Tom
moT01
Randell Dawson
Oliver Eyton-Williams
Michał Kozłowski
Siddhant Shekhar
Natalie Cardot
Varun
Matt Schlosser
Deanna Tran
Randell Dawson
RIHANE ZAKARIA
Aly Pilkons
BSi
Guayo Mena
Manish Giri
Kristofer Koishigawa
Илья
Amy Lam
lucassorenson
Lipis
Justin Hilliard
seanlaing
Hrishit Prasad Biswas
Christine Gierer
Aditya
Vikas KM
Hugo
Timur
Chuck Adams
grets311
Jade Michael Thornton
lasjorg
NITIN BISHT
Lauren Van Sloun
Lewis Horwood
Alan Price
Akshay Tiwari
Aashis kumar
Ihor Allin
Luane
Christopher McCormack
hilliarj
Ruchika Sharma
Niraj Nandish
Pete
geeseyj
Chris Del
TristanSeabrook
Almaz Kunpeissov
Fordco
rupali317
Lee
Kirill Malev
Christopher Szczechowicz
BurnhamG
Beau Carnes
Valeriy
Julien Galibois Sauvageau
Dom Coleman
Chelsea Marie Hicks
John Sprunger
Pepijnk12
The Coding Aviator
Paul Gamble
Casey Bennington
Joe Erickson
buhidar
Nhat Khanh
Ashish Singh
Adrian Skar
Ben Brown
Ariel
Abhishek Kakade
Mike Perry Yeboah Attara
Kenford20
Greg Brewton
mail-liam
Prabhat Kumar Sahu
Carol W
Eric Kao
Martin Payne
Shreyas BS
Bannon Tanner
Utkarsh Raj Singh
greggubarev
petern
Jonathan Grah
Ryan Bowlen
johngeesey
jefferson2z
Bouncey
halcyondays22
Lauren Van Sloun