Commit Graph

21796 Commits (1b4ce7e18857dceb5a4fbf25419178e91dea06e6)

Author SHA1 Message Date
Bouncey 75190d3a43 feat: Add challenge validation middleware 2019-02-26 00:17:02 +05:30
Nellie ff23e94e25 Update add-elements-within-your-bootstrap-wells.russian.md (#28969)
Fixed Russian translation in add-elements-within-your-bootstrap-wells.english.md.
2019-02-25 21:58:59 +04:00
geeseyj f3fd951446 fix(coding): uncomment destructuring test and add solution (#18909)
* fix(coding): uncomment destructuring test and add solution

the test that ensured destructuring was being used had been left commented out and there was no solution offered. I uncommented the test and verified it worked as well as added the solution.

* fix: corrected partial solution to full
2019-02-25 23:27:50 +05:30
Christopher McCormack 35b3495be1 fix: correct unbalanced <code> element spacing (#35344)
* fix: removed pseudo-elements and replaced with padding to fix unbalanced <code> element spacing

* fix: adjusted formatting to use white-space property instead of changing padding
2019-02-25 16:37:58 +03:00
mrugesh mohapatra 84c8aac07c fix(styles): apply conventional styles (#35371)
* fix(styles): apply conventional styles

* fix: add night styles to progress
2019-02-25 15:58:40 +03:00
seanjs 30b630b5b7 Realign indentation and checkstyle of bracket (#29205)
* Realign indentation and checkstyle of bracket

* Update index.md
2019-02-25 18:17:43 +09:00
hwannee f6b7958094 Correct wrong bracket 2019-02-25 17:46:35 +09:00
Koustav Chowdhury d226f4ceaa Changed as per review 2019-02-25 16:45:05 +09:00
Koustav Chowdhury d4848df011 Alternative way to sort a vector 2019-02-25 16:45:05 +09:00
Gökhan Gurbetoğlu 2efc5a8e7b Fixes for CSS Flexbox challenges (#34420)
* Make property names monospace

Property names as monospace would be more fitting to this challenge.

* Add default value for align-items

According to the standard, the default value for align-items, if it is not specified, is stretch.
Source: https://www.w3schools.com/cssref/css3_pr_align-items.asp

* Add monospace font for code elements

These elements need to be in a monospace font.
2019-02-25 02:11:47 -05:00
Randell Dawson 9e07f99b9e fix(curriculum): Added test to validate clockwise notation is used for the Use Clockwise Notation to Specify the Margin of an Element challenge (#35342)
* fix: corrected last test which validates clockwise notation

* fix: removed helper function

* fix: used jQuery to get style and removed extra slash
2019-02-25 02:07:11 -05:00
Alan Nguy 5d3ea76a3e fix: fixed styling for modal headers (className fcc-modal) (#35220) 2019-02-25 12:31:17 +05:30
Enjel Hutasoit 544401abd5 Add example explaination (#33226) 2019-02-24 21:58:06 -08:00
v01d3tr 0f905531df feat: added info about typeof null (#26899)
* feat: added info about typeof null

* Further clarify change
2019-02-24 23:43:49 -05:00
Shashank Goyal ef625c80c6 Fix output of sample code (#28971)
sample code to avoid using shared or mutable state has output commented as 2 while it should be 1.
2019-02-24 18:46:13 -08:00
Amaka Mbah 36d1a7d369 Fix typo on line 6. Add info on line 6 & 7 (#31531) 2019-02-24 19:19:09 -07:00
Christian Coffey 145a94f192 Update index.md (#30085)
Removed an unnecessary example as well as changed the description for the usage of the 'await' keyword. Also added an example for async method declarations.
2019-02-24 19:03:33 -07:00
justingiffard 97834c64d2 Fixed example 2 so that its runnable (#22328)
added some some time consuming code and a return to `CalcDamage`
removed `static` from `CalcTotalDamage` so that the compiler doesn't complain that `CalcDamage` should be static
compiler wasn't happy with `totalDamage += CalcDamage(player);` or `return await Task.WhenAll(totalDamage)` because you are attempting to assign a Task to an int. Fixed it by using `WhenAll` correctly
Changed parameter name of `CalcTotalDamage` from `group` to `people` as  `group` can  be confusing to read as its used with linq
2019-02-24 18:36:06 -07:00
NITIN BISHT f224bbc62f fix: seed code doesn't match description [arabic] (#35382) 2019-02-24 16:29:51 -06:00
Adam 36d0d5d70f Added description to help understand challenge (#34674)
* Added description to help understand challenge

I added a short description at the beginning to explain that the user needs to use a different starter project than the one they were using earlier.

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md

Looks good!

Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md

True, that makes sense..

Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>
2019-02-24 12:27:12 -07:00
Ahmed Elbessfy 61a5707ba7 Edit Description (#34329)
* Edit Description

Making some editing to make the description more understandable. I am a beginner but I think me edits makes more sense. If you think so, please merge them for helping others.

* Update curriculum/challenges/english/03-front-end-libraries/react/pass-props-to-a-stateless-functional-component.english.md

Co-Authored-By: Ahmed-Elbessfy <ahmedelbessfy@gmail.com>
2019-02-24 12:22:56 -07:00
Nguyen Viet 063257939b add php tag + update coding style (#26602)
should use all camel case for method
2019-02-24 09:41:44 -08:00
isha2812 caf6d3446f added recursive implemenation in c++ in index.md (#26218)
* added recursive implemenation in c++ in index.md

* fix: formatting/syntax highlighting
2019-02-24 10:17:31 -07:00
Vyrza d6cb576e89 Add further references (#33511)
* Add further references

* fix: added formatting for links using bullets
2019-02-24 09:53:18 -07:00
SpeedX 01bd850d3c Updated some new usages (#31635)
* Updated some new usages

Displaying information using wild card and merging file usuage added

* fix: resolve-conflicts
2019-02-24 10:32:57 -06:00
Christian Garcia ee635832ad fix(guide): typos and grammar in quickselection (#29284) 2019-02-24 10:32:26 -06:00
Irfan N.Hamid f79843e7ee Added Ionic Logo (#29332) 2019-02-24 09:24:31 -07:00
Wingman J. Lee 58a2313e29 changed 'redirect' to 'redirecting' (#27983) 2019-02-24 09:05:23 -07:00
aizelagustino d45f3c4c9f Added link to elm-lang.org (#33035) 2019-02-24 09:04:44 -07:00
Sashweana a495944a28 Added features (#28508)
- Added Audits feature
2019-02-24 09:01:03 -07:00
Wendy Gonzalez a3b74bb020 added way to access dev tools (#27432)
Noticed the two items listed under 'accessing the dev tools' weren't consecutive steps so I changed them to unordered list and added a third way
2019-02-24 09:00:22 -07:00
NITIN BISHT a9e4e88cbe fix: seed code doesn't match description [russian] (#35384) 2019-02-24 09:59:49 -06:00
NITIN BISHT 1fd4177354 Fix/seed code does not match description chinese (#35381)
* fix: seed code doesn't match description [english]

* fix: seed code doesn't match description [chinese]
2019-02-24 09:08:10 -06:00
NITIN BISHT b5468932f0 fix: seed code doesn't match description [english] (#35380) 2019-02-24 09:02:56 -06:00
lasjorg 0a7932ea1d fix(challenge): update test to support arrow function (#35268)
* fix(challenge): update test to support arrow function

* fix(challenge): update solution

* fix(challenge): update solution fully

* fix: corrected unrelated issue
2019-02-24 08:54:37 -06:00
NITIN BISHT 815cb03f2b fix: seed code doesn't match description [portuguese] (#35383) 2019-02-24 08:26:33 -06:00
riodajs d341c16aae Add some words (#23297)
like "uncomment" to "borrando etiquetas de comentarios"
2019-02-24 14:26:49 +01:00
riodajs 83ff4a53e7 Change some words conjugations. (#23261) 2019-02-24 13:46:29 +01:00
riodajs a5e5e1de50 Changet text "Usted especifique" to "tú especificas" (#23226) 2019-02-24 13:46:04 +01:00
Valeriy S 661a7705fd fix(client): do not throw on SASS compile errors 2019-02-24 12:35:46 +00:00
Edwin J. Munguia 803836db66 Translated remaining English text into Spanish (#23132) 2019-02-24 12:54:56 +01:00
Santiago 4f1f4238c2 Small Consisteny Fixes (#34107)
Consistency with the 'tu' way of refering to you.
Translated the html code part to spanish
2019-02-24 12:53:46 +01:00
Diego Arias García f1efc85ccb Fixed Translation Errors (#22754) 2019-02-24 12:07:59 +01:00
Diego Arias García 1ee9f6223c Grammar Errors fixed (#22749) 2019-02-24 12:00:56 +01:00
NITIN BISHT c9628f0296 fix: seed code doesn't match description [spanish] (#35385) 2019-02-24 13:47:08 +05:30
Chris Del 10e9c6f340 Update Higher-Order Arrow Functions code challenge (#34414)
* fix: update text of Write Higher Order Arrow to be more instructive

* fix: update tests and code to be more simple. Edit typos in text part. Prepare for PR

* fix: further changes to PR

* fix: checkout old head. Merge later commit with older commits

* fix: add MDN links to arrow-functions guide

* fix: re-add removed log and change working in guide wording

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Yep

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Removing unneeded line for clarity

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
2019-02-24 13:34:53 +05:30
Randell Dawson b83ab53047 [Fix] Corrected bug found in Shopping List challenge (#35017)
* fix: corrected bug found in issue #16044

* fix: account for empty strings

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: corrected wrong logic
2019-02-24 13:28:55 +05:30
codestin 5b73ed54e2 Update index.md with grammatical, spelling fixes (#28874) 2019-02-23 23:04:40 -08:00
Ian McCormack c91b475917 Corrected grammer, additional info & search glyph added. (#31431) 2019-02-23 22:54:20 -08:00
Jtorres68 e9478456f9 Added envelope and print icon and grammar fixes (#29261) 2019-02-23 22:36:01 -08:00