Commit Graph

246 Commits (1fb1a090e4bad84a9f01309e543248b02a8afe59)

Author SHA1 Message Date
Oliver Eyton-Williams 1fb1a090e4
test: allow CI to install current Cypress version (#46172) 2022-05-27 11:24:48 +02:00
renovate[bot] 385816436f
fix(deps): pin dependencies (#46128)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-05-24 12:57:08 +05:30
Mrugesh Mohapatra 359b823247
chore: drop dependency-review action (#46121) 2022-05-23 21:20:44 +05:30
Mrugesh Mohapatra 2b223704f6
fix(github): update issue templates (#46073) 2022-05-19 21:34:03 +05:30
Niraj Nandish 0f49664db2
fix(ci): update workspaces to pass NodeJS CI (#45980) 2022-05-15 20:14:25 +05:30
Naveen 2d05f98430
feat(.github): add dependency review action (#45879)
* chore(deps): Included dependency review

> Dependency Review GitHub Action in your repository to enforce dependency reviews on your pull requests.
> The action scans for vulnerable versions of dependencies introduced by package version changes in pull requests,
> and warns you about the associated security vulnerabilities.
> This gives you better visibility of what's changing in a pull request,
> and helps prevent vulnerabilities being added to your repository.

https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/about-dependency-review#dependency-review-enforcement

* Update .github/workflows/dependency-review.yml

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-05-10 15:31:02 +01:00
Oliver Eyton-Williams cf4b9a1557
feat: client overhaul proof of concept (#45844)
* chore: initial setup of web package

This is *not* a workspace, yet, because it would be nice to use the
latest React, but /client can't migrate (yet).

Having two React versions creates issues in workspaces since /.bin/next
gets hoisted to root... and finds the root React version :(

* feat: add config for next

* fix: use jsx-runtime for web linting

* chore: init curriculum-server with json-server

* chore: integrate curriculum-server with TS/eslint

* feat: add patch script

json-server doesn't like keys with '/'s in so, for now I'm just patching
them out.

This lets us keep a strong separation between this WIP and the rest of
the code.

* fix: use port 8000 to avoid conflicts

* feat: crude ISR demo using challenge pages

* feat: extend ISR demo to use params

* feat: return props for specific superblocks

* chore: re-organise folders

* refactor: put data fetching in a single module

* refactor: challenge page slightly

* feat: add link to test ISR

You can see that, if you run next dev, the linked page gets regenerated
whenever you navigate to it.  However, if you run next build that is no
longer the case and the page has to be reloaded for the user to see the
latest version.

The implication is that we'll need another method (Web worker, probably)
to detect if the page needs to be updated.

* feat: render static paths for rwd

* feat: add monaco Editor

* feat: send less data via props

Rather than sending superblocks, this now sends blocks. Next step, just
the challenge!

* fix: only send individual challenge's data

* feat: send /learn/stuff/<id> to the challenge page

* fix: redirect to path with trailing id

* fix: handle all possible path prefixes

* feat: add superblocks with trailing ids

* chore: rename block -> blockOrId

* chore: remove logs

* fix: return notFound if page id is missing

* chore: add a note about increasing TS strictness

* feat: serverside redirects

This should be a touch more performant, but mostly it separates the
concerns.

Since the server already has the responsibility of choosing what pages
to render, redirects fit naturally with its concerns.

* refactor: clean up param validation

* feat: create list of blocks in superblock

* feat: add challenge links to map

* feat: link to full path, not just id

* refactor: ensure props match getStaticProps

By specifying the props for GetStaticProps we ensure that it returns the
expected data and use InferGetStaticPropsType to get the type out again
for use in the component

* feat: improve and document dev experience

* refactor: separate routing from rendering

* refactor: extract routing logic into functions

* refactor: naming consistency

* refactor: move data wrangling into get-curriculum

* refactor: align blockOrId and id

* chore: remove the server from workspaces

* chore: remove the lock

* docs: paths

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* chore: install before linting

* fix: create env.json before installing new client

* chore: ignore generated json file

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2022-05-09 11:30:15 -05:00
Naveen f2580f58a6
chore: set permissions for GitHub actions (#45876)
* chore: Set permissions for GitHub actions

 Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.

- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions

https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)

Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>

* Update .github/workflows/codeql-analysis.yml

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>

* Update .github/workflows/labeler.yaml

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>

* Update .github/workflows/node.js-tests-upcoming.yml

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>

* Update .github/workflows/node.js-tests.yml

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>

* Update .github/workflows/codeql-analysis.yml

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>

* Update .github/workflows/labeler.yaml

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>

* Update .github/workflows/labeler.yaml

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-05-08 15:17:44 +05:30
Naomi Carrigan bc9634a799
feat: migrate to issue forms (#45858)
* feat: migrate to issue forms

* fix: validation errors

* feat: add description field
2022-05-04 12:25:39 -05:00
Huyen Nguyen ebf7186b44
chore: correct comments in github workflows files (#45855) 2022-05-03 11:23:02 -07:00
Naomi Carrigan 3999de294f
chore: a couple more places to update security policy (#45782) 2022-04-28 21:12:22 -05:00
Oliver Eyton-Williams 4cc20172c5
fix: fallback to english challenges (#45635)
* fix: fallback to english challenges

All challenges will use the english version if a translated file is not
available.  SHOW_NEW_CURRICULUM still gates what's shown in the client.

* refactor: use closures to simplify createChallenge

* refactor: remove messy destructure

* refactor: add meta via helper

* fix: fallback to [] for meta.required

* fix: repair challenge.block

* refactor: use CONST_CASE for meta + challenge dirs

* fix: catch empty superblocks immediately

* fix: clean up path.resolves

* fix: invalid syntax in JS project steps

* fix: default to english comments and relax tests

Instead of always throwing errors when a comment is not translated, the
tests now warn while SHOW_UPCOMING_CHANGES is true, so that tests will
pass while we're developing and allow translators time to work.

They still throw when SHOW_UPCOMING_CHANGES is false to catch issues
in production

* test: update createCommentMap test

* refactor: delete stale comment

* refactor: clarify validate with explanatory consts

* feat: throw if audited cert falls back to english

* fix: stop testing upcoming localized curriculum
2022-04-15 09:17:49 -05:00
renovate[bot] 770983a02b
chore(deps): update actions/upload-artifact action to v3 (#45491)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-21 07:05:26 -07:00
Oliver Eyton-Williams f485bc1c16
chore: update CI tests (#45401)
* chore: echo npm version in CI (as debugging info)

* chore: remove redundant alterations to .env

sample.env already has SHOW_NEW_CURRICULUM=true
2022-03-10 10:09:06 -08:00
Mrugesh Mohapatra 984a2f2bc2
fix(ci/cd): chill-out on weekends (#45365) 2022-03-07 14:15:45 +01:00
Naomi Carrigan 93075abae0
fix: skip untranslated files (#45336) 2022-03-04 13:06:33 +05:30
renovate[bot] f5c0c2bf7a
chore(deps): update actions/setup-python action to v3 (#45330)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-03 13:43:37 +05:30
renovate[bot] d96ab11ffd
chore(deps): update actions/setup-node action to v3 (#45329)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-03 13:42:39 +05:30
renovate[bot] b6de2b80d9
chore(deps): update actions/setup-java action to v3 (#45328)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-03 13:42:14 +05:30
renovate[bot] bae89da34f
chore(deps): update actions/labeler action to v4 (#45327)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-03 13:41:44 +05:30
renovate[bot] 7673ce9111
chore(deps): update actions/download-artifact action to v3 (#45325)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-03 13:41:11 +05:30
renovate[bot] 15232456b1
chore(deps): update actions/checkout action to v3 (#45324)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-03-03 06:29:31 +00:00
Renovate Bot 8af94c68c9
chore(deps): update actions/github-script action to v6 2022-03-03 06:12:27 +00:00
Mrugesh Mohapatra cafe0762aa
fix(ci): reduce runners consumption - codesee (#45252) 2022-02-25 19:50:58 +05:30
Naomi Carrigan abdbc58a3f
chore: DRY out crowdin workflows (#45078) 2022-02-24 16:33:02 +05:30
Mrugesh Mohapatra 94be3c3e7d
fix: ensure only one lockfile is used (#45230)
* fix: ensure only one lockfile is used

* fix: remove extra lockfiles
2022-02-24 09:23:30 +01:00
Naomi Carrigan 2147038e76
feat(tools): enable german docs download (#44994) 2022-02-10 12:14:21 -06:00
Krzysztof G a47610c0f0
fix(tools): autoclose syntax error (#44987) 2022-02-01 17:29:21 +07:00
nhcarrigan 33ddfd01fa
fix(tools): update autoclose workflow (#44917) 2022-01-25 14:59:45 -06:00
Oliver Eyton-Williams 7216ca55cc
refactor: organise TypeScript config and migrate helpers (#44747)
* feat: allow more 1000 steps to be created at once

* refactor: start migrating to typescript

* refactor: delete-step to ts

* refactor: migrated some helpers

* refactor: migrate create-empty-steps

* refactor: migrate create-step-between

* refactor: finish migrating to TS

* refactor: migrate tests

* fix: ensure mock.restore is done after each test

* fix: prevent double-tscing

* fix: repair the tests

* chore: use ts-node for scripts

We don't need the performance boost of incremental compilation and
ts-node is easier to work with

* refactor: consolidate tsconfigs

* refactor: replace gulp

* fix: use ts-node for build-curriculum

* fix: allow ts compilation of config

* feat: create and use create:config script

* fix: add /config to eslint projects

* fix: remove gulp script
2022-01-25 11:34:16 +01:00
nhcarrigan d050da3203
feat(tools): enable japanese download (#44826) 2022-01-20 10:01:09 +05:30
Nicholas Carrigan (he/him) 54317be92f
fix(.github): more workflow tweaks (#44741)
* chore: commit messages

* fix: add plugin name
2022-01-10 14:38:40 +00:00
Nicholas Carrigan (he/him) c8146f031e
fix: workflow run errors (#44699)
* fix: workflow run errors

* temp: comment out delete step

* fix: update yaml to bring parity with action updates
2022-01-08 18:32:03 +05:30
Nicholas Carrigan (he/him) b976b316d6
chore: migrate crowdin workflows (#44674) 2022-01-05 20:55:24 +05:30
Oliver Eyton-Williams 36363f277d
test: enable tests for steps (#44550)
* fix: handle missing solutions correctly

Rather than creating an [[]] the parser now creates [] which isEmpty().
This makes the test suite check the next challenge for a solution.

In addition, the logic for testing solutions was fixed.

* chore: update snapshots

* test: build new superblock in node.js-tests CI

* test: allow forward slash in superblock slug

* fix: borked tests oops

* test: ignore duplicated projects

* fix: i did not break these shaun did :)

* fix: idIndex is index of id not id

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2021-12-22 12:18:06 -08:00
Oliver Eyton-Williams 48f88428e8
test: login more directly (#44467)
* test: login more directly

* test: separate login from other visits

In a single test, Cypress can only visit within a single domain, hence
the separation.

* chore: fail slowly for all strategies

* test: user certified user for showing cert

* test: fix and cleanup certifications
2021-12-11 14:34:16 +05:30
Nicholas Carrigan (he/him) 557b689b79
feat: enable ukrainian downloads (#44443) 2021-12-09 15:58:00 -06:00
Nicholas Carrigan (he/him) 88524556e7
chore: remove hacktoberfest comment (#44442) 2021-12-09 11:43:57 -06:00
Mrugesh Mohapatra c9faf384b0
chore: exclude actions from changes to docs (#44412)
* chore: exclude actions from changes to docs

* fix(actions): Node.js flows needed for merge :(

* chore: apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* chore: apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-12-08 19:12:07 +05:30
Mrugesh Mohapatra c5fbfb84e1
fix(actions): run fewer workflows (#44375)
* fix(actions): remove run CodeQL from bots

* fix(actions): cosmetic renaming to the files
2021-12-03 16:24:00 +00:00
Oliver Eyton-Williams 9c078ab5d2
fix: update npm calls to handle workspaces (#44370)
* fix: use workspaces for crowdin npm ci

* fix: update server.Dockerfile to use workspaces

* fix: update client.Dockerfile to use workspaces
2021-12-03 20:06:08 +05:30
Mrugesh Mohapatra 4574e4e81d chore: update all workflows to Node.js v16 2021-11-03 15:06:19 +05:30
Mrugesh Mohapatra a695f744e2
chore(actions): update mongodb in cypress workflow (#44098) 2021-11-02 22:23:06 +05:30
Mrugesh Mohapatra 9c5104602f
chore(actions): bump Node.js to v16 in codesee workflow (#44094) 2021-11-02 17:27:31 +05:30
Mrugesh Mohapatra f84d6078fd
chore(actions): use Ubuntu-20.04 in all workflows (#44095) 2021-11-02 17:19:50 +05:30
Nicholas Carrigan (he/him) 499baa0422
fix(tools): no comment for staff (#44004)
fix(tools): no comment for staff
2021-10-26 10:30:38 +05:30
Oscar Dominguez 93ad0ae036
ci(workflow): add cache to workflows using actions/setup-node (#43830) 2021-10-13 13:04:58 +05:30
Grayson Hay 9b3a8e6bcf
fix(tools): 👷 update CodeSee workflow to now work with PRs from forks (#43816)
* 👷 CodeSee now works with PRs in forks

This change updates the CodeSee Architecture Diagram workflow to enable PR diagrams from forks.

* Adds back in the run condition

Missed this bit when I was copying over the updated template, adding it back in.

* Ran prettier on the workflow file
2021-10-12 17:26:04 +01:00
Oliver Eyton-Williams c8d7f0a782
feat(tools): remove eslint-plugin-prettier for prettier (#42438)
* feat: remove eslint-plugin-prettier for prettier

This removes the annoying lint warnings when all that needs to change is
formatting

* fix: use .js lint-staged config to ignore properly

* fix: lint everything if a lot of files are changed

It's faster than making lots of individual linter calls

* chore: apply prettier

* fix: ignore code in curriculum-file-structure
2021-10-06 21:02:21 +05:30
Nicholas Carrigan (he/him) da9725acd4
fix(tools): apply invalid label (#43684) 2021-10-02 14:02:33 -07:00