Berkeley Martinez
f4443e16dd
feat(nav): make navbar static ( #13673 )
...
* feat(nav): make navbar static
make the navbar in react layout and the static layout stick to the top of the screen
* feat(challenges): Make classic view flex
Classic view now uses flex to control it's height. This was necessary to control view and allow
navbar to be static on other pages.
This breaks mobile view and other non-classic challenge views
* feat(app): Add logic to make screen expand on tablet
* fix(app): let routes define their content structure
* fix(less): use American spelling of gray
* fix(classic-preview): make preview smaller to prevent scroll
* feat(classic-frame): Make frame border less distinct
* fix(challenges): scope test suite less to challenges
* feat(challenges): make generic ChallengeTitle component
2017-03-13 18:17:07 -05:00
Dylan
e52ca2a23c
Merge pull request #13866 from Manish-Giri/fix/add-tests-in-capture-group
...
Add tests in reuse capture group
2017-03-12 22:02:16 -05:00
Dylan
c125c38546
Merge pull request #13866 from Manish-Giri/fix/add-tests-in-capture-group
...
Add tests in reuse capture group
2017-03-12 22:02:16 -05:00
Atomk
5caad3301d
Minor text fixes in Applied Visual Design challenges
2017-03-12 22:08:34 +01:00
Atomk
d29afef0b1
Minor text fixes in Applied Visual Design challenges
2017-03-12 22:08:34 +01:00
Timo
6b9cfabcfa
Merge pull request #13811 from adetime/fix-radio-button-description
...
Insert a missing information needed to pass all tests on Radio Buttons Challenge
2017-03-12 16:42:48 +01:00
Timo
c9b5dbb26e
Merge pull request #13811 from adetime/fix-radio-button-description
...
Insert a missing information needed to pass all tests on Radio Buttons Challenge
2017-03-12 16:42:48 +01:00
MANISH-GIRI
1ce029e9c6
Add tests in reuse capture group
2017-03-11 22:37:55 -05:00
MANISH-GIRI
3cc97fa91b
Add tests in reuse capture group
2017-03-11 22:37:55 -05:00
Adeildo Amorim
9672ddcfb2
Correct English sentence
2017-03-11 19:29:42 -08:00
Adeildo Amorim
941ca5f0a2
Correct English sentence
2017-03-11 19:29:42 -08:00
Dylan
ee568c438f
Merge pull request #13834 from fonsecapontes/fix/spread-operator-test
...
fix test pass spread-operator
2017-03-11 20:33:27 -06:00
Dylan
8df1f13e14
Merge pull request #13834 from fonsecapontes/fix/spread-operator-test
...
fix test pass spread-operator
2017-03-11 20:33:27 -06:00
Timo
b2fa76f1c4
Merge pull request #13612 from erictleung/fix/clarify-concat-strings
...
Clarify concatenating strings with +=
2017-03-12 01:22:59 +01:00
Timo
249c6dfb40
Merge pull request #13612 from erictleung/fix/clarify-concat-strings
...
Clarify concatenating strings with +=
2017-03-12 01:22:59 +01:00
Eric Leung
c31b1fe293
Merge pull request #13855 from drguildo/fix/wikipedia-capitalisation
...
Correct capitalisation of Wikipedia
2017-03-11 09:24:21 -08:00
Simon Morgan
41df99060e
Correct capitalisation of Wikipedia
2017-03-11 11:30:10 +00:00
Simon Morgan
fea32fe2f4
Correct capitalisation of Wikipedia
2017-03-11 11:30:10 +00:00
Dylan
2eb22f6294
Merge pull request #13709 from cdrainxv/fix/media-query-description
...
Edited description and test
2017-03-10 21:25:16 -06:00
Dylan
51435e264b
Merge pull request #13709 from cdrainxv/fix/media-query-description
...
Edited description and test
2017-03-10 21:25:16 -06:00
Eric Leung
bfc1fc4f56
Merge pull request #13837 from austinthiel/fix/target-even-numbered-elements-typo
...
Fix poor wording for first test check of "Target Even Numbered Elements using jQuery"
2017-03-10 15:03:20 -08:00
Austin Thiel
2cb2bad2e7
Fix poor wording for first test check
2017-03-09 23:44:16 -08:00
Austin Thiel
1a2ef05569
Fix poor wording for first test check
2017-03-09 23:44:16 -08:00
fonsecapontes
55d9dacaec
fix test pass spread-operator
2017-03-09 23:33:08 -03:00
fonsecapontes
e6af4207c3
fix test pass spread-operator
2017-03-09 23:33:08 -03:00
Dylan
4917b16b49
Merge pull request #13820 from erictleung/fix/step-counter-spacing
...
Add space in challenge step counter within parens
2017-03-09 18:28:28 -05:00
Timo
0c1ad46f84
Merge pull request #13756 from ellenkorbes/translate/Pt-translation-getting-started
...
Review/editing pass on the pt-br text of the getting-started section
2017-03-09 23:11:42 +01:00
Timo
8234ed9788
Merge pull request #13756 from ellenkorbes/translate/Pt-translation-getting-started
...
Review/editing pass on the pt-br text of the getting-started section
2017-03-09 23:11:42 +01:00
Timo
fd45deeb9c
Merge pull request #13772 from jdeprey/fix/say-hello-map
...
Clarify instructions in Say Hello to HTML challenge
2017-03-09 22:52:35 +01:00
Timo
b2241954c1
Merge pull request #13772 from jdeprey/fix/say-hello-map
...
Clarify instructions in Say Hello to HTML challenge
2017-03-09 22:52:35 +01:00
Ellen
d61ae01f1b
Update getting-started.json
2017-03-09 18:32:00 -03:00
Ellen
b946adfdf9
Update getting-started.json
2017-03-09 18:32:00 -03:00
Eric Leung
14df0d45a0
Merge pull request #13822 from Manish-Giri/fix/improve-instructions-lookup-table
...
Convert lookup table to object
2017-03-09 08:35:28 -08:00
MANISH-GIRI
64bc7cb6ee
Convert lookup table to object
2017-03-09 09:07:47 -05:00
MANISH-GIRI
a71d6f9a77
Convert lookup table to object
2017-03-09 09:07:47 -05:00
Eric Leung
f046a7d5c3
Add space in challenge step counter within parens
2017-03-09 01:42:09 -08:00
Eric Leung
1397e3c790
Merge pull request #13576 from Greenheart/fix/learn-stack-tests
...
fix(challenge): More robust test for "Learn how a Stack Works".
2017-03-09 01:02:25 -08:00
Eric Leung
888ad67131
Merge pull request #13576 from Greenheart/fix/learn-stack-tests
...
fix(challenge): More robust test for "Learn how a Stack Works".
2017-03-09 01:02:25 -08:00
Eric Leung
0ccc4c8a54
Merge pull request #13599 from Manish-Giri/fix/change-tests-where-do-I-belong
...
Add type checking in Where Do I Belong
2017-03-09 00:52:31 -08:00
Eric Leung
100f02d4cc
Merge pull request #13599 from Manish-Giri/fix/change-tests-where-do-I-belong
...
Add type checking in Where Do I Belong
2017-03-09 00:52:31 -08:00
Eric Leung
3a16595e52
Clarify concatenating strings with +=
...
- Be more specific in what needs to be done using the plus equals
- Remove unnecessary line break before strings to be concatenated
2017-03-09 00:23:50 -08:00
Eric Leung
e8c22f543e
Clarify concatenating strings with +=
...
- Be more specific in what needs to be done using the plus equals
- Remove unnecessary line break before strings to be concatenated
2017-03-09 00:23:50 -08:00
Adeildo Amorim
2da119f0fd
fix/usage-of-text-align-to-anchor-tags
2017-03-08 20:34:50 -08:00
Adeildo Amorim
37fa7f56c0
fix/usage-of-text-align-to-anchor-tags
2017-03-08 20:34:50 -08:00
Adeildo Amorim
1cdac8c6bd
Insert a missing information needed to pass all tests
2017-03-08 13:00:11 -08:00
Adeildo Amorim
2a2dfa4430
Insert a missing information needed to pass all tests
2017-03-08 13:00:11 -08:00
Eric Leung
645ef2495b
Merge pull request #13795 from homerrowsky/fix/typo-in-html-and-css
...
Fix typo in basic-css-hex-code-colors. Add article -the- to description.
2017-03-08 09:38:33 -08:00
homerrowsky
736082869c
Fix typos in basic-css-hex-code-colors
2017-03-08 09:59:34 -06:00
homerrowsky
e435fb1a4a
Fix typos in basic-css-hex-code-colors
2017-03-08 09:59:34 -06:00
Joseph DePrey
14fcc35555
Clarify Basic HTML instructions
2017-03-08 09:06:00 +01:00