Commit Graph

86 Commits (31a69ea6857f7b68d00486cb3b37e21c7ad292d0)

Author SHA1 Message Date
Tom 6be76738b0
fix(curriculum): import a google font lesson regex test (#41907) 2021-04-24 12:43:55 +02:00
Evgeny Klimenchenko 9057750727
fix(curriculum): Fix a type `in line` -> `inline` in basic css challenge (#41847) 2021-04-18 11:54:17 +02:00
Sem Bauke d4aef30ea7
fix(curriculum): regex compatibility issue for Safari (#41725)
* fix(curriculum) regex compatibility issue for Safari

* fix: escape the dot parameter in regex

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-04-09 06:39:57 +02:00
Sem Bauke 87c9c799c6
fix(curriculum): Regex fix for Create a Variable for a Specific Area (#41501) 2021-03-29 17:09:52 +05:30
Randell Dawson 18ac058840
fix(curriculum): Improve wording of test text (#41606)
Co-authored-by: Ricardo Passos <55499252+dizz-y@users.noreply.github.com>
2021-03-26 13:01:20 -05:00
Sem Bauke b064991667
fix(curriculum): Replace single-line blocks with multi-line blocks for Responsive Web Design (#41519)
* fix(curriculum) replace single-line block with multi-line blocks

* fix(curriculum) replace single-line block with multi-line blocks (missed blocks)
2021-03-18 17:24:09 -06:00
Randell Dawson d2f4b70ea6
fix: remove end of line chars after code blocks (#41498) 2021-03-16 07:49:43 -07:00
Ricardo Passos ae79525493
fix(learn): added a missing period and removed single quotes (#41377)
* Added missing period

On line 24, just before "Note that in your CSS..." a period was missing.

* Removed single quotes and added a missing period

On line 24, just before "Note that in your CSS..." there is a missing period. 
On line 30, the text "red-text" within a code tag is enclosed in single quotes.
2021-03-05 07:16:30 -08:00
Randell Dawson 167f93df76
fix(learn): Add inline code blocks to for i18n (#40921) 2021-02-05 14:16:19 +05:30
Nicholas Carrigan (he/him) 427444c757
chore(learn): audit files for crowdin (#40838)
* chore(learn): audit files for crowdin

Audits the challenge text in the Responsive Web Design superblock to
account for words/phrases that should not be translated because they
refer to code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove quotes from code

Removes instances of quoted code blocks, or code blocked quotes.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: additional uncaught quote-codes

Thanks Oliver :)

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: so many quotes

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: missing punctuation

Noted in a Crowdin comment.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove more quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-01 12:56:07 -07:00
Oliver Eyton-Williams ee1e8abd87
feat(curriculum): restore seed + solution to Chinese (#40683)
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-12 19:31:00 -07:00
Oliver Eyton-Williams 0bd52f8bd1
Feat: add new Markdown parser (#39800)
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
Oliver Eyton-Williams 2b9e38a17b
fix: replace .english.md extension with .md 2020-09-29 22:09:04 +02:00
Hassaan Pasha 80438cac3e
feat(client, learn): add helper functions for common validation operations (#38605)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-17 19:38:01 +05:30
Oliver Eyton-Williams d7dc1acb4a chore: update lang tags on code blocks 2020-09-16 11:54:08 +05:30
Tom d765fa704b
fix(learn): size your images challenge (#39570)
* fix: size your images challenge

* fix: remove console log
2020-09-14 14:09:01 +01:00
Oliver Eyton-Williams bd68b70f3d
Feat: hide blocks not challenges (#39504)
* fix: remove isHidden flag from frontmatter

* fix: add isUpcomingChange

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* feat: hide blocks not challenges

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2020-09-03 15:07:40 -07:00
g4rry420 9a4ab36fa4
Changed Regex of 3rd textString (#38944)
* changes the regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Changed the Regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Changed the Regex of 3rd textString 

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Changed the Regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Chamged the Regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Changed the Regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* fix: regex tests and instructions

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/import-a-google-font.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* fix: add suggested change

* revert non-english changes

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <2397860h@student.gla.ac.uk>
2020-09-02 11:21:52 -07:00
Shaun Hamilton 9ed2a554a7
fix(curriculum): changed test to use regex (#38770)
* changed test to use regex

* added width has to be spelt correctly

* added second width assertion

* add case insensitive flag

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: allow compilable CSS to pass

* add allowance of final property without semicolon

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-02 11:59:16 -05:00
Hassaan Pasha b0f85de311
fix (curriculum): Adding regex to disregard any whitespaces in the basic-css challenge (#38330)
* fix (curriculum): Adding regex to account for any whitespace that may be added to the code

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/use-attribute-selectors-to-style-elements.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-08-31 15:16:24 -07:00
Carlos Diaz e0a062a3e7
Changes order of padding, border, margin in introductory sentence. (#39414) 2020-08-30 22:28:42 -05:00
Charles Ross 3db5bd7067
Update import-a-google-font.english.md (#38839)
Changed optional plural to possessive.
2020-08-30 22:07:46 -05:00
mstillman9 1f1c58ae18 fix regex 2020-07-16 15:41:35 +03:00
Randell Dawson 8ebb4922d4
fix(learn): updated catphotoapp links (#39215) 2020-07-15 15:26:49 +05:30
Oliver Eyton-Williams f1c9b08cf3 fix(curriculum): add isHidden: false to challenges
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
Ashraf Nazar 99c2f0d4f5
fix(curriculum): allow hex triplets for red and green colors to pass tests (#38523) 2020-04-12 17:15:31 +03:00
Randell Dawson 41718abf76
fix(learn): consolidate comments for responsive web design cert (#38256)
Related to PR #38040

This PR is an attempt to consolidate/remove as many comments in the challenge seed code in the Responsive Web Design certification challenges, to be able to create a small translation lookup object for translating the English comments to other languages.
2020-02-27 20:50:46 +05:30
lasjorg 9a5ae756ac
fix(challenge): check inline style for color (#38211)
* fix(challenge): check inline style for color

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/change-the-color-of-text.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-02-18 23:38:16 +05:30
John A Maloney c935d21f84 Fixed bad capture group in regex (#37575) 2019-12-13 22:16:30 -06:00
Christoph Deil dc5c0c7f82 Fix minor grammar issue in override-styles-in-subsequent-css.english.md (#37871) 2019-12-04 14:32:55 -08:00
mikemorr 62e1464eb7 change "given" to "adding" (Was: change "given" to "giving") (#37823)
* change "given" to "giving"

* change to "adding" as suggested

As suggested in https://github.com/freeCodeCamp/freeCodeCamp/pull/37823
2019-11-25 08:14:08 -08:00
Randell Dawson 9bf3fdbf38 fix(curriculum): changed challenge test text to use the word should for Responsive Web Design (#36860)
* fix: changed challenge test text to use should

* fix: changed have to be used in

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: reworded test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: improved test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: improved test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed have the to be used in

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected verbiage

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-11-20 20:15:19 +05:30
Tristan Michael Lawrence 5296d5c731 fix: removed trailing spaces, fixed a typo (#37572)
* removed trailing spaces, fixed a typo

* removed trailing spaces from basic-css challenges
2019-11-10 04:33:10 -08:00
Daniel Veazey 7f4531aed0 replace the word "dashes" with "hyphens" (#37705) 2019-11-07 01:19:39 -05:00
SomeDer bfa5c26288 fix: use dfn instead of code tag (#36640)
* Use dfn tags

* remove misused <dfn> tags

* Revert "remove misused <dfn> tags"

This reverts commit b24968a968.

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/fill-in-the-blank-with-placeholder-text.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Make "array" lowercase

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Fix dfn usage

* Address last dfn tags
2019-10-27 12:45:37 -04:00
Ahmad Shahzad 9db88a0d7c Fixed a typo in Specify How Fonts Degrade lesson. (#37567)
* Fixed a typo in Specify How Fonts Degrade.

'-->!' inside the code is misleading and prompts a learner
to put the exclamation mark when it is not needed as '-->!' is
also followed by a period.

Instead of "'-->!'.", it should be "'-->'."

* Made text wording consistent for the test instructions.

* Changed "To begin with," to "To begin," and fixed a minor typo.

If we are going to use "To begin with," the sentence should be
"To begin with the lesson/challenge", otherwise, "To begin" will
be more than enough.

Also added a space between "font(using HTML..." and changed it to
"font (using HTML...".
2019-10-26 16:55:10 -04:00
Randell Dawson 568f00e02a fix(curriculum): Added forumTopicId to remaining 1200 challeng… (#36558) 2019-08-05 22:14:37 +05:30
Randell Dawson 3ec1fe8ea7 feat: add forumTopicId to challenge frontmatter [pre-existing]
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
Randell Dawson d0d8282f86 fix(curriculum): Remove additional unnecessary assert message argument wrapped in double quotes from various curriculum sections (#36457)
* fix: remove double quoted assert msg arg - responsive

* fix: remove double quoted assert msg arg - js

* fix: remove double quoted assert msg arg - libraries

* fix: remove double quoted assert msg arg - coding interview
2019-07-24 13:06:12 +01:00
Randell Dawson 87615d2a7b fix: removed assert msg argument (#36406) 2019-07-24 11:50:51 +02:00
Randell Dawson c387873640 fix(curriculum): added extra line before </section> tag - Engl… (#36278) 2019-07-19 15:30:17 +05:30
Oliver Eyton-Williams 43fa451a38 fix(curriculum): Change wording to talk about inheritance not cascade (#36110) 2019-06-08 19:09:00 -07:00
Val Lipat 6feda1badb Improve capitalization (#36166) 2019-06-04 07:52:52 -07:00
Kyle Cheung 937dc23b5d fixed typos in custom css-variable challenge #36038 (#36041)
* fixed typos in custom css-variable challenge

* fix: Remove extra line
2019-05-14 20:31:03 +07:00
Randell Dawson df8659ab8c fix(curriculum): Convert blockquote elements to triple backtick syntax for Responsive Web Design (#35993)
* fix: converted blockquotes to code fences
2019-05-14 10:11:58 +02:00
Huyen Nguyen 791e589c93 Remove tag characters (#36037) 2019-05-14 00:14:16 +05:30
Manish Giri e736179720 fix(curriculum): Add solutions to CSS challenges (#35873) 2019-04-22 11:27:43 +05:30
Catalina ffcb092bf1 Fixed CSS Challenge English version (#35849) 2019-04-20 09:49:23 -07:00
lasjorg 69d9d522a2 fix(challenge): fix broken regex (#35632)
* fix(challenge): fix broken regex

* fix(challenge): update solution
2019-03-26 21:48:52 -07:00
lasjorg a1e853337b fix(challenge): simplify and cleanup tests (#35535) 2019-03-26 21:35:38 -07:00