9c28a2300a
fix(curriculum): look for inlined filter function ( #41953 )
2021-04-30 20:55:16 +01:00
db369fbed1
fix(client): remove JS comments from user code for tests ( #41873 )
...
* Removes comments in js challanges by default
* fix local-scope-and-functions test regex
* fix all languages
* revert language changes
* removed unnecessary removeJSComments from challenges
* fix challanges in other languages
* removed removeJSComments from all challanges
2021-04-28 10:18:54 -05:00
6ae186a8cf
fix(curriculum): record collection challenge - variable names shouldn't be keywords ( #41904 )
...
* style - update record collection challenge, variables shouldn't be name after keywords
* minor - typo fix
* Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-04-23 21:51:41 +02:00
02f232caf4
fix(curriculum): add additional test to telephone regex challenge ( #41852 )
2021-04-18 21:36:09 +01:00
4171277dc9
fix(curriculum): clarify instructions for ouput ( #41839 )
2021-04-16 20:33:58 +02:00
422bded413
fix: remove quotation marks from 'Hi World' in Instructions ( #41837 )
2021-04-16 10:36:59 +02:00
21c8500f94
fix(curriculum): prevent submitting array instead of string ( #41720 )
...
* fix(curriculum) prevent users from submitting an array instead of string
* use strict equality instead of new test
* Add suggestions from Tom
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-04-09 07:34:55 -05:00
fe95d5bca2
fix(curriculum): Remove unnecessary comments ( #41777 )
...
* Remove unnecessary comments
https://github.com/freeCodeCamp/freeCodeCamp/pull/41612
* Remove unnecessary comment
2021-04-08 10:59:25 -07:00
87b0e5bb7a
fix(curriculum): Remove unnecessary comments ( #41781 )
...
* Remove unnecessary comments
https://github.com/freeCodeCamp/freeCodeCamp/pull/41612
* Update the hints section
2021-04-08 10:49:47 -07:00
c4ba0c692f
fix(curriculum): Remove unnecessary comments ( #41776 )
...
* Remove unnecessary comments
* Remove last comment, change instruction wording
2021-04-08 10:46:39 -07:00
591a534701
Remove unnecessary comments ( #41775 )
...
https://github.com/freeCodeCamp/freeCodeCamp/pull/41612
2021-04-08 09:40:34 -07:00
a9a68fa498
fix(curriculum): Remove unnecessary comments ( #41774 )
...
* fix: Remove unnecessary comments
https://github.com/freeCodeCamp/freeCodeCamp/pull/41612
* Add empty line
2021-04-08 09:36:05 -07:00
617f7b07e9
Update iterate-through-an-array-with-a-for-loop ( #41742 )
...
* Update iterate-through-an-array-with-a-for-loop
* Update iterate-through-an-array-with-a-for-loop
Add space around minus for better readablilty.
* Update iterate-through-an-array-with-a-for-loop
* Update iterate-through-an-array-with-a-for-loop
* Update iterate-through-an-array-with-a-for-loop.md
2021-04-08 09:56:49 -05:00
523997c33b
fix: Mr.Page's firstname to Elliot ( #41744 )
2021-04-05 08:49:12 +02:00
7d83a6b65d
fix(curriculum): verbiage ( #41732 )
...
* fix(curriculum): verbiage
Modify the wording of the tests in this challenge to avoid having
two tests which sound the same.
* fix: Shaun's arrays have elements
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-04-03 23:00:15 +02:00
e75685f803
fix(curriculum): change tests to allow more solutions ( #41703 )
...
* fix(curriculum) only allow new object to be the second value in array
* fix(curriculum) remove direct array index notation
* Apply suggestions from Shaun
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-03-31 14:24:20 -07:00
37e8d0b757
fix/ownProps ( #41686 )
...
related issue:#4114
2021-03-31 13:48:37 +05:30
e1ea77412b
chore(i18n,curriculum): updates ( #41689 )
...
Apply typo fixes and formatting changes based on feedback from
internationalisation process.
2021-03-31 13:48:01 +05:30
c962c0c8e5
fix: wrap own properties and not just own ( #41614 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-27 07:59:44 -06:00
e5b4ae17a0
fix: Simplify wording to make more sense ( #41586 )
...
* fix: Simplify wording to make more sense
I think that "count odd numbers backward by twos" instead of "count backward by twos by odd numbers" is easier to understand.
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md
I think that this variation sounds better than what I originally wrote.
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-25 22:18:51 +00:00
b5ed2619eb
fix: replace inline code blocks ( #41576 )
2021-03-26 02:37:48 +05:30
fd5e6eebfb
fix(curriculum): add blank like to seed code
2021-03-22 16:18:15 +00:00
e18c6955b0
fix(curriculum): Improve test to allow any valid function call for Write Reusable JavaScript with Functions challenge ( #41538 )
...
* fix: improve test to allow function call anywhere
* fix: force user to put console.log in function
2021-03-20 12:23:32 +00:00
3f1cd6eb33
fixed the grammar of the description ( #41531 )
2021-03-19 06:55:21 -06:00
35a8f55515
fix(learn): Remove unnecessary inline code tag in challenge ( #41428 )
...
* remove unnecessary inline code tag
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-less-than-or-equal-to-operator.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* improve challenge wording
* improve challenge wording
* keep wording consistency
* keep wording consistency between similar challenges
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-10 10:16:03 -08:00
c5bcebc724
fix(learn): revert backslash change ( #41382 )
...
* fix(learn): revert backslash change
Crowdin resolved the issue with backslashes escaping backtics in
the markdown parser, so this reverts the workaround we implemented
for that bug.
* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/s-expressions.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 10:13:27 -06:00
77730ae209
fix(learn): address translator comments ( #41381 )
...
* fix(learn): address translator comments
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/quoting-strings-with-single-quotes.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 08:15:26 -06:00
65cc800689
fix: add blank lines on empty seeds ( #41348 )
2021-03-03 13:14:28 -08:00
7117919d36
chore(learn): audit javascript algorithms and data structures ( #41092 )
...
* chore(learn): audit basic algorithm scripting
* chore(learn): audit basic data structures
* chore(learn): audit basic javascript
* chore(learn): audit debugging
* chore(learn): audit es6
* chore(learn): audit functional programming
* chore(learn): audit intermidate algorithms
* chore(learn): audit js projects
* chore(learn): audit object oriented programming
* chore(learn): audit regex
* fix(learn): remove stray .
* fix(learn): string to code
* fix(learn): missed some
* fix(learn): clarify strings
Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.
* fix: apply suggestions - thanks Randy! :)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: non-suggestion comments
* chore(learn): remove comments from codes
Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.
* fix: Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
* fix: revert crowdin fix
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: Apply suggestions from code review
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
* fix: Apply suggestions from code review
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
* chore: change voice
* fix: Christopher Nolan
* fix: expressions would evaluate
* fix: will -> would
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: to work to push
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-02 17:12:12 -07:00
33356e403a
fix(learn): Use backticks around back slash character ( #41254 )
2021-02-25 16:34:40 +05:30
b11dd87047
fix: remove sentence not needed ( #41235 )
2021-02-23 11:21:58 -06:00
f4bbe3f34c
fix(learn): Updated code blocks to help with translation on two challenges ( #41217 )
2021-02-22 11:21:59 +05:30
b12360d4a8
Removed the hint Fixes #41192 ( #41215 )
...
* Removed the hint Fixes #41192
* Removed the blank line as suggested
2021-02-21 13:36:14 -07:00
f08174b5b1
fix(learn): Remove unnecessary inline code tag in challenge ( #41177 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-19 09:44:50 +05:30
fad168b465
fix(learn): fix some code tags, capitalization and punctuation in challenge ( #41161 )
...
* fix some code tags, capitalization and punctuation
Note: The reserved word in JavaScript is "boolean", so I think it is appropriate to use it like this inside the code tags.
* Remove code tags and capitalize first letter
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* capitalize letter and replace slash
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:45:12 -07:00
2c1280af65
fix(learn): Improve the clarity on a challenge sentence ( #41154 )
...
* Improve the clarity on a challenge sentence
* add string type and remove double quotes
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:29:31 -07:00
1fe1371b16
add missing inline-code block ( #41153 )
2021-02-17 11:24:53 -08:00
b45406ec9d
fix(learn): Remove repeated definition tag in challenge ( #41151 )
2021-02-17 23:01:42 +05:30
c15c27f474
fix(learn): Added another test to check for invalid characters ( #41144 )
2021-02-17 21:16:07 +05:30
21c7abf584
fix(learn): update challenge for crowdin ( #41089 )
2021-02-16 19:47:40 +05:30
0f8449788c
feat(learn): add tests to use a callback function in the sort method ( #40847 )
2021-02-10 17:05:23 +05:30
51f6077f7b
fix(learn): regex-criminal-in-hunt-challenge ( #40901 )
...
* fix: regex-criminal-in-hunt-challenge
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/find-one-or-more-criminals-in-a-hunt.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-08 06:10:59 -08:00
18e821bcd3
fix: remove clunky sentence ( #40751 )
2021-02-01 19:22:39 +05:30
d41630ee19
fix(learn): clarify test description for Use Rest Parameter with Function Parameter ( #40725 )
...
* fix: clarify test description
* fix: improve wording regarding rest parameters syntax
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: improve with better sounding wording
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-24 08:30:13 -08:00
ce3a20e552
fix(learn): change requirements for positive and negative lookaheads ( #40570 )
2021-01-21 15:35:19 -06:00
f2b1d7b147
fix(challenge): Assert arrays contain expected values ( #40693 )
2021-01-21 10:52:52 -08:00
8a9f3319c6
fix(learn): Fixed typos in count-backwards-with-a-for-loop.md ( #40478 )
...
* Spelling change in count-backwards-with-a-for-loop
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 08:44:10 -08:00
062b1cd424
fix: replace h tags ( #40750 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 13:41:46 +05:30
ef394093f7
fix(learn): removing unnecessary test case for regex challenge ( #40581 )
...
Co-authored-by: Alejandro Soto <alejandro.soto@wundermanthompson.com>
2021-01-20 21:53:04 -08:00
3061a5a0eb
Text in Basic Data Structures lesson is better clarified. ( #40492 )
...
* text_changes
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-items-using-splice.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Jagadeesh G <17941713+GJ-16@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-20 22:02:37 -07:00
Sem Bauke
Evgeny Klimenchenko
Jeremy L Thompson
Kyle Holmberg
Shaun Hamilton
Karen Blacktopp
Emer Conghaile
Saurabh Kumar singh
Akib Maredia
Nicholas Carrigan (he/him)
Rafael D. Hernandez
Randell Dawson
CoolBlueDesigns
Arjun Yadav
Kelvin Sánchez
Andrew Cen
Alexander Heß
Joshua Pelealu
Ismail Tlemçani
Tom
gikf
Lasse Jørgensen
matias-miller
Alex Soto
Jagadeesh G