Commit Graph

132 Commits (31a69ea6857f7b68d00486cb3b37e21c7ad292d0)

Author SHA1 Message Date
Sem Bauke 99cecfb581
fix(curriculum): check if count gets incremented by function (#41856)
* fix(curriculum): check if count gets incremented by function

* update text

* Update regex to look for whitespace

* look for function globally

* Apply suggestions from gikf

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
2021-04-23 11:01:54 -05:00
Jonathan e36ae5d80f
fix(curriculum): fluid containers test not specific (#41866)
* fix: fluid containers test not specific

* fix: fluid containers test not specific

* fix: update fluid containers test not specific

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-04-23 15:14:58 +01:00
Chinmay Kunkikar 50db7c557a
fix(curriculum): specify id attribute in the instructions (#41716)
* fix(curriculum): specify id attribute in the instructions

* Update curriculum/challenges/english/03-front-end-libraries/jquery/remove-an-element-using-jquery.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-04-13 22:16:48 +01:00
Alan fb40f56876
fix(curriculum): malformed paragraph in react/redux (#41645)
* fix: re-arranged paragraph in react-redux lesson

* fix: re-arranged paragraph in react-redux lesson in different locales

* fix: reverted other locale changes

* fix: switched link to enable opening as a new tab
2021-03-29 16:00:12 +00:00
Laurent Labine 00b37093db
fix(curriculum): replace single-line blocks with multi-line blocks for… (#41525)
* fix(curriculum) replace single-line blocks with multi-line blocks for Front End Libraries #41523

Second attempt

* Update curriculum/challenges/english/03-front-end-libraries/react/use--for-a-more-concise-conditional.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-03-18 23:40:32 +00:00
Randell Dawson d2f4b70ea6
fix: remove end of line chars after code blocks (#41498) 2021-03-16 07:49:43 -07:00
Randell Dawson 33bd4fb2c4
fix(learn): Change Codepen template link (#41440) 2021-03-12 10:41:48 +05:30
Nicholas Carrigan (he/him) 4d8aae1678
fix: backtick formatting (#41371) 2021-03-05 11:39:04 +05:30
Andrew Cen 65cc800689
fix: add blank lines on empty seeds (#41348) 2021-03-03 13:14:28 -08:00
Nicholas Carrigan (he/him) 31bdea63a2
chore(learn): audit front end libraries (#41179)
* chore(learn): audit bootstrap

* chore(learn): audit FE projects

* chore(learn): audit jQuery

* chore(learn): audit React

* chore(learn): audit react-redux

* chore(learn): audit redux

* chore(learn): audit sass

* fix: apply review suggestions

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: apply non-suggestions

* chore: remove comments from code

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-25 10:19:24 -07:00
Supritha ee6764519d
REMOVED comments (#41048)
* Added comments

Fixes freeCodeCamp/freeCodeCamp#40903

* remove comments
2021-02-11 09:13:38 -07:00
Jean-Baptiste LARRIVIERE 1c539d07c3
fix(curriculum): remove mention of null from challenge (#40942)
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-02-08 13:17:32 +05:30
Jason Liao 0b812c91e3
update task description (#40586) 2021-01-20 22:06:51 -07:00
Niraj Nair a8230fda57
Added Change this line comment (#40497) 2021-01-20 22:03:24 -07:00
Oliver Eyton-Williams ee1e8abd87
feat(curriculum): restore seed + solution to Chinese (#40683)
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-12 19:31:00 -07:00
Lakshya Baghel 036da8cd0c
Fixed seed-contents for react componentDidMount challenge (#40441) 2020-12-15 18:19:58 -07:00
Oliver Eyton-Williams 0bd52f8bd1
Feat: add new Markdown parser (#39800)
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
lucia montero c03beb3ca6
Fix tests to allow spaces in "Sass: Create Reusable CSS with Mixins" (#40230)
* Fix tests to allow spaces. Closes #40212

* Apply suggestions from code review

Remove redundant whitespace from regex

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-11-15 00:14:47 +01:00
Amy Surrett 1ef49d2c57
fix(learn): add note about tweet button restrictions (#40118)
* fix: add note about tweet button restrictions

* fix: added target blank and top hint
2020-11-14 11:52:48 +00:00
Oliver Eyton-Williams 35c4020f4d
fix(curriculum): test typos (#39984) 2020-10-15 14:49:57 -04:00
Haraman Johal 41d40608a1
fix(learn): reword incorrect line reference (#39742) 2020-10-01 04:26:43 -07:00
Oliver Eyton-Williams 2b9e38a17b
fix: replace .english.md extension with .md 2020-09-29 22:09:04 +02:00
Walter Palagi 3d7af80047
fix(learn): React propTypes challenge, improve test text (#39682)
* In React propTypes challenge, improve test text

Fixes #39204

* Remove code tags around "number"

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-24 23:11:05 -07:00
Sky020 a86b220eb7 chore: remove isRequired from curriculum files 2020-09-21 20:51:46 +05:30
Hassaan Pasha 80438cac3e
feat(client, learn): add helper functions for common validation operations (#38605)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-17 19:38:01 +05:30
Randell Dawson 30c61b808b
fix: consolidate misc comments (#39583) 2020-09-16 13:29:50 -05:00
Oliver Eyton-Williams d7dc1acb4a chore: update lang tags on code blocks 2020-09-16 11:54:08 +05:30
Randell Dawson a2f4c8d0e1
fix: consolidated comments for use with translation dictionary (#39578) 2020-09-15 22:23:25 +05:30
Kristofer Koishigawa c11bf0d02e
fix(curriculum): restrictive test for use map to dynamically render challenge (#39581) 2020-09-15 08:23:48 -07:00
Randell Dawson 0f5832b562
fix: project 25 + 5 (#39526) 2020-09-09 13:28:12 +05:30
Oliver Eyton-Williams bd68b70f3d
Feat: hide blocks not challenges (#39504)
* fix: remove isHidden flag from frontmatter

* fix: add isUpcomingChange

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* feat: hide blocks not challenges

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2020-09-03 15:07:40 -07:00
Shaun Hamilton 223c2dc205
fix: convert async tests to synchronous (#39478)
* fix: convert async tests to sync

* fix: correct formatting changed by prettier
2020-09-02 19:24:22 -05:00
Ashraf Nazar 70f1ebd2fc
fix(curriculum): regex to target html elements using jQuery to captur… (#38649)
* fix(curriculum): regex to target html elements using jQuery to capture white spaces

* replace whitespace before test

* fix linting issue with single quotes

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-08-31 20:24:43 -05:00
CheongJY a294021d53
fix: remove whitespace before testing (#39420)
* Proposed change to remove whitespace for issue #39370

Issue #39370: whitespace fails the 3rd test with test comparing to a no whitespace example.
Proposed: remove all whitespace in between tags(or literally all whitespaces) before comparing it with the no whitespace example

* Update render-state-in-the-user-interface.english.md

* Updated proposed change to remove whitespace 

An update to previously proposed change due to failed test of 'unexpected token \'<\'' was thrown'

* Update curriculum/challenges/english/03-front-end-libraries/react/render-state-in-the-user-interface.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* fix: linting issue

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-01 01:15:22 +01:00
Aviel212 fb77d48d13
curriculum: add test in React challenge to detect constructor call (#39304)
* fix: resolve #39301

Add a test to check the "MyComponent" constructor's parameters (params) and to check that the super function exists in the constructor.

* docs: describe the test better

* Update curriculum/challenges/english/03-front-end-libraries/react/write-a-react-component-from-scratch.english.md

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2020-08-25 08:41:35 -07:00
ML 9a4976bd57
fix(curriculum) typo in Create Reusable CSS (#39418)
Fixed a typo on the Sass Challenge "Create Reusable CSS with Mixins" where the word "vendor" was spelled incorrectly as "vender" in the test cases.
2020-08-16 18:33:34 -07:00
Ruchi Kushwaha 35c3609489
fix:Incorrect Usage of setState in React Challenge (#39290)
* fix:Incorrect Usaage of setState in React Challenge

* apply suggestion

* also set stage usage in other challenges

* fix setState usage in challenges

* correct syntax

* correct usage of useState in other files

* add current message to state

* remove current message from state

* change connect redux to the message app

* remove extra space
2020-08-11 10:12:27 -07:00
anthony 20d397f719
remove MDN links from English challenges (#39337)
* remove MDN links from English challenges

* add push challenge reference to record-collection

* refactor truthy falsy verbiage

* replace MDN link with news link

* remove unnecessary whitespace
2020-07-31 15:19:49 +09:00
Ayush Kumar 53cbe66c1a
Changed variable renderOnlineUsers to renderOnline in soluion seed. (#39229)
In the challenge seed renderOnline variable has been used and referenced but in the solution seed the variable has been changed to renderOnlineUser so, changed renderOnlineUsers back to renderOnline variable.
2020-07-23 23:35:01 -07:00
Himanshu maurya 07e665052d
Fixed-pass-an-array-as-props (#39268)
* Fixed-pass-an-arrays-props

* Fixed:pass-an-array-as-props2

* Update curriculum/challenges/english/03-front-end-libraries/react/pass-an-array-as-props.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/03-front-end-libraries/react/pass-an-array-as-props.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/03-front-end-libraries/react/pass-an-array-as-props.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-07-17 13:11:16 -07:00
Randell Dawson 8ebb4922d4
fix(learn): updated catphotoapp links (#39215) 2020-07-15 15:26:49 +05:30
Oliver Eyton-Williams f1c9b08cf3 fix(curriculum): add isHidden: false to challenges
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
Oliver Eyton-Williams 5e56a9a938
Feat(curriculum): scss not sass (#38764) 2020-05-09 20:01:18 +05:30
Shaun Hamilton b1de8ee4f8
fix(curriculum): change project codepen links (#38746) 2020-05-06 19:53:27 +05:30
Iván Franco 1d87dd82e3
updated english file (#38482) 2020-04-11 22:52:54 -05:00
Ashraf Nazar a2d31afe81
fix: Update test in Redux challenge to accomodate backticks (#38345) 2020-03-10 12:15:50 +03:00
kundan kumar 971c62ab53
fix : Unclear test output use-array.map-to-dynamically-render-… (#38191) 2020-02-13 02:41:36 +05:30
Hassaan Pasha 2f951f0dff
fix: edited the duplicate test guideline to mirror the actual… (#38199) 2020-02-12 20:47:24 +05:30
Josh Soref 004b99bf8f chore: fix typos in spelling (#38100)
* spelling: accidentally

* spelling: announce

* spelling: assembly

* spelling: avoid

* spelling: backend

* spelling: because

* spelling: claimed

* spelling: candidate

* spelling: certification

* spelling: certified

* spelling: challenge

* spelling: circular

* spelling: it isn't

* spelling: coins

* spelling: combination

* spelling: compliant

* spelling: containers

* spelling: concise

* spelling: deprecated

* spelling: development

* spelling: donor

* spelling: error

* spelling: everything

* spelling: exceed

* spelling: exist

* spelling: falsy

* spelling: faulty

* spelling: forward

* spelling: handle

* spelling: indicates

* spelling: initial

* spelling: integers

* spelling: issealed

* spelling: javascript

* spelling: length

* spelling: maximum

* spelling: minimum

* spelling: mutable

* spelling: notifier

* spelling: coordinate

* spelling: passport

* spelling: perform

* spelling: permuter

* spelling: placeholder

* spelling: progressively

* spelling: semantic

* spelling: submission

* spelling: submit

* spelling: translations

* spelling: turquoise

* spelling: visualization

* spelling: without

* spelling: registration

* spelling: representation
2020-02-08 23:59:10 +05:30
Kiara Barias afd467f5dc
Removes RSA links from English challenges (#37869)
* RSA links deleted from challenges

* fix: remove remaining RSA links in challenges
2020-02-07 14:46:07 +09:00