Commit Graph

72 Commits (31a69ea6857f7b68d00486cb3b37e21c7ad292d0)

Author SHA1 Message Date
Randell Dawson db8098601e fix(curriculum): Remove unnecessary assert message argument from English Data Visualization challenges (#36424)
* fix: removed assert msg argument

* fix: corrected test text
2019-07-11 10:53:41 +02:00
Daniel Simeonov 81d7127a5d Added solution for English/Data-Visualization/Hover-tod3-element (#36220)
* Added solution for English/Data-Visualization/Hover-tod3-element

* Added full solution for Data-Visualization-D3/Hover-effect-to-d3-element

* fix: added extra line to prevent linting errors
2019-06-20 09:49:47 -07:00
leodaher 0be75e4b39 feat(curriculum): Add fetch challenge to the current curriculum. (#36033)
* Add fetch challenge for the current curriculum
2019-06-18 00:19:33 +02:00
Randell Dawson dd6011b2cc fix(curriculum): Convert blockquote elements to triple backtick syntax for Data Visualization (#35995)
* fix: convert data visualization

* fix: reverted to blockquote

* fix: changed js to json

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: cleaned up code

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-05-14 07:04:05 -05:00
Yoelvis Jiménez fdb49ba89a Fix "ReferenceError: url is not defined" in challenge (#35415)
* Fix "ReferenceError: url is not defined" in challenge

I fix the challenge because issue #14002 
- The `url` variable is set to external resource `https://jsonplaceholder.typicode.com/posts`
- I replaced .textContent instead of .innerHTML (better practice)
- Checking for HTTP status of 201 instead of 200
All these suggestions by @HarplingeTom and "approved" by  @QuincyLarson. See the issue comments.
I test the code locally in my computer and this works 👍 
I modified and verify the tests according the new assessment.

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md

Minor typo: `<code>` to `</code>`

Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md

new declared as const

Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>
2019-05-08 20:07:36 -05:00
Sumer Patel 4f22235cc6 fix: broken tests in add-axes-to-a-visualization-challenge-in-d3 (Issue: #35554) (#35577) 2019-03-13 13:53:02 +05:30
NITIN BISHT b5468932f0 fix: seed code doesn't match description [english] (#35380) 2019-02-24 09:02:56 -06:00
lasjorg 0a7932ea1d fix(challenge): update test to support arrow function (#35268)
* fix(challenge): update test to support arrow function

* fix(challenge): update solution

* fix(challenge): update solution fully

* fix: corrected unrelated issue
2019-02-24 08:54:37 -06:00
Randell Dawson bc99876f9e [Fix] allow line breaks between method calls for several Data Visualization challenges (#35093)
* fix: allow spaces between lines breaks a function arguments

* fix: allow line breaks between method calls
2019-02-22 12:18:10 -07:00
Kristofer Koishigawa 84e28bd0f0 fix(challenges): update required links for d3 challenges (#34477) 2019-02-08 09:37:46 +03:00
The Coding Aviator 536fe28162 Update get-json-with-the-javascript-xmlhttprequest-method.english.md (#34408) 2019-02-06 07:51:59 -06:00
Bannon Tanner a3c917ee62 changed position data to make correct values pass (#26987)
Closes: #17996
2019-02-02 21:49:36 +04:00
Tracey Bushman b730b67e1a fix(curriculum): replace data urls with CDN urls for D3 projects (#34964)
* fix(curriculum): replace data urls with CDN urls for D3 projects

* fix(curriculum): data urls --languages

* fix(curriculum): stray old url
2019-01-29 03:41:02 +05:30
The Coding Aviator 5cc3e97c86 [Fixed Bug] Data Visualization with D3: Learn About SVG in D3 (#27022) 2018-12-03 12:44:30 +09:00
Valeriy 591309550b test(curriculum): check tests against solutions (#27716) 2018-10-24 16:45:00 +05:30
Valeriy 79d9012432 fix(curriculum): quotes in tests (#18828)
* fix(curriculum): tests quotes

* fix(curriculum): fill seed-teardown

* fix(curriculum): fix tests and remove unneeded seed-teardown
2018-10-20 23:32:47 +05:30
The Coding Aviator 5bc241a9a7 Update add-classes-with-d3.english.md (#19508)
* Update add-classes-with-d3.english.md

* Update add-classes-with-d3.english.md

* Update add-classes-with-d3.english.md
2018-10-16 16:05:22 +01:00
Bouncey ee9f6b2d72 chore(meta): Move challenge meta to challenges root 2018-10-11 02:15:05 +05:30
Beau Carnes d1751adc9e fix: add meta.json 2018-10-08 15:46:27 -04:00
Beau Carnes fcced4a6c3 docs: add Spanish docs 2018-10-08 13:34:43 -04:00
Bouncey a859035023 fix(challenge-md): Fix quotes that failed in the transform 2018-10-08 11:38:26 +05:30
Bouncey 8f39bc1288 chore(curriculum): Remove files in wrong format 2018-10-05 15:58:12 +01:00