Commit Graph

1347 Commits (31a69ea6857f7b68d00486cb3b37e21c7ad292d0)

Author SHA1 Message Date
danzel-py 48e19ccd7b
fix: typo in instructions (#41696) 2021-03-31 13:47:19 +05:30
Alan fb40f56876
fix(curriculum): malformed paragraph in react/redux (#41645)
* fix: re-arranged paragraph in react-redux lesson

* fix: re-arranged paragraph in react-redux lesson in different locales

* fix: reverted other locale changes

* fix: switched link to enable opening as a new tab
2021-03-29 16:00:12 +00:00
Sem Bauke 87c9c799c6
fix(curriculum): Regex fix for Create a Variable for a Specific Area (#41501) 2021-03-29 17:09:52 +05:30
Rafael D. Hernandez c962c0c8e5
fix: wrap own properties and not just own (#41614)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-27 07:59:44 -06:00
Randell Dawson 18ac058840
fix(curriculum): Improve wording of test text (#41606)
Co-authored-by: Ricardo Passos <55499252+dizz-y@users.noreply.github.com>
2021-03-26 13:01:20 -05:00
Emer Conghaile e5b4ae17a0
fix: Simplify wording to make more sense (#41586)
* fix: Simplify wording to make more sense

I think that "count odd numbers backward by twos" instead of "count backward by twos by odd numbers" is easier to understand.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md

I think that this variation sounds better than what I originally wrote.

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-25 22:18:51 +00:00
Randell Dawson b5ed2619eb
fix: replace inline code blocks (#41576) 2021-03-26 02:37:48 +05:30
gikf 8cc172d9e8
fix(learn): rework Rosetta Code Harshad or Niven series (#41554)
* fix: rework challenge to use argument in function

* fix: remove unnecessary link

* fix: improve wording

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-26 02:28:09 +05:30
Laurent Labine 8e22962523
fix(curriculum) replace single-line blocks with multi-line blocks for… (#41526)
* fix(curriculum) replace single-line blocks with multi-line blocks for issue 51418

Data visualization and Coding Interview Prep portions.

* Update execute-a-markov-algorithm.md

Implemented as inline code blocks as discussed

* Adding missed blocks

* Last file added
2021-03-25 07:43:13 -07:00
fuzzyray 2ad908b3a9
fix(learn): correct the instructions for functional tests (#41459) 2021-03-23 10:24:55 +05:30
CoolBlueDesigns fd5e6eebfb
fix(curriculum): add blank like to seed code 2021-03-22 16:18:15 +00:00
Randell Dawson e18c6955b0
fix(curriculum): Improve test to allow any valid function call for Write Reusable JavaScript with Functions challenge (#41538)
* fix: improve test to allow function call anywhere

* fix: force user to put console.log in function
2021-03-20 12:23:32 +00:00
Seth 654d66186e
Stock Price Checker: Change "form data" to "query parameter" (#41492)
* Stock Price Checker: Replace form data with query parameter

* Improve wording of Stock Price Checker user stories

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* More consistent wording and link term to Wikipedia

* Removed Link to External Resource

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-19 15:19:13 -06:00
Arjun Yadav 3f1cd6eb33
fixed the grammar of the description (#41531) 2021-03-19 06:55:21 -06:00
Shaun Hamilton 251d916e76
fix(learn): specify connect-mongo version in adnode (#41524) 2021-03-19 06:43:56 +01:00
Laurent Labine 00b37093db
fix(curriculum): replace single-line blocks with multi-line blocks for… (#41525)
* fix(curriculum) replace single-line blocks with multi-line blocks for Front End Libraries #41523

Second attempt

* Update curriculum/challenges/english/03-front-end-libraries/react/use--for-a-more-concise-conditional.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-03-18 23:40:32 +00:00
Sem Bauke b064991667
fix(curriculum): Replace single-line blocks with multi-line blocks for Responsive Web Design (#41519)
* fix(curriculum) replace single-line block with multi-line blocks

* fix(curriculum) replace single-line block with multi-line blocks (missed blocks)
2021-03-18 17:24:09 -06:00
gikf b8ddfc08b3
fix(learn): rework Project Euler 63 (#41425)
* fix: rework challenge to use argument in function

* fix: add solution

* fix: correct function call in seed code

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: improve instructions wording

* fix: correct typo

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-03-16 18:41:47 -05:00
Randell Dawson d2f4b70ea6
fix: remove end of line chars after code blocks (#41498) 2021-03-16 07:49:43 -07:00
Randell Dawson c198d508be
fix(learn): Improve tests for the Nest an Anchor Element within a Paragraph challenge (#41456) 2021-03-12 10:09:22 -07:00
gikf 9669e39b85
fix(learn): make tests and test descriptions more explicit (#41281)
* fix: make tests and descriptions more explicit

* fix: add example to description

* fix: replace pre tags with markdown

* fix: move test data to seed code for convenience

* fix: correct grammar from review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Revert "fix: move test data to seed code for convenience"

This reverts commit 7a9c4723d6.

* fix: small corrections

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-03-12 07:29:03 -08:00
Randell Dawson 33bd4fb2c4
fix(learn): Change Codepen template link (#41440) 2021-03-12 10:41:48 +05:30
pandacoder7 53d372c298
fix: update challenge for crowdin in anchor page (#41450) 2021-03-11 13:35:34 -07:00
Luca 5589c37804
fix(learn): remove wrong spaces and make quotes consistent (#41434)
* Remove spaces that are not meant to be there (L37, L134, L156) Makes quotes consistent (L61)

Remove spaces that are not meant to be there (L37, L134, L156)
Makes quotes consistent (L61)

* Consistent spacing after commas

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-11 07:19:07 -08:00
Kelvin Sánchez 35a8f55515
fix(learn): Remove unnecessary inline code tag in challenge (#41428)
* remove unnecessary inline code tag

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-less-than-or-equal-to-operator.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* improve challenge wording

* improve challenge wording

* keep wording consistency

* keep wording consistency between similar challenges

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-10 10:16:03 -08:00
Sem Bauke 5b760e50a3
fix(curriculum) Improved readability and grammar (#41340)
* fix(curriculum) Improved readability and grammar

* fix missing tags and grammar

* fix(curriculum) changes to grammar

* fix(curriculum) grammar fixes

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-elements-only-visible-to-a-screen-reader-by-using-custom-css.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix(curriculum) Grammar fix

* chore: apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-03-10 09:00:03 -08:00
Caden Parker 6b9aeff09e
fix(learn): Rework Euler Problem 461 (#41333)
* Made instructions more clear + Corrected test cases

* Added highlight for return values

* Adjusted challenge description

* Rework

* Fixed minor linting error

* Address PR Comments

* Adjusted wording in description
2021-03-10 08:14:27 -07:00
Caden Parker d8e6d8dc46
fix(learn): Rework Euler Problem 182 (#41337)
* Rework Euler Problem 182

* Reordered tests

* Fixes for formatting
2021-03-10 15:55:52 +01:00
Caden Parker 256e7f416d
fix(learn): Added more robust logic for the remove test case in Create A Hash Table (#41283)
* Added extra test cases for hashtable.remove

* Minor Change

* Adjusted tests to use user created add function / Modified description

* Made test case description much more clear

* Changed instructions to be more clear

* Minor change to instructions

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 12:45:20 -06:00
Emer Conghaile 18068cdeaa
fix: remove forward slash from <source> tag (#41422)
The forward slash at the end of the <source> tag in the example is removed, as this is more common.
2021-03-09 16:20:22 +00:00
Nicholas Carrigan (he/him) c5bcebc724
fix(learn): revert backslash change (#41382)
* fix(learn): revert backslash change

Crowdin resolved the issue with backslashes escaping backtics in
the markdown parser, so this reverts the workaround we implemented
for that bug.

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/s-expressions.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 10:13:27 -06:00
gikf bd02249a23
fix(learn): rework Rosetta Code Count the Coins (#41282)
* fix: rework challenge to use argument in function

* fix: use better wording

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-09 08:34:10 -06:00
Nicholas Carrigan (he/him) 77730ae209
fix(learn): address translator comments (#41381)
* fix(learn): address translator comments

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/quoting-strings-with-single-quotes.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 08:15:26 -06:00
gikf 93495ef6db
fix(learn): correct tests description (#41280)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 11:48:12 +05:30
Nicholas Carrigan (he/him) 16e420021c
chore: audit data visualisation challenges (#41336)
* chore(learn): audit d3 projects

* chore: audit data vis

* chore: audit json apis

* Update curriculum/challenges/english/04-data-visualization/data-visualization-projects/visualize-data-with-a-scatterplot-graph.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: apply suggestions

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: no colour backticks

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/get-geolocation-data-to-find-a-users-gps-coordinates.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-05 12:25:29 -07:00
Ricardo Passos ae79525493
fix(learn): added a missing period and removed single quotes (#41377)
* Added missing period

On line 24, just before "Note that in your CSS..." a period was missing.

* Removed single quotes and added a missing period

On line 24, just before "Note that in your CSS..." there is a missing period. 
On line 30, the text "red-text" within a code tag is enclosed in single quotes.
2021-03-05 07:16:30 -08:00
Nicholas Carrigan (he/him) 4d8aae1678
fix: backtick formatting (#41371) 2021-03-05 11:39:04 +05:30
gikf 5332628e6d
fix(learn): rework Rosetta Code Hailstone Sequence (#41279)
* fix: rework challenge to use argument in function

* fix: change leftover html to markdown

* Apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* remove leftovers

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-04 13:28:47 -08:00
lusc 8a5711dda7
Fix: remove a colon in rosetta-code/happy-numbers (#41349)
* Fix: remove a colon in rosetta-code/happy-numbers

Removed a colon that shouldn't be there

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/happy-numbers.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add inline code tags around all true and falses

https://github.com/freeCodeCamp/freeCodeCamp/pull/41349#discussion_r586700058

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-04 09:25:55 -07:00
Andrew Cen 65cc800689
fix: add blank lines on empty seeds (#41348) 2021-03-03 13:14:28 -08:00
gikf 728f44ab38
fix: clarify case for already placed valid number (#41225) 2021-03-03 23:02:51 +05:30
Nicholas Carrigan (he/him) 7117919d36
chore(learn): audit javascript algorithms and data structures (#41092)
* chore(learn): audit basic algorithm scripting

* chore(learn): audit basic data structures

* chore(learn): audit basic javascript

* chore(learn): audit debugging

* chore(learn): audit es6

* chore(learn): audit functional programming

* chore(learn): audit intermidate algorithms

* chore(learn): audit js projects

* chore(learn): audit object oriented programming

* chore(learn): audit regex

* fix(learn): remove stray .

* fix(learn): string to code

* fix(learn): missed some

* fix(learn): clarify strings

Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.

* fix: apply suggestions - thanks Randy! :)

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: non-suggestion comments

* chore(learn): remove comments from codes

Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: revert crowdin fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* chore: change voice

* fix: Christopher Nolan

* fix: expressions would evaluate

* fix: will -> would

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: to work to push

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-02 17:12:12 -07:00
Randell Dawson 57f3c80345
fix(learn): Clarify date format expectations for the Date Format challenge (#41327)
* fix: clarify date format expectations

* chore: apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-02 15:46:30 -08:00
Sem Bauke f328bdb93e
fix(curriculum) fixes for grammar and missing articles (#41335)
* fix(curriculum) fixes for grammar and missing articles

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/add-gaps-faster-with-grid-gap.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-02 12:27:45 -07:00
Ilenia 051a010798
fix(learn): disallow www link from challenge (#41275)
This commit disallows www link from "Nest an anchor in a paragraph" challenge.
2021-02-27 02:47:47 +05:30
Nicholas Carrigan (he/him) 31bdea63a2
chore(learn): audit front end libraries (#41179)
* chore(learn): audit bootstrap

* chore(learn): audit FE projects

* chore(learn): audit jQuery

* chore(learn): audit React

* chore(learn): audit react-redux

* chore(learn): audit redux

* chore(learn): audit sass

* fix: apply review suggestions

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: apply non-suggestions

* chore: remove comments from code

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-25 10:19:24 -07:00
Randell Dawson 33356e403a
fix(learn): Use backticks around back slash character (#41254) 2021-02-25 16:34:40 +05:30
Oliver Eyton-Williams 4917e59aaa
fix(curriculum): use user's url in url shortner tests (#41257)
This service is both guaranteed to be up (they're hosting it) and should
allow CORS for all requests (including the tests).
2021-02-25 12:04:09 +01:00
Randell Dawson b11dd87047
fix: remove sentence not needed (#41235) 2021-02-23 11:21:58 -06:00
Randell Dawson f4bbe3f34c
fix(learn): Updated code blocks to help with translation on two challenges (#41217) 2021-02-22 11:21:59 +05:30
Alexander Heß b12360d4a8
Removed the hint Fixes #41192 (#41215)
* Removed the hint Fixes #41192

* Removed the blank line as suggested
2021-02-21 13:36:14 -07:00
Ilenia aa615763af
fixed tests for link to external pages challenge (#41191)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-21 11:46:00 +05:30
gikf 531c3f9997
feat(learn): add project tests (#41183) 2021-02-21 10:37:02 +05:30
gikf 219339b2ce
fix(learn): rework Project Euler - Problem 58 (#41188) 2021-02-20 12:06:32 +05:30
gikf f5a905b7c2
fix(learn): unmangle challenge description (#41182) 2021-02-20 12:04:38 +05:30
gikf 70c4d82068
fix(learn): correct test result (#41068) 2021-02-20 12:04:12 +05:30
gikf c8db838754
fix: correct function call in test description (#40949) 2021-02-20 12:03:54 +05:30
gikf a91444d3d4
fix: correct function call in test description (#40944) 2021-02-20 12:03:33 +05:30
Kelvin Sánchez f08174b5b1
fix(learn): Remove unnecessary inline code tag in challenge (#41177)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-19 09:44:50 +05:30
Kelvin Sánchez fad168b465
fix(learn): fix some code tags, capitalization and punctuation in challenge (#41161)
* fix some code tags, capitalization and punctuation

Note: The reserved word in JavaScript is "boolean", so I think it is appropriate to use it like this inside the code tags.

* Remove code tags and capitalize first letter

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* capitalize letter and replace slash

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:45:12 -07:00
Kelvin Sánchez 2c1280af65
fix(learn): Improve the clarity on a challenge sentence (#41154)
* Improve the clarity on a challenge sentence

* add string type and remove double quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:29:31 -07:00
gikf 762775889e
fix: rework Project Euler - Problem 57 (#40926)
* fix: rework challenge to use argument in function

* fix: add solution

* fix: correct variable name
2021-02-17 11:58:18 -08:00
Kelvin Sánchez 1fe1371b16
add missing inline-code block (#41153) 2021-02-17 11:24:53 -08:00
Joshua Pelealu 10aee18748
Remove broken twitter links (#41152) 2021-02-17 12:03:57 -07:00
Kelvin Sánchez b45406ec9d
fix(learn): Remove repeated definition tag in challenge (#41151) 2021-02-17 23:01:42 +05:30
Joshua Pelealu c15c27f474
fix(learn): Added another test to check for invalid characters (#41144) 2021-02-17 21:16:07 +05:30
fots 2a2657d36c
fix: update regex for Convert JSON Data to HTML (#41134)
* fix: updated solution for Convert JSON Data to HTML

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-02-16 16:27:47 +00:00
Nicholas Carrigan (he/him) 21c7abf584
fix(learn): update challenge for crowdin (#41089) 2021-02-16 19:47:40 +05:30
Supritha ee6764519d
REMOVED comments (#41048)
* Added comments

Fixes freeCodeCamp/freeCodeCamp#40903

* remove comments
2021-02-11 09:13:38 -07:00
Kristofer Koishigawa c9de726d6a
feat: move Repl.it links to first challenge in backend projects (#40803) 2021-02-11 14:09:59 +05:30
gikf 6ae3735979
fix: correct tests descriptions (#40945) 2021-02-10 17:12:12 +05:30
ehsabd 9f219f3f2b
fix(learn): Fix the public assets folder confusion by giving it its own folder (#40802)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-10 17:11:40 +05:30
Kim Leung 082b269dce
fix(learn): backslashes in description & hint text (#40801)
Correct example code in description and last hints text to match the last assertion test's actual and expected inputs.  The string input with a single backslash throws an unterminated string constant error (single backslash starts a regex).  No change to last assertion test as it was written correctly with a double backslash and passing as expected.
2021-02-10 17:10:51 +05:30
Lucas Sorenson f8aa6c04e2
fix(learn): update seed code for D3.js challenge (#40699)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Lucas Sorenson <lsorenson@sunsh1n3.com>
2021-02-10 17:06:19 +05:30
Ismail Tlemçani 0f8449788c
feat(learn): add tests to use a callback function in the sort method (#40847) 2021-02-10 17:05:23 +05:30
Tom 959fe8323a
fix(learn): mongoose set up instructions (#40909)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-10 17:04:16 +05:30
Tom 51f6077f7b
fix(learn): regex-criminal-in-hunt-challenge (#40901)
* fix: regex-criminal-in-hunt-challenge

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/find-one-or-more-criminals-in-a-hunt.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-08 06:10:59 -08:00
Jean-Baptiste LARRIVIERE 1c539d07c3
fix(curriculum): remove mention of null from challenge (#40942)
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-02-08 13:17:32 +05:30
Tom 15227a0148
fix(curriculum): helmet install and csp lessons (#40904) 2021-02-06 16:36:40 +00:00
Randell Dawson 167f93df76
fix(learn): Add inline code blocks to for i18n (#40921) 2021-02-05 14:16:19 +05:30
Shaun Hamilton 1a9b791f29
update(curriculum): explicitise use-the-env-file (#40898)
* update(curriculum): explicitise use-the-env-file

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-04 19:43:18 +01:00
Nicholas Carrigan (he/him) 12658d33fc
fix(i18n, learn): more crowdin fixes (#40905) 2021-02-04 13:34:44 +05:30
Tom 30c923b73d
fix(curriculum): helmet hide-powered-by description (#40900)
* fix: remove option that isn't usable in new version of helmet

* fix: make text instructional
2021-02-03 23:13:02 +00:00
Keith c21b2a9707
fix(learn): corrected typo (#40902)
Fixed typo at the end of the 4th paragraph. Changed "Others options include:" to "Other options include:".
2021-02-03 15:11:44 -08:00
Guilherme Dias Simões ddf495c335
Fix 'wrap' and 'wrap-reverse' definitions. (#40766)
The definitions for the options 'wrap' and 'wrap-reverse' were slightly wrong as can be seen by applying them to the challenge.
2021-02-03 13:01:43 -06:00
gikf 313b345611
fix: correct Rosetta Code Knight's tour solution (#40830)
* fix: correct answers in tests and descriptions

* fix: replace sample solution for correct one

* fix: missing space

* fix: improve sample solution performance
2021-02-03 12:43:29 -06:00
Nicholas Carrigan (he/him) b0bd3f5549
fix(learn): abstract comments from code (#40869) 2021-02-03 22:28:33 +05:30
Nicholas Carrigan (he/him) 4d48fb5ce7
fix(learn, i18n): crowdin issues (#40884)
Resolves a couple of issues with Crowdin parsing.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2021-02-02 14:08:32 -07:00
Oliver Eyton-Williams 66b684807c chore: migrate certs from .markdown to .yml 2021-02-02 09:51:02 +05:30
Nicholas Carrigan (he/him) 427444c757
chore(learn): audit files for crowdin (#40838)
* chore(learn): audit files for crowdin

Audits the challenge text in the Responsive Web Design superblock to
account for words/phrases that should not be translated because they
refer to code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove quotes from code

Removes instances of quoted code blocks, or code blocked quotes.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: additional uncaught quote-codes

Thanks Oliver :)

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: so many quotes

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: missing punctuation

Noted in a Crowdin comment.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove more quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-01 12:56:07 -07:00
Luis H. Ball Jr 8d60aad97b
feat(curriculum): add extension tests for css-flexbox curriculum modules (#40473)
* feat(curriculum): add extension tests for css-flexbox curriculum modules

* apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* fix: reorder tests

Moves the test that asserts the presence of the follow button to the
top of the order.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-01 07:57:36 -08:00
Kim Leung a37d5f5817
fix(learn): add output type verbiage (#40589)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-01 19:41:15 +05:30
Nicholas Carrigan (he/him) 18e821bcd3
fix: remove clunky sentence (#40751) 2021-02-01 19:22:39 +05:30
Hernando Guzmán f63ca27e6a
Fix: corrected the typo (#40837)
Updated run-functional-tests-using-a-headless-browser.md to correct the typo
2021-02-01 06:52:11 -07:00
Randell Dawson 22f017caa2
fix(learn): replace single bactick with <code> tag for Crowdin (#40774) 2021-02-01 19:09:13 +05:30
Kai-Chin Huang 5503b54f85
fix(learn): update the return Object.values & solution (#40451) 2021-02-01 13:12:54 +05:30
Evan Boehs 8c22432b17
fix(learn): add period for readability (#40836) 2021-01-31 13:57:46 +05:30
Hernando Guzmán 3394a654bd
fix(learn): Correct syntax in the code example (#40811)
Closes #40810
2021-01-27 11:03:22 -08:00
gikf d41630ee19
fix(learn): clarify test description for Use Rest Parameter with Function Parameter (#40725)
* fix: clarify test description

* fix: improve wording regarding rest parameters syntax

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: improve with better sounding wording

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-24 08:30:13 -08:00
Mainak Debnath d5ad87d915
fix(learn): put test cases under --seed-- and remove them from the solution (#40755)
* fix: put test cases under --seed--

* fix: put test cases under --seed--
2021-01-21 18:26:06 -08:00