Commit Graph

4 Commits (3886d3435afca8cc20fac00c7e0c95d32330b1be)

Author SHA1 Message Date
Kaiguang Li 360e3fffbd Fix misplaced anchor tag (#20346) 2018-10-30 19:01:01 -07:00
Pablo Rubianes 5c2bd53d5c fixes the Advanced Code Solution to make it work when run tests in the Convert HTML Entities exercise (#24930)
* fix in the Advanced Code Solution to make it work when run tests

* making htmlEntities a const to fix the example
2018-10-25 13:41:36 -07:00
Bill Sourour f0eb384b10 Smallest Common Multiple – Optimized Advanced Solution (#19572)
* Optimized advanced solution

Made 2 minor improvement to the advanced solution:

1. The original advanced solution used `Math.max` and `Math.min` against the supplied array, this causes the values in the supplied array to be compared twice. If we use sort instead, the values are only compared once and we can target the max and min values using an index. This is more efficient.

2. The original solution caused `lcm(min, min + 1)` to be evaluated twice. By incrementing `min` the first time we run `lcm` we avoid this duplication and also by taking advantage of the prefix increment operator ++ in the while loop, we trim a line.

* Fixed extra spaces in code block

* Incorporated code feedback from #19572

Made the following changes to the advanced code solution:

- Converted helper functions to arrow function constants
- Simplified comments
- Used destructuring and `sort` for `min` and `max`

* Fixed spacing.
2018-10-18 10:08:45 -07:00
Mrugesh Mohapatra da0df12ab7 fix(guide): simplify directory structure 2018-10-16 21:32:40 +05:30