Commit Graph

49 Commits (394ae3d1ce107f668157b6c22837616593d877e8)

Author SHA1 Message Date
Илья a326c2cf9a Make a comparison in the test more accurately (#35500)
* Update use-arrow-functions-to-write-concise-anonymous-functions.english.md

* refactor:  fix the assert messages to make them more like all the rest in the curriculum (i.e. using `should`)

Co-Authored-By: iliyaZelenko <iliyazelenkog@gmail.com>
2019-04-01 10:55:43 +02:00
Amy Lam 914a7c522d Copy edits (#35536)
* Copy edits to Basic JavaScript section

* Copy edits to ES6 section

* Update index.md
2019-03-29 22:06:58 +05:30
Lipis e84ae45008 Javascript -> JavaScript (English) (#35183)
* Javascript -> JavaScript (English)

* Update technical documentation page for required change

* Update use-class-syntax-to-define-a-constructor-function.english.md

* Update left-factorials.md
2019-03-28 14:05:41 +05:30
Randell Dawson 6c82a07b2d fix: made destructuring test more flexible (#35685) 2019-03-27 23:59:53 +05:30
Justin Hilliard 8b5ef8cfdd Fix(Curriculum): Constructor function not explained before ES6 #17865 (#35463)
* Fix(Curriculum): Constructor function not explained before ES6 #17865

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md

Co-Authored-By: hilliarj <hilliarj@dickinson.edu>

* Update to #17865 PR

Fix(Curriculum): Constructor function not explained before ES6. Used an unordered list and the syntax that others recommended.
2019-03-26 09:53:19 -07:00
seanlaing e4870c472a fix/update-es6-destructor-challenge: Added test (#35455)
* fix/update-es6-destructor-challenge: Added test
- Added test incase during destructuring somebody pass and extra key

* fix/update-es6-destructor-challenge: Fixed the test case per review comments
-Cleaned up regex
- Setup two cases one where additional assignment of variables before and then after
- Did not put uppercase case CONSTANT checks because not related to question

* fix: corrected tests
2019-03-25 15:49:56 -05:00
Aditya 9cca21f57f [Fix] Removed unnecessary IIFEs from ES6 challenges (#34538)
* feat: removed IIFE and added solution

* feat: updated challenges seed, test and solution

* style: removed semicolon

* feat: updated seed and solution

* feat: updated challenges seed and solution

* feat: updated test, seed and solution

* fix: added seed code to solution

* fix: removed function and added solution

* fix: removed makeClass function and fixed solution

* style: removed excessive semicolons

* Fixed spacing for note in instructions section

* fix: removed assert messages and used const

* fix: regex fails correctly now
2019-03-25 09:19:34 -05:00
Hugo 739f4a8850 fix: Update test for ES6 challenge (#34300)
* fix: es6 challenge test

* delete console.log
2019-03-21 10:50:30 +01:00
Chuck Adams 4b2219b01d close #35246 - change AVG_TEMPERATURES to avgTemperatures in instructions (#35537) 2019-03-20 22:02:21 +01:00
Lewis Horwood 38c99d7ff5 Simplify challenge wording (#25120)
* Simplify challenge wording

* Update use--to-import-everything-from-a-file.english.md
2019-03-06 18:57:43 -05:00
Alan Price 27a59c5418 fix: reworded text messages (#27072) 2019-03-06 18:30:58 -05:00
geeseyj f3fd951446 fix(coding): uncomment destructuring test and add solution (#18909)
* fix(coding): uncomment destructuring test and add solution

the test that ensured destructuring was being used had been left commented out and there was no solution offered. I uncommented the test and verified it worked as well as added the solution.

* fix: corrected partial solution to full
2019-02-25 23:27:50 +05:30
Chris Del 10e9c6f340 Update Higher-Order Arrow Functions code challenge (#34414)
* fix: update text of Write Higher Order Arrow to be more instructive

* fix: update tests and code to be more simple. Edit typos in text part. Prepare for PR

* fix: further changes to PR

* fix: checkout old head. Merge later commit with older commits

* fix: add MDN links to arrow-functions guide

* fix: re-add removed log and change working in guide wording

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Yep

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Removing unneeded line for clarity

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
2019-02-24 13:34:53 +05:30
rupali317 5f6595b7dc fix: use correct variables for challenge (#34935)
Deleted the sentence which refers a.start.x as an object, as it is not an
object
2019-02-20 22:00:21 -08:00
Lee 551c97feb1 Update: Added info re uppercase and lowercase (#35094)
* Update: Added info re uppercase and lowercase

Included information to explain that lowercase and camelCase can be used for const identifiers.

* Fix: corrected mutable to immutable

I corrected the error that uppercase is used for mutable values.

* Fix: changed ** ** to <strong></strong>

I changed the markdown **  ** to <strong></strong>, as I was informed that ** didin't work.
2019-02-19 23:12:46 -05:00
Christopher Szczechowicz 994ee89a86 fix: add a ; to the end of the example code (#34379) 2019-02-16 19:20:10 +05:30
Valeriy 99cf6090bd fix(curriculum): getUserInput is not defined 2019-02-13 22:01:38 +00:00
The Coding Aviator 90a9df1a5d Fixed problem with regex in es6 import challenge (#19718)
import-a-default-export.english.md: support both main quoting styles
2019-02-03 18:07:55 +01:00
Paul Gamble fabd45e1b4 Revert "Challenge - ES6: Use Destructuring Assignment to Assign Variables from Arrays - Added solution (#26531)" (#34949)
This reverts commit 23096f7ed6.
2019-01-31 10:39:39 -08:00
Alan Price 1a6e1e57cc Added solution (#27077) 2019-01-24 15:36:57 -05:00
Alan Price 23096f7ed6 Challenge - ES6: Use Destructuring Assignment to Assign Variables from Arrays - Added solution (#26531)
* added solution for challenge

* removed function from seed and solution
2019-01-24 14:24:27 -05:00
Valeriy S 9b75c1965a fix(curriculum): replace window by self for js challenges 2019-01-16 10:45:39 +00:00
Alan Price 37d98f1123 Challenge - ES6: Write Arrow Functions with Parameters - Expanded description (#25997)
* Reworded and expanded the description

* renamed the function in the multiple param example
2019-01-09 11:00:16 +00:00
Alan Price d36922c496 Added solution (#27127) 2018-12-15 12:41:12 +05:30
Ashish Singh ffce49d024 fixing typo for one of the challenges in es6 section for issue #34578 (#34579)
* fixing typo on UI

* changed tes string

* updated changes for issue #34578
2018-12-15 11:56:12 +05:30
Adrian Skar 0af7ebad6d [Curriculum] ES6: Prevent object mutation; fix minor typos (#34650) 2018-12-12 13:32:28 +00:00
Alan Price 40f152ba15 Challenge - ES6: Use getters and setters to Control Access to an Object - Added solution and explanation of private variable naming convention (#24362)
* added explanation of private variable naming convention

* Added "Note:" to the front of the explanation

* Added solution

* Moved "Note:" to it's own line and made it bold

* fix: moved note block at the bottom
2018-12-03 19:10:09 +05:30
Aditya 254897c372 fix: fixed the test and added solution 2018-11-27 19:52:49 +09:00
Abhishek Kakade f4f5ce4b85 fix: updated challenges text (#34458) 2018-11-27 02:05:14 +05:30
Aditya 8d593a1256 fix(curriculum): Create Strings using Template Literals (#34296) 2018-11-22 19:51:51 +03:00
Aditya d9c6a13741 [Tests] ES6: Use Destructuring Assignment with the Rest Operator (#34303) 2018-11-22 22:27:16 +09:00
Prabhat Kumar Sahu fa4117ae85 Solution write-higher-order-arrow-functions.english.md (#18772) 2018-11-07 20:37:01 +09:00
The Coding Aviator f4ff1d961d Corrected wording in es6 challenge (#19946)
* Update compare-scopes-of-the-var-and-let-keywords.english.md

* Updated line

Co-Authored-By: thecodingaviator <34807532+thecodingaviator@users.noreply.github.com>

* Format the document
2018-11-05 12:58:36 -05:00
Shreyas BS 55686d7197 Updated grammar (#20541) 2018-10-30 22:58:51 -05:00
Bannon Tanner 088b0ec458 added note about UpperCamelCase for ES6 classes (#26979)
* added note about UpperCamelCase for ES6 classes

proposed note in issue #17864

* added note as a new heading

changed from note as a sentence to note as a heading plus the actual note

* added <code> around SpaceShuttle

* removed markdown and added <strong> tag
2018-10-24 23:28:15 +05:30
Valeriy 79d9012432 fix(curriculum): quotes in tests (#18828)
* fix(curriculum): tests quotes

* fix(curriculum): fill seed-teardown

* fix(curriculum): fix tests and remove unneeded seed-teardown
2018-10-20 23:32:47 +05:30
Prabhat Kumar Sahu d7810f6ab4 Update use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md 2018-10-17 21:40:37 +09:00
Prabhat Kumar Sahu c9a8b38ed3 Update use-destructuring-assignment-to-assign-variables-from-objects.english.md 2018-10-17 21:35:21 +09:00
Prabhat Kumar Sahu 6f09033346 Update use-the-spread-operator-to-evaluate-arrays-in-place.english.md 2018-10-17 21:31:51 +09:00
Prabhat Kumar Sahu 1a2843934f Update write-arrow-functions-with-parameters.english.md 2018-10-17 21:03:53 +09:00
Prabhat Kumar Sahu 393489565e Update use-arrow-functions-to-write-concise-anonymous-functions.english.md 2018-10-17 21:01:40 +09:00
Prabhat Kumar Sahu e5ebcec171 Update declare-a-read-only-variable-with-the-const-keyword.english.md 2018-10-16 15:52:06 +09:00
Prabhat Kumar Sahu 9f98cdce3b Solution prevent-object-mutation.english.md (#18767)
* Update prevent-object-mutation.english.md

* Improved JavaScript style
2018-10-15 21:04:52 -03:00
Prabhat Kumar Sahu b13e23037c Solution mutate-an-array-declared-with-const.english.md (#18759)
* Update mutate-an-array-declared-with-const.english.md

* Improved JavaScript style
2018-10-15 20:54:43 -03:00
Prabhat Kumar Sahu 1e3804889e Solution compare-scopes-of-the-var-and-let-keywords.english.md (#18756)
* Update compare-scopes-of-the-var-and-let-keywords.english.md

* Improved JavaScript style
2018-10-15 20:51:56 -03:00
Prabhat Kumar Sahu 7d0212dfb8 Solution explore-differences-between-the-var-and-let-keywords.english.md (#18752)
* Update explore-differences-between-the-var-and-let-keywords.english.md

* Improve JavaScript style
2018-10-15 20:50:04 -03:00
Bouncey ee9f6b2d72 chore(meta): Move challenge meta to challenges root 2018-10-11 02:15:05 +05:30
Bouncey a859035023 fix(challenge-md): Fix quotes that failed in the transform 2018-10-08 11:38:26 +05:30
Bouncey 8f39bc1288 chore(curriculum): Remove files in wrong format 2018-10-05 15:58:12 +01:00