Commit Graph

24906 Commits (3a2db6f090821fd0bff8c7258283050552046417)

Author SHA1 Message Date
Oliver Eyton-Williams 3c006d1823 fix: close CompletionModal when unmounted (#36991) 2019-10-03 09:42:24 -07:00
Miguel Mano fec32bbbac Fix broken contributing link in line 16 (#36990) 2019-10-03 18:03:58 +02:00
CubeSky 40e6ddca31 Added solution to "01-Responsive Web design" challenge (#36971) 2019-10-03 22:38:49 +07:00
CubeSky 3099f303ed Added solution to "01-Responsive Web design" challenge (#36968) 2019-10-03 21:11:38 +07:00
Gilson Santos af6a172145 Fix images link in spanish translation (#36952)
Fix images link in spanish translation "how-to-catch-outgoing-emails-locally"
2019-10-03 01:38:06 +07:00
Vicky Yue 5c7319f880 grammar fix (lines 37-41) (#36958)
* grammar fix (lines 37-41)

* Removed comma before 'and'

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-10-02 10:37:40 -07:00
Gilson Santos 7064886c07 Fix images link in chinese translation (#36954)
Fix images link in chinese translation "how-to-catch-outgoing-emails-locally"
2019-10-02 22:17:22 +07:00
Igor Hideki Trindade d574d1b9a9 Fix images link (#36927)
Fix images link in article "how to catch outgoing emails locally"
2019-10-02 14:48:34 +07:00
mrugesh b16ba8d18c chore: update issue templates 2019-10-02 11:55:13 +05:30
mrugesh abcb70b3d5
chore: update bug report template 2019-10-02 11:45:18 +05:30
mrugesh 80b40f73c5
chore: update bug report template for platform 2019-10-02 11:34:32 +05:30
mrugesh 2b7e41d355
chore: remove bug template for guides 2019-10-02 11:31:26 +05:30
Kristofer Koishigawa 07c552bffe feat: accessible search bar (#36784)
* feat: Passing hits from SearchHits to parent SearchBar to keep track of with the keyboard. Moved all logic for number of hits to WithInstantSearch.js

* Basic functionality working

* Added up/down looping functionality to dropdown

* Set 's' and '/' as shortcuts to focus the search bar

* Moved some things around and added functionality for mouse hovering to change the selected hit. Reworked a bit of the global CSS so mouse hovers don't cause multiple highlights in the dropdown

* Brought back magnifying glass icon

* feat: Switched out onKeyDown and key codes for react-hotkeys

* Refactoring based on review
2019-10-01 07:43:53 -07:00
Randell Dawson 8225ce7572 fix: added 3 new tests to mutations challenge (#36857) 2019-09-30 16:33:57 -04:00
Oliver Eyton-Williams aada59b068 fix: make fcc console log undefined 2019-09-27 22:08:40 +05:30
Oliver Eyton-Williams 6b5aaee3c5 feat: add script to clean, install and develop 2019-09-27 13:53:17 +05:30
Oliver Eyton-Williams f159645810 fix: make dasherize trim first 2019-09-26 22:15:27 +05:30
Oliver Eyton-Williams 3dc4e5897d fix: add tests and refactor slug utils 2019-09-26 22:15:27 +05:30
Oliver Eyton-Williams 9c2f1ffd82 refactor: combine slug utils into one module 2019-09-26 22:15:27 +05:30
Oliver Eyton-Williams 32ee2f032c fix: install cross-env for server npm script (#36855) 2019-09-26 21:16:45 +05:30
ivan-nikolaievskyi 6db0c1e71b fix(client): enable setting button when user profile is private (#36848)
Co-authored-by: i.nikolaievskyi <ivan.nikolaievskyi@leaseplan.com>
2019-09-26 15:53:02 +05:30
mrugesh 5b8ed8637e
docs: re-arrange frequently asked questions 2019-09-26 12:32:04 +05:30
Tom 8134a480a5 fix: use gatsby link where applicable (#36788) 2019-09-25 19:49:14 +05:30
Tom 52bd3a65de fix: balanced-brackets-tests (#36807) 2019-09-25 11:39:11 +02:00
mrugesh 92861b91cf
docs: update security docs 2019-09-25 02:04:12 +05:30
mrugesh a2c5e2379e
docs: update instructions for modifying hint topics (#36842) 2019-09-25 01:25:58 +05:30
Oliver Eyton-Williams 95fdb74d95 feat: escape prevents automatic editor focus 2019-09-24 22:22:14 +05:30
moT01 a7c42446be fix: remove command from hotkeys 2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams 6f5b22fd21 fix: re-remove Side-Panel 2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams 8b2f96609d fix: improve cross-platform consistency
Co-authored-by: moT01 <tmondloch01@gmail.com>
2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams cd3ef998a6 fix: rollback react-hotkeys and remove buttons 2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams 465f206a9d fix: focus on HotKeys by default 2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams 023df09289 fix: use GlobalHotKeys to catch keyup events
Added GlobalHotKeys just to make sure all keyup events are registered,
regardless of what state HotKeys is in.

Co-authored-by: moT01 <tmondloch01@gmail.com>
2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams af1008f4e5 fix: wrap backend and project in Hotkeys
Co-authored-by: moT01 <tmondloch01@gmail.com>
2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams c91393d737 feat: use local HotKeys and allow editor escape
GlobalHotKeys were abandoned, because they were capturing events that
had called stopPropagation.  This meant that something needed to be in
focus, hence passing a ref of the HotKey DOM element to the Editor.

react-hotkeys has been updated to 2.0.0-pre9, because 2.0.0 captured
ctrl keypresses when asked for ctrl+enter

Currently only classic challenges can be executed by hotkey, but all
allow hotkey navigation
2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams ab3a9076d9 fix: change hotkeys to work across platforms
Co-authored-by: moT01 <tmondloch01@gmail.com>
2019-09-24 22:22:14 +05:30
Oliver Eyton-Williams a19ceeffe2 feat: add navigation hotkeys 2019-09-24 22:22:14 +05:30
SomeDer 5de58ad98d fix(curriculum): use function form of this.setState (#36623)
* Fix solution

* Update description

* Add test for this.setState function syntax

* Update toggle element instructions

* Fix simple-counter solutions

* Fix bind-this challenge seed and solution

* Fix && challenge seed and solution

* Fix ternary challenge seed and solution

* Use the function form -> Pass a function

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Mention "passing a function" instead of "alternative form"

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Rephrase explanation

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* clarify why functions should be used

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Improve tests

* Fix \s escaping in []

* Improve regex

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add test for `this`

* Use block code

* Update bind-this challenge

* Fix last part of instructions

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-09-24 08:12:50 -07:00
Ent Wickler d08f009bd1 fix(curriculum): Add tests for setter, getter and setting a temperature (es6 tests) (#36620)
* add testing for setter, getter and setting a temperature according to some of feedbacks into the issues 17403

* bugfix: temperature is not a function
2019-09-23 17:13:32 +02:00
mrugesh e54a7fb350 fix(client): merge and update the learn map (#36822) 2019-09-21 16:39:48 +03:00
mrugesh a5b176be88
docs: update contributing guides (#36816) 2019-09-20 23:56:56 +05:30
Oliver Eyton-Williams 0c68f6a605 fix: improve map responsiveness (#36827)
* fix: improve map responsiveness

* fix: update SuperBlock tests
2019-09-20 23:52:03 +05:30
Oliver Eyton-Williams 3a0cd56ad3 fix(curriculum): Add and modify tests to catch bad code. (#36429) 2019-09-20 09:28:50 -07:00
Parth Parth 8c921a05d6 feat: add top five company logos (#36812) 2019-09-19 22:24:08 +05:30
Ahmad Abdolsaheb e653235d94 feat: universal navbar (#36744)
* feat: add universal nav

* fix: add portfolio redirect
2019-09-19 22:15:01 +05:30
sybiljasmine 5d946f3d77 valid factorial number update under the tests (#36792)
* valid factorial number update under the tests

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Removed redundant array in the tests
2019-09-19 08:52:09 -07:00
Oliver Eyton-Williams c483940da0 fix: stop Editor competing with Modal for focus
Editor now checks if the modal is open before trying to obtain focus.
2019-09-19 17:47:02 +05:30
Randell Dawson 1dd13a5865 docs: update how to work on guide articles on forum
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2019-09-19 16:21:27 +05:30
Kaitlin 76e1b1a4ba Update user test 13 desc to match changed test (#36523)
* Update user test 13 desc to match changed test

Refer https://github.com/freeCodeCamp/testable-projects-fcc/issues/933.

* Add examples to illustrate change to user story 13
2019-09-19 17:51:10 +09:00
mrugesh 5d92b3c668 fix: project views and icons for intros (#36811) 2019-09-19 10:14:58 +03:00