Commit Graph

1032 Commits (3f8d31656bf748802e699c4b810bf1db1cb0f6d6)

Author SHA1 Message Date
Randell Dawson 48884f3a4a fix: changed to h4 > s in selector (#36023) 2019-05-11 19:09:08 -05:00
Lipis 4101d5c73e Replace Github -> GitHub (Spanish) (#35182) 2019-05-10 12:44:53 -07:00
Randell Dawson 7437145bb4 fix: improved existing tests (#35801) 2019-05-09 09:01:50 -04:00
Yoelvis Jiménez fdb49ba89a Fix "ReferenceError: url is not defined" in challenge (#35415)
* Fix "ReferenceError: url is not defined" in challenge

I fix the challenge because issue #14002 
- The `url` variable is set to external resource `https://jsonplaceholder.typicode.com/posts`
- I replaced .textContent instead of .innerHTML (better practice)
- Checking for HTTP status of 201 instead of 200
All these suggestions by @HarplingeTom and "approved" by  @QuincyLarson. See the issue comments.
I test the code locally in my computer and this works 👍 
I modified and verify the tests according the new assessment.

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md

Minor typo: `<code>` to `</code>`

Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md

new declared as const

Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>
2019-05-08 20:07:36 -05:00
duytrinhvn 534824e232 Fix spelling error (#35925)
* Fix spelling error

* fix: changed be conformed to conform
2019-05-08 19:54:32 -05:00
Kyle Scheuerlein 3b5fbe3edb Improve formatting of Challenge Seed (#35854) 2019-05-08 18:32:01 -05:00
Deanna Tran 338d7ee8a7 Change "rest operator" to say "rest parameter" in challenges and guide (#35496)
* change es6 challenges rest operator to param

* fix rest parameter typos

* change rest operator to parameter in guide

* fix casing

* change rest operator to rest parameter in guide

* change rest operator to rest parameter in curriculum

* remove extra whitespace

* remove whitespaces

* remove whitespace

* fix: removed arabic file

* fix: removed chinese file
2019-05-08 16:30:24 +02:00
Tom 4f73b5a7f3 Fix/manage state locally tests (#35980)
* fix/manage-state-locally-test

* fix/update-test-words

* fix/update-test
2019-05-08 10:17:54 -04:00
Picklebunker 6a304ef9bb Updated grammar and consistency of terms. (#30668) 2019-05-07 22:46:37 -07:00
Picklebunker c16014531e Updated grammar and readability (#30658)
* Updated grammar and readability 

Terms such as class and item are either referred to in English or avoided in the Chinese versions of tutorials that I have found, as translating them directly does not make much sense.
Changed some sentence structures for the ease of understandings.

* fix typo
2019-05-07 12:14:06 -07:00
Picklebunker 5570716edf Update use-media-queries-to-create-responsive-layouts.chinese.md (#30686)
* Update use-media-queries-to-create-responsive-layouts.chinese.md

* update some translation
2019-05-07 12:13:47 -07:00
Tom 93e5554615 fix: added semi-colon not in original code
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-07 10:43:43 -07:00
Randell Dawson 5cfff58c7b fix: added all js to end of 3 backticks 2019-05-07 10:43:43 -07:00
Randell Dawson 5cf039e5fd fix: performed first conversions 2019-05-07 10:43:43 -07:00
Randell Dawson 1cb6092dd9 fix: performed first conversions 2019-05-07 10:43:43 -07:00
Picklebunker d96f5562a3 Updated grammar and term consistency (#30694) 2019-05-06 17:54:30 -07:00
Sergey Lebedev 44fa34a9b0 Improved Russian Translation. (#34189) 2019-05-06 16:32:53 -07:00
Sergey Lebedev 50d23c5381 Improved Russian translation. (#34188) 2019-05-06 16:15:48 -07:00
Ivan Gretsky 3fb3c494df Fix russian translation for use-the-flex-direction-property-to-make-a… (#33487)
* Fix russian translation for use-the-flex-direction-property-to-make-a-row.russian.md

* Update use-the-flex-direction-property-to-make-a-row.russian.md
2019-05-06 16:13:52 -07:00
The Coding Aviator 675b204b8a fix(curriculum): Hide solution from tests (#35254) 2019-05-06 16:01:23 -07:00
Mo7amm1d 579aa7628c Improving Arabic translation on several "Basic HTML and HTML5" section files (#34908)
* Improving Arabic translation

Improving Arabic translation in say-hello-to-html-elements.arabic.md file

* Translating Description and Improving Arabic Translation.

Translated the Description from the English version. Also Improving the Arabic translation.

* Fixing a mistake in translating the tests.

* Fixing a mistake I made while translating the tests in headline-with-the-h2-element.arabic.md

* Improving the Arabic translation and fixing grammar.

* adding space to (I'm a p tag) in line 10

* fixing bad indentation.

* fixing bad indentation (mistake by me)

* fixing bad indentation (mistake by me)

* Add missing Description and Test text

Adding missing description text and Test text from English version. Also general improvements to the Translation.

* Adding missing description text and Test text 

Adding missing description text and Test text in in uncomment-html.arabic.md from English version. Also general improvements to the Translation.

* Improving the Arabic translation

* Minor updates to the translation

* Overall Enhancement to the translation.

* General translation improvement 

Improving the translation on the Description, Instructions and the Tests.
Separate text to different lines for better readability.

* Improving "Link to External Pages with Anchor Elements" Arabic Translation.

* Matching characters and entities to the English version.
2019-05-06 15:59:19 -07:00
Allister Bernal 91a5e8dfed Remove quotes around codetags curriculum/challenges/arabic (#35843) 2019-05-06 15:51:49 -07:00
Víctor Lasa 914e7a4fe4 Fix typos, consistent styling w/ English version (#31238)
Also made the whole text have the same level of formality and corrected Google translations.
2019-05-06 14:56:23 -07:00
Allister Bernal 6481ddd435 Delete quotes around codetags spanish curriculum (#35772) 2019-05-06 14:52:25 -07:00
Niraj Nandish 8bf15ba060 fix(challenges): Fix broken links in Spanish challenges (#35129) 2019-05-06 14:38:31 -07:00
The Coding Aviator b1206f0b53 fix(curriculum): Hide solution from tests in Chinese challenge (#35252)
* fix(curriculum): Remove solution from tests

* fix(curriculum): Hide solution from tests
2019-05-06 14:25:47 -07:00
Niraj Nandish 02eff252b5 fix(challenges): Fix broken links in Chinese challenges (#35126) 2019-05-06 14:23:48 -07:00
Yige 80338ee9f7 Some keywords should not be translated. (#32544) 2019-05-06 14:22:41 -07:00
Ziyao Zhang 304262a90f Improve Chinese translation in euler-problem-2 (#29927)
*  Improve Chinese translation in euler-problem-2

* Minor translation fix

* Minor translation fix 2
2019-05-06 14:19:25 -07:00
Cleo Aguiar d259580de4 Fix subtitle translation (#34433)
* Fix subtitle translation

- add solution

* Apply suggestions from code review

Co-Authored-By: CleoAguiar <cleotaisas@gmail.com>

* fix: added full solution
2019-05-06 13:55:25 -07:00
Hélio Guilherme 9add16b0a7 Improves Portuguese translation for challenge avoid-colorblindness-issues-by-using-sufficient-contrast.portuguese.md (#28255) 2019-05-06 13:54:53 -07:00
Cleo Aguiar 38fa8b71a1 Add solution required (#35369) 2019-05-06 13:53:44 -07:00
Paulo Henrique Junior f91a7dfbf3 Small adjustment in the translation (#32194)
Small adjustment in the translation
2019-05-06 13:53:18 -07:00
Hélio Guilherme 3ae9d14e17 Improves Portuguese translation for challenge add-a-text-alternative-to-images-for-visually-impaired-accessibility.portuguese.md (#27455) 2019-05-06 13:17:51 -07:00
Rafael Monteiro 15396b28c2 Improve check-for-all-or-none.portuguese.md translation (#24123)
Improve translation of `curriculum/challenges/portuguese/02-javascript-algorithms-and-data-structures/regular-expressions/check-for-all-or-none.portuguese.md` and fix wrong Javascript replacements.
2019-05-06 13:17:28 -07:00
kieffwong 2bf9b28224 change the wordking from '給它` to '采用' , also the words '不正确格式' & '描述' (#28245)
improve the translation wording
2019-05-06 13:17:02 -07:00
kieffwong 1208fa17f3 change the wordking from '給它` to '采用' (#28239)
'給它` is like google translate,
采用 sounds smoother.
2019-05-06 13:15:32 -07:00
Jeff Lung YK f40e101eab Update give-links-meaning-by-using-descriptive-link-text.chinese.md (#24043)
As I am a Chinese, I want to improve the smoothness of the presentation.
2019-05-06 13:12:45 -07:00
Peres Badial 5127506001 Update find-characters-with-lazy-matching.portuguese.md (#28001)
A few suggestions to improve readability.
2019-05-06 13:12:16 -07:00
Yige f2c8591931 Fix Chinese character error. (#32564)
* Fixed some translation errors.

* Fixed some translation errors.

* Fixed some translation errors.

These errors will cause the code to be unable to run.

* Fix Chinese character error
2019-05-06 13:08:55 -07:00
Yige dfcd44eb09 Fix translation error. (#32559)
* Fixed some translation errors.

* Fixed some translation errors.

* Fixed some translation errors.

These errors will cause the code to be unable to run.

* Fixed some translation errors.

These errors will cause the code to be unable to run.
2019-05-06 13:06:55 -07:00
Hélio Guilherme db3c83cf3e Improves Portuguese translation for challenge avoid-colorblindness-issues-by-carefully-choosing-colors-that-convey-information.portuguese.md (#27473) 2019-05-06 13:04:26 -07:00
Hélio Guilherme d7b2cace7f Improves Portuguese translation for challenge add-an-accessible-date-picker.portuguese.md (#27433) 2019-05-06 13:01:09 -07:00
Sofia Silva cec85339e1 minor portuguese translation fixes (#23641)
* minor portuguese translation fixes

* fix: removed extra lines
2019-05-06 12:43:27 -07:00
helen414 74057447ac Remove extra word and translation (#26310)
remove extra Chinese  word '的' in front of console.log.  Also, there's no need to translate code into Chinese.
2019-05-06 12:35:43 -07:00
Igor Hideki Trindade 04062a9889 Update translation of titles (#26056) 2019-05-06 12:33:53 -07:00
Giulia 630c98f297 Update Portuguese translation for add-alt-text-to-an-image-for-accessibility (#22739) 2019-05-06 12:31:14 -07:00
Otávio Carvalho e9fae2dc10 Fix translation problems that difficult reading (#25390) 2019-05-06 12:30:24 -07:00
rsgs e5be5b9fe6 Made changes to the Text (#24311)
Made changes to the text in order to be accurate with Portuguese language and not Brazilian Portuguese
2019-05-06 12:27:32 -07:00
Jeff Lung YK ad85742a45 Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.chinese.md (#23914)
As I am a Chinese so I just improve the smoothness of the readability of the content.
2019-05-06 12:20:50 -07:00