* fix(curriculum): grid area template lesson
* fix: remove next step mention and fix hint
* fix: rework to make solution line up with seed of next lesson
* Update curriculum/challenges/english/01-responsive-web-design/css-grid/divide-the-grid-into-an-area-template.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* Update curriculum/challenges/english/01-responsive-web-design/css-grid/divide-the-grid-into-an-area-template.md
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* repair of a small logical underdevelopment
a> b is false if a == b
* Apply suggestions (fix small typo )
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
* fix: added additional matrix1 test case for different arguments to fix hard code issue #43050
* fix: reduced additional test case to only 1 with zeroArray(4,3) and added to all languages
* Revert "fix: reduced additional test case to only 1 with zeroArray(4,3) and added to all languages"
This reverts commit bbbb1c7cbc.
* fix: only simplify and reduce to 1 test case using zeroArray(4,3), reverted internationalization
* fix: removed unused matrix1 from seed and solution
* update: for better wording of the added test case suggested
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
* fix: remove circular dependency
redux depended on templates/Challenges/redux and vice versa. This
meant that import order mattered and confusing bugs could arise.
(cherry picked from commit 7d67a4e70922bbb3051f2f9982dcc69e240d43dc)
* feat: require imports to be in alphabetical order
Import order generally does not matter, but there are edge cases
(circular imports and css imports, for example) where changing order
changes behaviour
(cherry picked from commit b8d1393a91ec6e068caf8e8498a5c95df68c2b2c)
* chore: order imports
* fix: lift up challenge description + title comps
This brings the classic Show closer to the others as they
now all create the description and title components
* fix: remove donation-saga/index circular import
(cherry picked from commit 51a44ca668a700786d2744feffeae4fdba5fd207)
* refactor: extract action-types from settings
(cherry picked from commit 25e26124d691c84a0d0827d41dafb761c686fadd)
* fix: lint errors
* feat: prevent useless renames
* fix: general bugs
- Ensure editable region at end of code-block is followed by a blank
line.
- Remove apparent duplicate step.
- Address spelling issues.
* feat: some tests
* feat: tests 6-20
Add tests for steps 6-20.
* feat: tests 21-30
Add tests for steps 21 through 30.
* feat: tests 31-40
Add tests for steps 31 through 40.
* feat: tests 41-50
Add tests for steps 41 through 50.
* feat: tests 51-60
Add tests for steps 51 through 60.
* feat: tests 61-70
Add tests for steps 61 through 70.
* feat: tests 71-80
Add tests for steps 71 through 80.
* feat: steps 81-92
Add tests for steps 81 through 92.
* feat: align dashed names
Align the dashed names with the titles and file names.
* fix: apply gikf's suggestions
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
* fix: manual review suggestions
Apply gikf's other suggestions.
* feat: more thorough testing
When a test asserts that a camper adds a new element relative to
an existing element, also test that the existing element is not
malformed.
* feat: optional semi colons
Make EOL semi-colons optional in the CSS. If they're missing and the
CSS doesn't render correctly, other tests will catch that. If they
are on the last property of the ruleset, they technically aren't
required so we shouldn't require them?
* chore: apply review suggestions
Apply review suggestions from gikf
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
* chore: apply suggestions from code review
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
* feat: review suggestions
Apply Ahmad's review suggestions.
* chore: additional suggestions
Manual application of Ahmad's review suggestions.
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
* chore: apply suggestions from code review
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
* chore: apply shaun's review suggestions
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
* feat: add clarification
Add a bit of text clarifying the file switch in the editor.
* chore: replace URLs
Replace the tinyurls with our self-hosted CDN images.
* feat: new CSS tests
Re-write CSS tests with new parser.
* fix: grammar
Apply Shaun's grammar reviews.
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
* fix: optional chaining
* chore: apply suggestions from code review
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* chore: apply reviews manually
* chore: getStyle update
Replace getStyleDeclaration with getStyle.
* fix: resolve test issue
* chore: remove jQuery :(
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* chore: apply suggestions from code review
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
* fiux: Update curriculum/challenges/english/01-responsive-web-design/basic-css-cafe-menu/part-073.md
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
* fix: update regex to account for bracket notation
fix minor bug in regex referring to literal dots with a dot
closes#42877
* account for both single and double quotes
Co-authored-by: awu43 <46470763+awu43@users.noreply.github.com>
* fix: make case sensitive
Co-authored-by: Ilenia <nethleen@gmail.com>
Co-authored-by: awu43 <46470763+awu43@users.noreply.github.com>
Co-authored-by: Ilenia <nethleen@gmail.com>