Commit Graph

1482 Commits (41c6914a254f43faa92139562480e6dac87b51e9)

Author SHA1 Message Date
Laurent Labine 00b37093db
fix(curriculum): replace single-line blocks with multi-line blocks for… (#41525)
* fix(curriculum) replace single-line blocks with multi-line blocks for Front End Libraries #41523

Second attempt

* Update curriculum/challenges/english/03-front-end-libraries/react/use--for-a-more-concise-conditional.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-03-18 23:40:32 +00:00
Sem Bauke b064991667
fix(curriculum): Replace single-line blocks with multi-line blocks for Responsive Web Design (#41519)
* fix(curriculum) replace single-line block with multi-line blocks

* fix(curriculum) replace single-line block with multi-line blocks (missed blocks)
2021-03-18 17:24:09 -06:00
gikf b8ddfc08b3
fix(learn): rework Project Euler 63 (#41425)
* fix: rework challenge to use argument in function

* fix: add solution

* fix: correct function call in seed code

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: improve instructions wording

* fix: correct typo

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-03-16 18:41:47 -05:00
Randell Dawson d2f4b70ea6
fix: remove end of line chars after code blocks (#41498) 2021-03-16 07:49:43 -07:00
Randell Dawson c198d508be
fix(learn): Improve tests for the Nest an Anchor Element within a Paragraph challenge (#41456) 2021-03-12 10:09:22 -07:00
gikf 9669e39b85
fix(learn): make tests and test descriptions more explicit (#41281)
* fix: make tests and descriptions more explicit

* fix: add example to description

* fix: replace pre tags with markdown

* fix: move test data to seed code for convenience

* fix: correct grammar from review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Revert "fix: move test data to seed code for convenience"

This reverts commit 7a9c4723d6.

* fix: small corrections

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-03-12 07:29:03 -08:00
Randell Dawson 33bd4fb2c4
fix(learn): Change Codepen template link (#41440) 2021-03-12 10:41:48 +05:30
pandacoder7 53d372c298
fix: update challenge for crowdin in anchor page (#41450) 2021-03-11 13:35:34 -07:00
Luca 5589c37804
fix(learn): remove wrong spaces and make quotes consistent (#41434)
* Remove spaces that are not meant to be there (L37, L134, L156) Makes quotes consistent (L61)

Remove spaces that are not meant to be there (L37, L134, L156)
Makes quotes consistent (L61)

* Consistent spacing after commas

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-11 07:19:07 -08:00
Kelvin Sánchez 35a8f55515
fix(learn): Remove unnecessary inline code tag in challenge (#41428)
* remove unnecessary inline code tag

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-less-than-or-equal-to-operator.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* improve challenge wording

* improve challenge wording

* keep wording consistency

* keep wording consistency between similar challenges

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-10 10:16:03 -08:00
Sem Bauke 5b760e50a3
fix(curriculum) Improved readability and grammar (#41340)
* fix(curriculum) Improved readability and grammar

* fix missing tags and grammar

* fix(curriculum) changes to grammar

* fix(curriculum) grammar fixes

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-elements-only-visible-to-a-screen-reader-by-using-custom-css.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix(curriculum) Grammar fix

* chore: apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-03-10 09:00:03 -08:00
Caden Parker 6b9aeff09e
fix(learn): Rework Euler Problem 461 (#41333)
* Made instructions more clear + Corrected test cases

* Added highlight for return values

* Adjusted challenge description

* Rework

* Fixed minor linting error

* Address PR Comments

* Adjusted wording in description
2021-03-10 08:14:27 -07:00
Caden Parker d8e6d8dc46
fix(learn): Rework Euler Problem 182 (#41337)
* Rework Euler Problem 182

* Reordered tests

* Fixes for formatting
2021-03-10 15:55:52 +01:00
Caden Parker 256e7f416d
fix(learn): Added more robust logic for the remove test case in Create A Hash Table (#41283)
* Added extra test cases for hashtable.remove

* Minor Change

* Adjusted tests to use user created add function / Modified description

* Made test case description much more clear

* Changed instructions to be more clear

* Minor change to instructions

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 12:45:20 -06:00
Emer Conghaile 18068cdeaa
fix: remove forward slash from <source> tag (#41422)
The forward slash at the end of the <source> tag in the example is removed, as this is more common.
2021-03-09 16:20:22 +00:00
Nicholas Carrigan (he/him) c5bcebc724
fix(learn): revert backslash change (#41382)
* fix(learn): revert backslash change

Crowdin resolved the issue with backslashes escaping backtics in
the markdown parser, so this reverts the workaround we implemented
for that bug.

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/s-expressions.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 10:13:27 -06:00
gikf bd02249a23
fix(learn): rework Rosetta Code Count the Coins (#41282)
* fix: rework challenge to use argument in function

* fix: use better wording

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-09 08:34:10 -06:00
Nicholas Carrigan (he/him) 77730ae209
fix(learn): address translator comments (#41381)
* fix(learn): address translator comments

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/quoting-strings-with-single-quotes.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 08:15:26 -06:00
gikf 93495ef6db
fix(learn): correct tests description (#41280)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 11:48:12 +05:30
Nicholas Carrigan (he/him) 16e420021c
chore: audit data visualisation challenges (#41336)
* chore(learn): audit d3 projects

* chore: audit data vis

* chore: audit json apis

* Update curriculum/challenges/english/04-data-visualization/data-visualization-projects/visualize-data-with-a-scatterplot-graph.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: apply suggestions

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: no colour backticks

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/get-geolocation-data-to-find-a-users-gps-coordinates.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-05 12:25:29 -07:00
Ricardo Passos ae79525493
fix(learn): added a missing period and removed single quotes (#41377)
* Added missing period

On line 24, just before "Note that in your CSS..." a period was missing.

* Removed single quotes and added a missing period

On line 24, just before "Note that in your CSS..." there is a missing period. 
On line 30, the text "red-text" within a code tag is enclosed in single quotes.
2021-03-05 07:16:30 -08:00
Nicholas Carrigan (he/him) 4d8aae1678
fix: backtick formatting (#41371) 2021-03-05 11:39:04 +05:30
gikf 5332628e6d
fix(learn): rework Rosetta Code Hailstone Sequence (#41279)
* fix: rework challenge to use argument in function

* fix: change leftover html to markdown

* Apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* remove leftovers

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-04 13:28:47 -08:00
lusc 8a5711dda7
Fix: remove a colon in rosetta-code/happy-numbers (#41349)
* Fix: remove a colon in rosetta-code/happy-numbers

Removed a colon that shouldn't be there

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/happy-numbers.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add inline code tags around all true and falses

https://github.com/freeCodeCamp/freeCodeCamp/pull/41349#discussion_r586700058

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-04 09:25:55 -07:00
Andrew Cen 65cc800689
fix: add blank lines on empty seeds (#41348) 2021-03-03 13:14:28 -08:00
gikf 728f44ab38
fix: clarify case for already placed valid number (#41225) 2021-03-03 23:02:51 +05:30
Nicholas Carrigan (he/him) 7117919d36
chore(learn): audit javascript algorithms and data structures (#41092)
* chore(learn): audit basic algorithm scripting

* chore(learn): audit basic data structures

* chore(learn): audit basic javascript

* chore(learn): audit debugging

* chore(learn): audit es6

* chore(learn): audit functional programming

* chore(learn): audit intermidate algorithms

* chore(learn): audit js projects

* chore(learn): audit object oriented programming

* chore(learn): audit regex

* fix(learn): remove stray .

* fix(learn): string to code

* fix(learn): missed some

* fix(learn): clarify strings

Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.

* fix: apply suggestions - thanks Randy! :)

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: non-suggestion comments

* chore(learn): remove comments from codes

Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: revert crowdin fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* chore: change voice

* fix: Christopher Nolan

* fix: expressions would evaluate

* fix: will -> would

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: to work to push

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-02 17:12:12 -07:00
Randell Dawson 57f3c80345
fix(learn): Clarify date format expectations for the Date Format challenge (#41327)
* fix: clarify date format expectations

* chore: apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-02 15:46:30 -08:00
Sem Bauke f328bdb93e
fix(curriculum) fixes for grammar and missing articles (#41335)
* fix(curriculum) fixes for grammar and missing articles

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/add-gaps-faster-with-grid-gap.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-02 12:27:45 -07:00
Ilenia 051a010798
fix(learn): disallow www link from challenge (#41275)
This commit disallows www link from "Nest an anchor in a paragraph" challenge.
2021-02-27 02:47:47 +05:30
Nicholas Carrigan (he/him) 31bdea63a2
chore(learn): audit front end libraries (#41179)
* chore(learn): audit bootstrap

* chore(learn): audit FE projects

* chore(learn): audit jQuery

* chore(learn): audit React

* chore(learn): audit react-redux

* chore(learn): audit redux

* chore(learn): audit sass

* fix: apply review suggestions

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: apply non-suggestions

* chore: remove comments from code

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-25 10:19:24 -07:00
Randell Dawson 33356e403a
fix(learn): Use backticks around back slash character (#41254) 2021-02-25 16:34:40 +05:30
Oliver Eyton-Williams 4917e59aaa
fix(curriculum): use user's url in url shortner tests (#41257)
This service is both guaranteed to be up (they're hosting it) and should
allow CORS for all requests (including the tests).
2021-02-25 12:04:09 +01:00
Randell Dawson b11dd87047
fix: remove sentence not needed (#41235) 2021-02-23 11:21:58 -06:00
Randell Dawson f4bbe3f34c
fix(learn): Updated code blocks to help with translation on two challenges (#41217) 2021-02-22 11:21:59 +05:30
Alexander Heß b12360d4a8
Removed the hint Fixes #41192 (#41215)
* Removed the hint Fixes #41192

* Removed the blank line as suggested
2021-02-21 13:36:14 -07:00
Ilenia aa615763af
fixed tests for link to external pages challenge (#41191)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-21 11:46:00 +05:30
gikf 531c3f9997
feat(learn): add project tests (#41183) 2021-02-21 10:37:02 +05:30
gikf 219339b2ce
fix(learn): rework Project Euler - Problem 58 (#41188) 2021-02-20 12:06:32 +05:30
gikf f5a905b7c2
fix(learn): unmangle challenge description (#41182) 2021-02-20 12:04:38 +05:30
gikf 70c4d82068
fix(learn): correct test result (#41068) 2021-02-20 12:04:12 +05:30
gikf c8db838754
fix: correct function call in test description (#40949) 2021-02-20 12:03:54 +05:30
gikf a91444d3d4
fix: correct function call in test description (#40944) 2021-02-20 12:03:33 +05:30
Kelvin Sánchez f08174b5b1
fix(learn): Remove unnecessary inline code tag in challenge (#41177)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-19 09:44:50 +05:30
Kelvin Sánchez fad168b465
fix(learn): fix some code tags, capitalization and punctuation in challenge (#41161)
* fix some code tags, capitalization and punctuation

Note: The reserved word in JavaScript is "boolean", so I think it is appropriate to use it like this inside the code tags.

* Remove code tags and capitalize first letter

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* capitalize letter and replace slash

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:45:12 -07:00
Kelvin Sánchez 2c1280af65
fix(learn): Improve the clarity on a challenge sentence (#41154)
* Improve the clarity on a challenge sentence

* add string type and remove double quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:29:31 -07:00
gikf 762775889e
fix: rework Project Euler - Problem 57 (#40926)
* fix: rework challenge to use argument in function

* fix: add solution

* fix: correct variable name
2021-02-17 11:58:18 -08:00
Kelvin Sánchez 1fe1371b16
add missing inline-code block (#41153) 2021-02-17 11:24:53 -08:00
Joshua Pelealu 10aee18748
Remove broken twitter links (#41152) 2021-02-17 12:03:57 -07:00
Kelvin Sánchez b45406ec9d
fix(learn): Remove repeated definition tag in challenge (#41151) 2021-02-17 23:01:42 +05:30
Joshua Pelealu c15c27f474
fix(learn): Added another test to check for invalid characters (#41144) 2021-02-17 21:16:07 +05:30
fots 2a2657d36c
fix: update regex for Convert JSON Data to HTML (#41134)
* fix: updated solution for Convert JSON Data to HTML

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-02-16 16:27:47 +00:00
Nicholas Carrigan (he/him) 21c7abf584
fix(learn): update challenge for crowdin (#41089) 2021-02-16 19:47:40 +05:30
Supritha ee6764519d
REMOVED comments (#41048)
* Added comments

Fixes freeCodeCamp/freeCodeCamp#40903

* remove comments
2021-02-11 09:13:38 -07:00
Kristofer Koishigawa c9de726d6a
feat: move Repl.it links to first challenge in backend projects (#40803) 2021-02-11 14:09:59 +05:30
gikf 6ae3735979
fix: correct tests descriptions (#40945) 2021-02-10 17:12:12 +05:30
ehsabd 9f219f3f2b
fix(learn): Fix the public assets folder confusion by giving it its own folder (#40802)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-10 17:11:40 +05:30
Kim Leung 082b269dce
fix(learn): backslashes in description & hint text (#40801)
Correct example code in description and last hints text to match the last assertion test's actual and expected inputs.  The string input with a single backslash throws an unterminated string constant error (single backslash starts a regex).  No change to last assertion test as it was written correctly with a double backslash and passing as expected.
2021-02-10 17:10:51 +05:30
Lucas Sorenson f8aa6c04e2
fix(learn): update seed code for D3.js challenge (#40699)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Lucas Sorenson <lsorenson@sunsh1n3.com>
2021-02-10 17:06:19 +05:30
Ismail Tlemçani 0f8449788c
feat(learn): add tests to use a callback function in the sort method (#40847) 2021-02-10 17:05:23 +05:30
Tom 959fe8323a
fix(learn): mongoose set up instructions (#40909)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-10 17:04:16 +05:30
Tom 51f6077f7b
fix(learn): regex-criminal-in-hunt-challenge (#40901)
* fix: regex-criminal-in-hunt-challenge

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/find-one-or-more-criminals-in-a-hunt.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-08 06:10:59 -08:00
Jean-Baptiste LARRIVIERE 1c539d07c3
fix(curriculum): remove mention of null from challenge (#40942)
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-02-08 13:17:32 +05:30
Tom 15227a0148
fix(curriculum): helmet install and csp lessons (#40904) 2021-02-06 16:36:40 +00:00
Randell Dawson 167f93df76
fix(learn): Add inline code blocks to for i18n (#40921) 2021-02-05 14:16:19 +05:30
Shaun Hamilton 1a9b791f29
update(curriculum): explicitise use-the-env-file (#40898)
* update(curriculum): explicitise use-the-env-file

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-04 19:43:18 +01:00
Nicholas Carrigan (he/him) 12658d33fc
fix(i18n, learn): more crowdin fixes (#40905) 2021-02-04 13:34:44 +05:30
Tom 30c923b73d
fix(curriculum): helmet hide-powered-by description (#40900)
* fix: remove option that isn't usable in new version of helmet

* fix: make text instructional
2021-02-03 23:13:02 +00:00
Keith c21b2a9707
fix(learn): corrected typo (#40902)
Fixed typo at the end of the 4th paragraph. Changed "Others options include:" to "Other options include:".
2021-02-03 15:11:44 -08:00
Guilherme Dias Simões ddf495c335
Fix 'wrap' and 'wrap-reverse' definitions. (#40766)
The definitions for the options 'wrap' and 'wrap-reverse' were slightly wrong as can be seen by applying them to the challenge.
2021-02-03 13:01:43 -06:00
gikf 313b345611
fix: correct Rosetta Code Knight's tour solution (#40830)
* fix: correct answers in tests and descriptions

* fix: replace sample solution for correct one

* fix: missing space

* fix: improve sample solution performance
2021-02-03 12:43:29 -06:00
Nicholas Carrigan (he/him) b0bd3f5549
fix(learn): abstract comments from code (#40869) 2021-02-03 22:28:33 +05:30
Nicholas Carrigan (he/him) 4d48fb5ce7
fix(learn, i18n): crowdin issues (#40884)
Resolves a couple of issues with Crowdin parsing.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2021-02-02 14:08:32 -07:00
Oliver Eyton-Williams 66b684807c chore: migrate certs from .markdown to .yml 2021-02-02 09:51:02 +05:30
Nicholas Carrigan (he/him) 427444c757
chore(learn): audit files for crowdin (#40838)
* chore(learn): audit files for crowdin

Audits the challenge text in the Responsive Web Design superblock to
account for words/phrases that should not be translated because they
refer to code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove quotes from code

Removes instances of quoted code blocks, or code blocked quotes.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: additional uncaught quote-codes

Thanks Oliver :)

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: so many quotes

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: missing punctuation

Noted in a Crowdin comment.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove more quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-01 12:56:07 -07:00
Luis H. Ball Jr 8d60aad97b
feat(curriculum): add extension tests for css-flexbox curriculum modules (#40473)
* feat(curriculum): add extension tests for css-flexbox curriculum modules

* apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* fix: reorder tests

Moves the test that asserts the presence of the follow button to the
top of the order.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-01 07:57:36 -08:00
Kim Leung a37d5f5817
fix(learn): add output type verbiage (#40589)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-01 19:41:15 +05:30
Nicholas Carrigan (he/him) 18e821bcd3
fix: remove clunky sentence (#40751) 2021-02-01 19:22:39 +05:30
Hernando Guzmán f63ca27e6a
Fix: corrected the typo (#40837)
Updated run-functional-tests-using-a-headless-browser.md to correct the typo
2021-02-01 06:52:11 -07:00
Randell Dawson 22f017caa2
fix(learn): replace single bactick with <code> tag for Crowdin (#40774) 2021-02-01 19:09:13 +05:30
Kai-Chin Huang 5503b54f85
fix(learn): update the return Object.values & solution (#40451) 2021-02-01 13:12:54 +05:30
Evan Boehs 8c22432b17
fix(learn): add period for readability (#40836) 2021-01-31 13:57:46 +05:30
Hernando Guzmán 3394a654bd
fix(learn): Correct syntax in the code example (#40811)
Closes #40810
2021-01-27 11:03:22 -08:00
gikf d41630ee19
fix(learn): clarify test description for Use Rest Parameter with Function Parameter (#40725)
* fix: clarify test description

* fix: improve wording regarding rest parameters syntax

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: improve with better sounding wording

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-24 08:30:13 -08:00
Mainak Debnath d5ad87d915
fix(learn): put test cases under --seed-- and remove them from the solution (#40755)
* fix: put test cases under --seed--

* fix: put test cases under --seed--
2021-01-21 18:26:06 -08:00
Shaun Hamilton ce3a20e552
fix(learn): change requirements for positive and negative lookaheads (#40570) 2021-01-21 15:35:19 -06:00
Lasse Jørgensen f2b1d7b147
fix(challenge): Assert arrays contain expected values (#40693) 2021-01-21 10:52:52 -08:00
Ilenia a38922536c
Adding language to code fences and pre to console logs (#40603)
* added languages to prismjs

* added language to code fences for python for everybody

* multiline pre to python for everybody questions

* multiline pre for data analysis with python

* multiline pre in numpy questions

* single line pre for python for everybody

* single line pre for data analysis with python

* single line pre for numpy

* Revert "multiline pre in numpy questions"

This reverts commit af1a02cdd3.

* fix unneded escaping

commit suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Revert "single line pre for numpy"

This reverts commit 5f90981108.

* revert changes to snippet that have a language

* one last code fence to pre

* Revert "fix unneded escaping
"

This reverts commit 64c84a9213.

* Revert "single line pre for data analysis with python"

This reverts commit 3bccaff753.

* Revert "single line pre for python for everybody"

This reverts commit 03a5379062.

* remove unnecessary escape

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-21 12:12:42 -06:00
Nicholas Carrigan (he/him) 8e62a243bb
fix(learn): Update demo links (#40575)
* fix(learn): Replace demo projects

Replaces the Heroku demo project links with the
.rocks demo projects that @moT01 provided.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(learn): Use correct endpoint

Corrects the API endpoint for the image search
project.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: user stories to align with project + backticks

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2021-01-21 11:09:35 -06:00
Durbatuluk1701 0a7aa59d51
fix(learn): Convert response testcase regex handles any variable name (#40568)
* Update convert response to JSON testcase

Testcase previously required that variable be named exactly "response". Changes will allow variable of any name to be used.
Example: res can now be used and tests still pass.

* Forgot the \ in front of )
2021-01-21 08:54:24 -08:00
matias-miller 8a9f3319c6
fix(learn): Fixed typos in count-backwards-with-a-for-loop.md (#40478)
* Spelling change in count-backwards-with-a-for-loop

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 08:44:10 -08:00
Mukesh Gurpude a5dceb3e7e
Fixed error when changing the default order of css properties (#40525)
* Bug with psoitioning

Fixed bug with positioning of background-color` property for Selector `.heart::after`

* Trying new changes

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/create-a-more-complex-shape-using-css-and-html.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Tests passing

Check the regex matching at [Regex101](https://regex101.com/r/GU18ds/4)

* fixed typo

* applied suggestions

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-21 10:17:16 -06:00
Nicholas Carrigan (he/him) 062b1cd424
fix: replace h tags (#40750)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 13:41:46 +05:30
Randell Dawson 83e3d93953
fix(learn): Remove strong syntax around code inline code (#40754) 2021-01-21 13:40:19 +05:30
Kim Leung e57f32438c
fix(learn): correct LCG equation in description (#40615)
* fix(learn): correct LCG equation in description

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/linear-congruential-generator.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/chinese/10-coding-interview-prep/rosetta-code/linear-congruential-generator.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Revert LCG equation in Chinese file

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-20 22:05:37 -08:00
Alex Soto ef394093f7
fix(learn): removing unnecessary test case for regex challenge (#40581)
Co-authored-by: Alejandro Soto <alejandro.soto@wundermanthompson.com>
2021-01-20 21:53:04 -08:00
Randell Dawson dd4c7e0097
fix(learn): Update text as code for vector-dot-product (#40460)
* fix: implemented suggestted changes

* fix: correct last test expected return value

* fix: remove slash

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: remove slash

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: add test to return null if more than 2 vectors

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: added correct solution

* fix: removed extra brackets

Co-authored-by: Yuval Levental <yhl3051@rit.edu>

Co-authored-by: Lakshya Baghel <lakshyab.1999@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Yuval Levental <yhl3051@rit.edu>
2021-01-20 21:23:10 -08:00
Ian Turner fb2e5d81f3
Add line breaks to instructions (#40425) (#40428)
* feat: add line breaks to instructions  (#40425)

* feat: add punctuation to instructions (#40425)
2021-01-20 22:19:21 -07:00
Brandon Dusch 570d9ad906
fix: updated JSON string in snippet for Python Web Services (#40742) 2021-01-20 22:09:16 -07:00
Sergey Musiyenko 0b01b73e1f
fix: a typo - TSL certificate ===> TLS certificate (#40697)
* Fixed a typo

* fix: a typo - TSL certificate ===> TLS certificate

* revert: non-English translations have to adhere to a new policy
2021-01-20 22:08:47 -07:00
Jason Liao 0b812c91e3
update task description (#40586) 2021-01-20 22:06:51 -07:00
Durbatuluk1701 b62cf73116
Correcting type on word error (#40578)
Bug Fix for #40533
2021-01-20 22:05:42 -07:00
Niraj Nair a8230fda57
Added Change this line comment (#40497) 2021-01-20 22:03:24 -07:00
Jagadeesh G 3061a5a0eb
Text in Basic Data Structures lesson is better clarified. (#40492)
* text_changes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-items-using-splice.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Jagadeesh G <17941713+GJ-16@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-20 22:02:37 -07:00
Yaseen Sayyed 3bdf143fd8
Changed the question to one with no ambiguity (#40488)
* Changed the question to one with no ambiguity

* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/jupyter-notebooks-cells.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/jupyter-notebooks-cells.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/jupyter-notebooks-cells.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-20 22:00:18 -07:00
Nicholas Carrigan (he/him) 891a64fa3d
fix(learn): Remove arrows from test name assertion (#40467)
* fix: Remove arrows from test name assertion

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Add note about time span

Adds a note regarding the expectation of the `span` element to wrap the
entire time string when translated, not just the delimiter symbol.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: use correct note syntax

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: remove note syntax

New line was breaking the build, so changing the `note` comment to be
regular text.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-20 21:57:32 -07:00
Nicholas Carrigan (he/him) b07394603b
feat(learn): Move metric imperial converter tests (#40358)
* Move tests to /learn

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Modify test verbiage

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/metric-imperial-converter.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/metric-imperial-converter.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: add missing tests

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Correct inaccurate test text - thx @ShaunSHamilton

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove arrow from test name

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-20 21:51:57 -07:00
Ismail Tlemçani d6e47037de
fix(learn): tests of the for in issue regarding the curly braces (#40344)
* fix: fix the regex of the test of the challenge

* fix: fix data structure challenge

* fix: fix data structure challenge

* fix:fix the test regex of the challenge

* fix: fix the test regex
2021-01-20 21:50:44 -07:00
Martin Milani 8e96fef862
fix(learn): Updated instructions for challenge solution for Reuse Patterns Using Capture Groups (#40658)
* Grammatically updated the instructions for the challenge

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/reuse-patterns-using-capture-groups.md

Co-authored-by: Eric Leung <eric@erictleung.com>

Co-authored-by: Eric Leung <eric@erictleung.com>
2021-01-20 19:39:23 -08:00
Nicholas Carrigan (he/him) 8d8d25e9f2
fix(learn): address escaped backticks (#40717)
* fix(learn): address escaped backticks

Addresses the instances of escaped backticks - where a backtick is
preceded by a backslash.  In most cases, this was left over from the
old parser. In some cases, a backtick was intended to be wrapped in
code tags and has been adjusted accordingly.

This issue came to light due to a bug in the translation flow on
Crowdin.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: EVEN MORE :( :( :(

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: backslash nightmares

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: When you wish upon a *******

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(curriculum): md error introduced by formatter

* fix(curriculum): remove extra `s

* fix: restore quote symbol

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Typo

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: apply review changes

Applying review feedback from call with @RandellDawson.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: markdown does weird stuff sometimes

Can't stick backticks together - use code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-01-20 19:01:00 -07:00
Sergey Rufanov 5379b04387
fix(learn): Removed note about commented array from sorting algorithm challenges (#40652) 2021-01-16 12:00:10 -08:00
Vicky Zhang 594b63bc35
fix(learn): Clarify sudoku solver instructions (#40604)
* Clarify sudoku solver instructions

* decrease spaces
2021-01-16 11:58:48 -08:00
Mathieu HAAGE 1f62718f52
fix(docs): Add empty line after HTTP request headers (#40654) 2021-01-16 12:58:21 -07:00
Jeremy L Thompson a5840f57a4
Update Description of Stern-Brocot Challenge (#40686)
* fix: update description of target function

* fix: include note about 1 based indexing
2021-01-16 12:57:38 -07:00
Nicholas Carrigan (he/him) bab54ad619
fix(learn): no capital code block (#40688)
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-16 12:54:38 -07:00
majkelmichel 3ecdfe87d7
Update create-a-form-element.md (#40720)
Improved wording in Description and Instructions sections
2021-01-16 12:25:13 -07:00
Thomas fc976aba74
fix(learn): Change example text in create-a-form-element.md (#40542)
* Update create-a-form-element.md

Update example. For issue 40523

* Clearer formatting of example
2021-01-16 01:11:47 -08:00
Oliver Eyton-Williams ee1e8abd87
feat(curriculum): restore seed + solution to Chinese (#40683)
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-12 19:31:00 -07:00
Steven Ding ab222e31e7
an audit for some changes (#40680) 2021-01-12 09:31:18 -07:00
miyaliu666 9770cd0f81
translated some Chinese curriculum files (#40531)
* translate task #1 - #4

* add translation of zhang-suen-thinning and markov algorithm

Co-authored-by: S1ngS1ng <liuxing0514@gmail.com>
2021-01-08 11:59:18 -07:00
Ilenia 7de8549e02
fix(learn): Made the Escaping literal quotes channel accept the dot inside the double quotes too (#40465)
* made valid solution dot inside and dot outside quotes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escaping-literal-quotes-in-strings.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-12-16 08:07:47 -08:00
Lakshya Baghel 036da8cd0c
Fixed seed-contents for react componentDidMount challenge (#40441) 2020-12-15 18:19:58 -07:00
Nicholas Carrigan (he/him) 582d3ab93f
fix(learn): Headless Browser Tests have incorrect values (#40330)
* Restructure files

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Realign forum topic ids

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Missed query string numbers

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Test all previous tests

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Fix the semi-colon

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* change test name to match boilerplate change

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-12-15 19:17:25 -06:00
Kai-Chin Huang a1928ba272
Update the return value of values method in create a set class challenge (#40450)
* fix #40443

* Fix the solution add method
2020-12-15 18:15:33 -07:00
vbinithyanandamv 7c19c82076
[BUG] Able to pass challenge "Basic JavaScript: Initializing Variables with the Assignment Operator" with incorrect answers #40406 (#40409)
* [BUG] #40406 Fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/initializing-variables-with-the-assignment-operator.md

Requested Change.

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-12-15 18:07:36 -07:00
Oliver Eyton-Williams 0bd52f8bd1
Feat: add new Markdown parser (#39800)
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
ngschaider 6c5304980d
fix(learn): type checking and additional test for isBalanced binary search tree (#40323)
* Update find-the-minimum-and-maximum-height-of-a-binary-search-tree.md

* fixed binary search tree values for balanced tree test

* Apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-26 22:33:45 -06:00
Jennifer Garst 4079a197fe
fix(learn): clarify gradient description (#40322)
* fix: clarify gradient description

* Apply suggested changes

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-26 22:33:03 -06:00
Shaun Hamilton 493880ffaf
feat(learn): add mocha and chai instructions (#39976)
* feat(learn): add mocha and chai instructions

* test: added one new lesson

* rename added file and add tests

* add meta to prettierignore, fix formatting

* add unit-test numbering

* add examples from boilerplate

Co-authored-by: Randell Dawson <rdawson@onepathtech.com>

* remove code comments, add description

* elaborate test testStrings

Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
2020-11-26 10:05:42 -08:00
Ilenia f294d9cacc
fix(learn): removed use strict from various challenges (#40321) 2020-11-25 15:59:04 -08:00
Timo Köhler 7ce8c58709
Put value into quotes (#40172)
* Put value into quotes

It can be missunderstanding that "value" is a string!

* fix: remove quotes from inside code tags

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-25 16:32:14 -06:00
Nicholas Carrigan (he/him) 49f6875db5
fix(learn): ES6 Getters + Setters tests (#40238)
* Strengthen tests

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Improve verbiage

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Add second check to setter test

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-11-25 14:22:44 -08:00
Nicholas Carrigan (he/him) ec8b2dc016
feat(learn): Message Board User Stories (#40219)
* Update verbiage, add instructions

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Remove unit test mention

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Move test descriptions to learn

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* target blank on gh link

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-11-25 14:11:38 -08:00
Nicholas Carrigan (he/him) 49f2055b98
Move tests to /learn (#40263)
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-25 13:27:22 -08:00
Nicholas Carrigan (he/him) 62713f0e10
feat(learn): Move American British Translator tests (#40265)
* Move tests to /learn

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Replace quotes with code

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-11-25 12:10:52 -08:00
Nicholas Carrigan (he/him) c0b9ad6bf2
Move tests to /learn (#40264)
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-11-25 12:06:42 -08:00
Nicholas Carrigan (he/him) b5d5ec5a90
feat(learn): Stock Price Checker user stories (#40218)
* Adjust user stories, add instructions

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Apply review suggestion

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Move tests to /learn

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-11-25 11:55:03 -06:00
Lasse Jørgensen df44da9dc2
fix(challenge): correct terminology and inform of correct array copying (#40045)
* fix(challenge): correct terminology and inform of correct array copying

* fix(challenge): update text with proposed changes
2020-11-25 08:14:33 -08:00
Tom 0b117274d7
fix(learn): enhance exercise tracker user stories (#39965)
* fix(learn): enhance exercise tracker user stories

* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: remove duplication mention of count

* fix: add more tests for user story

* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/exercise-tracker.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: change single quotes to double quotes

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-25 09:25:01 +00:00
Rex Schrader 79e3cb51e5
feat(learn): add/remove tests for Imperial-Metric Converter (#39615)
* Remove Infosoc Tests, Add tests, fix error reporting

* Add capital 'L' for liter requirement, check unit/funct test counts

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-11-24 20:19:49 +00:00
Kristofer Koishigawa 5a41edca1a
fix(learn): issue tracker test text error message (#40301) 2020-11-24 12:56:41 -06:00
Randell Dawson b47487b8b2
fix(learn): Change Node project descriptions to all use same template (#40266)
* fix/change-node-project-descriptions-to-all-use-same-template

* fix: use correct boilerplate

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* fix: add url to link text

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* fix: add _blank for target attribute

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* fix: add missing single quote

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* fix: remove extra lines

* fix: improved wording of description

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* fix: move sentence to previous paragraph

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* fix: move sentence to previous paragraph

* fix: move sentence to previous paragraph

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-11-20 12:02:31 -08:00
Farhan Ullah 9ba94e38b4
fix(learn): `isSorted` returning true on empty arrays which passes the test (#40192)
* bug-fix: isSorted returning true on empty arrays

* sorted order test improvements
2020-11-20 09:51:59 -08:00
Shaun Hamilton bce3d5b372
fix(learn): remove white space for quick fix (#40231)
* fix(learn): remove white space for quick fix

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-20 09:21:21 +01:00
Yasamin Yaldaei 72b8629ecc
fix(learn): personal library boilerplate links destination (#40267) 2020-11-19 14:51:59 -08:00
Randell Dawson 2c9a900353
fix: added more values to list to improve tests (#40256) 2020-11-18 09:38:26 +00:00
lucia montero c03beb3ca6
Fix tests to allow spaces in "Sass: Create Reusable CSS with Mixins" (#40230)
* Fix tests to allow spaces. Closes #40212

* Apply suggestions from code review

Remove redundant whitespace from regex

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-11-15 00:14:47 +01:00
Amy Surrett 1ef49d2c57
fix(learn): add note about tweet button restrictions (#40118)
* fix: add note about tweet button restrictions

* fix: added target blank and top hint
2020-11-14 11:52:48 +00:00
pkarczma 273f1d1aed
fix(learn): typo in an answer to the Numpy question (#40227)
* fix: typo in an answer to the Numpy question

* fix: revert typo in Chinese file
2020-11-13 13:52:13 -06:00
Rex Schrader 5a9680a1a6
feat(learn): Add Tests to Issue Tracker Project, Remove InfoSec Tests (#39627)
* Feature: Add Tests to Issue Tracker Project

* Refactored User Stories

* Apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Modify verbiage for #39721

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-12 19:51:09 -08:00
Rex Schrader bd593667f6
feat(learn): Add tests to Personal Library (#39642)
* Resolve Merge Conflict

* Add Instructions, Reformat Description

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md

* Change links to Markdown style

* Apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Verbiage per #39721

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/personal-library.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-12 16:13:00 -06:00
Tom f353278905
feat: update description and user stories (#40217)
* feat: update description and user stories

* feat: add hint from boilerplate

* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/file-metadata-microservice.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-11 12:32:10 -08:00
Kristofer Koishigawa 135928dc5d
fix(learn): update machine learning project colab links (#40213)
* fix(learn): update machine learning project colab links

Update current machine learning project Colab links to clone Jupyter notebooks from the boilerplate repos rather than the ones in Google Drive.

* fix(learn): update chinese versions of colab links
2020-11-11 08:56:23 -08:00
Tom 5aef8a70c6
Fix(learn): improve timestamp project user stories (#39961)
* fix(learn): enhance timestamp project user stories

* fix(learn): clarify user stories for timestamp project

* fix: update description area

* fix: update verbiage

* fix: broken tests + add a specific example

* fix: add code highlighting
2020-11-10 15:53:57 -08:00
rajapandi_vijayakumar e8b6a9e5dd
fix(learn): add example declaration for clarity (#40207)
Variable declaration is added which is used inside the switch case.
2020-11-09 17:09:21 +00:00
Rex Schrader 8fd00afd9c
feat(learn): Add tests for refactored American/British Translator (#39822)
* feat(learn): Add tests for refactored American/British Translator

* Move to Markdown formatting

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/american-british-translator.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update american-british-translator.md

With contributions from @mot01

* Apply suggestions from code review

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-06 20:23:11 -06:00
Nicholas Carrigan (he/him) 9cfd9ad887
feat: Add tests for Sudoku Solver (#39816)
* Add tests

* Apply Tom's requests

* Verbiage change

* Apply suggestions from code review

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-06 20:03:43 -06:00
Randell Dawson 895e6b8daf
fix(learn): add test to prevent hardcoded pass (#40179) 2020-11-06 17:05:20 +00:00
Tom 7ce85a8f03
fix(learn): update helmet and bcrypt instructions so we can remove them from boilerplates (#39954)
* fix: update helmet and bcrypt lesson instructions

* fix: update instrutions I missed

* Update curriculum/challenges/english/09-information-security/information-security-with-helmetjs/install-and-require-helmet.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/09-information-security/information-security-with-helmetjs/understand-bcrypt-hashes.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-11-04 19:11:36 -08:00
Ty Mick f2236983a2
Strengthen test for reassigning node reference (#40133) 2020-11-04 09:46:18 -08:00
Nicholas Carrigan (he/him) cf35d24311
feat(learn): Add Stock Price Checker tests (#39640)
* Add some tests

* More tests

* remove extraneous declaration

* Remove unneeded test string

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-11-04 09:37:27 -08:00
Shaun Hamilton c058af2caa
feat(learn): add url-shortener instructions (#40162)
* feat(learn): add url-shortener instructions

* capatalise post word

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* remove sentence with external link

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-03 09:06:07 -06:00
Nicholas Carrigan (he/him) d8be4d24a5
feat(learn): Some tests for Anonymous Message Board (#39652)
* Clean up text, partial test completion

* remove extraneous declaration

* Apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Use non-breaking space after colon

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-03 08:26:10 -06:00
Shaun Hamilton e1bae44036
feat(learn): migrate mongodb-mongoose instructions to learn (#39970)
* feat(learn): migrate mongodb-mongoose instructions to learn

* remove extraneous quotation mark

* update with boilerplate change

* grammar changes on instructions

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-11-03 08:22:55 -06:00
Shaun Hamilton d2e1a385e7
fix(learn): add route to timestamp api in tests (#40144) 2020-11-02 12:54:56 +09:00
Marc Antoni 1badd3c3a6
fix(learn): add test case to regex challenge (#40087)
existing test cases can be satisfied by /^[a-z][a-z]+$|^[a-z][a-z]*\d\d+$/i
2020-11-01 13:24:35 +00:00
Atakan fb0812b6d2
fix(learn): added description about a nonallowed method (#40121) 2020-10-31 20:01:03 +01:00
Shai 8ceae38730
fix(learn): modified usage of words from argument to parameter based on the title (#40130) 2020-10-31 19:59:43 +01:00
Steven Walker 2645fae939
fix(learn): updated instructions to be explicit (#40131) 2020-10-31 19:53:30 +01:00
Oliver Eyton-Williams e4a9b2988c
feat: update Ask for help (#40114)
* feat: get helpCategory from frontmatter

* DEBUG: sets all the projects to JavaScript

This is just so the tests pass, it'll need to go.

* fix: updated helpCategoryMap categories

* fix: added Python to helpCategory frontmatter key

Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
2020-10-30 14:10:34 -05:00
Ty Mick 5f956e9a16
Strengthen isBinarySearchTree test (#39982) 2020-10-26 13:30:46 -05:00
Adrian Muntean 0ae1df30c7
fix: add info for problem 54 - project Euler (#40057)
* fix: add info for problem 54 - project Euler

* update text
2020-10-22 11:59:49 -07:00
Akiko Takano 8ec0da2259
fix(learn): update the required package name (#40056) 2020-10-22 19:32:55 +05:30
sreekumar menon dec4b2180f
Scalar addition issue on Element-wise operations (#40013)
* Scalar addition issue on Element-wise operations

* remove chinese from PR

Co-authored-by: Sreekumar Menon <sreekumar@roofstock.com>
2020-10-19 11:29:23 -07:00
steviehailey b503333c64
Rephrase linear gradient explanation (#39990)
* Rephrase linear gradient explanation

Small tweak to explanation to remove ambiguity over horizontal vs vertical

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/create-a-gradual-css-linear-gradient.md

Code review suggestion - mention horizontal and quote the values

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Use code tag for snippets

Was using backtick but updated based on formatting guidelines - https://contribute.freecodecamp.org/#/how-to-work-on-coding-challenges?id=formatting-challenge-text

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-10-19 11:01:03 -07:00
Bobby BuffaloBoy 71659b7c94
fix(learn): Date corrected the example description from Sunday, to Friday, in the date-format Rosetta Code Challenge (English) (#39998) 2020-10-17 23:01:18 +02:00
Ke Cleveland 13e7251ed9
fix(learn): Update findXmasSunday function arguments from (2008,2121) to (1970, 2017) to match expected return. (#39996)
Co-authored-by: keiveland <keivelanddev@gmail.com>
2020-10-17 22:46:03 +02:00
Oliver Eyton-Williams 35c4020f4d
fix(curriculum): test typos (#39984) 2020-10-15 14:49:57 -04:00
Ty Mick f6fcb26a9d
fix(learn): strengthen a test in "Data Structures: Remove Elements from a Linked List" (#39977)
* Add an additional test to LinkedList.remove

* Consolidate tests
2020-10-15 17:14:05 +01:00
Tom 15cf41e7e1
fix(learn): Update basic node express instructions to remove them from boilerplates (#39953)
* fix: adjust instuctions so we can remove them all from the boilerplate

* fix: adjust instuctions so we can remove them all from the boilerplate
2020-10-15 16:01:10 +01:00
Shaun Hamilton cb1c3b2001
feat(learn): migrate instructions from adnode boilerplate (#39791)
* feat(learn): clarify instructions for boilerplate

* add how-to-put-a-profile-together

* add pug as language

* rephrase sentence for clarity

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-10-15 09:37:29 -05:00
Randell Dawson 52f27c1cbf
fix(learn): Remove isHidden from frontmatter for steps 87-94 of Cafe Menu project (#39974)
* fix: remove isHidden from frontmatter

* fix: corrected ERM name

* fix: removed duplicate step (54)
2020-10-15 09:24:25 -05:00
Mykyta Ivanchenko cc464a6e56
fix(learn): Possible semantic error in explanation comment (#39813)
* Possible semantic error

"identical" generally means that both variables are linked to exact same array which is not the case:
``` thisArray !== thatArray ```

Maybe "similar" or other word could be used instead

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/copy-an-array-with-the-spread-operator.md

Made the comment more accurate

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-10-14 19:53:49 -06:00
Tom 3131360318
fix(learn): enhance user stories for header parser project (#39964)
* fix(learn): enhance user stories for header parser project

* Update curriculum/challenges/english/05-apis-and-microservices/apis-and-microservices-projects/request-header-parser-microservice.md

Co-authored-by: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-10-14 18:49:02 -04:00
James Bush 5164b09dab
Update post-data-with-the-javascript-xmlhttprequest-method.md (#39835)
Uses common language to describe API data request. Improves clarity of instruction.
2020-10-14 16:34:13 -06:00
Joseph Mawa e2ae6303d5
fix(learn): Implement map and filter (#39621)
* Added changes to implement-filter-method challenge as requested in reviews by Randall D and moT01

* Added changes requested for in code review
2020-10-14 10:33:43 -06:00
Oliver Eyton-Williams a71150074d
fix(learn): preserve whitespace in the tool panel (#39973) 2020-10-14 21:40:15 +05:30
Abdullah 1d2ff7aef6
Add Tests to the Shortener Microservice Project (#39311)
* fix/add-tests-for-url-shortner-project

* update microservice url shortner test on checking submitted project link

* update microservice url shortner test first test wording

* update microservice url shortner test tests wording

* fix: add suggestions and clarify instructions

* fix: instructions

* fix: add Kris's second suggestion

* fix: change to use timestamp project for requests

* fix: update wording for first test

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Kris Koishigawa <scissorsneedfoodtoo@gmail.com>
2020-10-14 12:28:44 +09:00
Randell Dawson b3cbbe0f3d
fix(learn): Broke several steps down into smaller steps for the Cafe Menu project - v7 (#39778)
* fix: made some verbiage changes to existing steps

* fix: rewrite step 45 instructions

* fix: added two steps between 45 and 46

* fix: miscellaneous edits for steps 21,22, 27

* fix: change step 35 to allow for smaller steps

* fix: update 36-41 seed code

* fix: added new step between 41 and 42

* fix: add new step between 42 and 43

* fix: broke step 33 into 4 new steps

* fix: removed unnecessary step 37

* fix: change wording of step 33 instructions

* fix: corrected ERM syntax

* fix: corrected seed code typos in steps 45 and 46

* fix: corrected typo

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed wording to improve readability

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: changed "Free Code Camp" to "freeCodeCamp"

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo and improved wording

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: correct typos

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: corrected punctuation

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: corrected punctuation

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: corrected punctuation

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: added missing period

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: corrected typo

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: added the missing word "larger"

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: corrected typo

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: change paragraph to `p`

* fix: reorderd steps after step 37 deleted

* fix: added two new steps to fix missing steps problem

* fix: added missing ERMs for step 69

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>
2020-10-13 17:27:40 -05:00
nick-w-nick 10d3126383
fix(learn): correct minor grammar mistake (#39915) 2020-10-13 12:14:49 +01:00
Ollie e22adfcc6b
fix(learn): Update the regex in Adjust the background-color Property (#39907)
* fix: Updated the regex in background-color test

As mentioned by @Skye020 in issue #39823, I have made the semi-colon after the background-colour declaration optional, but only if it is the last declaration in the scope.

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/adjust-the-background-color-property-of-text.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-10-09 11:09:33 -07:00
dhanush1909 a32427c120
fix(learn): make semicolon at end of line optional (#39821) 2020-10-08 21:02:59 +01:00
Randell Dawson 94f0cf0ef8
chore(learn): Remove remaining isHidden keys from frontmatter (English and Chinese challenges) (#39809)
* fix: remove isHidden key from tool template

* fix: removed isHidden key from English challenges

* fix: remove isHidden key from Chinese challenges
2020-10-08 14:18:47 +02:00
Randell Dawson d90f84e968
fix(learn): Change demo urls on various backend projects (#39688)
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-10-05 23:41:27 +05:30
Randell Dawson d94b3010e3
fix(learn): changed question to be different from the video (#39773)
* fix(learn): changed test to be different from the video

the array on the test and it's solution were same as the video explanation, replaced the test with one suggested in #39097

* fix to use np,ones

Co-authored-by: Nitin <67074979+nitnjain@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-10-01 22:08:57 +01:00
Haraman Johal 41d40608a1
fix(learn): reword incorrect line reference (#39742) 2020-10-01 04:26:43 -07:00
Tom d23feadc1f
feat: update replit links to clone from repos (#39724) 2020-09-29 21:37:53 -07:00
Oliver Eyton-Williams 2b9e38a17b
fix: replace .english.md extension with .md 2020-09-29 22:09:04 +02:00
Tom 1f530602ba
fix: nightlife app link (#39727) 2020-09-29 15:55:27 -04:00
Mike Shecket 682b85a423
Copyediting of descriptions for Advanced Node & Express challenges (#39606)
* Copyediting of challenge descriptions

* Copyedited descriptions of Chai challenges

* Update curriculum/challenges/english/06-quality-assurance/advanced-node-and-express/clean-up-your-project-with-modules.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/advanced-node-and-express/create-new-middleware.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/advanced-node-and-express/implement-the-serialization-of-a-passport-user.english.md

* Update curriculum/challenges/english/06-quality-assurance/advanced-node-and-express/create-new-middleware.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/advanced-node-and-express/implementation-of-social-authentication.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/advanced-node-and-express/implementation-of-social-authentication.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/advanced-node-and-express/registration-of-new-users.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-and-testing-with-chai/test-for-truthiness.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-and-testing-with-chai/test-for-truthiness.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/advanced-node-and-express/how-to-use-passport-strategies.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/advanced-node-and-express/implement-the-serialization-of-a-passport-user.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/advanced-node-and-express/implementation-of-social-authentication-ii.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/advanced-node-and-express/clean-up-your-project-with-modules.english.md

Co-authored-by: Manish Giri <manish.giri.me@gmail.com>

* fix: added code tags

Co-authored-by: Manish Giri <manish.giri.me@gmail.com>

* fix: add code tag

* fix: change to code tag

* fix: change to code tags

* fix: added code tags

* fix: capitalize Passport

* fix: added code tags

* fix: added code tags

* fix: added code tags

* fix: added code tags

* fix: added code tags

* fix: added code tags

* fix: added code tags

* fix: added code tags

* fix: added code tags

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-29 09:43:21 -07:00
Jeremy A Gray 0e3c3e2ff7
fix(learn): avoid conflict with spring forward EST to EDT (#39681)
March 8, 2009 is the weekend of spring forward to EDT in the US.  This change moves the example date and test back one day to add twelve hours to a time on March 6, 2009, resulting in a time on March 7, 2009.
2020-09-29 20:47:26 +05:30
Mainak Debnath 362e8254f8
fix(learn): update test to allow negative arguments (#39701)
* Updated the regex in test

* Changed regex

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Updated changes in regex

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-28 16:03:24 +01:00
Walter Palagi 3d7af80047
fix(learn): React propTypes challenge, improve test text (#39682)
* In React propTypes challenge, improve test text

Fixes #39204

* Remove code tags around "number"

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-24 23:11:05 -07:00
Walter Palagi 104a8068e3
fix(learn): in ES6 spread operator challenge test for arr2 length > 0 (#39680)
* fix(learn): in ES6 spread operator challenge test for arr2 length > 0 too

Fixes #39662

* Accept correction

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2020-09-24 16:14:44 -07:00
Menno 9d2e89984c
fix(learn): add notMatch method to instructions (#39655)
update use regular expressions to test a string with the notMatch method
2020-09-24 22:32:55 +01:00
Nicholas Carrigan 6ccd0d21a1
fix(learn): Update test text in Profile Lookup (#39678) 2020-09-25 00:38:40 +05:30
Nicholas Carrigan d33f5f82a7
fix(learn): Consistent Styling in `Set up a Template Engine` (#39657)
* Replace bold with code

* Typo

* Apply suggested verbiage change.

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* remove code tags from render

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-24 07:10:29 -07:00
Nicholas Carrigan f132f5157c
feat(learn): Add test for file metadata project (#39625)
* Add tests

* Switch from local file to CDN

* remove extraneous declaration

* Apply review suggestions
2020-09-23 20:21:09 -07:00
Konstantinos Lamogiannis 82c8d6d3de
fix(curriculum): update db method used in implementation-of-social-authentication-iii (#39651)
* fix: update method used from findAndModify to findOneAndUpdate

Updating the method used at implementation-of-social-authentication-iii, both for english and chinese

* fix: changed text findAndModify to findOneAndUpdate

* fix: removed chinese file

* Update curriculum/challenges/english/06-quality-assurance/advanced-node-and-express/implementation-of-social-authentication-iii.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-23 15:21:26 +00:00
Darren Stoll 2f4d1c2804
fix(learn): correct typo in description (#39653)
Remove hyphen in word 'view engine'
2020-09-23 06:59:23 +00:00
Nicholas Carrigan 3969f651b8
Remove helmet test instructions (#39613) 2020-09-22 14:42:25 -05:00
Sky020 a86b220eb7 chore: remove isRequired from curriculum files 2020-09-21 20:51:46 +05:30
Tom 181713aa10
Fix/remove broken scrimba (#39619)
* fix: remove broken scrimba video link

* fix: revert file structure
2020-09-18 17:38:37 -07:00
Joseph Mawa d8e8da36a0
Fixed tests for JS Basic Algorithms: Slice and Splice challenge as suggested in issue #39560 (#39610) 2020-09-18 11:30:56 -07:00
Joseph Mawa d5000b5d0f
Removed note about promise chaining as suggested in issue #39487 (#39609) 2020-09-18 10:30:37 -05:00
Gaurav Khairnar a338d4b79d
fix(learn): clear instructions for basic JavaScript: Appending Variables to Strings lesson (#39587) 2020-09-17 13:00:58 -05:00
Hassaan Pasha 80438cac3e
feat(client, learn): add helper functions for common validation operations (#38605)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-17 19:38:01 +05:30
Ajeeth thangarasu 8223903aac
Removed 'videoUrl' (#39601) 2020-09-16 19:04:58 -07:00
Ajeeth thangarasu 8db3fc2df4
removed videoUrl (#39600) 2020-09-16 19:01:47 -07:00
Randell Dawson 30c61b808b
fix: consolidate misc comments (#39583) 2020-09-16 13:29:50 -05:00
Randell Dawson 06da30e48a feat(learn): Basic CSS Cafe Menu instructions and hints/tests (v7) (#39407)
* feat: created step instructions for cafe menu

fix: added instructions to steps 1-31

fix: changed steps 29-31

fix: added instructions for steps 32-42

fix: changed prototype class definition

fix: padded file names

fix: added instructions for steps 43-61

fix: add object id to final.md and final prototype to meta.json

fix: correct typos in steps 26 and 27

fix: misc wording changes

fix: added forward slash to closing html tag

fix: added instructions for steps 62-75

feat: added instructions to steps 76-79

fix: added FOOTER comment for steps 68-75

fix: add steps 68a and 68b

fix: add steps 69a and reorder steps

fix: added instructions to the final steps

* fix: remove final.md

* fix: fixed typo of menue to menu

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed wording to improve readability

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed wording to improve readability

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed wording to improve readability

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: combined two lines into same paragraph

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-09-16 11:54:13 +05:30
Randell Dawson 7abf0fde34 fix: correct filenames in d3 dashboard project 2020-09-16 11:54:12 +05:30
Randell Dawson b9c9a95223 chore(learn): Renamed all project-based curriculum project step filenames to use 3-digit format of part-ddd.md (#39463)
* fix: renamed basic html cat photo app steps

* fix: renamed css-variables project steps

* fix: renamed d3-dashboard filenames

* fix: renamed rpg-game filenames

* fix: renamed functional-progamming-spreadsheet filenames

* fix: renamed calorie-counter project filenames
2020-09-16 11:54:12 +05:30
Randell Dawson 69e3e138f6 fix: added missing ERMs to challenge seed 2020-09-16 11:54:11 +05:30
Randell Dawson 3b8e257643 fix: corrected freecatphotoapp.com link 2020-09-16 11:54:09 +05:30
Randell Dawson fd6f8b5cd4 feat(learn): Update Basic HTML Cat Photo App project descriptions and hints and tests (v7) (#39131)
* feat: added Cat Photo App project

Added new steps

feat: add tests + targetted hints for demo

simplify wording and combine some tests

feat: update text and add tests/hints

fix: changed descriptions and tests

feat: added tests for part 11 - 15

fix: reworded description for steps 2 and 10

fix: changed isBeta to isHidden

fix: temporarily remove fcc-editable strings

fix: added project to challengeTypes.js

fix: added missing parentheses

fix: test text improvements

fix: changes to tests and text discussed in meeting

fix: adjust logic for detecting indentation in part 07

fix: missing regex characters and made last test more permissive for part 04

feat: add steps 25 to 55 and notes

fix: added h1 element back to steps 5-24

fix: h1 and h2 elements from steps 25 to 50

fix: added missing DOCTYPE declaration steps 20-24

fix: miscellaneous text edits

fix: break up part 28, change local paths for images to short s3 cdn URLs

fix: part 01 and 02 descriptions and tests

feat: pull in changes from #39145 and remove solution sections

fix: adjust descriptions and break up steps 33 and 35

fix: break up more steps and adjust text

feat: add tests for parts 25 - 30

* fix: ran reorder-steps.js

* fix: added editable region markers

* fix: standardize opening tag hint text

* fix: remove trailing periods from descriptions and hints and adjust tests

* fix: remove unnecessary instructions sections

* fix: added test to check for only one h1 element

* fix: removed comma

* fix: changed paragraph element to `p` element

* fix: added test for extra h1 element

* fix: test to validate only one img element exists

* fix: replaced code tags with backticks

* fix: reworded description

* fix: reworded step description

* fix: changed tests for first step

* fix: change last two alt values to sentences

* fix: check for spaces in text strings

* fix: removed extra dot before replace method

* fix: moved example before instruction

* fix: rearranged step 6 tests

* fix: capitalized p in paragraph

* fix: rewored step 7's description and a test text

* fix: corrected test for step 8

* fix: improved step 9 tests

* fix: moved example above instruction

* fix: corrected step 9 test wording

* fix: rearrange test order for step 10

* fix: moved example before instructions for step 11

* fix: improved step 12 descripton and tests

* fix: corrected tests for steps 9, 10, 11, 13, 14

* fix: added ERMs to steps 4-14

* fix: minor typos

* fix: reword steps so examples are above instructions

* fix: introduce inline and block elements and use divs instead of br

* fix: add or adjust tests for steps 15 - 27

* fix: moved ERM up one line

* fix: removed unnecessary quotes in tests' text

* fix: added dfn tags for step 45

* fix: removed adding # to href step

* fix: tests 15 - 16

* fix: reword descriptions so they're not as hand holdy

* fix: reorder/reword steps 58 - 60

* feat: simplify radio button steps

* fix: wording and add demo step

* fix: remove doctype and teach in last step

* fix: update part-demo

* fix: added some more step 15 hints

* fix: added step to introduce section elems

* fix: added section elements to project

* fix: update final code

* fix: update tests for 15a and 16

* fix: add section elements to parts 45 to 61

* fix: change p elements to h3, update tests and text

* fix: added new test for step 9

* fix: fixed/added tests for steps 15-30a

* fix: use fieldset elements instead of divs in the form

* fix: added new test to setp 30a

* fix: changed `main` to `section`

* fix: corrected/added tests for step 31

* feat: add tests 32 - 36

* fix: revert change to js rpg game

* fix: simplify tests 32 - 36

* fix: updated submit-cat-form url

fix: changed submit-cat-form url

* fix: added/rearranged tests steps 32-36

* fix: added tests for step 36a

* fix: used hasAttribute where applicable

* fix: misc edits for steps 10 and 35-36a

* fix: add tests to step 37

* fix: reworded step 37

* fix: added more verbiage to steps 35 and 36

* fix: modified step 38 desc and added tests

* fix: added hints/tests for step 40

* fix: added hints/tests for step 41

* fix: added hints/tests for steps 42 and 43

* fix: made attribute values match exactly

* fix: change wording from text input to text field

* fix: rearrange name attribute lessons

* feat: tests for 44 - 44b

* fix: added a step  35a

* fix: added name="catphotourl" to steps 36-61

* fix: reworded steps 41 and 43

* fix: removed intro to for attribute

* fix: rewrite of step 44b's desc and tests

* fix: added step 45 hints/tests

fix

* fix: removed for attribute from steps 45a-61

* fix: removed extra )

* fix: wrapped "section" with backticks

* fix: added test for steps 45a and 45b

* fix: adjust position of label steps 55-61

* fix: removed conole.log statements

* fix: added tests to step 45c

* fix: renamed step 49 to step 46a

* fix: moved label element for steps 48-53

* fix: reworded step 47 description and instructions

* fix: typos in description and test text

* feat: add tests 46-48

* fix: wording

* fix: remove case insensitivity from a couple of tests

* fix: wording and add erms

* fix: add additional test for step 48

* fix: added hints/tests for step 50

* fix: added hints/tests for step 51

* fix: added hints/tests to step 53

* fix: added hints/tests for step 55

* fix: added hints/tests for step 56

* feat: tests for 57-61

* fix: removed duplicate test in step 55

* fix: adjusted 1st test for step 57

* fix: simplified test for title text

* fix: improved tests for step 60-61

* fix: removed demo.md file

* fix: ran reorder-steps.js

* fix: part 10 description

* fix: part 14 description

* fix: part 24 - move ERMs

* fix: part 05 description

* fix: part 54 test text

* fix: part 06 - wording and add test for p and main closing tag order

* fix: part 50 - add test to check for order of fieldset elements

* feat: value attribute for radio buttons step and seed changes

* feat: value attribute for checkboxes step and seed changes

* fix: update part 14 description

* fix: revert ERMs for part 24

* fix: remove last test in part 06

* fix: text and typos for new radio and checkbox lessons

* fix: text and typos for new radio and checkbox lessons

* fix: add test to part 01

* fix: ran reorder-steps.js

Co-authored-by: Kris Koishigawa <scissorsneedfoodtoo@gmail.com>
2020-09-16 11:54:09 +05:30
Oliver Eyton-Williams d7dc1acb4a chore: update lang tags on code blocks 2020-09-16 11:54:08 +05:30
Kris Koishigawa 4f1be63055 feat(learn): sync master and next-curriculum branches 2020-09-16 11:54:01 +05:30
Tom 977701937b Feat: add d3 dashboard project to next curriculum (#38028)
* feat: add d3 dashboard project to next curriculum
2020-09-16 11:54:01 +05:30
Tom dae411d408 fix: failing test (#38253) 2020-09-16 11:54:00 +05:30
lmilliken 9ba1f1f6d0 feat: tests for calorie counter
split up calorie counter lesson
2020-09-16 11:54:00 +05:30
Kris Koishigawa b99d78858b fix: basic js rpg spacing and tests
Replaced tabs with spaces so spacing is consistent in the monaco editor. Also adjust some tests to account for the new loop protection.
2020-09-16 11:54:00 +05:30
lmilliken 39b0afd5f0 feat: tests for calorie counter 2020-09-16 11:54:00 +05:30
Kristofer Koishigawa d3d5147c1f fix: renamed files and titles in the frontmatter for consitency (#37792) 2020-09-16 11:53:59 +05:30
SomeDer 2fbafda167 feat: functional programming spreadsheet (#36873)
* Add meta.json for spreadsheet

* Add spreadsheet files

* Close code tags for tests in 2 files

* Add solution section

* Add index file

* Add javascript-spreadsheet to stringifier

* Move index to step

* Rename steps in meta.json

* Rename step numbers in files

* Add index file to proper location

* Remove inappropriate files from spreadsheet dir

* Fix typo in first step

* Fix test sections

* Rename files to correct step

* Fix broken tests

* Add newline between sections

* Change challengeType from 1 to 0

* Add missng ) in step-079.md

* test -> tests in step-079

* Simplify test in step-103

* Fix step-137 test

* Remove last step

* Added solutions and adjusted some tests

* Fix some challenges

* Remove wrong spaces

* Fix more tests

* Add missing semicolon

* Fix more tests

* Fix type: lastttwo

* Fix all remaining tests
2020-09-16 11:53:59 +05:30
Tom 89e18e3a81 feat: add challenges for skyline project (#36854) 2020-09-16 11:53:59 +05:30
Kristofer Koishigawa 529f2596d9 feat: JS RPG game tests (#37678)
* feat: Add JavaScript RPG Game for testing
2020-09-16 11:53:58 +05:30
Randell Dawson 876d9f3994
fix(learn): Consolidated comments for Coding Interview Prep challenges - part 2 of 2 (#39576)
* fix: consolidate comments for use with the translation dictionary

* fix: added blank line between comments

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: removed unneeded comment

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-09-16 01:01:21 +05:30
Randell Dawson 8788ad946b
fix: remove Good luck! comment from challenge seed code (#39575) 2020-09-15 22:27:40 +05:30
Randell Dawson a2f4c8d0e1
fix: consolidated comments for use with translation dictionary (#39578) 2020-09-15 22:23:25 +05:30
Randell Dawson 104f359902
consolidated comments for use in translation dictionary (#39577) 2020-09-15 12:37:50 -04:00
Kristofer Koishigawa c11bf0d02e
fix(curriculum): restrictive test for use map to dynamically render challenge (#39581) 2020-09-15 08:23:48 -07:00
Tom d765fa704b
fix(learn): size your images challenge (#39570)
* fix: size your images challenge

* fix: remove console log
2020-09-14 14:09:01 +01:00
Aleksa S. Stevic 5cb609dc5c
Changed "statement" to "expression" (#39564)
The ternary operator doesn't allow statements, just expressions.
2020-09-12 10:37:59 +02:00
Tom ae6cf5b724
fix: update instructions to be consistent (#39557)
* fix: update instructions to be consistent

* fix: change to use code tags instead of backticks
2020-09-11 19:03:18 -04:00
Randell Dawson c345bc9886
fix: removed scrimba video links that do not reflect current challenge (#39559) 2020-09-11 11:17:50 -05:00
Lasse Jørgensen 2743ac2e84
fix(challenge): update variable names, assign empty array, update solution code, remove "use strict" (#39525)
* fix(challenge): update variable names, assign empty array, update solution code, remove "use strict"

* fix(challenge): update solution code

* fix:(challenge) update instructions and variable name

* fix:(challenge) update instructions
2020-09-09 19:58:27 -05:00
Siddharth Pathak 5418307936
fix(learn): add whitespace check to else-if test (#39555) 2020-09-09 20:30:33 +01:00
Randell Dawson 0f5832b562
fix: project 25 + 5 (#39526) 2020-09-09 13:28:12 +05:30
Tom b79a332984
fix: remove scrimba link for inaccurate video (#39545) 2020-09-08 13:09:53 -07:00