Commit Graph

801 Commits (50f15886b85259d589df4b20b1052df7dae4a8d2)

Author SHA1 Message Date
Randell Dawson 50f15886b8
fix(curriculum): Strip comments from user code for Use Destructuring Assignment to Extract Values from Objects challenge (#38213)
* fix: strip user code to improve tests

* fix: removed closing section tag messing up tests
2020-03-25 13:28:17 +01:00
Kalyanasundaram 8b0cbd6f83
Modify tests for testing objects for properties challenge (#38414)
* Stronger test cases for testing objects for properties

Change function signature to take in a custom object to be tested

* YML formatting mistake

* Yaml no space in string

* Small one more fix - most likely final

* REmove double space in return

* Update instruction Section
2020-03-24 22:09:57 -07:00
Randell Dawson 1f2a93b646
fix: added additional test for altText (#38395) 2020-03-23 07:02:34 -05:00
Keith Warter 022bbdd1b0
Adding a solution for searching within a linked list for future students (#38326)
* Adding a solution for future students

* fix: added new tests and correctied existing tests

* Adding isEmpty method as well

* Update curriculum/challenges/english/08-coding-interview-prep/data-structures/search-within-a-linked-list.english.md

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-03-21 09:30:14 -05:00
Vincent Shury 6920634e6c
TYPO-FIX JS-regex-match-non-whitespace-characters (#38407)
Added Markdown to correctly display second test
2020-03-20 21:13:48 -07:00
Sanket Kogekar f25d035e9d
add: solution to project euler problem 23 md file (#38369) 2020-03-18 16:37:26 -07:00
Hassaan Pasha a282c24bf4
fix (curriculum): added console output checks for the inheritance challenge (#38360)
Co-authored-by: Hassaan Pasha <hassaan.pasha@teamo.io>
2020-03-14 21:55:21 -07:00
Sanket Kogekar 705cc32579
add: solution to project euler problem 22 md file (#38263)
* add: solution to project euler 22 md file

* Copied the array instead of using it directly

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-13 14:31:13 -07:00
Shivam saini 4ef78f7f7d
Update use-recursion-to-create-a-countdown.english.md (#38366) 2020-03-13 16:05:59 +01:00
Randell Dawson cc190aba99 fix: removed assert message arguments 2020-03-12 20:46:46 +09:00
Bhanu Pratap Singh 72bc067e6b feat(interview-prep): Regenerated IDs 2020-03-12 20:46:46 +09:00
Bhanu Pratap Singh ec0a5e0b6f feat(interview-prep): Updated descriptions and corrected syntax 2020-03-12 20:46:46 +09:00
unknown e4a6f5563f feat(interview-prep): Converting and transferring Rosetta problems 2020-03-12 20:46:46 +09:00
Randell Dawson fde8c05a20
fix(curriculum): strip comments from CSS in testString to fix bug caught by tests (#38351)
* fix: strip-comments-from-css

* fix: added challenge referenced in issue

* fix: added call to function removeCssComments

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-11 08:56:34 -05:00
Hassaan Pasha 8c435c8b75
fix (curriculum): changed the index to 0 for the fibonacci sequence challenge (#38331) 2020-03-10 13:43:41 +03:00
Ashraf Nazar a2d31afe81
fix: Update test in Redux challenge to accomodate backticks (#38345) 2020-03-10 12:15:50 +03:00
Randell Dawson c401fc7f83
fix(curriculum): removed solution required comment from 6 challenges (#38339)
* fix: removed solution required comments

* fix: fixed two more challenge soltuions with solution required comment

* fix: remove debugging code

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-09 13:58:46 +01:00
Randell Dawson 9252f96566
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 4 of 4 (#38267)
* fix: consolidate comments


Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-03-08 15:46:28 +01:00
Shivam dbf3815fc7
added:solution for Coding Interview Prep/Data Structures-Create a Map Data Structure (#38337)
* add: solution to Data Structures-Create a Map Data Structure

* Proper usage of -hasOwnProperty

removed unnecessary returns
2020-03-07 22:07:40 -08:00
Hassaan Pasha 3a47c5411f
fix (curriculum): made the order of the required code to be re… (#38320)
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-03-06 12:44:39 +05:30
Tom 17a55c6e18
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 1 of 4 (#38258)
* fix: consolidate/remove comments

* fix: remove => from comment

* fix: reverted changes to add same changes to another PR

* fix: removed 'the' from sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: removed 'the' from the sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-04 13:08:54 -06:00
Randell Dawson 6a7a7e6d7d
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 2 of 4 (#38259) 2020-03-03 10:18:30 +03:00
Senipah 012e5c848b
reword instruction referring to 3d array (#38272) 2020-02-29 22:35:53 -08:00
Ashraf Nazar 181ac1e8ad
fix: Update test for wrapping strong tag around text to include periods at the end (#38305) 2020-02-29 01:02:39 -05:00
Oliver Eyton-Williams 2d7b1255cc
fix: add missing .english extensions (#38298) 2020-02-28 07:19:22 -08:00
Kristofer Koishigawa 6cfd0fc503
fix: improve Project Euler descriptions, challenge seeds, and test cases (#38016)
* fix: improve Project Euler descriptions and test case

Improve formatting of Project Euler test descriptions. Also add poker hands array and new test case for problem 54

* feat: add typeof tests and gave functions proper names for first 100 challenges

* fix: continue fixing test descriptions and adding "before test" sections

* fix: address review comments

* fix: adjust grids in 18 and 67 and fix some text that reference files rather than the given arrays

* fix: implement bug fixes and improvements from review

* fix: remove console.log statements from seed and solution
2020-02-28 06:39:47 -06:00
Randell Dawson 41718abf76
fix(learn): consolidate comments for responsive web design cert (#38256)
Related to PR #38040

This PR is an attempt to consolidate/remove as many comments in the challenge seed code in the Responsive Web Design certification challenges, to be able to create a small translation lookup object for translating the English comments to other languages.
2020-02-27 20:50:46 +05:30
Harsh Savergaonkar c21c9f0acb
Added meaning of ones in adjacency matrices (#37048)
* Added meaning of ones in the matrix

* Apply suggestions from code review

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: add slash to avoid markdown lint error

Co-authored-by: mrugesh <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-27 06:54:11 -06:00
Sanket Kogekar 1a87f1f7c0
add: solution to project euler problem 20 (#38257)
* add: solution to project euler problem 20

* Update curriculum/challenges/english/08-coding-interview-prep/project-euler/problem-20-factorial-digit-sum.english.md

Accidentally added last line. Calling function is unnecessary in solution.

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* right place for starting braces

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* moved starting brace to previous line.

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-02-26 14:22:40 -05:00
Prakash Kumar c9d8c2a73c
fix(learn): typo in Serialization of a User Object (#38262) 2020-02-26 15:07:32 +05:30
Vincent Shury b49b9f3e3c
Typo whitespace fix in access-multi-dimensional-arrays-with-indexes.english.md (#38247)
* Update access-multi-dimensional-arrays-with-indexes.english.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-24 17:02:53 +01:00
Randell Dawson 78156a65f0
fix(curriculum): Added test to Return a Sorted Array Without Changing the Original Array challenge to validate new array is returned (#38105)
* fix: added test to validate new array is returned

* fix: changed text to reflect changed test

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-24 15:30:48 +01:00
Tom a09ffadd5a
fix: responsive image challenge (#37934)
* fix: responve image challenge

* fix: bad solution

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-20 22:53:30 +05:30
Oliver Eyton-Williams b0f1fa4b96
fix: make recursion challenge more intuitive (#37399) 2020-02-20 21:36:33 +05:30
Igor Snitkin dc7092ecd1
(fix learn): Update description to accommodate tests (#38224) 2020-02-19 00:13:34 +05:30
lasjorg 9a5ae756ac
fix(challenge): check inline style for color (#38211)
* fix(challenge): check inline style for color

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/change-the-color-of-text.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-02-18 23:38:16 +05:30
Oliver Eyton-Williams f84173866a
fix: make frankenSplice tests more robust (#38225) 2020-02-18 21:24:24 +05:30
Prakash Kumar c730f4aef4
Update hash-and-compare-passwords-synchronously.english.md (#38226) 2020-02-18 09:28:38 +01:00
Prayag 701bbc2ae9
added solution to d3 challenge add-labels-to-d3-elements (#38208) 2020-02-13 20:59:16 +05:30
kundan kumar 971c62ab53
fix : Unclear test output use-array.map-to-dynamically-render-… (#38191) 2020-02-13 02:41:36 +05:30
Hassaan Pasha 2f951f0dff
fix: edited the duplicate test guideline to mirror the actual… (#38199) 2020-02-12 20:47:24 +05:30
srdubya 3fd336d3e9
fix(learn): correcting Hash Table Lookup Efficiency (#38130)
A hash table provide a lookup of O(1), not O(n).
2020-02-12 12:27:47 +05:30
Hassaan Pasha 0498e27902
fix: added white space checks including newlines to ensure pro… (#38166)
* fix: added white space checks including newlines to ensure proper validation of trim method

* fix: Addressing comments
2020-02-12 12:17:54 +05:30
Ashraf Nazar 5feabd762c
fix: Add tests to check lazy matching is applied and that the string "h1" is not matched (#38193) 2020-02-11 10:17:51 -06:00
Hassaan Pasha 80ba943ca3
fix: fixed regex for validating newlines in for loops (#38180) 2020-02-09 18:43:43 -06:00
Josh Soref 004b99bf8f chore: fix typos in spelling (#38100)
* spelling: accidentally

* spelling: announce

* spelling: assembly

* spelling: avoid

* spelling: backend

* spelling: because

* spelling: claimed

* spelling: candidate

* spelling: certification

* spelling: certified

* spelling: challenge

* spelling: circular

* spelling: it isn't

* spelling: coins

* spelling: combination

* spelling: compliant

* spelling: containers

* spelling: concise

* spelling: deprecated

* spelling: development

* spelling: donor

* spelling: error

* spelling: everything

* spelling: exceed

* spelling: exist

* spelling: falsy

* spelling: faulty

* spelling: forward

* spelling: handle

* spelling: indicates

* spelling: initial

* spelling: integers

* spelling: issealed

* spelling: javascript

* spelling: length

* spelling: maximum

* spelling: minimum

* spelling: mutable

* spelling: notifier

* spelling: coordinate

* spelling: passport

* spelling: perform

* spelling: permuter

* spelling: placeholder

* spelling: progressively

* spelling: semantic

* spelling: submission

* spelling: submit

* spelling: translations

* spelling: turquoise

* spelling: visualization

* spelling: without

* spelling: registration

* spelling: representation
2020-02-08 23:59:10 +05:30
Oliver Eyton-Williams a7075a579c
Fix: Problem 39: Integer right triangles (#38145)
* fix: correct test and add solution

I also changed the seed to report the results of an easier example to
the user, since just evaluating the function mostly wastes time.

* fix: use a better solution

* fix: credit original author
2020-02-08 21:09:32 +05:30
Sidtharthan A N 8cf64f2539
ProjectEuler | Update Problem statement of 002 to match projecteuler.net (#38101)
* Correct ProjectEuler:002 definition and tests

From projecteuler.net:
By considering the terms in the Fibonacci sequence whose values do not exceed four million, find the sum of the even-valued terms.
Correct: take all f(n) where f(n) <= 4,000,000 and f(n) is even
Incorrect: take all f(n) where n <= 4,000,000 and f(n) is even

* Incorporate PR review suggestios to ProjectEuler 002

Reword the problem statement

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-02-07 10:09:35 -06:00
Kristofer Koishigawa 4ef445c543
feat: add styles for markdown tables and convert some HTML tables to markdown (#38126) 2020-02-07 09:47:35 +01:00
Kiara Barias afd467f5dc
Removes RSA links from English challenges (#37869)
* RSA links deleted from challenges

* fix: remove remaining RSA links in challenges
2020-02-07 14:46:07 +09:00