greatbody
/
freeCodeCamp
mirror of https://github.com/freeCodeCamp/freeCodeCamp.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
25,464 Commits
3 Branches
0 Tags
959 MiB
Commit Graph

42 Commits (50f15886b85259d589df4b20b1052df7dae4a8d2)

Author SHA1 Message Date
kundan kumar 971c62ab53
fix : Unclear test output use-array.map-to-dynamically-render-… (#38191) 2020-02-13 02:41:36 +05:30
Nick Black 6a4b42c4ec
Update to make instructions more clear (#38068) 
The instructions on the exercise following this specify 'behind the scenes' which sounds more clear than 'in the background'.
 2020-02-04 10:54:02 +03:00
M B 7f6a653c28 fix: update react lesson link (remove 404) (#38031) 
* Update lesson link (remove 404)

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2020-01-09 17:29:50 +01:00
Randell Dawson 44ff327a38 fix(curriculum): make test more flexible for (#37902) 
* make test more robust

* fix: changed test to ignore extra spaces in html

* Revert "make test more robust"

This reverts commit 89718eb5e5.
 2019-12-11 23:20:19 -05:00
Randell Dawson 6fc32ab9b6 fix(curriculum): changed test text to use should for Front End Libraries (#37762) 
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
 2019-11-22 13:44:40 +01:00
Ananda Umamil 734b794714 fix: update react proptypes lesson description (#37477) 2019-11-05 00:42:07 -05:00
Roberto Ruccia 36de803902 Fix link in use-proptypes-to-define-the-props-you-expect.english.md (#37665) 
* Fix link in use-proptypes-to-define-the-props-you-expect.english.md

* Add a blank line before Note line
 2019-11-01 20:22:19 -05:00
SomeDer bfa5c26288 fix: use dfn instead of code tag (#36640) 
* Use dfn tags

* remove misused <dfn> tags

* Revert "remove misused <dfn> tags"

This reverts commit b24968a968.

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/fill-in-the-blank-with-placeholder-text.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Make "array" lowercase

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Fix dfn usage

* Address last dfn tags
 2019-10-27 12:45:37 -04:00
Johnny Zabala e9bbcc55cd test rendered output instead of state in react write a simple counter challenge (#36791) 2019-10-09 09:52:41 -05:00
SomeDer 5de58ad98d fix(curriculum): use function form of this.setState (#36623) 
* Fix solution

* Update description

* Add test for this.setState function syntax

* Update toggle element instructions

* Fix simple-counter solutions

* Fix bind-this challenge seed and solution

* Fix && challenge seed and solution

* Fix ternary challenge seed and solution

* Use the function form -> Pass a function

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Mention "passing a function" instead of "alternative form"

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Rephrase explanation

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* clarify why functions should be used

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Improve tests

* Fix \s escaping in []

* Improve regex

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add test for `this`

* Use block code

* Update bind-this challenge

* Fix last part of instructions

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2019-09-24 08:12:50 -07:00
Oliver Eyton-Williams 3a0cd56ad3 fix(curriculum): Add and modify tests to catch bad code. (#36429) 2019-09-20 09:28:50 -07:00
Oliver Eyton-Williams 44804abeb5 fix: Remove and update challenges with legacy methods (#36444) 2019-08-15 01:22:41 +01:00
Tiago Salema a305a3df9f componentWillReceiveProps is deprecated (#35894) 
* componentWillReceiveProps is deprecated

Consider removing this lesson from the React tutorial, once this lifecycle method is now deprecated.
In case it isn't, a warning in the beginning should be displayed

* Removed also `componentWillReceiveProps`
 2019-08-13 09:14:10 -07:00
SomeDer 01c8554adc 03-render-conditionally-from-props: use const (#36551) 2019-08-12 18:17:39 +05:30
Randell Dawson 568f00e02a fix(curriculum): Added forumTopicId to remaining 1200 challeng… (#36558) 2019-08-05 22:14:37 +05:30
Randell Dawson ba6ae7154c fix: removed more assert msg arguments (#36439) 2019-07-28 05:16:04 +01:00
Randell Dawson f2df76c099 fix(curriculum): Remove unnecessary assert message argument from English Front End Libraries challenges - 02 (#36409) 
* fix: removed assert msg argument

* fix: removed more assert msg args

* fix: removed more assert msg args
 2019-07-24 13:07:46 +01:00
Oliver Eyton-Williams 7d4dc382b4 fix(curriculum): format challenge markdown as per linting rules (#36326) 
* fix: Format challenge markdown according to linting rules

* fix: Put spaces after section tags
 2019-07-19 15:30:17 +05:30
Tiago Salema e561953827 Removed deprecated lifecycle methods (#35895) 
Removed `componentWillReceiveProps` and `componentWillUpdate` from the list of lifecycle methods since they are now deprecated.
 2019-07-03 13:56:15 +02:00
Randell Dawson 933350c148 fix(curriculum): Convert blockquote elements to triple backtick syntax for Front End Libraries (#35994) 
* fix: converted blockquotes for react/redux

* fix: converted blockquotes for sass

* fix: changed jsx to js

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: changed jsx to js

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2019-05-14 07:01:32 -05:00
Kyle Scheuerlein 3b5fbe3edb Improve formatting of Challenge Seed (#35854) 2019-05-08 18:32:01 -05:00
Benjamin Herrchen 20f71fd22e correct usage of Math.random() to give equal 50/50 results (#35840) 
* Update render-conditionally-from-props.english.md

* Update render-conditionally-from-props.english.md
 2019-04-13 18:06:01 -04:00
lasjorg 394ae3d1ce fix(challenge): check for li and specify elements accepting text (#35193) 
* fix(challenge): check for li and specify elements accepting text

* fix(challenge): revert text

* fix(challenge): remove word added by mistake

* fix(challenge): update test, cleanup assertion text
 2019-04-10 20:52:37 +05:30
chaomt 216e10e2b7 fix: A testing bug in FCC's React Simple Counter Challenge (#35715) 2019-04-03 22:24:05 -05:00
Randell Dawson 4d1d89b1c7 fix(curriculum) Fixed test to only allow valid JSX comments for Add Comments In JSX challenge (#35320) 
* fix: only allow valid jsx comments in div elem

* fix: allow blank comment and removed assert msgs
 2019-03-19 01:00:12 -04:00
Oliver Eyton-Williams e7bc4bd014 fix: Allow trailing commas to be used in challenge (#35585) 
* fix: Allow trailing commas to be used in challenge

* fix: use regex to simplify challenge tests

* Update curriculum/challenges/english/03-front-end-libraries/react/review-using-props-with-stateless-functional-components.english.md

Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>
 2019-03-18 09:56:46 -07:00
kevindelsh 64faca718b Changed the definition of stateful components (#34837) 
A stateful component is always a class component because functional components can't maintain state by definition. Changed a line to better reflect that.
 2019-03-16 19:25:46 +01:00
Theodoros Gkortsilas cd501ee4c5 change wording: React component -> class component (#34692) 
Hi,

I noticed that in the instructions it is written that in the code editor there is a functional component and a React component. I do believe this is a typo as both are React components, just defined differently. Therefore, the sentence should be "...there is a simple functional component called ChildComponent and a class component called ParentComponent...".

Theo
 2019-03-04 01:47:28 -05:00
Ahmed Elbessfy 61a5707ba7 Edit Description (#34329) 
* Edit Description

Making some editing to make the description more understandable. I am a beginner but I think me edits makes more sense. If you think so, please merge them for helping others.

* Update curriculum/challenges/english/03-front-end-libraries/react/pass-props-to-a-stateless-functional-component.english.md

Co-Authored-By: Ahmed-Elbessfy <ahmedelbessfy@gmail.com>
 2019-02-24 12:22:56 -07:00
Niraj Nandish cb35d49a21 fix(challenges): Fix broken links in English challenges (#35125) 2019-02-21 17:58:31 -05:00
Theodoros Gkortsilas a17b123510 Added curly brackets to comment in JSX element (#34694) 
Added curly brackets to comment in JSX element to hide it from the rendered DOM
 2019-02-21 03:24:27 -05:00
Aditya 46be1e2ed1 fix: React: Give Sibling Elements a Unique Key Attribute (#34648) 
* feat: added additional test

Added additional test, formatted description and updated instructions and solution

* fix: removed unnecessary linebreaks
 2019-02-19 14:29:06 -05:00
Steven Torrence 06b3b078a6 Fixed comment closing tag to match comment opening tag spacing and be symmetrical (#35136) 2019-02-10 14:29:12 -08:00
coderlyn 4fe2558f99 Edit text string to have the correct case (#34366) 
Change "You win!" and "You lose!" in the description to to "You Win!" and "You Lose!" to match the test
 2019-02-05 18:51:13 -08:00
Tomer Ben-Rachel cd783c32da Adding link to React documentation (#32635) 
* Adding link to React documentation

* Modified link to fit github markdown

* Update use-proptypes-to-define-the-props-you-expect.english.md
 2018-11-16 11:55:56 -05:00
The Coding Aviator ebf96cb0b2 Added info about deprecated React method in curriculum (#19930) 
* Update use-the-lifecycle-method-componentwillmount.english.md

* Added correction to deprecation timeline and updated link
 2018-10-27 19:49:49 -07:00
Valeriy e099d6486d fix: test curriculum challenges (#24180) 2018-10-23 18:51:53 +05:30
Valeriy 79d9012432 fix(curriculum): quotes in tests (#18828) 
* fix(curriculum): tests quotes

* fix(curriculum): fill seed-teardown

* fix(curriculum): fix tests and remove unneeded seed-teardown
 2018-10-20 23:32:47 +05:30
Bouncey ee9f6b2d72 chore(meta): Move challenge meta to challenges root 2018-10-11 02:15:05 +05:30
petergrainger e0e8ab8409 fix: clarify test text in line with test functionality 2018-10-08 11:38:29 +01:00
Bouncey a859035023 fix(challenge-md): Fix quotes that failed in the transform 2018-10-08 11:38:26 +05:30
Bouncey 8f39bc1288 chore(curriculum): Remove files in wrong format 2018-10-05 15:58:12 +01:00