Commit Graph

21726 Commits (53bb915868c2350aae4bcc38690155a7b86e13e2)

Author SHA1 Message Date
Niraj Nandish 769ec3cb63 Make code consistent in challenge (#19054) 2019-02-26 16:38:46 -05:00
Randell Dawson 5aab82cc89 fix(docs) Corrected challenge template example (#35307) 2019-02-26 22:21:00 +03:00
Mrugesh Mohapatra 67d1a633cf fix(saga): update actions for reset and delete
Co-authored-by: bouncey <staylor1012@gmail.com>
2019-02-26 22:57:13 +05:30
Mrugesh Mohapatra 1ce38a99e0 fix: apply conventional styling changes 2019-02-26 22:57:13 +05:30
Hemakshi Sachdev 05f8c2bd5c feat: added danger-zone-saga.js 2019-02-26 22:57:13 +05:30
Hemakshi Sachdev e51b8bfaca feat: added danger zone 2019-02-26 22:57:13 +05:30
riodajs 2a61d4327c Update some words to commons spanish words (#23340) 2019-02-26 16:39:10 +01:00
Christopher McCormack 52105e3968 feat: fixed grammar/formatting of entire document (#35392) 2019-02-26 21:01:25 +05:30
Bouncey f4528ad0ff fix: Consolodate full screen loaders in to one component 2019-02-26 16:06:05 +03:00
Pete 41ffe5a7e4 Adding-missing-challenge-solution (#35025)
* Adding-missing-challenge-solution

* updating solution as requested

added back in //solution required and removing console.log

* Adding-solution

* Update access-property-names-with-bracket-notation.english.md

* adding-solution

* Adding-solution
2019-02-26 03:44:33 -05:00
kevindelsh e40909b055 Corrected minor spelling error (#34750)
Changed "areas template" => "area's template".
2019-02-25 23:38:40 -05:00
Randell Dawson ab456a9a94 fix: changed js to html in solution section (#35414) 2019-02-25 22:50:58 -05:00
Aditya 665c9cb47f fix: Object Oriented Programming: Use Dot Notation to Access the Properties of an Object (#34675)
* fix: typos

* fix: removed unnecessary assert message
2019-02-25 22:24:06 -05:00
Paul Gamble 0c652e3ace feat: curriculum-basic-html-form-element-solution (#34956) 2019-02-25 22:23:08 -05:00
The Coding Aviator cbd1ebd4f5 Remove extra empty line from Applied Visual Design Challenge (#35241)
* Remove extra empty line

* fix(client): Removed extra line
2019-02-25 22:00:00 -05:00
Dana Ottaviani 30fd0aa78e fix: add solution for accessibility challenge (#35366) 2019-02-25 21:58:35 -05:00
Héctor Estéllez fd1a19d956 Add indentation spaces to example code (#35047) 2019-02-25 18:49:42 -06:00
Bannon Tanner fe07433d0e fixed typo with instructions and preview (#26088)
* fixed typo with instructions and preview

Instructions stated that grid-template-columns was set to repeat(auto-fill, minmax(60px, 1fr)); but it was not in .container or .container2
Changed .container2 to already include this as I believe was intended, leaving camper to change .container on their own
Fixes #18034

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/create-flexible-layouts-using-auto-fill.english.md

suggested change by @thecodingaviator

Co-Authored-By: bannon-tanner <bannon.n.tanner@gmail.com>

* possible fix for solution

* apply my suggestioned changes
2019-02-25 15:50:00 -08:00
Mrugesh Mohapatra ff53235efd fix: update welcome page for night 2019-02-25 23:26:48 +00:00
Alex 06311a56f6 Fixed the code formatting for readability (#25831)
I fixed the code formatting for readability. Made the spacing easier to see so updates and changes could be made more easily.
2019-02-25 21:03:32 +01:00
Ahmad Abdolsaheb 1c4d57dfb3 fix: text bleeding buttons in profile and donate-form (#35399)
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
- [x] My changes do not use shortened URLs or affiliate links.

<!--If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.-->

Closes #35265
2019-02-26 01:09:05 +05:30
lolabarri 0a228ab8e8 Update build-a-tribute-page.spanish.md (#23321)
Modified user history number 7, so it has the same format as the others. Also modified last line, which was too informal compared with the rest of the article
2019-02-25 20:37:02 +01:00
riodajs ca24e4bca2 Update traduction from some words (#23314) 2019-02-25 20:34:56 +01:00
Anton Honcharuk d7b5946c31 fix: text overflow on cta buttons (#35378) 2019-02-26 00:47:18 +05:30
Mrugesh Mohapatra 58edfce838 chore: fixup linting the api tests 2019-02-25 19:14:52 +00:00
Valeriy S 1faa8dc0c1 fix: set a max-len rule for eslint 2019-02-26 00:18:46 +05:30
Bouncey 1c6df3649b chore: Add readme for boot_tests directory 2019-02-26 00:17:02 +05:30
Bouncey f743f4edf5 fix: Convert ints to strings for validation 2019-02-26 00:17:02 +05:30
Bouncey 014c26cd4e fix: Add tests for redirectToLearn 2019-02-26 00:17:02 +05:30
Bouncey 953e1b2e11 feat: Add tests for challenge>buildUserUpdate 2019-02-26 00:17:02 +05:30
Bouncey 75190d3a43 feat: Add challenge validation middleware 2019-02-26 00:17:02 +05:30
Nellie ff23e94e25 Update add-elements-within-your-bootstrap-wells.russian.md (#28969)
Fixed Russian translation in add-elements-within-your-bootstrap-wells.english.md.
2019-02-25 21:58:59 +04:00
geeseyj f3fd951446 fix(coding): uncomment destructuring test and add solution (#18909)
* fix(coding): uncomment destructuring test and add solution

the test that ensured destructuring was being used had been left commented out and there was no solution offered. I uncommented the test and verified it worked as well as added the solution.

* fix: corrected partial solution to full
2019-02-25 23:27:50 +05:30
Christopher McCormack 35b3495be1 fix: correct unbalanced <code> element spacing (#35344)
* fix: removed pseudo-elements and replaced with padding to fix unbalanced <code> element spacing

* fix: adjusted formatting to use white-space property instead of changing padding
2019-02-25 16:37:58 +03:00
mrugesh mohapatra 84c8aac07c fix(styles): apply conventional styles (#35371)
* fix(styles): apply conventional styles

* fix: add night styles to progress
2019-02-25 15:58:40 +03:00
seanjs 30b630b5b7 Realign indentation and checkstyle of bracket (#29205)
* Realign indentation and checkstyle of bracket

* Update index.md
2019-02-25 18:17:43 +09:00
hwannee f6b7958094 Correct wrong bracket 2019-02-25 17:46:35 +09:00
Koustav Chowdhury d226f4ceaa Changed as per review 2019-02-25 16:45:05 +09:00
Koustav Chowdhury d4848df011 Alternative way to sort a vector 2019-02-25 16:45:05 +09:00
Gökhan Gurbetoğlu 2efc5a8e7b Fixes for CSS Flexbox challenges (#34420)
* Make property names monospace

Property names as monospace would be more fitting to this challenge.

* Add default value for align-items

According to the standard, the default value for align-items, if it is not specified, is stretch.
Source: https://www.w3schools.com/cssref/css3_pr_align-items.asp

* Add monospace font for code elements

These elements need to be in a monospace font.
2019-02-25 02:11:47 -05:00
Randell Dawson 9e07f99b9e fix(curriculum): Added test to validate clockwise notation is used for the Use Clockwise Notation to Specify the Margin of an Element challenge (#35342)
* fix: corrected last test which validates clockwise notation

* fix: removed helper function

* fix: used jQuery to get style and removed extra slash
2019-02-25 02:07:11 -05:00
Alan Nguy 5d3ea76a3e fix: fixed styling for modal headers (className fcc-modal) (#35220) 2019-02-25 12:31:17 +05:30
Enjel Hutasoit 544401abd5 Add example explaination (#33226) 2019-02-24 21:58:06 -08:00
v01d3tr 0f905531df feat: added info about typeof null (#26899)
* feat: added info about typeof null

* Further clarify change
2019-02-24 23:43:49 -05:00
Shashank Goyal ef625c80c6 Fix output of sample code (#28971)
sample code to avoid using shared or mutable state has output commented as 2 while it should be 1.
2019-02-24 18:46:13 -08:00
Amaka Mbah 36d1a7d369 Fix typo on line 6. Add info on line 6 & 7 (#31531) 2019-02-24 19:19:09 -07:00
Christian Coffey 145a94f192 Update index.md (#30085)
Removed an unnecessary example as well as changed the description for the usage of the 'await' keyword. Also added an example for async method declarations.
2019-02-24 19:03:33 -07:00
justingiffard 97834c64d2 Fixed example 2 so that its runnable (#22328)
added some some time consuming code and a return to `CalcDamage`
removed `static` from `CalcTotalDamage` so that the compiler doesn't complain that `CalcDamage` should be static
compiler wasn't happy with `totalDamage += CalcDamage(player);` or `return await Task.WhenAll(totalDamage)` because you are attempting to assign a Task to an int. Fixed it by using `WhenAll` correctly
Changed parameter name of `CalcTotalDamage` from `group` to `people` as  `group` can  be confusing to read as its used with linq
2019-02-24 18:36:06 -07:00
NITIN BISHT f224bbc62f fix: seed code doesn't match description [arabic] (#35382) 2019-02-24 16:29:51 -06:00
Adam 36d0d5d70f Added description to help understand challenge (#34674)
* Added description to help understand challenge

I added a short description at the beginning to explain that the user needs to use a different starter project than the one they were using earlier.

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md

Looks good!

Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/information-security-with-helmetjs/understand-bcrypt-hashes.english.md

True, that makes sense..

Co-Authored-By: adam-weiler <42845085+adam-weiler@users.noreply.github.com>
2019-02-24 12:27:12 -07:00