Ahmad Abdolsaheb
8b4fb5a452
fix: imgur to s3 for various files without conflict ( #36057 )
2019-05-20 23:58:20 +05:30
Kyle Cheung
937dc23b5d
fixed typos in custom css-variable challenge #36038 ( #36041 )
...
* fixed typos in custom css-variable challenge
* fix: Remove extra line
2019-05-14 20:31:03 +07:00
Randell Dawson
df8659ab8c
fix(curriculum): Convert blockquote elements to triple backtick syntax for Responsive Web Design ( #35993 )
...
* fix: converted blockquotes to code fences
2019-05-14 10:11:58 +02:00
Huyen Nguyen
791e589c93
Remove tag characters ( #36037 )
2019-05-14 00:14:16 +05:30
Randell Dawson
48884f3a4a
fix: changed to h4 > s in selector ( #36023 )
2019-05-11 19:09:08 -05:00
RIHANE ZAKARIA
a40451feaa
Define the Head and Body of an HTML Document for challenge solution ( #35826 )
...
* Define the Head and Body of an HTML Document for challenge solution
* edit on check the body tag contain h1 and p tags
2019-05-06 16:44:57 +02:00
Randell Dawson
409aa30b0a
fix(curriculum): add new test to use calculated space for Use grid-column to Control Spacing challenge ( #35893 )
...
* fix: use calculated space for test
* fix: reworded comment
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: changed After Test to Before Test
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-01 14:08:35 +05:30
Huyen Nguyen
5b32e98c4a
fix(curriculum): Add solutions to Applied Visual Design challenges ( #35815 )
...
* fix: add solutions to Applied Visual Design challenges
* fix: remove extra opening style tag
2019-04-28 13:13:38 -05:00
Ian Effendi
cf86246866
fix(curriculum): Add solutions to 16 Applied Accessibility challenges #35751 ( #35809 )
...
This commit adds 16 full working solutions to the responsive web design
principles dealing with applied accessibility.
2019-04-24 19:12:46 +05:30
Manish Giri
722b65d80f
fix(curriculum): Add solutions to HTML challenges ( #35766 )
...
* fix(curriculum): Add solutions to HTML challenges
* Remove extra anchor element
2019-04-22 11:37:05 +05:30
Manish Giri
e736179720
fix(curriculum): Add solutions to CSS challenges ( #35873 )
2019-04-22 11:27:43 +05:30
Catalina
ffcb092bf1
Fixed CSS Challenge English version ( #35849 )
2019-04-20 09:49:23 -07:00
Tom
f1bcd5f0de
fix/add-full-solutions-to-flexbox ( #35760 )
2019-04-20 09:45:18 -07:00
Astrid
9ee8b4fa57
fix: minor grammar mistake in 'applied visual design' challenge ( #35839 )
...
fix: revert changes to package-lock.json
2019-04-15 14:05:30 +05:30
Beau Carnes
63fc21f702
Update videoURL for HTML5 Elements challenge ( #35802 )
2019-04-14 09:20:36 -07:00
Paul Gamble
bddcda5559
added html solution for testing - responsive-web-design/applied-visual-design/decrease-the-opacity-of-an-element ( #35516 )
...
* added html solution for testing
* fix: corrected invalid solution
2019-04-12 18:17:12 +02:00
Aditi Joshi
ebdd8632fc
Fix/update challenges for responsive-web-design-principles ( #35804 )
...
* Fix/update challenges for responsive-web-design-principles
* fix/update fix some minor mistakes
* fix/update remove extra line
* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/create-a-media-query.english.md
Co-Authored-By: aditijoshi14 <aditijoshi1997@hotmail.com>
* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/create-a-media-query.english.md
Co-Authored-By: aditijoshi14 <aditijoshi1997@hotmail.com>
2019-04-10 17:26:56 -04:00
Beau Carnes
7e522dc473
fix: add new scrimbas ( #35803 )
2019-04-10 09:23:12 -07:00
Ian Effendi
f74d507434
fix(curriculum): replace js with full solution in accessibility challenge ( #35810 )
...
* fix(curriculum): add full, working solution for accessibility challenge.
This commit replaces a JavaScript only solution where a full, working
solution should have been written.
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
Co-Authored-By: rimij405 <effendiian@gmail.com>
2019-04-10 17:55:16 +02:00
Manish Giri
9b9a96234f
fix(curriculum): Add solutions to responsive web design principles ( #35761 )
2019-04-10 07:57:14 -07:00
Randell Dawson
42bc9fa9b6
fix(curriculum): Made tests not accept invalid HTML ( #35774 )
...
* fix: made tests stricter
* fix: simplify text
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-04-10 19:21:52 +05:30
Kyle Scheuerlein
f590fecb34
Update reduce-repetition-using-the-repeat-function.english.md ( #35787 )
2019-04-08 20:09:26 +05:30
lasjorg
f91dea9b5c
fix(challenge): update text to give an explanation of wrapping ( #34811 )
...
* fix(challenge): update text to give an explanation of wrapping
* fix(challenge): simplify challenge text
* fix(challenge): update challenge text add solution
* fix(challenge): remove line breaks
* fix(challenge): make second instruction more clear
2019-04-04 22:49:21 -04:00
Roberto Ruccia
91f4865ab4
Fix typo in curriculum/challanges/english/01-responsive-web-design/applied-visual-design/use-the-css-transform-scale-property-to-scale-an-element-on-hover.english.md ( #35743 )
2019-04-02 21:43:27 -04:00
Lipis
e84ae45008
Javascript -> JavaScript (English) ( #35183 )
...
* Javascript -> JavaScript (English)
* Update technical documentation page for required change
* Update use-class-syntax-to-define-a-constructor-function.english.md
* Update left-factorials.md
2019-03-28 14:05:41 +05:30
lasjorg
be687977cf
fix(challenge): add .english to file name ( #35687 )
2019-03-27 06:38:25 -07:00
lasjorg
d9213b38cd
fix(challenge): remove child selector from name attribute test ( #35423 )
2019-03-27 11:33:41 +05:30
lasjorg
69d9d522a2
fix(challenge): fix broken regex ( #35632 )
...
* fix(challenge): fix broken regex
* fix(challenge): update solution
2019-03-26 21:48:52 -07:00
lasjorg
a1e853337b
fix(challenge): simplify and cleanup tests ( #35535 )
2019-03-26 21:35:38 -07:00
Oliver Eyton-Williams
b10589fadf
fix: Challenge solution added and broken test updated. ( #35526 )
...
* fix: solution added and broken test updated.
* fix: Change test to equality and finish solution
* Update use-css-selectors-to-style-elements.english.md
2019-03-26 21:01:22 -07:00
Jean Jordaan
33edc072b9
Use the correct element name in <code> blocks, gloss it seperately ( #35616 )
...
* Update link-to-external-pages-with-anchor-elements.english.md
If you write "`anchor` element" instead of "`a` element", you should also write "`hyperreference` attribute", instead of "`href` attribute".
Suggestion: write "`a` (_anchor_) element", or "anchor (`a`) element", to communicate the element name explicitly and gloss it at the same time.
The `<code>` sections should be valid code as far as possible.
* Change md to html
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
* Revert "Don't mark up 'anchor' as code"
This reverts commit 50c6a3a7c9
.
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
2019-03-25 10:50:33 -05:00
lasjorg
98e68d04be
feat(curriculum): Add challenge on using the value attribute ( #35301 )
...
* feat(curriculum): Add challenge on using the value attribute
fix(challenge): update file name and add comma
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
Apply suggestions from code review
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com>
* fix(challenge): update tests
2019-03-24 18:43:05 -05:00
rupali317
bc72c86dc6
fix: updated the note sections for responsive web design english ( #35528 )
2019-03-22 15:02:12 +01:00
Shashank Bairy R
f313c094cb
fix: clarify how to create multiple box shadows (Issue: #35534 ) ( #35555 )
...
* fix: clarify how to create multiple box shadows
* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/add-a-box-shadow-to-a-card-like-element.english.md
<code> tags added to 'color' property in order to make it look more consistent with the other propertes of 'box-shadow'.
Co-Authored-By: BA1RY <shashank.bairy04@gmail.com>
2019-03-20 15:32:53 +01:00
NITIN BISHT
228d873dd3
Fix: remove quote from challenge where not needed [english] ( #35493 )
2019-03-19 15:04:03 +05:30
Gökhan Gurbetoğlu
3b0a75e648
Add default value for justify-content ( #34419 )
...
According to the standard, the default value for justify-content if it is not specified is flex-start.
Source: https://www.w3schools.com/cssref/css3_pr_justify-content.asp
2019-03-14 07:14:21 -07:00
Nathan Lakritz
c31d1e2de9
Add semicolon to inline CSS ( #34737 )
2019-03-14 01:08:25 +05:30
Greg Brewton
0b3415b2fa
Clarifies definitions and adds missing definition ( #28591 )
...
Corrects incomplete definitions of space-between space-around values and adds definition of space-evenly value
2019-03-13 11:10:37 -07:00
Ron Sogueco
748212f99c
fix: Test fails with comments ( #35079 )
...
* fix: Test fails with comments
* fix: Account for last line of code
* fix: false positive for padding clockwise notation
* fix: false positive for commented blue-box class
* fix: use same assertion as #35342
* fix: update Solution section
* fix: update last test for margin/padding challenges
2019-03-13 13:54:59 -04:00
Vedrana_R
0ffdae1093
Fixed interpunction in the introduction paragraph ( #32157 )
...
* Fixed interpunction in the introduction paragraph
* fix: made suggested change
2019-03-12 14:53:17 -07:00
Dana Ottaviani
0a2aa3dcfa
feat: add solution to accessibility challenge ( #35553 )
...
* feat: add solution to accessibility challenge
* Remove space before closing `time` tag
Co-Authored-By: Dana94 <dana.ottaviani@gmail.com>
2019-03-10 11:09:57 -07:00
Bannon Tanner
9ebaa10eea
added clarification in test text ( #26458 )
...
* added clarification in test text
fix to issue #17490
* moved the note from the test text to description
* fix: updated note sytnax
2019-03-08 14:01:47 +05:30
nik
304d36ab47
fix(challenge): decrease opacity testString ( #34711 )
2019-03-05 12:11:27 -05:00
Randell Dawson
b7fee2848c
fix(curriculum): Corrected test which allowed wrong solution to pass ( #35394 )
...
* fix: corret-wrong-checks-in-test
* fix: improved robustness of test
* fix: added a full working solution for challenge
* fix: added && to asssert
2019-03-04 12:33:02 -06:00
Randell Dawson
6db2e12e9e
fix: Removed unnecessary note from instructions ( #35502 )
2019-03-03 23:56:22 -06:00
lasjorg
25ea44edf5
fix(challenge): allow new line in linear-gradient formatting ( #35435 )
...
* fix(challenge): allow new line in linear-gradient formatting
* fix(challenge): update test with suggested changes
* fix(challenge): update test to use computed style
2019-03-03 19:32:41 -06:00
Dana Ottaviani
3d1fd805e6
feat: add solution to accessibility challenge ( #35484 )
2019-03-01 20:03:38 -05:00
Alan Nguy
1957b1f636
fix: added test case and working solution for empty li elements in the 'Create an ordered list' challenge. ( #35177 )
...
* fix: added test case for empty li elements
* fix: added error message in test case of empty li elements.
* fix: corrected error in test case.
* fix: added valid working solution
* fix: migrated test case to challenge: create-an-ordered-list (working solution included)
* fix: adjusted condition for empty li elements and fixed typo.
2019-03-01 23:50:09 +05:30
kevindelsh
e40909b055
Corrected minor spelling error ( #34750 )
...
Changed "areas template" => "area's template".
2019-02-25 23:38:40 -05:00
Randell Dawson
ab456a9a94
fix: changed js to html in solution section ( #35414 )
2019-02-25 22:50:58 -05:00