Commit Graph

2164 Commits (55a1b2a5bf1dce6f0dca8b99d4f157065af96c8c)

Author SHA1 Message Date
Randell Dawson 33bd4fb2c4
fix(learn): Change Codepen template link (#41440) 2021-03-12 10:41:48 +05:30
pandacoder7 53d372c298
fix: update challenge for crowdin in anchor page (#41450) 2021-03-11 13:35:34 -07:00
camperbot 8821a51474
chore(i8n,learn): processed translations (#41445)
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2021-03-11 13:34:42 -07:00
Luca 5589c37804
fix(learn): remove wrong spaces and make quotes consistent (#41434)
* Remove spaces that are not meant to be there (L37, L134, L156) Makes quotes consistent (L61)

Remove spaces that are not meant to be there (L37, L134, L156)
Makes quotes consistent (L61)

* Consistent spacing after commas

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-11 07:19:07 -08:00
Kelvin Sánchez 35a8f55515
fix(learn): Remove unnecessary inline code tag in challenge (#41428)
* remove unnecessary inline code tag

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-less-than-or-equal-to-operator.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* improve challenge wording

* improve challenge wording

* keep wording consistency

* keep wording consistency between similar challenges

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-10 10:16:03 -08:00
Sem Bauke 5b760e50a3
fix(curriculum) Improved readability and grammar (#41340)
* fix(curriculum) Improved readability and grammar

* fix missing tags and grammar

* fix(curriculum) changes to grammar

* fix(curriculum) grammar fixes

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-elements-only-visible-to-a-screen-reader-by-using-custom-css.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix(curriculum) Grammar fix

* chore: apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-03-10 09:00:03 -08:00
camperbot 0c29e743d3
chore(i8n,learn): processed translations (#41433)
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2021-03-10 07:16:44 -08:00
Caden Parker 6b9aeff09e
fix(learn): Rework Euler Problem 461 (#41333)
* Made instructions more clear + Corrected test cases

* Added highlight for return values

* Adjusted challenge description

* Rework

* Fixed minor linting error

* Address PR Comments

* Adjusted wording in description
2021-03-10 08:14:27 -07:00
Caden Parker d8e6d8dc46
fix(learn): Rework Euler Problem 182 (#41337)
* Rework Euler Problem 182

* Reordered tests

* Fixes for formatting
2021-03-10 15:55:52 +01:00
Caden Parker 256e7f416d
fix(learn): Added more robust logic for the remove test case in Create A Hash Table (#41283)
* Added extra test cases for hashtable.remove

* Minor Change

* Adjusted tests to use user created add function / Modified description

* Made test case description much more clear

* Changed instructions to be more clear

* Minor change to instructions

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 12:45:20 -06:00
Emer Conghaile 18068cdeaa
fix: remove forward slash from <source> tag (#41422)
The forward slash at the end of the <source> tag in the example is removed, as this is more common.
2021-03-09 16:20:22 +00:00
Nicholas Carrigan (he/him) c5bcebc724
fix(learn): revert backslash change (#41382)
* fix(learn): revert backslash change

Crowdin resolved the issue with backslashes escaping backtics in
the markdown parser, so this reverts the workaround we implemented
for that bug.

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/s-expressions.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 10:13:27 -06:00
camperbot 529d72b242
chore(i18n,learn): processed translations (#41424)
* chore(i8n,learn): processed translations

* Update curriculum/challenges/chinese/01-responsive-web-design/applied-visual-design/use-the-u-tag-to-underline-text.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 08:51:59 -07:00
gikf bd02249a23
fix(learn): rework Rosetta Code Count the Coins (#41282)
* fix: rework challenge to use argument in function

* fix: use better wording

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-09 08:34:10 -06:00
Nicholas Carrigan (he/him) 77730ae209
fix(learn): address translator comments (#41381)
* fix(learn): address translator comments

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/quoting-strings-with-single-quotes.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 08:15:26 -06:00
gikf 93495ef6db
fix(learn): correct tests description (#41280)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-09 11:48:12 +05:30
camperbot 7c3cbbbfd5
chore(i18n,learn): processed translations (#41416)
* chore(i8n,learn): processed translations

* Update curriculum/challenges/chinese/01-responsive-web-design/applied-visual-design/use-the-u-tag-to-underline-text.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-08 06:28:46 -08:00
camperbot 0432ec995f
chore(i18n,learn): processed translations (#41387)
* chore(i8n,learn): processed translations

* fix: remove extra space

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-03-07 08:15:14 -08:00
Nicholas Carrigan (he/him) 16e420021c
chore: audit data visualisation challenges (#41336)
* chore(learn): audit d3 projects

* chore: audit data vis

* chore: audit json apis

* Update curriculum/challenges/english/04-data-visualization/data-visualization-projects/visualize-data-with-a-scatterplot-graph.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: apply suggestions

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: no colour backticks

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/get-geolocation-data-to-find-a-users-gps-coordinates.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-05 12:25:29 -07:00
camperbot 5075f14248
chore(i18n,learn): processed translations (#41378)
* chore(i8n,learn): processed translations

* Update curriculum/challenges/chinese/01-responsive-web-design/applied-visual-design/use-the-u-tag-to-underline-text.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-05 07:43:24 -08:00
Ricardo Passos ae79525493
fix(learn): added a missing period and removed single quotes (#41377)
* Added missing period

On line 24, just before "Note that in your CSS..." a period was missing.

* Removed single quotes and added a missing period

On line 24, just before "Note that in your CSS..." there is a missing period. 
On line 30, the text "red-text" within a code tag is enclosed in single quotes.
2021-03-05 07:16:30 -08:00
Nicholas Carrigan (he/him) 4d8aae1678
fix: backtick formatting (#41371) 2021-03-05 11:39:04 +05:30
camperbot d58e605825
chore(i8n,learn): processed translations (#41364)
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2021-03-04 19:55:32 -07:00
gikf 5332628e6d
fix(learn): rework Rosetta Code Hailstone Sequence (#41279)
* fix: rework challenge to use argument in function

* fix: change leftover html to markdown

* Apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* remove leftovers

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-04 13:28:47 -08:00
Nicholas Carrigan (he/him) aff0ea700d
chore(i8n,learn): processed translations (#41350)
* chore(i8n,learn): processed translations

* fix: restore deleted test

* fix: revert casing change

Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2021-03-04 10:49:46 -07:00
lusc 8a5711dda7
Fix: remove a colon in rosetta-code/happy-numbers (#41349)
* Fix: remove a colon in rosetta-code/happy-numbers

Removed a colon that shouldn't be there

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/happy-numbers.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add inline code tags around all true and falses

https://github.com/freeCodeCamp/freeCodeCamp/pull/41349#discussion_r586700058

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-04 09:25:55 -07:00
Andrew Cen 65cc800689
fix: add blank lines on empty seeds (#41348) 2021-03-03 13:14:28 -08:00
gikf 728f44ab38
fix: clarify case for already placed valid number (#41225) 2021-03-03 23:02:51 +05:30
Nicholas Carrigan (he/him) 7117919d36
chore(learn): audit javascript algorithms and data structures (#41092)
* chore(learn): audit basic algorithm scripting

* chore(learn): audit basic data structures

* chore(learn): audit basic javascript

* chore(learn): audit debugging

* chore(learn): audit es6

* chore(learn): audit functional programming

* chore(learn): audit intermidate algorithms

* chore(learn): audit js projects

* chore(learn): audit object oriented programming

* chore(learn): audit regex

* fix(learn): remove stray .

* fix(learn): string to code

* fix(learn): missed some

* fix(learn): clarify strings

Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.

* fix: apply suggestions - thanks Randy! :)

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: non-suggestion comments

* chore(learn): remove comments from codes

Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: revert crowdin fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* chore: change voice

* fix: Christopher Nolan

* fix: expressions would evaluate

* fix: will -> would

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: to work to push

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-02 17:12:12 -07:00
Randell Dawson 57f3c80345
fix(learn): Clarify date format expectations for the Date Format challenge (#41327)
* fix: clarify date format expectations

* chore: apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-03-02 15:46:30 -08:00
Sem Bauke f328bdb93e
fix(curriculum) fixes for grammar and missing articles (#41335)
* fix(curriculum) fixes for grammar and missing articles

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/add-gaps-faster-with-grid-gap.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-03-02 12:27:45 -07:00
Ilenia 051a010798
fix(learn): disallow www link from challenge (#41275)
This commit disallows www link from "Nest an anchor in a paragraph" challenge.
2021-02-27 02:47:47 +05:30
Nicholas Carrigan (he/him) 31bdea63a2
chore(learn): audit front end libraries (#41179)
* chore(learn): audit bootstrap

* chore(learn): audit FE projects

* chore(learn): audit jQuery

* chore(learn): audit React

* chore(learn): audit react-redux

* chore(learn): audit redux

* chore(learn): audit sass

* fix: apply review suggestions

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: apply non-suggestions

* chore: remove comments from code

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-25 10:19:24 -07:00
Randell Dawson 33356e403a
fix(learn): Use backticks around back slash character (#41254) 2021-02-25 16:34:40 +05:30
Oliver Eyton-Williams 4917e59aaa
fix(curriculum): use user's url in url shortner tests (#41257)
This service is both guaranteed to be up (they're hosting it) and should
allow CORS for all requests (including the tests).
2021-02-25 12:04:09 +01:00
Randell Dawson b11dd87047
fix: remove sentence not needed (#41235) 2021-02-23 11:21:58 -06:00
Randell Dawson f4bbe3f34c
fix(learn): Updated code blocks to help with translation on two challenges (#41217) 2021-02-22 11:21:59 +05:30
Alexander Heß b12360d4a8
Removed the hint Fixes #41192 (#41215)
* Removed the hint Fixes #41192

* Removed the blank line as suggested
2021-02-21 13:36:14 -07:00
Randell Dawson a0a7598c44
chore(i8n,learn): processed translations (#41197)
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2021-02-21 07:49:16 -08:00
Ilenia aa615763af
fixed tests for link to external pages challenge (#41191)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-21 11:46:00 +05:30
gikf 531c3f9997
feat(learn): add project tests (#41183) 2021-02-21 10:37:02 +05:30
gikf 219339b2ce
fix(learn): rework Project Euler - Problem 58 (#41188) 2021-02-20 12:06:32 +05:30
gikf f5a905b7c2
fix(learn): unmangle challenge description (#41182) 2021-02-20 12:04:38 +05:30
gikf 70c4d82068
fix(learn): correct test result (#41068) 2021-02-20 12:04:12 +05:30
gikf c8db838754
fix: correct function call in test description (#40949) 2021-02-20 12:03:54 +05:30
gikf a91444d3d4
fix: correct function call in test description (#40944) 2021-02-20 12:03:33 +05:30
Kelvin Sánchez f08174b5b1
fix(learn): Remove unnecessary inline code tag in challenge (#41177)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-19 09:44:50 +05:30
Kelvin Sánchez fad168b465
fix(learn): fix some code tags, capitalization and punctuation in challenge (#41161)
* fix some code tags, capitalization and punctuation

Note: The reserved word in JavaScript is "boolean", so I think it is appropriate to use it like this inside the code tags.

* Remove code tags and capitalize first letter

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* capitalize letter and replace slash

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:45:12 -07:00
Kelvin Sánchez 2c1280af65
fix(learn): Improve the clarity on a challenge sentence (#41154)
* Improve the clarity on a challenge sentence

* add string type and remove double quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:29:31 -07:00
gikf 762775889e
fix: rework Project Euler - Problem 57 (#40926)
* fix: rework challenge to use argument in function

* fix: add solution

* fix: correct variable name
2021-02-17 11:58:18 -08:00
Kelvin Sánchez 1fe1371b16
add missing inline-code block (#41153) 2021-02-17 11:24:53 -08:00
Joshua Pelealu 10aee18748
Remove broken twitter links (#41152) 2021-02-17 12:03:57 -07:00
Kelvin Sánchez b45406ec9d
fix(learn): Remove repeated definition tag in challenge (#41151) 2021-02-17 23:01:42 +05:30
Kelvin Sánchez 1cdd009d7a
fix(learn): Remove repeated definition tag in challenge (#41148) 2021-02-17 21:28:09 +05:30
Joshua Pelealu c15c27f474
fix(learn): Added another test to check for invalid characters (#41144) 2021-02-17 21:16:07 +05:30
Randell Dawson 4696b47c01
chore(i8n,learn): processed translations (#41141)
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2021-02-16 14:21:30 -08:00
Nicholas Carrigan (he/him) 785405fdfd
chore(i8n,learn): processed translations (#41061)
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2021-02-16 14:01:20 -07:00
fots 2a2657d36c
fix: update regex for Convert JSON Data to HTML (#41134)
* fix: updated solution for Convert JSON Data to HTML

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-02-16 16:27:47 +00:00
Nicholas Carrigan (he/him) 21c7abf584
fix(learn): update challenge for crowdin (#41089) 2021-02-16 19:47:40 +05:30
Supritha ee6764519d
REMOVED comments (#41048)
* Added comments

Fixes freeCodeCamp/freeCodeCamp#40903

* remove comments
2021-02-11 09:13:38 -07:00
Kristofer Koishigawa c9de726d6a
feat: move Repl.it links to first challenge in backend projects (#40803) 2021-02-11 14:09:59 +05:30
gikf 6ae3735979
fix: correct tests descriptions (#40945) 2021-02-10 17:12:12 +05:30
ehsabd 9f219f3f2b
fix(learn): Fix the public assets folder confusion by giving it its own folder (#40802)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-10 17:11:40 +05:30
Kim Leung 082b269dce
fix(learn): backslashes in description & hint text (#40801)
Correct example code in description and last hints text to match the last assertion test's actual and expected inputs.  The string input with a single backslash throws an unterminated string constant error (single backslash starts a regex).  No change to last assertion test as it was written correctly with a double backslash and passing as expected.
2021-02-10 17:10:51 +05:30
Lucas Sorenson f8aa6c04e2
fix(learn): update seed code for D3.js challenge (#40699)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Lucas Sorenson <lsorenson@sunsh1n3.com>
2021-02-10 17:06:19 +05:30
Ismail Tlemçani 0f8449788c
feat(learn): add tests to use a callback function in the sort method (#40847) 2021-02-10 17:05:23 +05:30
Tom 959fe8323a
fix(learn): mongoose set up instructions (#40909)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-10 17:04:16 +05:30
Tom 51f6077f7b
fix(learn): regex-criminal-in-hunt-challenge (#40901)
* fix: regex-criminal-in-hunt-challenge

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/find-one-or-more-criminals-in-a-hunt.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-08 06:10:59 -08:00
Jean-Baptiste LARRIVIERE 1c539d07c3
fix(curriculum): remove mention of null from challenge (#40942)
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-02-08 13:17:32 +05:30
Crowdin Bot e5c44a3ae5 chore(i8n,learn): processed translations 2021-02-07 14:08:31 +05:30
Tom 15227a0148
fix(curriculum): helmet install and csp lessons (#40904) 2021-02-06 16:36:40 +00:00
Randell Dawson 167f93df76
fix(learn): Add inline code blocks to for i18n (#40921) 2021-02-05 14:16:19 +05:30
Shaun Hamilton 1a9b791f29
update(curriculum): explicitise use-the-env-file (#40898)
* update(curriculum): explicitise use-the-env-file

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-04 19:43:18 +01:00
Nicholas Carrigan (he/him) 12658d33fc
fix(i18n, learn): more crowdin fixes (#40905) 2021-02-04 13:34:44 +05:30
Tom 30c923b73d
fix(curriculum): helmet hide-powered-by description (#40900)
* fix: remove option that isn't usable in new version of helmet

* fix: make text instructional
2021-02-03 23:13:02 +00:00
Keith c21b2a9707
fix(learn): corrected typo (#40902)
Fixed typo at the end of the 4th paragraph. Changed "Others options include:" to "Other options include:".
2021-02-03 15:11:44 -08:00
Guilherme Dias Simões ddf495c335
Fix 'wrap' and 'wrap-reverse' definitions. (#40766)
The definitions for the options 'wrap' and 'wrap-reverse' were slightly wrong as can be seen by applying them to the challenge.
2021-02-03 13:01:43 -06:00
gikf 313b345611
fix: correct Rosetta Code Knight's tour solution (#40830)
* fix: correct answers in tests and descriptions

* fix: replace sample solution for correct one

* fix: missing space

* fix: improve sample solution performance
2021-02-03 12:43:29 -06:00
Nicholas Carrigan (he/him) b0bd3f5549
fix(learn): abstract comments from code (#40869) 2021-02-03 22:28:33 +05:30
Nicholas Carrigan (he/him) 4d48fb5ce7
fix(learn, i18n): crowdin issues (#40884)
Resolves a couple of issues with Crowdin parsing.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2021-02-02 14:08:32 -07:00
Oliver Eyton-Williams f4efb13a21 chore(curriculum): rename cert .markdown to .yml 2021-02-02 09:51:02 +05:30
Oliver Eyton-Williams 66b684807c chore: migrate certs from .markdown to .yml 2021-02-02 09:51:02 +05:30
Nicholas Carrigan (he/him) 427444c757
chore(learn): audit files for crowdin (#40838)
* chore(learn): audit files for crowdin

Audits the challenge text in the Responsive Web Design superblock to
account for words/phrases that should not be translated because they
refer to code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove quotes from code

Removes instances of quoted code blocks, or code blocked quotes.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: additional uncaught quote-codes

Thanks Oliver :)

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: so many quotes

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: missing punctuation

Noted in a Crowdin comment.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove more quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-01 12:56:07 -07:00
Luis H. Ball Jr 8d60aad97b
feat(curriculum): add extension tests for css-flexbox curriculum modules (#40473)
* feat(curriculum): add extension tests for css-flexbox curriculum modules

* apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* fix: reorder tests

Moves the test that asserts the presence of the follow button to the
top of the order.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-01 07:57:36 -08:00
Kim Leung a37d5f5817
fix(learn): add output type verbiage (#40589)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-01 19:41:15 +05:30
Nicholas Carrigan (he/him) 18e821bcd3
fix: remove clunky sentence (#40751) 2021-02-01 19:22:39 +05:30
Hernando Guzmán f63ca27e6a
Fix: corrected the typo (#40837)
Updated run-functional-tests-using-a-headless-browser.md to correct the typo
2021-02-01 06:52:11 -07:00
Randell Dawson 22f017caa2
fix(learn): replace single bactick with <code> tag for Crowdin (#40774) 2021-02-01 19:09:13 +05:30
Kai-Chin Huang 5503b54f85
fix(learn): update the return Object.values & solution (#40451) 2021-02-01 13:12:54 +05:30
Evan Boehs 8c22432b17
fix(learn): add period for readability (#40836) 2021-01-31 13:57:46 +05:30
Hernando Guzmán 3394a654bd
fix(learn): Correct syntax in the code example (#40811)
Closes #40810
2021-01-27 11:03:22 -08:00
gikf d41630ee19
fix(learn): clarify test description for Use Rest Parameter with Function Parameter (#40725)
* fix: clarify test description

* fix: improve wording regarding rest parameters syntax

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: improve with better sounding wording

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-24 08:30:13 -08:00
Mainak Debnath d5ad87d915
fix(learn): put test cases under --seed-- and remove them from the solution (#40755)
* fix: put test cases under --seed--

* fix: put test cases under --seed--
2021-01-21 18:26:06 -08:00
Shaun Hamilton ce3a20e552
fix(learn): change requirements for positive and negative lookaheads (#40570) 2021-01-21 15:35:19 -06:00
Lasse Jørgensen f2b1d7b147
fix(challenge): Assert arrays contain expected values (#40693) 2021-01-21 10:52:52 -08:00
Ilenia a38922536c
Adding language to code fences and pre to console logs (#40603)
* added languages to prismjs

* added language to code fences for python for everybody

* multiline pre to python for everybody questions

* multiline pre for data analysis with python

* multiline pre in numpy questions

* single line pre for python for everybody

* single line pre for data analysis with python

* single line pre for numpy

* Revert "multiline pre in numpy questions"

This reverts commit af1a02cdd3.

* fix unneded escaping

commit suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Revert "single line pre for numpy"

This reverts commit 5f90981108.

* revert changes to snippet that have a language

* one last code fence to pre

* Revert "fix unneded escaping
"

This reverts commit 64c84a9213.

* Revert "single line pre for data analysis with python"

This reverts commit 3bccaff753.

* Revert "single line pre for python for everybody"

This reverts commit 03a5379062.

* remove unnecessary escape

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-21 12:12:42 -06:00
github-actions[bot] 392005154c
chore(i8n,learn): processed chinese translations (#40752)
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2021-01-21 10:07:18 -08:00
Nicholas Carrigan (he/him) 8e62a243bb
fix(learn): Update demo links (#40575)
* fix(learn): Replace demo projects

Replaces the Heroku demo project links with the
.rocks demo projects that @moT01 provided.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(learn): Use correct endpoint

Corrects the API endpoint for the image search
project.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: user stories to align with project + backticks

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2021-01-21 11:09:35 -06:00
Durbatuluk1701 0a7aa59d51
fix(learn): Convert response testcase regex handles any variable name (#40568)
* Update convert response to JSON testcase

Testcase previously required that variable be named exactly "response". Changes will allow variable of any name to be used.
Example: res can now be used and tests still pass.

* Forgot the \ in front of )
2021-01-21 08:54:24 -08:00
matias-miller 8a9f3319c6
fix(learn): Fixed typos in count-backwards-with-a-for-loop.md (#40478)
* Spelling change in count-backwards-with-a-for-loop

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 08:44:10 -08:00
Mukesh Gurpude a5dceb3e7e
Fixed error when changing the default order of css properties (#40525)
* Bug with psoitioning

Fixed bug with positioning of background-color` property for Selector `.heart::after`

* Trying new changes

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/create-a-more-complex-shape-using-css-and-html.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Tests passing

Check the regex matching at [Regex101](https://regex101.com/r/GU18ds/4)

* fixed typo

* applied suggestions

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-21 10:17:16 -06:00
Nicholas Carrigan (he/him) 062b1cd424
fix: replace h tags (#40750)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 13:41:46 +05:30
Randell Dawson 83e3d93953
fix(learn): Remove strong syntax around code inline code (#40754) 2021-01-21 13:40:19 +05:30
Kim Leung e57f32438c
fix(learn): correct LCG equation in description (#40615)
* fix(learn): correct LCG equation in description

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/linear-congruential-generator.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/chinese/10-coding-interview-prep/rosetta-code/linear-congruential-generator.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Revert LCG equation in Chinese file

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-20 22:05:37 -08:00
Alex Soto ef394093f7
fix(learn): removing unnecessary test case for regex challenge (#40581)
Co-authored-by: Alejandro Soto <alejandro.soto@wundermanthompson.com>
2021-01-20 21:53:04 -08:00
Randell Dawson dd4c7e0097
fix(learn): Update text as code for vector-dot-product (#40460)
* fix: implemented suggestted changes

* fix: correct last test expected return value

* fix: remove slash

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: remove slash

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: add test to return null if more than 2 vectors

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: added correct solution

* fix: removed extra brackets

Co-authored-by: Yuval Levental <yhl3051@rit.edu>

Co-authored-by: Lakshya Baghel <lakshyab.1999@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Yuval Levental <yhl3051@rit.edu>
2021-01-20 21:23:10 -08:00
Ian Turner fb2e5d81f3
Add line breaks to instructions (#40425) (#40428)
* feat: add line breaks to instructions  (#40425)

* feat: add punctuation to instructions (#40425)
2021-01-20 22:19:21 -07:00
Brandon Dusch 570d9ad906
fix: updated JSON string in snippet for Python Web Services (#40742) 2021-01-20 22:09:16 -07:00
Sergey Musiyenko 0b01b73e1f
fix: a typo - TSL certificate ===> TLS certificate (#40697)
* Fixed a typo

* fix: a typo - TSL certificate ===> TLS certificate

* revert: non-English translations have to adhere to a new policy
2021-01-20 22:08:47 -07:00
Jason Liao 0b812c91e3
update task description (#40586) 2021-01-20 22:06:51 -07:00
Durbatuluk1701 b62cf73116
Correcting type on word error (#40578)
Bug Fix for #40533
2021-01-20 22:05:42 -07:00
Niraj Nair a8230fda57
Added Change this line comment (#40497) 2021-01-20 22:03:24 -07:00
Jagadeesh G 3061a5a0eb
Text in Basic Data Structures lesson is better clarified. (#40492)
* text_changes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-items-using-splice.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Jagadeesh G <17941713+GJ-16@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-20 22:02:37 -07:00
Yaseen Sayyed 3bdf143fd8
Changed the question to one with no ambiguity (#40488)
* Changed the question to one with no ambiguity

* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/jupyter-notebooks-cells.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/jupyter-notebooks-cells.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/jupyter-notebooks-cells.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-20 22:00:18 -07:00
Nicholas Carrigan (he/him) 891a64fa3d
fix(learn): Remove arrows from test name assertion (#40467)
* fix: Remove arrows from test name assertion

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Add note about time span

Adds a note regarding the expectation of the `span` element to wrap the
entire time string when translated, not just the delimiter symbol.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: use correct note syntax

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: remove note syntax

New line was breaking the build, so changing the `note` comment to be
regular text.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-20 21:57:32 -07:00
Nicholas Carrigan (he/him) b07394603b
feat(learn): Move metric imperial converter tests (#40358)
* Move tests to /learn

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Modify test verbiage

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/metric-imperial-converter.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/metric-imperial-converter.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: add missing tests

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Correct inaccurate test text - thx @ShaunSHamilton

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove arrow from test name

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-20 21:51:57 -07:00
Ismail Tlemçani d6e47037de
fix(learn): tests of the for in issue regarding the curly braces (#40344)
* fix: fix the regex of the test of the challenge

* fix: fix data structure challenge

* fix: fix data structure challenge

* fix:fix the test regex of the challenge

* fix: fix the test regex
2021-01-20 21:50:44 -07:00
Martin Milani 8e96fef862
fix(learn): Updated instructions for challenge solution for Reuse Patterns Using Capture Groups (#40658)
* Grammatically updated the instructions for the challenge

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/reuse-patterns-using-capture-groups.md

Co-authored-by: Eric Leung <eric@erictleung.com>

Co-authored-by: Eric Leung <eric@erictleung.com>
2021-01-20 19:39:23 -08:00
github-actions[bot] 7bd905f393
chore(i8n,learn): processed chinese translations (#40716)
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
2021-01-20 18:58:05 -08:00
Nicholas Carrigan (he/him) 8d8d25e9f2
fix(learn): address escaped backticks (#40717)
* fix(learn): address escaped backticks

Addresses the instances of escaped backticks - where a backtick is
preceded by a backslash.  In most cases, this was left over from the
old parser. In some cases, a backtick was intended to be wrapped in
code tags and has been adjusted accordingly.

This issue came to light due to a bug in the translation flow on
Crowdin.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: EVEN MORE :( :( :(

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: backslash nightmares

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: When you wish upon a *******

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(curriculum): md error introduced by formatter

* fix(curriculum): remove extra `s

* fix: restore quote symbol

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Typo

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: apply review changes

Applying review feedback from call with @RandellDawson.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: markdown does weird stuff sometimes

Can't stick backticks together - use code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-01-20 19:01:00 -07:00
Sergey Rufanov 5379b04387
fix(learn): Removed note about commented array from sorting algorithm challenges (#40652) 2021-01-16 12:00:10 -08:00
Vicky Zhang 594b63bc35
fix(learn): Clarify sudoku solver instructions (#40604)
* Clarify sudoku solver instructions

* decrease spaces
2021-01-16 11:58:48 -08:00
Mathieu HAAGE 1f62718f52
fix(docs): Add empty line after HTTP request headers (#40654) 2021-01-16 12:58:21 -07:00
Jeremy L Thompson a5840f57a4
Update Description of Stern-Brocot Challenge (#40686)
* fix: update description of target function

* fix: include note about 1 based indexing
2021-01-16 12:57:38 -07:00
Nicholas Carrigan (he/him) bab54ad619
fix(learn): no capital code block (#40688)
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-16 12:54:38 -07:00
majkelmichel 3ecdfe87d7
Update create-a-form-element.md (#40720)
Improved wording in Description and Instructions sections
2021-01-16 12:25:13 -07:00
Thomas fc976aba74
fix(learn): Change example text in create-a-form-element.md (#40542)
* Update create-a-form-element.md

Update example. For issue 40523

* Clearer formatting of example
2021-01-16 01:11:47 -08:00
Xing Liu 2cbb30a2f3
partial translation of basic-javascript (#40689) 2021-01-13 10:11:33 -07:00
Oliver Eyton-Williams ee1e8abd87
feat(curriculum): restore seed + solution to Chinese (#40683)
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-12 19:31:00 -07:00
Steven Ding ab222e31e7
an audit for some changes (#40680) 2021-01-12 09:31:18 -07:00
ZhichengChen 797cc3024e
Update Chinese translation of fornt-end-libraries (#40653)
* Update Chinese translation of fornt-end-libraries

* fix: revert to previous translation

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-12 09:22:19 -07:00
Xing Liu 306e4aaacf
add translation of algorithm and data structures (#40678) 2021-01-12 09:18:51 -07:00
Nicky Xu a469138ae4
feat: audit for data visualization projects (#40612)
* feat: audit for data visualization projects

* feat: translate data visualization curriculum
2021-01-12 08:56:49 -07:00
Xing Liu 05ba7c3482
Chinese translation of responsive-web-design (#40607) 2021-01-08 12:20:48 -07:00
miyaliu666 9770cd0f81
translated some Chinese curriculum files (#40531)
* translate task #1 - #4

* add translation of zhang-suen-thinning and markov algorithm

Co-authored-by: S1ngS1ng <liuxing0514@gmail.com>
2021-01-08 11:59:18 -07:00
Ilenia 7de8549e02
fix(learn): Made the Escaping literal quotes channel accept the dot inside the double quotes too (#40465)
* made valid solution dot inside and dot outside quotes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escaping-literal-quotes-in-strings.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-12-16 08:07:47 -08:00
Randell Dawson 9ce4a02a41
chore(learn): Applied MDX format to Chinese curriculum files (#40462) 2020-12-16 13:07:30 +05:30
Lakshya Baghel 036da8cd0c
Fixed seed-contents for react componentDidMount challenge (#40441) 2020-12-15 18:19:58 -07:00
Nicholas Carrigan (he/him) 582d3ab93f
fix(learn): Headless Browser Tests have incorrect values (#40330)
* Restructure files

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Realign forum topic ids

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Missed query string numbers

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Test all previous tests

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Fix the semi-colon

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* change test name to match boilerplate change

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-12-15 19:17:25 -06:00
Kai-Chin Huang a1928ba272
Update the return value of values method in create a set class challenge (#40450)
* fix #40443

* Fix the solution add method
2020-12-15 18:15:33 -07:00
vbinithyanandamv 7c19c82076
[BUG] Able to pass challenge "Basic JavaScript: Initializing Variables with the Assignment Operator" with incorrect answers #40406 (#40409)
* [BUG] #40406 Fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/initializing-variables-with-the-assignment-operator.md

Requested Change.

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-12-15 18:07:36 -07:00
Oliver Eyton-Williams 0bd52f8bd1
Feat: add new Markdown parser (#39800)
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
ngschaider 6c5304980d
fix(learn): type checking and additional test for isBalanced binary search tree (#40323)
* Update find-the-minimum-and-maximum-height-of-a-binary-search-tree.md

* fixed binary search tree values for balanced tree test

* Apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-26 22:33:45 -06:00
Jennifer Garst 4079a197fe
fix(learn): clarify gradient description (#40322)
* fix: clarify gradient description

* Apply suggested changes

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-26 22:33:03 -06:00
Shaun Hamilton 493880ffaf
feat(learn): add mocha and chai instructions (#39976)
* feat(learn): add mocha and chai instructions

* test: added one new lesson

* rename added file and add tests

* add meta to prettierignore, fix formatting

* add unit-test numbering

* add examples from boilerplate

Co-authored-by: Randell Dawson <rdawson@onepathtech.com>

* remove code comments, add description

* elaborate test testStrings

Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
2020-11-26 10:05:42 -08:00
Oliver Eyton-Williams 25429b9f3f
fix: update linter for new challenge format (#40317)
Also uses yaml for better vscode integration
2020-11-26 17:42:57 +05:30
Ilenia f294d9cacc
fix(learn): removed use strict from various challenges (#40321) 2020-11-25 15:59:04 -08:00
Timo Köhler 7ce8c58709
Put value into quotes (#40172)
* Put value into quotes

It can be missunderstanding that "value" is a string!

* fix: remove quotes from inside code tags

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-25 16:32:14 -06:00
Nicholas Carrigan (he/him) 49f6875db5
fix(learn): ES6 Getters + Setters tests (#40238)
* Strengthen tests

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Improve verbiage

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Add second check to setter test

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-11-25 14:22:44 -08:00
Nicholas Carrigan (he/him) ec8b2dc016
feat(learn): Message Board User Stories (#40219)
* Update verbiage, add instructions

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Remove unit test mention

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* Move test descriptions to learn

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* target blank on gh link

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2020-11-25 14:11:38 -08:00