Commit Graph

115 Commits (62713f0e10425eac49aaec91f123c53cc3e775d2)

Author SHA1 Message Date
lucia montero c03beb3ca6
Fix tests to allow spaces in "Sass: Create Reusable CSS with Mixins" (#40230)
* Fix tests to allow spaces. Closes #40212

* Apply suggestions from code review

Remove redundant whitespace from regex

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-11-15 00:14:47 +01:00
Amy Surrett 1ef49d2c57
fix(learn): add note about tweet button restrictions (#40118)
* fix: add note about tweet button restrictions

* fix: added target blank and top hint
2020-11-14 11:52:48 +00:00
Oliver Eyton-Williams 35c4020f4d
fix(curriculum): test typos (#39984) 2020-10-15 14:49:57 -04:00
Haraman Johal 41d40608a1
fix(learn): reword incorrect line reference (#39742) 2020-10-01 04:26:43 -07:00
Oliver Eyton-Williams 2b9e38a17b
fix: replace .english.md extension with .md 2020-09-29 22:09:04 +02:00
Walter Palagi 3d7af80047
fix(learn): React propTypes challenge, improve test text (#39682)
* In React propTypes challenge, improve test text

Fixes #39204

* Remove code tags around "number"

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-24 23:11:05 -07:00
Sky020 a86b220eb7 chore: remove isRequired from curriculum files 2020-09-21 20:51:46 +05:30
Hassaan Pasha 80438cac3e
feat(client, learn): add helper functions for common validation operations (#38605)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-17 19:38:01 +05:30
Randell Dawson 30c61b808b
fix: consolidate misc comments (#39583) 2020-09-16 13:29:50 -05:00
Oliver Eyton-Williams d7dc1acb4a chore: update lang tags on code blocks 2020-09-16 11:54:08 +05:30
Randell Dawson a2f4c8d0e1
fix: consolidated comments for use with translation dictionary (#39578) 2020-09-15 22:23:25 +05:30
Kristofer Koishigawa c11bf0d02e
fix(curriculum): restrictive test for use map to dynamically render challenge (#39581) 2020-09-15 08:23:48 -07:00
Randell Dawson 0f5832b562
fix: project 25 + 5 (#39526) 2020-09-09 13:28:12 +05:30
Oliver Eyton-Williams bd68b70f3d
Feat: hide blocks not challenges (#39504)
* fix: remove isHidden flag from frontmatter

* fix: add isUpcomingChange

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* feat: hide blocks not challenges

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2020-09-03 15:07:40 -07:00
Shaun Hamilton 223c2dc205
fix: convert async tests to synchronous (#39478)
* fix: convert async tests to sync

* fix: correct formatting changed by prettier
2020-09-02 19:24:22 -05:00
Ashraf Nazar 70f1ebd2fc
fix(curriculum): regex to target html elements using jQuery to captur… (#38649)
* fix(curriculum): regex to target html elements using jQuery to capture white spaces

* replace whitespace before test

* fix linting issue with single quotes

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-08-31 20:24:43 -05:00
CheongJY a294021d53
fix: remove whitespace before testing (#39420)
* Proposed change to remove whitespace for issue #39370

Issue #39370: whitespace fails the 3rd test with test comparing to a no whitespace example.
Proposed: remove all whitespace in between tags(or literally all whitespaces) before comparing it with the no whitespace example

* Update render-state-in-the-user-interface.english.md

* Updated proposed change to remove whitespace 

An update to previously proposed change due to failed test of 'unexpected token \'<\'' was thrown'

* Update curriculum/challenges/english/03-front-end-libraries/react/render-state-in-the-user-interface.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* fix: linting issue

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-01 01:15:22 +01:00
Aviel212 fb77d48d13
curriculum: add test in React challenge to detect constructor call (#39304)
* fix: resolve #39301

Add a test to check the "MyComponent" constructor's parameters (params) and to check that the super function exists in the constructor.

* docs: describe the test better

* Update curriculum/challenges/english/03-front-end-libraries/react/write-a-react-component-from-scratch.english.md

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2020-08-25 08:41:35 -07:00
ML 9a4976bd57
fix(curriculum) typo in Create Reusable CSS (#39418)
Fixed a typo on the Sass Challenge "Create Reusable CSS with Mixins" where the word "vendor" was spelled incorrectly as "vender" in the test cases.
2020-08-16 18:33:34 -07:00
Ruchi Kushwaha 35c3609489
fix:Incorrect Usage of setState in React Challenge (#39290)
* fix:Incorrect Usaage of setState in React Challenge

* apply suggestion

* also set stage usage in other challenges

* fix setState usage in challenges

* correct syntax

* correct usage of useState in other files

* add current message to state

* remove current message from state

* change connect redux to the message app

* remove extra space
2020-08-11 10:12:27 -07:00
anthony 20d397f719
remove MDN links from English challenges (#39337)
* remove MDN links from English challenges

* add push challenge reference to record-collection

* refactor truthy falsy verbiage

* replace MDN link with news link

* remove unnecessary whitespace
2020-07-31 15:19:49 +09:00
Ayush Kumar 53cbe66c1a
Changed variable renderOnlineUsers to renderOnline in soluion seed. (#39229)
In the challenge seed renderOnline variable has been used and referenced but in the solution seed the variable has been changed to renderOnlineUser so, changed renderOnlineUsers back to renderOnline variable.
2020-07-23 23:35:01 -07:00
Himanshu maurya 07e665052d
Fixed-pass-an-array-as-props (#39268)
* Fixed-pass-an-arrays-props

* Fixed:pass-an-array-as-props2

* Update curriculum/challenges/english/03-front-end-libraries/react/pass-an-array-as-props.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/03-front-end-libraries/react/pass-an-array-as-props.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/03-front-end-libraries/react/pass-an-array-as-props.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-07-17 13:11:16 -07:00
Randell Dawson 8ebb4922d4
fix(learn): updated catphotoapp links (#39215) 2020-07-15 15:26:49 +05:30
Oliver Eyton-Williams f1c9b08cf3 fix(curriculum): add isHidden: false to challenges
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
Oliver Eyton-Williams 5e56a9a938
Feat(curriculum): scss not sass (#38764) 2020-05-09 20:01:18 +05:30
Shaun Hamilton b1de8ee4f8
fix(curriculum): change project codepen links (#38746) 2020-05-06 19:53:27 +05:30
Iván Franco 1d87dd82e3
updated english file (#38482) 2020-04-11 22:52:54 -05:00
Ashraf Nazar a2d31afe81
fix: Update test in Redux challenge to accomodate backticks (#38345) 2020-03-10 12:15:50 +03:00
kundan kumar 971c62ab53
fix : Unclear test output use-array.map-to-dynamically-render-… (#38191) 2020-02-13 02:41:36 +05:30
Hassaan Pasha 2f951f0dff
fix: edited the duplicate test guideline to mirror the actual… (#38199) 2020-02-12 20:47:24 +05:30
Josh Soref 004b99bf8f chore: fix typos in spelling (#38100)
* spelling: accidentally

* spelling: announce

* spelling: assembly

* spelling: avoid

* spelling: backend

* spelling: because

* spelling: claimed

* spelling: candidate

* spelling: certification

* spelling: certified

* spelling: challenge

* spelling: circular

* spelling: it isn't

* spelling: coins

* spelling: combination

* spelling: compliant

* spelling: containers

* spelling: concise

* spelling: deprecated

* spelling: development

* spelling: donor

* spelling: error

* spelling: everything

* spelling: exceed

* spelling: exist

* spelling: falsy

* spelling: faulty

* spelling: forward

* spelling: handle

* spelling: indicates

* spelling: initial

* spelling: integers

* spelling: issealed

* spelling: javascript

* spelling: length

* spelling: maximum

* spelling: minimum

* spelling: mutable

* spelling: notifier

* spelling: coordinate

* spelling: passport

* spelling: perform

* spelling: permuter

* spelling: placeholder

* spelling: progressively

* spelling: semantic

* spelling: submission

* spelling: submit

* spelling: translations

* spelling: turquoise

* spelling: visualization

* spelling: without

* spelling: registration

* spelling: representation
2020-02-08 23:59:10 +05:30
Kiara Barias afd467f5dc
Removes RSA links from English challenges (#37869)
* RSA links deleted from challenges

* fix: remove remaining RSA links in challenges
2020-02-07 14:46:07 +09:00
Nick Black 6a4b42c4ec
Update to make instructions more clear (#38068)
The instructions on the exercise following this specify 'behind the scenes' which sounds more clear than 'in the background'.
2020-02-04 10:54:02 +03:00
M B 7f6a653c28 fix: update react lesson link (remove 404) (#38031)
* Update lesson link (remove 404)

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-01-09 17:29:50 +01:00
Randell Dawson 6809578044 fix: change starting font-size (#37981) 2020-01-07 13:39:06 +03:00
Randell Dawson 44ff327a38 fix(curriculum): make test more flexible for (#37902)
* make test more robust

* fix: changed test to ignore extra spaces in html

* Revert "make test more robust"

This reverts commit 89718eb5e5.
2019-12-11 23:20:19 -05:00
Randell Dawson 6fc32ab9b6 fix(curriculum): changed test text to use should for Front End Libraries (#37762)
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-22 13:44:40 +01:00
Lowell Hamilton 301d03df7b Update add-font-awesome-icons-to-all-of-our-buttons.english.md (#37668)
The thumbs up from the previous challenge was removed from the seed in an earlier merge -- seems like it should be there since the instructions only say to add the icons to the remaining buttons.
2019-11-19 20:12:15 -05:00
Mo Zargham 437ba8b103 fix(curriculum): Read-search-ask link now point to correct url as noted in the issue (#37753)
* fix: broken Read-search-ask link now point to correct url

* fix: changed link to original forum link with more views

* fix: changed http links to correct version

* fix: link in help modal
2019-11-19 19:54:48 -05:00
Lowell Hamilton 73943994ff Update add-font-awesome-icons-to-our-buttons.english.md (#37667)
Correct typo in instructions  -- says to add the "fa" class instead of the "fas" class.
2019-11-17 07:55:39 -08:00
Ananda Umamil 734b794714 fix: update react proptypes lesson description (#37477) 2019-11-05 00:42:07 -05:00
Roberto Ruccia 36de803902 Fix link in use-proptypes-to-define-the-props-you-expect.english.md (#37665)
* Fix link in use-proptypes-to-define-the-props-you-expect.english.md

* Add a blank line before Note line
2019-11-01 20:22:19 -05:00
SomeDer bfa5c26288 fix: use dfn instead of code tag (#36640)
* Use dfn tags

* remove misused <dfn> tags

* Revert "remove misused <dfn> tags"

This reverts commit b24968a968.

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/fill-in-the-blank-with-placeholder-text.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Make "array" lowercase

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Fix dfn usage

* Address last dfn tags
2019-10-27 12:45:37 -04:00
csteacher1 1a019f952b Added hyphen to "coopted" on Line 17 (#37468)
* Added hyphen to "coopted" on Line 17

Added a hyphen to the word"coopted" to correct it to "co-opted" on Line 17.

* Update curriculum/challenges/english/03-front-end-libraries/jquery/change-text-inside-an-element-using-jquery.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-10-25 13:47:05 -05:00
Johnny Zabala e9bbcc55cd test rendered output instead of state in react write a simple counter challenge (#36791) 2019-10-09 09:52:41 -05:00
SomeDer 5de58ad98d fix(curriculum): use function form of this.setState (#36623)
* Fix solution

* Update description

* Add test for this.setState function syntax

* Update toggle element instructions

* Fix simple-counter solutions

* Fix bind-this challenge seed and solution

* Fix && challenge seed and solution

* Fix ternary challenge seed and solution

* Use the function form -> Pass a function

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Mention "passing a function" instead of "alternative form"

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Rephrase explanation

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* clarify why functions should be used

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Improve tests

* Fix \s escaping in []

* Improve regex

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add test for `this`

* Use block code

* Update bind-this challenge

* Fix last part of instructions

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-09-24 08:12:50 -07:00
Oliver Eyton-Williams 3a0cd56ad3 fix(curriculum): Add and modify tests to catch bad code. (#36429) 2019-09-20 09:28:50 -07:00
Kaitlin 76e1b1a4ba Update user test 13 desc to match changed test (#36523)
* Update user test 13 desc to match changed test

Refer https://github.com/freeCodeCamp/testable-projects-fcc/issues/933.

* Add examples to illustrate change to user story 13
2019-09-19 17:51:10 +09:00
Tom 428ab97650 Fix/tests whitespace strictness (#36706)
* fix(tests): make less strict about white space
2019-08-28 10:53:17 +02:00