Commit Graph

71 Commits (6f744e063e6a0adf73ccf48720fe8a48feee313d)

Author SHA1 Message Date
Sem Bauke b064991667
fix(curriculum): Replace single-line blocks with multi-line blocks for Responsive Web Design (#41519)
* fix(curriculum) replace single-line block with multi-line blocks

* fix(curriculum) replace single-line block with multi-line blocks (missed blocks)
2021-03-18 17:24:09 -06:00
Randell Dawson f4bbe3f34c
fix(learn): Updated code blocks to help with translation on two challenges (#41217) 2021-02-22 11:21:59 +05:30
Nicholas Carrigan (he/him) 427444c757
chore(learn): audit files for crowdin (#40838)
* chore(learn): audit files for crowdin

Audits the challenge text in the Responsive Web Design superblock to
account for words/phrases that should not be translated because they
refer to code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove quotes from code

Removes instances of quoted code blocks, or code blocked quotes.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: additional uncaught quote-codes

Thanks Oliver :)

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: so many quotes

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: missing punctuation

Noted in a Crowdin comment.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove more quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-01 12:56:07 -07:00
Mukesh Gurpude a5dceb3e7e
Fixed error when changing the default order of css properties (#40525)
* Bug with psoitioning

Fixed bug with positioning of background-color` property for Selector `.heart::after`

* Trying new changes

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/create-a-more-complex-shape-using-css-and-html.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Tests passing

Check the regex matching at [Regex101](https://regex101.com/r/GU18ds/4)

* fixed typo

* applied suggestions

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-21 10:17:16 -06:00
Oliver Eyton-Williams ee1e8abd87
feat(curriculum): restore seed + solution to Chinese (#40683)
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
2021-01-12 19:31:00 -07:00
Oliver Eyton-Williams 0bd52f8bd1
Feat: add new Markdown parser (#39800)
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
Jennifer Garst 4079a197fe
fix(learn): clarify gradient description (#40322)
* fix: clarify gradient description

* Apply suggested changes

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2020-11-26 22:33:03 -06:00
Steven Walker 2645fae939
fix(learn): updated instructions to be explicit (#40131) 2020-10-31 19:53:30 +01:00
steviehailey b503333c64
Rephrase linear gradient explanation (#39990)
* Rephrase linear gradient explanation

Small tweak to explanation to remove ambiguity over horizontal vs vertical

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/create-a-gradual-css-linear-gradient.md

Code review suggestion - mention horizontal and quote the values

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Use code tag for snippets

Was using backtick but updated based on formatting guidelines - https://contribute.freecodecamp.org/#/how-to-work-on-coding-challenges?id=formatting-challenge-text

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-10-19 11:01:03 -07:00
Ollie e22adfcc6b
fix(learn): Update the regex in Adjust the background-color Property (#39907)
* fix: Updated the regex in background-color test

As mentioned by @Skye020 in issue #39823, I have made the semi-colon after the background-colour declaration optional, but only if it is the last declaration in the scope.

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/adjust-the-background-color-property-of-text.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-10-09 11:09:33 -07:00
Oliver Eyton-Williams 2b9e38a17b
fix: replace .english.md extension with .md 2020-09-29 22:09:04 +02:00
Hassaan Pasha 80438cac3e
feat(client, learn): add helper functions for common validation operations (#38605)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-17 19:38:01 +05:30
Ajeeth thangarasu 8223903aac
Removed 'videoUrl' (#39601) 2020-09-16 19:04:58 -07:00
Oliver Eyton-Williams bd68b70f3d
Feat: hide blocks not challenges (#39504)
* fix: remove isHidden flag from frontmatter

* fix: add isUpcomingChange

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* feat: hide blocks not challenges

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2020-09-03 15:07:40 -07:00
Tom e48664af2a
fix(learn): font size multiple headings exercise (#39511)
* fix: use regex to capture font-size of h6 element, as minimum font-size of browsers may influence outcome

* fix: add suggested changes

Co-authored-by: Ashraf Nazar <ashraf.caspian@gmail.com>
2020-09-02 18:11:23 +01:00
Shaun Hamilton fe3f0b2ac4
fix: remove quotation marks from code tag text (#38316) 2020-08-30 22:53:09 -05:00
law27 b88c8ab351
Update use-the-s-tag-to-strikethrough-text.english.md (#38515)
Alphabet word is not wrapped inside double quotes

Co-authored-by: LawranceMichaelite <40236169+LawranceMichaelite@users.noreply.github.com>
2020-08-30 22:08:51 -05:00
Randell Dawson 8ebb4922d4
fix(learn): updated catphotoapp links (#39215) 2020-07-15 15:26:49 +05:30
Oliver Eyton-Williams f1c9b08cf3 fix(curriculum): add isHidden: false to challenges
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
Hassaan Pasha 3a47c5411f
fix (curriculum): made the order of the required code to be re… (#38320)
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-03-06 12:44:39 +05:30
Ashraf Nazar 181ac1e8ad
fix: Update test for wrapping strong tag around text to include periods at the end (#38305) 2020-02-29 01:02:39 -05:00
Randell Dawson 41718abf76
fix(learn): consolidate comments for responsive web design cert (#38256)
Related to PR #38040

This PR is an attempt to consolidate/remove as many comments in the challenge seed code in the Responsive Web Design certification challenges, to be able to create a small translation lookup object for translating the English comments to other languages.
2020-02-27 20:50:46 +05:30
Tom 0adfc79c7a fix: fixed position challenge (#37945) 2020-01-02 17:41:36 -07:00
Randell Dawson 5609a1303e fix: corrected tests for 3 challenges (#37948) 2019-12-19 11:26:50 +01:00
lasjorg 63b9be8faf fix(challenge): account for browser zoom, add note to challenge (for width challenge) (#37688)
* fix(challenge): account for browser zoom, add note to challenge

* fix(challenge): use regex for width assert

* fix(challenge): remove note

* fix(challenge): revert to initial PR code

* updated regex, add check for maxWidth
2019-12-13 07:05:23 -08:00
Randell Dawson d39dd970b6 fix(curriculum): use regex to avoid differences in how browsers calculate style property values for Decrease Opacity of an Element challenge (#37838)
* fix: use regex to avoid diff in browsers

* fix: improve regex
2019-12-02 20:50:34 +05:30
lasjorg ba927090fe fix(challenge): account for browser zoom, add note to challenge (for height challenge) (#37687)
* fix(challenge): account for browser zoom, add note to challenge

* fix(challenge): use regex for height assert

* fix(challenge): remove note

* fix(challenge): revert to initial PR code
2019-11-25 19:40:21 -08:00
Randell Dawson 9bf3fdbf38 fix(curriculum): changed challenge test text to use the word should for Responsive Web Design (#36860)
* fix: changed challenge test text to use should

* fix: changed have to be used in

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: reworded test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: improved test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: improved test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed have the to be used in

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected verbiage

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-11-20 20:15:19 +05:30
Randell Dawson 55f95c2f74 fix(curriculum): Allow leading to zero before decimal point to be optional for opacity value (#37715)
* fix: allow-leading-zero-to-be-optional-before-decimal-point-for-opacity

* fix: use getComputedStyle intead of regex

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-13 14:39:03 -06:00
Daniel Veazey 9e1b2b7401 fix(curriculum) correct "an" to "a" (#37726)
* replace the word "dashes" with "hyphens"

* correct "an" to "a"
2019-11-09 18:13:10 -05:00
lasjorg 316d56ba11 fix(challenge): use offsetHeight to get height value (#36995) 2019-10-27 19:02:53 -04:00
SomeDer bfa5c26288 fix: use dfn instead of code tag (#36640)
* Use dfn tags

* remove misused <dfn> tags

* Revert "remove misused <dfn> tags"

This reverts commit b24968a968.

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/fill-in-the-blank-with-placeholder-text.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Make "array" lowercase

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Fix dfn usage

* Address last dfn tags
2019-10-27 12:45:37 -04:00
Randell Dawson 568f00e02a fix(curriculum): Added forumTopicId to remaining 1200 challeng… (#36558) 2019-08-05 22:14:37 +05:30
Randell Dawson ba6ae7154c fix: removed more assert msg arguments (#36439) 2019-07-28 05:16:04 +01:00
Randell Dawson e763330fc3 fix: removed assert msg argument (#36405) 2019-07-24 11:42:26 +02:00
Randell Dawson c387873640 fix(curriculum): added extra line before </section> tag - Engl… (#36278) 2019-07-19 15:30:17 +05:30
Ahmad Abdolsaheb 8b4fb5a452 fix: imgur to s3 for various files without conflict (#36057) 2019-05-20 23:58:20 +05:30
Randell Dawson df8659ab8c fix(curriculum): Convert blockquote elements to triple backtick syntax for Responsive Web Design (#35993)
* fix: converted blockquotes to code fences
2019-05-14 10:11:58 +02:00
Randell Dawson 48884f3a4a fix: changed to h4 > s in selector (#36023) 2019-05-11 19:09:08 -05:00
Huyen Nguyen 5b32e98c4a fix(curriculum): Add solutions to Applied Visual Design challenges (#35815)
* fix: add solutions to Applied Visual Design challenges

* fix: remove extra opening style tag
2019-04-28 13:13:38 -05:00
Astrid 9ee8b4fa57 fix: minor grammar mistake in 'applied visual design' challenge (#35839)
fix: revert changes to package-lock.json
2019-04-15 14:05:30 +05:30
Paul Gamble bddcda5559 added html solution for testing - responsive-web-design/applied-visual-design/decrease-the-opacity-of-an-element (#35516)
* added html solution for testing

* fix: corrected invalid solution
2019-04-12 18:17:12 +02:00
Roberto Ruccia 91f4865ab4 Fix typo in curriculum/challanges/english/01-responsive-web-design/applied-visual-design/use-the-css-transform-scale-property-to-scale-an-element-on-hover.english.md (#35743) 2019-04-02 21:43:27 -04:00
rupali317 bc72c86dc6 fix: updated the note sections for responsive web design english (#35528) 2019-03-22 15:02:12 +01:00
Shashank Bairy R f313c094cb fix: clarify how to create multiple box shadows (Issue: #35534) (#35555)
* fix: clarify how to create multiple box shadows

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/add-a-box-shadow-to-a-card-like-element.english.md

<code> tags added to 'color' property in order to make it look more consistent with the other propertes of 'box-shadow'.

Co-Authored-By: BA1RY <shashank.bairy04@gmail.com>
2019-03-20 15:32:53 +01:00
nik 304d36ab47 fix(challenge): decrease opacity testString (#34711) 2019-03-05 12:11:27 -05:00
Randell Dawson b7fee2848c fix(curriculum): Corrected test which allowed wrong solution to pass (#35394)
* fix: corret-wrong-checks-in-test

* fix: improved robustness of test

* fix: added a full working solution for challenge

* fix: added && to asssert
2019-03-04 12:33:02 -06:00
Randell Dawson 6db2e12e9e fix: Removed unnecessary note from instructions (#35502) 2019-03-03 23:56:22 -06:00
lasjorg 25ea44edf5 fix(challenge): allow new line in linear-gradient formatting (#35435)
* fix(challenge): allow new line in linear-gradient formatting

* fix(challenge): update test with suggested changes

* fix(challenge): update test to use computed style
2019-03-03 19:32:41 -06:00
The Coding Aviator cbd1ebd4f5 Remove extra empty line from Applied Visual Design Challenge (#35241)
* Remove extra empty line

* fix(client): Removed extra line
2019-02-25 22:00:00 -05:00