Commit Graph

1222 Commits (71fbf2b658a7ef443d1b36ece32795b98d1dee24)

Author SHA1 Message Date
Randell Dawson 3e237f43ad fix: removed assert msg argument-3 (#36417) 2019-07-26 21:30:17 -05:00
Randell Dawson 399705a37a fix: removed assert msg argument-2 (#36416) 2019-07-26 21:26:37 -05:00
Randell Dawson 04f18e43f6 fix(curriculum): Remove unnecessary assert message argument from English Coding Interview Prep challenges - 02 (#36412)
* fix: removed assert msg argument

* fix: removed msgs surrounded by 2 single quotes

* fix: removed missing 2 assert msg arguments

* fix: remove msg surrounded by two single quotes

* fix: removed unnecessary assert msg args

* fix; remove msgs surrounded by double quotes

* fix: removed unnecessary assert msg args

* fix: remove unnecessary assert msg args

* fix: removed unnecessary assert msg arg

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg arg

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg args

* fix: removed unnecessary assert msg arg

* fix: removed unnecessary assert msg args

* fix: Restore expected values to assertions

* fix: remove assertion message

Co-authored-by: Vivek Agrawal <vivekmittalagrawal@gmail.com>
2019-07-26 14:24:52 +02:00
Randell Dawson d73b94133a fix: removed assert msg argument (#36415) 2019-07-25 17:44:15 +02:00
Randell Dawson 61baeb0cd6 fix(curriculum): Remove unnecessary assert message argument from English Coding Interview Prep challenges - 01 (#36410)
* fix: removed assert msg argument

* fix: remove msg surrounded by two single quotes

* fix: remove assert msg surrounded by double quotes

* fix: remove msg surrounded by double quotes
2019-07-25 08:56:32 +02:00
Randell Dawson a53d992613 fix(curriculum): Remove unnecessary assert message argument from English Front End Libraries challenges - 01 (#36408)
* fix: removed assert msg argument

* fix: removed more assert msg args

* fix: removed assert msg missed

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: correct indentation
2019-07-25 08:53:37 +02:00
Randell Dawson cbbfc08108 fix: removed more assert msg args (#36441) 2019-07-24 13:13:06 +01:00
Randell Dawson ee97fa4542 fix(curriculum): Remove additional unnecessary assert message argument from English Coding Interview Prep challenges (#36440)
* fix: removed more assert msg args

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: remove single quotes wrapping testString

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-07-24 13:09:23 +01:00
Randell Dawson f2df76c099 fix(curriculum): Remove unnecessary assert message argument from English Front End Libraries challenges - 02 (#36409)
* fix: removed assert msg argument

* fix: removed more assert msg args

* fix: removed more assert msg args
2019-07-24 13:07:46 +01:00
Randell Dawson d0d8282f86 fix(curriculum): Remove additional unnecessary assert message argument wrapped in double quotes from various curriculum sections (#36457)
* fix: remove double quoted assert msg arg - responsive

* fix: remove double quoted assert msg arg - js

* fix: remove double quoted assert msg arg - libraries

* fix: remove double quoted assert msg arg - coding interview
2019-07-24 13:06:12 +01:00
Randell Dawson 8e6c26f271 fix: removed assert msg argument (#36407) 2019-07-24 12:54:35 +02:00
Randell Dawson 87615d2a7b fix: removed assert msg argument (#36406) 2019-07-24 11:50:51 +02:00
Randell Dawson e763330fc3 fix: removed assert msg argument (#36405) 2019-07-24 11:42:26 +02:00
Randell Dawson 1fa0dcb1e1 fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 04 (#36404)
* fix: rm assert msg OOP

* fix: rm assert msg regular expressions
2019-07-24 11:32:04 +02:00
Randell Dawson d78168f7db fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 03 (#36403)
* fix: rm assert msg basic-data-structures

* fix: rm assert msg intermed-algo-scripting

* fix: rm assert msg data-structures projects
2019-07-24 10:56:38 +02:00
Randell Dawson 5bf8527523 fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 02 (#36402)
* fix: rm assert msg basic-algorithm-scripting

* fix: rm assert msg debugging

* fix: rm assert msg es6

* fix: rm assert msg functional-programming
2019-07-24 10:47:32 +02:00
Oliver Eyton-Williams 55b5d22d68 fix: use rounding to fix floating point comparison 2019-07-22 17:10:54 +05:30
Oliver Eyton-Williams 6078081a3f feat: Add guide article and update its challenge (#36371)
* feat: Add guide article and update its challenge

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/javascript-algorithms-and-data-structures/basic-javascript/replace-loops-using-recursion/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Stop hints from being hidden

* fix: Improve the wording.

* Update index.md

Fixed per suggestion

* Update index.md

Fixed per suggestion
2019-07-19 16:14:28 -05:00
Oliver Eyton-Williams b8593326b0 fix: remove guide linting and fix failing challenges 2019-07-19 15:30:17 +05:30
Oliver Eyton-Williams 7d4dc382b4 fix(curriculum): format challenge markdown as per linting rules (#36326)
* fix: Format challenge markdown according to linting rules

* fix: Put spaces after section tags
2019-07-19 15:30:17 +05:30
Randell Dawson c387873640 fix(curriculum): added extra line before </section> tag - Engl… (#36278) 2019-07-19 15:30:17 +05:30
Ashrith Reddy 8e9014214a made semi-colon on basic-javascript challenge optional. (#36465)
* made closing operator optional.

* truncated unnecessary regex
2019-07-18 08:07:17 -07:00
Randell Dawson e9212c61d2 fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 01 (#36401)
* fix: rm assert msg basic-javascript

* fix: removed more assert msg args

* fix: fixed verbiage

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-07-13 08:07:53 +01:00
moT01 9ce8bbb4c0 fix/add-suggested-grammar-and-punctuation 2019-07-12 22:44:23 +09:00
moT01 d3cf6f42dd fix/grammar+punctuation 2019-07-12 22:44:23 +09:00
moT01 6f24bc5d41 fix/capitalization-in-title-in-meta 2019-07-12 22:44:23 +09:00
moT01 fa365a7f77 fix/capitalization-in-title 2019-07-12 22:44:23 +09:00
moT01 832cbc91b1 fix/the-mess-I-made 2019-07-12 22:44:23 +09:00
moT01 da254743cd feat/new-lessons-on-js-promises 2019-07-12 22:44:23 +09:00
Randell Dawson 73bdff45fd fix(curriculum): Added a Recursion challenge to the Basic JavaScript section (#35968)
* fix: added a recursion challenge

* fix: changed blockquote to triple backtick syntax

* fix: added an extra line to separate code section

* fix: renamed challenge and improved verbiage

* fix: added full path to challenge

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: improved wording

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added closing )

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added missing comma and the word at

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added missing text for test case

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added note regarding startNum and endNum being same

* fix: wrapped parameter names with code tags
2019-07-12 13:40:50 +02:00
Randell Dawson db8098601e fix(curriculum): Remove unnecessary assert message argument from English Data Visualization challenges (#36424)
* fix: removed assert msg argument

* fix: corrected test text
2019-07-11 10:53:41 +02:00
lasjorg f03f05d53d fix(challenge): rename challenge, change fields to properties, fix test (#36338)
* fix(challenge): rename challenge, change fields to properties, fix test

* fix(challenge): update challenge name in meta.json

* fix(challenge): update test and assertion message

* fix(challenge): update second assert message

* fix(challenge): remove the word Person from text
2019-07-10 10:31:15 +02:00
Greg Fletcher 61588df778 fixed grammar: removed middlewares (#36392)
* fix: Improved grammar

Replaced 'middlewares' to 'middleware functions'.  Middleware is an uncountable noun, just like 'software'.  No such word as 'softwares'

* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/serve-static-assets.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-07-09 14:38:25 -04:00
Saad Monem d9cccd6d74 Fixed typos in description of challenge: "Use a Template Engine's Powers" (#36395)
* Fixed typos in template engine challenge

* Incorporated suggestions into updated description

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Incorporated new suggestion

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-07-09 14:36:47 -04:00
Tiago Salema e561953827 Removed deprecated lifecycle methods (#35895)
Removed `componentWillReceiveProps` and `componentWillUpdate` from the list of lifecycle methods since they are now deprecated.
2019-07-03 13:56:15 +02:00
organicdude f65eea3dd6 Increase language clarity in challenge "Basic Javascript: Iterate Through an Array with a For Loop" (#36081)
* Increase language clarity in the challenge.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix/make-suggested-changes-on-behalf-of-author

* fix/add-empty-line-back-in
2019-07-03 15:13:25 +05:30
Fabricio Asfora Lira a32f719d3a Fix/add a stricter test for the Add Placeholder Text to a Text Field challenge (#36186)
* fix: add test for input closing tag

* fix: add condintion to final syntax test

This wil test if there's any character after the input tag that isn't a white space

* fix/tests+remove-not-needed-text
2019-07-02 19:30:12 -04:00
Prashanth Ashok Ramkumar b68f752847 Adding solution for queue class (#36319) 2019-07-02 07:45:42 -07:00
Michał Kozłowski e05e17ce31 fix regexp to match require statement without .js extension (#36293) 2019-07-02 01:51:41 +05:30
Steven Failla 438e7d4c51 fixed testString to disallow any extra characters from passing. Also … (#35987)
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

Co-Authored-By: Stevo99 <Sfailla1983@gmail.com>

* fixed test so it won't pass if datetime attr is left blank

* fixed test so it will not pass if datetime attribute is left empty

* fixed error in testString where test would pass if user runs test right away

* added tear-down div to make test code look cleaner

* fixed merge conflict. added tear-down div to make code look cleaner

* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

improvement to test case where element should have closing tag.

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fixed conflict in git

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

removed unnecessary test

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

removed unnecessary test

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-28 18:49:00 -04:00
Tom 50b45b9379 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/create-an-export-fallback-with-export-default.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-28 16:04:59 +08:00
moT01 2e49aa02df fix/add-anonymous-function-example 2019-06-28 16:04:59 +08:00
moT01 9c1b83dd0c fix/add-tests+note-in-import-lesson 2019-06-28 16:04:59 +08:00
moT01 c133a6fbd0 fix/remove-duplicate-from-meta 2019-06-28 16:04:59 +08:00
moT01 9199319ae1 fix/build-error 2019-06-28 16:04:59 +08:00
moT01 9c249bf8be fix/build-error 2019-06-28 16:04:59 +08:00
moT01 d68475e7ea fix/build-error 2019-06-28 16:04:59 +08:00
moT01 ffc3a827c2 fix/conflicts 2019-06-28 16:04:59 +08:00
moT01 61895e05f7 fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
moT01 f14f1bf750 fix/rename-lessons 2019-06-28 16:04:59 +08:00
moT01 23d723a71f fix/add-tests 2019-06-28 16:04:59 +08:00
moT01 2e6cb9181a fix/revise-es6-import-export-lessons 2019-06-28 16:04:59 +08:00
moT01 6e8bbd169b fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
moT01 956212cdc0 fix/rename-lessons 2019-06-28 16:04:59 +08:00
moT01 8b5cc6d277 fix/add-tests 2019-06-28 16:04:59 +08:00
moT01 8a579210e3 fix/revise-es6-import-export-lessons 2019-06-28 16:04:59 +08:00
moT01 00b5ce97e3 fix/verbiage 2019-06-27 15:48:07 +08:00
Tom 72cb38a839 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-27 15:48:07 +08:00
moT01 3b96f3e60d fix/terminology 2019-06-27 15:48:07 +08:00
Tom 81758eeea6 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom d2c5cc7ff3 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom 9f4799bba1 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom e58c512052 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
moT01 d0e5405e5c fix/make-tests-more-robust 2019-06-27 15:48:07 +08:00
moT01 21b411b855 fix/bad-solution 2019-06-27 15:48:07 +08:00
moT01 246ca16f32 fix/es6-destructuring-reword+new-lesson 2019-06-27 15:48:07 +08:00
Kris Koishigawa 1028310819 Changed bold to strong or code tags where possible 2019-06-26 17:34:03 +08:00
Kris Koishigawa 3ce97bbd81 Fixing other problems from comments 2019-06-26 17:34:03 +08:00
Kris Koishigawa 0544554b00 Fix curly quotes 2019-06-26 17:34:03 +08:00
Kris Koishigawa a6ed1e51b7 Change links from http to https 2019-06-26 17:34:03 +08:00
Kris Koishigawa 32b24a3a20 Fixing merge conflicts 2019-06-26 17:34:03 +08:00
Kris Koishigawa ae49dfd376 fix(challenges): Fix merge conflicts convert seconds and towers of hanoi 2019-06-26 17:34:03 +08:00
Kris Koishigawa 14bcbac669 fix(challenges): Added blockquote to department numbers and fixed fractions in fractran 2019-06-26 17:34:03 +08:00
Kris Koishigawa aeb0dccb15 fix(challenges): Added left margin to blockquote footer in Babbage Problem 2019-06-26 17:34:03 +08:00
Kris Koishigawa 12d84e83a8 fix(challenges): Y problem 2019-06-26 17:34:03 +08:00
Kris Koishigawa 723ee2cfa5 W problem 2019-06-26 17:34:03 +08:00
Kris Koishigawa a0e68a39a7 fix(challenges): V problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 74f70c19d8 fix(challenges): T problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 539e93d01b fix(challenges): The rest of the S problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 442c9c291d fix(challenges): More S problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa c752d57611 Added sorting algorithms 2019-06-26 17:34:03 +08:00
Kris Koishigawa 2053e99cd5 S problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa df88daa482 fix(challenges): J problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 263d2c496b fix(challenges): I problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa a3fd1aa284 fix(challenges): H problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa 537d1ed642 fix(challenges): G problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa abbfee1189 fix(challenges): Formatted F challenges 2019-06-26 17:34:03 +08:00
Kris Koishigawa 1a56a5b0ae fix(challenges): Minor changes to D challenges. Add E challenges 2019-06-26 17:34:03 +08:00
Kris Koishigawa 461155f7ef fix(challenges): Replaced image with svg in Cut a Rectangle 2019-06-26 17:34:03 +08:00
Kris Koishigawa da4999cb46 fix(challenges): Moved challenge instructions to instructions section 2019-06-26 17:34:03 +08:00
Kris Koishigawa 3a7ac2c0c0 fix(challenges): Forgot to remove the space between the function name and first parenthesis 2019-06-26 17:34:03 +08:00
Kris Koishigawa bc1d2be822 fix(challenges): Added all D problems except Department Numbers 2019-06-26 17:34:03 +08:00
Kris Koishigawa d024b96a92 fix(challenges): Went back and fixed a missing A problem. Fixed C problems. 2019-06-26 17:34:03 +08:00
Kris Koishigawa f9f4048258 fix(challenges): Revert 24 game due to another PR being submitted 2019-06-26 17:34:03 +08:00
Kris Koishigawa 201c383148 fix(challenges): Fixed formatting for numbered and challenges starting with A 2019-06-26 17:34:03 +08:00
Tom 51b5defb7e fix/regex-upper-and-lower-bounds-tests (#36059)
* fix/regex-upper-and-lower-bounds-tests

* fix/add-solution-back

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/specify-upper-and-lower-number-of-matches.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-25 14:45:20 -07:00
Randell Dawson 3fa14df925 fix: renamed folder without starting dash (#36124) 2019-06-21 18:05:33 -04:00
Randell Dawson f53ca79890 fix: changed tests to allow other valid solutions (#36210) 2019-06-21 18:04:30 -04:00
Randell Dawson 63a0fa745b fix: improved tests to allow more valid solutions (#36193) 2019-06-20 17:09:46 -04:00
Randell Dawson a6afaf1eb6 fix(curriculum) - added new tests to prevent invalid solutions in the Remove Elements from a Linked List by Index challenge (#36168)
* fix: added new tests to prevent invalid solutions

* fix: corrected tests and added solution

* fix: added linked word

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added by one

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: removed duplicate code

* fix: changed verbiage

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added extra line to avoid linting errors
2019-06-20 13:34:08 -04:00