Updated create radio / create checkbox to identify that the input element is not required to be inside the label element. Tried to use soft language without making user think it was incorrect because current tests still require the input to be nested within the label element. Also, this is not necessarily incorrect syntax as noted at W3 - Forms - Labels: https://bit.ly/2sLiXvE. Nesting implies implicit association vs explicit association using for attribute.
Excessively strict assertions were causing the test to fail when user
added extra attributes such as 'id' to the opening audio tag. Test has
been simplified to remove the unnecessary criteria.
Closes#17343
* Correct text mistake
In challenge: Animate Multiple Elements at Variable Rates
text implicated that we changed in previous challenge two frames, while we were changing only one.
* Update applied-visual-design.json
Updated spelling mistake. The word 'declare' was spelled 'declar' in the challenges: Basic CSS - Create a custom CSS Variable and the Basic CSS - Use CSS Variables to change several elements at once.
For the last test case in 'Access Props using this.props' challenge, I
updated the test condition to check that the value of the tempPassword
prop is the same as the content within the <strong/> tags. This test
case will ensure that there is text present in the strong tag and its
value is as expected.
BREAKING CHANGE: none
Closes#17134
<!-- freeCodeCamp Pull Request Template -->
<!-- IMPORTANT Please review https://github.com/freeCodeCamp/freeCodeCamp/blob/staging/CONTRIBUTING.md for detailed contributing guidelines -->
<!-- Help with PRs can be found at https://gitter.im/FreeCodeCamp/Contributors -->
<!-- Make sure that your PR is not a duplicate -->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply. -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] Your pull request targets the `staging` branch of freeCodeCamp.
- [x] Branch starts with either `fix/`, `feature/`, or `translate/` (e.g. `fix/signin-issue`)
- [ ] You have only one commit (if not, [squash](http://forum.freecodecamp.org/t/how-to-squash-multiple-commits-into-one-with-git/13231) them into one commit).
- [x] All new and existing tests pass the command `npm test`. Use `git commit --amend` to amend any fixes.
#### Type of Change
<!-- What type of change does your code introduce? After creating the PR, tick the checkboxes that apply. -->
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
- [ ] Add new translation (feature adding new translations)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply. -->
<!-- If you're unsure about any of these, don't hesitate to ask in the Contributors room linked above. We're here to help! -->
- [x] Tested changes locally.
- [x] Addressed currently open issue (replace XXXXX with an issue no in next line)
Closes#17215
#### Description
<!-- Describe your changes in detail -->
Here are a list of style changes made for problems 1-16:
* 2: Centered text
* 6: Centered text and `<sup>` tags
* 8: Centered text
* 9: Centered text, `<var>`, and `<sup>` tags
* 11: Centered text and spacing between number grid and next paragraph
* 12: Tab spacing (padding-left: 4em)
* 14: Centered text, `<var>` tags, and tab spacing (padding-left: 4em)
* 16: `<sup>` tags
BREAKING CHANGE: None
Here's a list of style changes made for problems 17-26:
*17: Bold tags
*18: Bold tags
*19: ul and li tags for leap year information
*20: var tags and line break
*21: var tags
*22: added code tag
*23: var tags
*24: centered text and var tag
*25: sup tags, tab-like spacing, and CSS grid for spacing
*26: sub, sup, and var tags, and CSS grid for spacing
BREAKING CHANGE: None
This PR allows us to validate the schema during test.
It also removes some cruft from the seed files and ensures only the required data is packaged and consumable, reducing the package weight somewhat.
* fix(logs): Remove console.log's
* chore(challengeMap): challengeMap -> completedChallenges
* chore(userModel): Update user model
* feat(userIDs): Add user ident fields
* chore(github): Remove more refs to github data
Bouncey
Mrugesh Mohapatra
Alex Swiontek
Varun
Vimal Raghubir
Bhanu Pratap Singh Rathore
Tom
Kristofer Koishigawa
Matthew Smith
Todd Bradshaw
Vuong
Devon Aleshire
Jarek Wojciechowski
bogadodiegoh
Jaka Kranjc
Andrew Bales
Rachel Sinclair
Stefan Feješ
Gonzalo Pozzo
Mateusz Mazurczak
Quincy Larson
Jerrid Schilling
manjeet5
Rajat Kanti Nandi
Bennett Elder