Certain challenges involve code that is not run until the user
interacts with the preview (typically via a click listener). This uses
consoleProxy to report those errors.
Error logging has been simplified, reducing the number of places errors
can be reported from.
Some of the redux-saga code has been renamed in an attempt to improve
clarity.
console.logs and errors are only reported during the first evaluation of
the user's code. This is because the code is evaluated for each test,
but the logs will not change between the build phases of the tests.
Errors thrown during testing (except failing assertions) are always
reported. This is to inform the user that their code is faulty, rather
than that it does not meet the challenge's requirements.
Any console.logs inside script tags will be written to the fcc console
as the user types. DOM challenges only.
Also, DRYed out the main and test frame creation.
Errors thrown during evaluation of the user's code will now be reported.
JavaScript challenges will only report to the browser console and only
during testing.
DOM challenges will report to the browser console during testing and as
the user types, but only report to the fcc console during testing
Previously only challenges with previews would inform the user of syntax
errors. This extends that to all challenges and corrects the output
format so errors are clearer.
* fix: make help button use subforum topics
* fix: add test to check that block exists
Co-authored-by: ojeytonwilliams <ojeytonwilliams@gmail.com>
* fix: improve error message
* Update curriculum/test/test-challenges.js
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* fix: added new test to test href attribute
* fix: changed You to Your
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix: changed a to an
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* fix(client): add cache-busting hashes to chunks
* fix: create cache-busting names for the workers
Prior to this PR the first webpack compilation gave the workers static
names. This can cause caching problems, so this PR adds hashes to
their names to invalidate the cache.
In order for Gatsby to find them, the names are added to the
config directory.
* Switch statement example updated
* Update switch-statements.english.md example
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
* Update switch-statements.english.md example
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Users can now press ctrl/cmd+f1 to toggle the screen reader mode, in
addition to using the accessibility tooltip. The mode now persists
between challenges.
If screen reader mode is on, the instructions are focused by default so
the user is not required to navigate to them before reading starts.
* fix: allow-leading-zero-to-be-optional-before-decimal-point-for-opacity
* fix: use getComputedStyle intead of regex
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
challenge requires two files to be created whose names are given with first letter in uppercase but further down in the description those files are imported with lowercase name.
it is little confusing and requires renaming of files
* [ FIXES ] - fixed function keyword not misspelled
* Update client/src/pages/learn/javascript-algorithms-and-data-structures/debugging/index.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* fix: added comment back into example code
* Improve viewport unit readability
Ran into a readability issue when trying to complete challenge. Instead of using `width: 80vw` was attempting `vw: 80vw` based on the initial layout. I believe either this change or the example that was added but doesn't seem to be pushed yet will help.
* edited description to be a little more clear on how to access elements in an array through indeces
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-array-data-with-indexes.english.md
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
* Fix typo in CONTRIBUTING.md
Remove spacebar and enable markdown
* Retranslate CONTRIBUTING.md in Korean
- Retranslate CONTRIBUTING.md (updated version) in Korean
- Correct an error in translation
- Make expressions more clear and friendly
* Change wording to more friendly one
Removed the donate page tests, which seemed weirdly depending on
the rendered tree. Unreliable at the best.
We sould be adding comprehensive tests to the components instead.
This commit removed the donate modal and related wiring,
although some of the state mapping is still around.
The remaining state mapping can either be removed, or kept
for now, because it will be replaced as is for the newer
motivation based donation prompts
This section is now after Basic Javascript, but the challenge indicates that "function" and "return" are unknown at this point. Simply a product of an (apparent?) move.
Oliver Eyton-Williams
Arthur
Lowell Hamilton
Marco Valero
Tom
bitrixtoday
Randell Dawson
HoJeong Im
Kiara Barias
Rohit Ambre
Quincy Larson
allison-strandberg
Subash Iglesias
Tom
Matheus Genteluci
jotagarciaz
Eunjeong Park
Tristan Michael Lawrence
anthonyjvoss
Loic Beylot
jasonranney
lasjorg
Kirankumar Ambati
Daniel Veazey
Mrugesh Mohapatra
imgbot[bot]
Ahmad Abdolsaheb
David Carlson
Abdelrahman Ashraf