Commit Graph

2138 Commits (86a1da59fff721db73ada72bbb7148183ce785ac)

Author SHA1 Message Date
max-voronov 17a6a8868b
Refactor Honesty (#39726)
* remove unused prop from Honesty component

* convert Honesty into a functional component
2020-10-01 09:11:45 -05:00
Ahmad Abdolsaheb 4e51e845bb
fix: remove duplicate of borderColorPicker (#39732) 2020-09-30 14:56:30 +05:30
max-voronov 55f3df293a
chore(client): refactor ImageLoader (#39691) 2020-09-30 14:52:20 +05:30
Oliver Eyton-Williams 9718244431
fix: watch curriculum changes 2020-09-29 22:09:02 +02:00
Kristofer Koishigawa 0a0fe2bae5
fix: suppress algolia errors (#39703) 2020-09-27 16:25:11 +05:30
Oliver Eyton-Williams f5f2fca28c
fix(client): use mongoids for challenge.id (#39676) 2020-09-24 23:49:40 +05:30
Ahmad Abdolsaheb 1a66eac990 feat: render nav conditionally 2020-09-24 17:48:29 +05:30
Tom 422bacd15d
feat: add button to add cert to LinkedIn profile (#39466) 2020-09-24 17:33:11 +05:30
Oliver Eyton-Williams 0a4316b0ae fix(client): update eslint and fix issues
The eslint config now includes rules that have been added to Gatsby.
This uncovered some problems with missing labels that have been fixed.
2020-09-24 16:29:55 +05:30
Oliver Eyton-Williams 5528823151 fix(client): add polyfill explicitly
Previously it was only present because of a chain of dependencies
2020-09-24 16:29:55 +05:30
Oliver Eyton-Williams 410ab87c61 fix(client): use new Gatsby --inspect 2020-09-24 16:29:55 +05:30
Mrugesh Mohapatra 806cadfd91 chore:(deps): client - update minor and patch 2020-09-24 16:29:55 +05:30
Oliver Eyton-Williams 4b14f9297b
fix: source certificates into Gatsby (#39648)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-24 16:04:35 +05:30
Oliver Eyton-Williams 4f0959df1d
fix: use position: fixed to avoid forcing Cypress (#39605) 2020-09-23 20:45:21 +05:30
Oliver Eyton-Williams dd7fba4558 fix(learn): ignore missing editable regions
They should never be missing, so that bug should be squashed.  However,
for now, this gracefully deals with their absence.
2020-09-22 14:15:00 +05:30
Sky020 a86b220eb7 chore: remove isRequired from curriculum files 2020-09-21 20:51:46 +05:30
Twaha Rahman 984f311061
fix(Client): Use `font-display: fallback` to avoid FOIT (#39628) 2020-09-21 16:06:44 +03:00
Jarson Abenojar 66630715ee
fix(learn): update 'Whitelist' to 'Access List' for Atlas setup (#39626)
Mongodb has been updated to call this the 'IP Access List'
2020-09-19 23:03:23 +01:00
Hassaan Pasha 80438cac3e
feat(client, learn): add helper functions for common validation operations (#38605)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-17 19:38:01 +05:30
Lasse Jørgensen 45520cd7c5
fix(editor): disable suggestion actions squiggly-hint (#39596) 2020-09-17 16:18:04 +05:30
Shaun Hamilton bdc29c2e49
fix(client): rename certification for typo (#39567)
* fix(client): rename legacy cert

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-09-16 19:18:01 +02:00
Oliver Eyton-Williams 39b4aff4f8 fix(client): return frame-runner err correctly 2020-09-16 11:54:15 +05:30
Ahmad Abdolsaheb 9d647ee90c fix: load editor tabs conditionally on mobile 2020-09-16 11:54:14 +05:30
Oliver Eyton-Williams c16785f74e fix(client): do not build Intro for missing blocks
This creates an empty page, but ideally it should be a 404
2020-09-16 11:54:14 +05:30
Oliver Eyton-Williams 1ce354a179 fix(client): show editor for React challenges 2020-09-16 11:54:14 +05:30
Oliver Eyton-Williams 07cf7e3e72 fix(client): set custom schema
Necessary for the time being, as all the multi-file challenges are
upcoming (and thus hidden)
2020-09-16 11:54:14 +05:30
Ahmad Abdolsaheb a500279036 fix: editor resize (#39542) 2020-09-16 11:54:13 +05:30
Ahmad Abdolsaheb 9b1077acf5 fix: render editor tabs if SHOW_UPCOMING_CHANGES is 'true' (#39513) 2020-09-16 11:54:13 +05:30
Randell Dawson 06da30e48a feat(learn): Basic CSS Cafe Menu instructions and hints/tests (v7) (#39407)
* feat: created step instructions for cafe menu

fix: added instructions to steps 1-31

fix: changed steps 29-31

fix: added instructions for steps 32-42

fix: changed prototype class definition

fix: padded file names

fix: added instructions for steps 43-61

fix: add object id to final.md and final prototype to meta.json

fix: correct typos in steps 26 and 27

fix: misc wording changes

fix: added forward slash to closing html tag

fix: added instructions for steps 62-75

feat: added instructions to steps 76-79

fix: added FOOTER comment for steps 68-75

fix: add steps 68a and 68b

fix: add steps 69a and reorder steps

fix: added instructions to the final steps

* fix: remove final.md

* fix: fixed typo of menue to menu

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed wording to improve readability

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed wording to improve readability

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed wording to improve readability

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: combined two lines into same paragraph

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-09-16 11:54:13 +05:30
Oliver Eyton-Williams 3cfd80a806 fix: handle editable region covering editor's top 2020-09-16 11:54:12 +05:30
Oliver Eyton-Williams 9df098953d Feat: editable dom element (#39341)
* feat: __testEditable allows editable region tests

It's not entirely isolated, but it makes it possible to select only the
element with id 'editable-only' which is built solely from code inside
the editable region.

* fix(client): missing editableContents -> ''

Previously it was added as the string 'undefined'

* fix: more informative error messages

* fix: DRY, correct and test getLines
2020-09-16 11:54:11 +05:30
Ahmad Abdolsaheb a1a051bd3a feat: add action row for challenges with ERMs on desktop (#39377) 2020-09-16 11:54:11 +05:30
Oliver Eyton-Williams 9a137573a7 fix: only show description in target editor 2020-09-16 11:54:11 +05:30
Oliver Eyton-Williams 2abefc27a2 fix: handle missing ERB 2020-09-16 11:54:11 +05:30
Oliver Eyton-Williams 78c3b42770 fix: scroll to editable region on mount 2020-09-16 11:54:10 +05:30
Oliver Eyton-Williams a4c836c6d4 feat: open target editor on mount 2020-09-16 11:54:10 +05:30
Oliver Eyton-Williams 02aff4d400 feat: multiple concurrent editors 2020-09-16 11:54:10 +05:30
Oliver Eyton-Williams 2e7a2424c1 refactor: DRY out DesktopLayout 2020-09-16 11:54:10 +05:30
Oliver Eyton-Williams 3ea251383f fix: use loadable MonacoEditor 2020-09-16 11:54:10 +05:30
Randell Dawson fd6f8b5cd4 feat(learn): Update Basic HTML Cat Photo App project descriptions and hints and tests (v7) (#39131)
* feat: added Cat Photo App project

Added new steps

feat: add tests + targetted hints for demo

simplify wording and combine some tests

feat: update text and add tests/hints

fix: changed descriptions and tests

feat: added tests for part 11 - 15

fix: reworded description for steps 2 and 10

fix: changed isBeta to isHidden

fix: temporarily remove fcc-editable strings

fix: added project to challengeTypes.js

fix: added missing parentheses

fix: test text improvements

fix: changes to tests and text discussed in meeting

fix: adjust logic for detecting indentation in part 07

fix: missing regex characters and made last test more permissive for part 04

feat: add steps 25 to 55 and notes

fix: added h1 element back to steps 5-24

fix: h1 and h2 elements from steps 25 to 50

fix: added missing DOCTYPE declaration steps 20-24

fix: miscellaneous text edits

fix: break up part 28, change local paths for images to short s3 cdn URLs

fix: part 01 and 02 descriptions and tests

feat: pull in changes from #39145 and remove solution sections

fix: adjust descriptions and break up steps 33 and 35

fix: break up more steps and adjust text

feat: add tests for parts 25 - 30

* fix: ran reorder-steps.js

* fix: added editable region markers

* fix: standardize opening tag hint text

* fix: remove trailing periods from descriptions and hints and adjust tests

* fix: remove unnecessary instructions sections

* fix: added test to check for only one h1 element

* fix: removed comma

* fix: changed paragraph element to `p` element

* fix: added test for extra h1 element

* fix: test to validate only one img element exists

* fix: replaced code tags with backticks

* fix: reworded description

* fix: reworded step description

* fix: changed tests for first step

* fix: change last two alt values to sentences

* fix: check for spaces in text strings

* fix: removed extra dot before replace method

* fix: moved example before instruction

* fix: rearranged step 6 tests

* fix: capitalized p in paragraph

* fix: rewored step 7's description and a test text

* fix: corrected test for step 8

* fix: improved step 9 tests

* fix: moved example above instruction

* fix: corrected step 9 test wording

* fix: rearrange test order for step 10

* fix: moved example before instructions for step 11

* fix: improved step 12 descripton and tests

* fix: corrected tests for steps 9, 10, 11, 13, 14

* fix: added ERMs to steps 4-14

* fix: minor typos

* fix: reword steps so examples are above instructions

* fix: introduce inline and block elements and use divs instead of br

* fix: add or adjust tests for steps 15 - 27

* fix: moved ERM up one line

* fix: removed unnecessary quotes in tests' text

* fix: added dfn tags for step 45

* fix: removed adding # to href step

* fix: tests 15 - 16

* fix: reword descriptions so they're not as hand holdy

* fix: reorder/reword steps 58 - 60

* feat: simplify radio button steps

* fix: wording and add demo step

* fix: remove doctype and teach in last step

* fix: update part-demo

* fix: added some more step 15 hints

* fix: added step to introduce section elems

* fix: added section elements to project

* fix: update final code

* fix: update tests for 15a and 16

* fix: add section elements to parts 45 to 61

* fix: change p elements to h3, update tests and text

* fix: added new test for step 9

* fix: fixed/added tests for steps 15-30a

* fix: use fieldset elements instead of divs in the form

* fix: added new test to setp 30a

* fix: changed `main` to `section`

* fix: corrected/added tests for step 31

* feat: add tests 32 - 36

* fix: revert change to js rpg game

* fix: simplify tests 32 - 36

* fix: updated submit-cat-form url

fix: changed submit-cat-form url

* fix: added/rearranged tests steps 32-36

* fix: added tests for step 36a

* fix: used hasAttribute where applicable

* fix: misc edits for steps 10 and 35-36a

* fix: add tests to step 37

* fix: reworded step 37

* fix: added more verbiage to steps 35 and 36

* fix: modified step 38 desc and added tests

* fix: added hints/tests for step 40

* fix: added hints/tests for step 41

* fix: added hints/tests for steps 42 and 43

* fix: made attribute values match exactly

* fix: change wording from text input to text field

* fix: rearrange name attribute lessons

* feat: tests for 44 - 44b

* fix: added a step  35a

* fix: added name="catphotourl" to steps 36-61

* fix: reworded steps 41 and 43

* fix: removed intro to for attribute

* fix: rewrite of step 44b's desc and tests

* fix: added step 45 hints/tests

fix

* fix: removed for attribute from steps 45a-61

* fix: removed extra )

* fix: wrapped "section" with backticks

* fix: added test for steps 45a and 45b

* fix: adjust position of label steps 55-61

* fix: removed conole.log statements

* fix: added tests to step 45c

* fix: renamed step 49 to step 46a

* fix: moved label element for steps 48-53

* fix: reworded step 47 description and instructions

* fix: typos in description and test text

* feat: add tests 46-48

* fix: wording

* fix: remove case insensitivity from a couple of tests

* fix: wording and add erms

* fix: add additional test for step 48

* fix: added hints/tests for step 50

* fix: added hints/tests for step 51

* fix: added hints/tests to step 53

* fix: added hints/tests for step 55

* fix: added hints/tests for step 56

* feat: tests for 57-61

* fix: removed duplicate test in step 55

* fix: adjusted 1st test for step 57

* fix: simplified test for title text

* fix: improved tests for step 60-61

* fix: removed demo.md file

* fix: ran reorder-steps.js

* fix: part 10 description

* fix: part 14 description

* fix: part 24 - move ERMs

* fix: part 05 description

* fix: part 54 test text

* fix: part 06 - wording and add test for p and main closing tag order

* fix: part 50 - add test to check for order of fieldset elements

* feat: value attribute for radio buttons step and seed changes

* feat: value attribute for checkboxes step and seed changes

* fix: update part 14 description

* fix: revert ERMs for part 24

* fix: remove last test in part 06

* fix: text and typos for new radio and checkbox lessons

* fix: text and typos for new radio and checkbox lessons

* fix: add test to part 01

* fix: ran reorder-steps.js

Co-authored-by: Kris Koishigawa <scissorsneedfoodtoo@gmail.com>
2020-09-16 11:54:09 +05:30
Oliver Eyton-Williams ad83a2e3f4 feat: show one hint at a time 2020-09-16 11:54:09 +05:30
Oliver Eyton-Williams 68b223322f feat: make editable code available in tests 2020-09-16 11:54:09 +05:30
Oliver Eyton-Williams 120bb342e8 fix: keep the zones in the right places
The description zone needs fixing, but the hint zone should behave correctly.
2020-09-16 11:54:08 +05:30
Oliver Eyton-Williams e34bdded7d fix: region expansion
Now the top region can expand up and the bottom region down.
2020-09-16 11:54:08 +05:30
Oliver Eyton-Williams f7ce54a154 fix: prevent deletion of editable region at bottom
If the first line of the greyed out region is deleted it now springs
back. As does the second line - which needs fixing
2020-09-16 11:54:07 +05:30
Oliver Eyton-Williams 52cb6adf02 refactor: sortFiles -> toSortedArray 2020-09-16 11:54:07 +05:30
Oliver Eyton-Williams 1ee5e24d0f feat(multi): insert description into editor 2020-09-16 11:54:07 +05:30
Oliver Eyton-Williams 59c838e8ca feat(multi): add editor decoration
The warning region does not grow at the edges This makes it harder for
the user to get into an odd state.  It might be better to have let the
user expand the second region at the trailing edge.  I'm not sure, and
that's harder to implement.
2020-09-16 11:54:07 +05:30
Oliver Eyton-Williams dfbf1ae9ae refactor(multi): DRY out view state changes 2020-09-16 11:54:06 +05:30
Oliver Eyton-Williams 1e1a0939ab feat: highlight currently selected editor tab 2020-09-16 11:54:06 +05:30