Commit Graph

1311 Commits (8b082995b53b5f7a82702162bfc49cf06e419dd9)

Author SHA1 Message Date
Chayanon Tonsai 8b082995b5 Change test method from string.test(regex) to regex.test(string) (#37458) 2019-10-23 09:32:17 -05:00
Bhanu Pratap Singh Rathore ca63f90070 feat(interview-prep): Converting and transfering Rosetta problems (#35770)
* feat(interview-prep): Converting and transfering Rosetta problems
2019-10-23 23:23:50 +09:00
Tom 69d4d4fe2f fix: recursion test (#37419)
* fix(challenge): recursion test

* fix(challenge): replace regex s flag with g
2019-10-23 00:18:40 +05:30
shrobbins a13bb1b96f fix: missing semi-colon (#37454) 2019-10-21 20:50:51 -04:00
gmal1 174c6f5c68 Make corrections in the Tests section, fix inconsistent spelling (#37246) 2019-10-20 09:27:01 +05:30
jasonranney f0c1d3a759 change "therefor" to "therefore" to be grammatically correct (#37297) 2019-10-16 11:41:11 -04:00
Kris Koishigawa 26eacf6f47 fix: Change project URL to a working fCC example project 2019-10-15 00:45:50 +09:00
Ambar Mutha 5dce06fccb add comment explaining no need for solutions (#37227) 2019-10-14 11:30:42 -04:00
Kristofer Koishigawa 71fbf2b658
fix(challenges): Update stock price checker sample project URL and add proxy info (#36801)
* fix(challenges): Updated sample project URL, added information about a proxy for stock price information, and tweaked the English test text slightly
2019-10-15 00:04:32 +09:00
mariorguez 372cba1c4c docs: fix unnecessary translation of strong tag (#37223)
When translating to Spanish, the tag itself doesn't have to be translated, to avoid confusion. So, strong should be kept "strong" and not "fuerte".
2019-10-11 16:38:32 -07:00
mrugesh 06b950fdae
chore: cleanup old assets from curriculum (#37164) 2019-10-10 00:06:21 -07:00
Luis Ignacio Collantes 99c86be86b Fixed error in traduction of "Node" (#37120) 2019-10-09 21:04:00 +01:00
Johnny Zabala e9bbcc55cd test rendered output instead of state in react write a simple counter challenge (#36791) 2019-10-09 09:52:41 -05:00
Irina Serdiuk ac1d0a6f78 translation fix (#37073) 2019-10-09 07:51:36 -07:00
Kris Koishigawa 74778c1af8 fix: Updated all Glitch URLs used to import/remix a GitHub repo 2019-10-08 11:04:30 -07:00
nemogoc 23a3287d8f update test wording for undefined fn returns (#36804)
* update test wording for undefined fn returns, bring code out of after test section and check that the function does what it says it does (rather than just checking the result), update seed, example, and solution
2019-10-08 19:16:36 +09:00
Oliver Eyton-Williams 2066ed674b fix: make challenge test errors more informative (#37020) 2019-10-04 03:16:30 -07:00
CubeSky 7128eb0211 Added solution to "01-Responsive Web design" challenge (#36972) 2019-10-04 12:12:27 +07:00
CubeSky 16e72aa393 Added solution to "Responsive Web design" challenge (#36970) 2019-10-04 11:36:11 +07:00
CubeSky 40e6ddca31 Added solution to "01-Responsive Web design" challenge (#36971) 2019-10-03 22:38:49 +07:00
CubeSky 3099f303ed Added solution to "01-Responsive Web design" challenge (#36968) 2019-10-03 21:11:38 +07:00
Randell Dawson 8225ce7572 fix: added 3 new tests to mutations challenge (#36857) 2019-09-30 16:33:57 -04:00
Oliver Eyton-Williams 9c2f1ffd82 refactor: combine slug utils into one module 2019-09-26 22:15:27 +05:30
Tom 52bd3a65de fix: balanced-brackets-tests (#36807) 2019-09-25 11:39:11 +02:00
SomeDer 5de58ad98d fix(curriculum): use function form of this.setState (#36623)
* Fix solution

* Update description

* Add test for this.setState function syntax

* Update toggle element instructions

* Fix simple-counter solutions

* Fix bind-this challenge seed and solution

* Fix && challenge seed and solution

* Fix ternary challenge seed and solution

* Use the function form -> Pass a function

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Mention "passing a function" instead of "alternative form"

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Rephrase explanation

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* clarify why functions should be used

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Improve tests

* Fix \s escaping in []

* Improve regex

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add test for `this`

* Use block code

* Update bind-this challenge

* Fix last part of instructions

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-09-24 08:12:50 -07:00
Ent Wickler d08f009bd1 fix(curriculum): Add tests for setter, getter and setting a temperature (es6 tests) (#36620)
* add testing for setter, getter and setting a temperature according to some of feedbacks into the issues 17403

* bugfix: temperature is not a function
2019-09-23 17:13:32 +02:00
Oliver Eyton-Williams 3a0cd56ad3 fix(curriculum): Add and modify tests to catch bad code. (#36429) 2019-09-20 09:28:50 -07:00
sybiljasmine 5d946f3d77 valid factorial number update under the tests (#36792)
* valid factorial number update under the tests

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Removed redundant array in the tests
2019-09-19 08:52:09 -07:00
Kaitlin 76e1b1a4ba Update user test 13 desc to match changed test (#36523)
* Update user test 13 desc to match changed test

Refer https://github.com/freeCodeCamp/testable-projects-fcc/issues/933.

* Add examples to illustrate change to user story 13
2019-09-19 17:51:10 +09:00
Ezgi Kaysı Kesler 93360f4e01 fix:Typo in uncomment-html page (#36800)
* fix:Typo in uncomment-html page

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/uncomment-html.english.md

removed comma

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2019-09-18 10:51:55 -07:00
Valeriy S 12f65a6742 fix(curriculum): fix challenges for russian language 2019-09-18 12:05:38 +05:30
Jasper Pilgrim 191f915e94 fix(curriculum): grammar, add period (#36785) 2019-09-12 18:48:28 +05:30
Huyen Nguyen 087640d020 fix(curriculum): Make challenge instruction clearer (#36771) 2019-09-11 14:18:28 +05:30
Tom 91dc86fbf0 fix(curriculum): update debugging challenge (fcc vs browser console) (#36703)
* fix: debugging-challege+difference-in-consoles

* fix: grammar

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix/remove-comments-for-first-test
2019-08-30 15:31:57 -07:00
Sahil Bondre 335600d91c fix: change the explanation of splice function (#36721) 2019-08-30 13:59:56 +02:00
mrugesh fa0e198ef9
fix: update lerna npm audit commands (#36700)
* fix: update the audit commands

* chore: update all dependencies

* chore: remove concurrency limit from commands

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: add no-bail to commands

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-08-28 23:06:23 +05:30
Tom 428ab97650 Fix/tests whitespace strictness (#36706)
* fix(tests): make less strict about white space
2019-08-28 10:53:17 +02:00
Tom 46d67deb46 fix(test): make less strict about whitespace (#36705) 2019-08-28 10:48:57 +02:00
Tom 07b38d02b3 fix(challenge-test): make semi-colon optional (#36704) 2019-08-28 06:22:47 +05:30
Tom 742a21345d fix(take-home-projects): Remove paragraphs with bad links (#36702) 2019-08-27 20:02:12 -04:00
Randell Dawson 316503bfaa fix: added forumTopicId to new challenge (#36609) 2019-08-21 11:20:05 -05:00
Lauren Van Sloun 4507a6b254 Minor grammar fixes (#36643)
* Minor grammar fix
2019-08-20 14:36:22 +01:00
Ai-Lyn Tang 24b3bed83f fix: add link to boilerplate Glitch file (#36340)
* Add link to boilerplate Glitch file

The boilerplate link is hard to see in the previous "introduction" page. I was using the old Glitch project link, and was confused.

When I googled for a solution, it was clear than others had also been quite confused. I believe this additional instruction will help many people.

* Direct people back to introduction page

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Remove unnecessary indentation

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Remove spaces on empty line

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Remove spaces on empty line

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add empty line to fix markdown link

Markdown link needs a blank line to render correctly

* fix: add extra line to prevent linting error

* fix/remove-bullet-points


Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
Co-authored-by: Tom <tmondloch01@gmail.com>
2019-08-18 20:27:54 +05:30
rns350 1ad3abd50f feat(curriculum); added another challenge to help teach recursion (#35966)
* Squashed the removal of the before test section

* fix: changed blockquote triple backtick syntax

* fix: removed recursion explanation

* fix: changed meta title and thru to through

* fix: capitalize "after" in several strings
2019-08-15 20:07:15 +09:00
Oliver Eyton-Williams 44804abeb5 fix: Remove and update challenges with legacy methods (#36444) 2019-08-15 01:22:41 +01:00
Tiago Salema a305a3df9f componentWillReceiveProps is deprecated (#35894)
* componentWillReceiveProps is deprecated

Consider removing this lesson from the React tutorial, once this lifecycle method is now deprecated.
In case it isn't, a warning in the beginning should be displayed

* Removed also `componentWillReceiveProps`
2019-08-13 09:14:10 -07:00
SomeDer 01c8554adc 03-render-conditionally-from-props: use const (#36551) 2019-08-12 18:17:39 +05:30
SomeDer 4ff5e6eff6 Add code tag to test in extract-state-logic-to-redux (#36553) 2019-08-12 10:50:13 +02:00
happyhappyyay 7bb6aa7605 Typos fixed for readability (#36577)
* typo fixed

* fixed typos
2019-08-11 12:26:32 -05:00
joelzehring 992fc8f1bf Update generate-an-array-of-all-object-keys-with-object.keys.english.md (#36578)
Method should act on any passed parameter rather than the specific object named in this problem.
2019-08-11 11:42:19 -05:00