Commit Graph

1977 Commits (9089ddca5caa423808d966ed77f542e177f327c7)

Author SHA1 Message Date
Randell Dawson 7565849d7d feat(learn): Added project-based curriculum tools (#39448)
* feat: added project-based curriculum tools

* fix: allow script to work /w or /wo npm run

* fix: moved console.log to reorder-steps function

* fix: integrated bson-objectid library
2020-09-16 11:54:12 +05:30
Randell Dawson b9c9a95223 chore(learn): Renamed all project-based curriculum project step filenames to use 3-digit format of part-ddd.md (#39463)
* fix: renamed basic html cat photo app steps

* fix: renamed css-variables project steps

* fix: renamed d3-dashboard filenames

* fix: renamed rpg-game filenames

* fix: renamed functional-progamming-spreadsheet filenames

* fix: renamed calorie-counter project filenames
2020-09-16 11:54:12 +05:30
Oliver Eyton-Williams 9df098953d Feat: editable dom element (#39341)
* feat: __testEditable allows editable region tests

It's not entirely isolated, but it makes it possible to select only the
element with id 'editable-only' which is built solely from code inside
the editable region.

* fix(client): missing editableContents -> ''

Previously it was added as the string 'undefined'

* fix: more informative error messages

* fix: DRY, correct and test getLines
2020-09-16 11:54:11 +05:30
Randell Dawson 69e3e138f6 fix: added missing ERMs to challenge seed 2020-09-16 11:54:11 +05:30
Randell Dawson 3b8e257643 fix: corrected freecatphotoapp.com link 2020-09-16 11:54:09 +05:30
Randell Dawson fd6f8b5cd4 feat(learn): Update Basic HTML Cat Photo App project descriptions and hints and tests (v7) (#39131)
* feat: added Cat Photo App project

Added new steps

feat: add tests + targetted hints for demo

simplify wording and combine some tests

feat: update text and add tests/hints

fix: changed descriptions and tests

feat: added tests for part 11 - 15

fix: reworded description for steps 2 and 10

fix: changed isBeta to isHidden

fix: temporarily remove fcc-editable strings

fix: added project to challengeTypes.js

fix: added missing parentheses

fix: test text improvements

fix: changes to tests and text discussed in meeting

fix: adjust logic for detecting indentation in part 07

fix: missing regex characters and made last test more permissive for part 04

feat: add steps 25 to 55 and notes

fix: added h1 element back to steps 5-24

fix: h1 and h2 elements from steps 25 to 50

fix: added missing DOCTYPE declaration steps 20-24

fix: miscellaneous text edits

fix: break up part 28, change local paths for images to short s3 cdn URLs

fix: part 01 and 02 descriptions and tests

feat: pull in changes from #39145 and remove solution sections

fix: adjust descriptions and break up steps 33 and 35

fix: break up more steps and adjust text

feat: add tests for parts 25 - 30

* fix: ran reorder-steps.js

* fix: added editable region markers

* fix: standardize opening tag hint text

* fix: remove trailing periods from descriptions and hints and adjust tests

* fix: remove unnecessary instructions sections

* fix: added test to check for only one h1 element

* fix: removed comma

* fix: changed paragraph element to `p` element

* fix: added test for extra h1 element

* fix: test to validate only one img element exists

* fix: replaced code tags with backticks

* fix: reworded description

* fix: reworded step description

* fix: changed tests for first step

* fix: change last two alt values to sentences

* fix: check for spaces in text strings

* fix: removed extra dot before replace method

* fix: moved example before instruction

* fix: rearranged step 6 tests

* fix: capitalized p in paragraph

* fix: rewored step 7's description and a test text

* fix: corrected test for step 8

* fix: improved step 9 tests

* fix: moved example above instruction

* fix: corrected step 9 test wording

* fix: rearrange test order for step 10

* fix: moved example before instructions for step 11

* fix: improved step 12 descripton and tests

* fix: corrected tests for steps 9, 10, 11, 13, 14

* fix: added ERMs to steps 4-14

* fix: minor typos

* fix: reword steps so examples are above instructions

* fix: introduce inline and block elements and use divs instead of br

* fix: add or adjust tests for steps 15 - 27

* fix: moved ERM up one line

* fix: removed unnecessary quotes in tests' text

* fix: added dfn tags for step 45

* fix: removed adding # to href step

* fix: tests 15 - 16

* fix: reword descriptions so they're not as hand holdy

* fix: reorder/reword steps 58 - 60

* feat: simplify radio button steps

* fix: wording and add demo step

* fix: remove doctype and teach in last step

* fix: update part-demo

* fix: added some more step 15 hints

* fix: added step to introduce section elems

* fix: added section elements to project

* fix: update final code

* fix: update tests for 15a and 16

* fix: add section elements to parts 45 to 61

* fix: change p elements to h3, update tests and text

* fix: added new test for step 9

* fix: fixed/added tests for steps 15-30a

* fix: use fieldset elements instead of divs in the form

* fix: added new test to setp 30a

* fix: changed `main` to `section`

* fix: corrected/added tests for step 31

* feat: add tests 32 - 36

* fix: revert change to js rpg game

* fix: simplify tests 32 - 36

* fix: updated submit-cat-form url

fix: changed submit-cat-form url

* fix: added/rearranged tests steps 32-36

* fix: added tests for step 36a

* fix: used hasAttribute where applicable

* fix: misc edits for steps 10 and 35-36a

* fix: add tests to step 37

* fix: reworded step 37

* fix: added more verbiage to steps 35 and 36

* fix: modified step 38 desc and added tests

* fix: added hints/tests for step 40

* fix: added hints/tests for step 41

* fix: added hints/tests for steps 42 and 43

* fix: made attribute values match exactly

* fix: change wording from text input to text field

* fix: rearrange name attribute lessons

* feat: tests for 44 - 44b

* fix: added a step  35a

* fix: added name="catphotourl" to steps 36-61

* fix: reworded steps 41 and 43

* fix: removed intro to for attribute

* fix: rewrite of step 44b's desc and tests

* fix: added step 45 hints/tests

fix

* fix: removed for attribute from steps 45a-61

* fix: removed extra )

* fix: wrapped "section" with backticks

* fix: added test for steps 45a and 45b

* fix: adjust position of label steps 55-61

* fix: removed conole.log statements

* fix: added tests to step 45c

* fix: renamed step 49 to step 46a

* fix: moved label element for steps 48-53

* fix: reworded step 47 description and instructions

* fix: typos in description and test text

* feat: add tests 46-48

* fix: wording

* fix: remove case insensitivity from a couple of tests

* fix: wording and add erms

* fix: add additional test for step 48

* fix: added hints/tests for step 50

* fix: added hints/tests for step 51

* fix: added hints/tests to step 53

* fix: added hints/tests for step 55

* fix: added hints/tests for step 56

* feat: tests for 57-61

* fix: removed duplicate test in step 55

* fix: adjusted 1st test for step 57

* fix: simplified test for title text

* fix: improved tests for step 60-61

* fix: removed demo.md file

* fix: ran reorder-steps.js

* fix: part 10 description

* fix: part 14 description

* fix: part 24 - move ERMs

* fix: part 05 description

* fix: part 54 test text

* fix: part 06 - wording and add test for p and main closing tag order

* fix: part 50 - add test to check for order of fieldset elements

* feat: value attribute for radio buttons step and seed changes

* feat: value attribute for checkboxes step and seed changes

* fix: update part 14 description

* fix: revert ERMs for part 24

* fix: remove last test in part 06

* fix: text and typos for new radio and checkbox lessons

* fix: text and typos for new radio and checkbox lessons

* fix: add test to part 01

* fix: ran reorder-steps.js

Co-authored-by: Kris Koishigawa <scissorsneedfoodtoo@gmail.com>
2020-09-16 11:54:09 +05:30
Oliver Eyton-Williams 68b223322f feat: make editable code available in tests 2020-09-16 11:54:09 +05:30
Oliver Eyton-Williams 0f3f27287d fix: unify single and multifile testing 2020-09-16 11:54:08 +05:30
Oliver Eyton-Williams d7dc1acb4a chore: update lang tags on code blocks 2020-09-16 11:54:08 +05:30
Oliver Eyton-Williams 52cb6adf02 refactor: sortFiles -> toSortedArray 2020-09-16 11:54:07 +05:30
Oliver Eyton-Williams 301212e194 feat: handle multi-file solutions 2020-09-16 11:54:06 +05:30
Oliver Eyton-Williams 3783ef118e fix(multi): validate challenges correctly 2020-09-16 11:54:05 +05:30
Oliver Eyton-Williams 754a33970e refactor(multi) move preparation into curriculum 2020-09-16 11:54:05 +05:30
Oliver Eyton-Williams b25089d7c8 fix: relax challenge validation for multiple seeds 2020-09-16 11:54:02 +05:30
Oliver Eyton-Williams f77005cc43 fix: accept numbers for boundaries (#39181) 2020-09-16 11:54:02 +05:30
Randell Dawson 8478e021bf feat (learn): Remove editable regions from seed code before displaying user's code (#39153)
* feat: pull editable region from markdown

* test: update seed tests to reflect new schema

* feat(curriculum): validate multi-file solutions

* test: add editableRegionBoundaries to schema

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-09-16 11:54:02 +05:30
Oliver Eyton-Williams fd7a8c0d5e feat: allow next challenge's seed to be a solution (#39145)
* feat: allow next challenge's seed to be a solution
2020-09-16 11:54:01 +05:30
Kris Koishigawa 4f1be63055 feat(learn): sync master and next-curriculum branches 2020-09-16 11:54:01 +05:30
Tom 977701937b Feat: add d3 dashboard project to next curriculum (#38028)
* feat: add d3 dashboard project to next curriculum
2020-09-16 11:54:01 +05:30
Tom dae411d408 fix: failing test (#38253) 2020-09-16 11:54:00 +05:30
lmilliken 9ba1f1f6d0 feat: tests for calorie counter
split up calorie counter lesson
2020-09-16 11:54:00 +05:30
Kris Koishigawa b99d78858b fix: basic js rpg spacing and tests
Replaced tabs with spaces so spacing is consistent in the monaco editor. Also adjust some tests to account for the new loop protection.
2020-09-16 11:54:00 +05:30
lmilliken 39b0afd5f0 feat: tests for calorie counter 2020-09-16 11:54:00 +05:30
Kristofer Koishigawa d3d5147c1f fix: renamed files and titles in the frontmatter for consitency (#37792) 2020-09-16 11:53:59 +05:30
Kristofer Koishigawa 869b4f479e fix(client): modified test suite to not throw errors (#37894)
modified challenge test suite so it does not throw an error if two steps for the project based curriculum have the same title
2020-09-16 11:53:59 +05:30
SomeDer 2fbafda167 feat: functional programming spreadsheet (#36873)
* Add meta.json for spreadsheet

* Add spreadsheet files

* Close code tags for tests in 2 files

* Add solution section

* Add index file

* Add javascript-spreadsheet to stringifier

* Move index to step

* Rename steps in meta.json

* Rename step numbers in files

* Add index file to proper location

* Remove inappropriate files from spreadsheet dir

* Fix typo in first step

* Fix test sections

* Rename files to correct step

* Fix broken tests

* Add newline between sections

* Change challengeType from 1 to 0

* Add missng ) in step-079.md

* test -> tests in step-079

* Simplify test in step-103

* Fix step-137 test

* Remove last step

* Added solutions and adjusted some tests

* Fix some challenges

* Remove wrong spaces

* Fix more tests

* Add missing semicolon

* Fix more tests

* Fix type: lastttwo

* Fix all remaining tests
2020-09-16 11:53:59 +05:30
Tom 89e18e3a81 feat: add challenges for skyline project (#36854) 2020-09-16 11:53:59 +05:30
Kristofer Koishigawa 529f2596d9 feat: JS RPG game tests (#37678)
* feat: Add JavaScript RPG Game for testing
2020-09-16 11:53:58 +05:30
Randell Dawson 876d9f3994
fix(learn): Consolidated comments for Coding Interview Prep challenges - part 2 of 2 (#39576)
* fix: consolidate comments for use with the translation dictionary

* fix: added blank line between comments

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: removed unneeded comment

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-09-16 01:01:21 +05:30
Randell Dawson 8788ad946b
fix: remove Good luck! comment from challenge seed code (#39575) 2020-09-15 22:27:40 +05:30
Randell Dawson a2f4c8d0e1
fix: consolidated comments for use with translation dictionary (#39578) 2020-09-15 22:23:25 +05:30
Randell Dawson 104f359902
consolidated comments for use in translation dictionary (#39577) 2020-09-15 12:37:50 -04:00
Kristofer Koishigawa c11bf0d02e
fix(curriculum): restrictive test for use map to dynamically render challenge (#39581) 2020-09-15 08:23:48 -07:00
Tom d765fa704b
fix(learn): size your images challenge (#39570)
* fix: size your images challenge

* fix: remove console log
2020-09-14 14:09:01 +01:00
Aleksa S. Stevic 5cb609dc5c
Changed "statement" to "expression" (#39564)
The ternary operator doesn't allow statements, just expressions.
2020-09-12 10:37:59 +02:00
Tom ae6cf5b724
fix: update instructions to be consistent (#39557)
* fix: update instructions to be consistent

* fix: change to use code tags instead of backticks
2020-09-11 19:03:18 -04:00
Randell Dawson c345bc9886
fix: removed scrimba video links that do not reflect current challenge (#39559) 2020-09-11 11:17:50 -05:00
Lasse Jørgensen 2743ac2e84
fix(challenge): update variable names, assign empty array, update solution code, remove "use strict" (#39525)
* fix(challenge): update variable names, assign empty array, update solution code, remove "use strict"

* fix(challenge): update solution code

* fix:(challenge) update instructions and variable name

* fix:(challenge) update instructions
2020-09-09 19:58:27 -05:00
Siddharth Pathak 5418307936
fix(learn): add whitespace check to else-if test (#39555) 2020-09-09 20:30:33 +01:00
Randell Dawson 0f5832b562
fix: project 25 + 5 (#39526) 2020-09-09 13:28:12 +05:30
Tom b79a332984
fix: remove scrimba link for inaccurate video (#39545) 2020-09-08 13:09:53 -07:00
Oliver Eyton-Williams 189b9081ca feat: add script reporting more errors 2020-09-09 01:00:43 +05:30
Oliver Eyton-Williams e9bd88d245 fix: make all unhandled errors fail tests 2020-09-09 01:00:43 +05:30
piouson fbbf7e3f75
Fix tests failing due to whitespaces and trailing forward slash in Advanced Node and Express (#39534)
* Fix implementation-of-social-authentication.english.md

Resolve #39533

* Update implementation-of-social-authentication.english.md

- added capture groups
- updated whitespace filter, `/[\s\r\n]/g` -> `/\s/g`

* Update curriculum/challenges/english/06-quality-assurance/advanced-node-and-express/implementation-of-social-authentication.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update implementation-of-social-authentication.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-08 11:55:20 -05:00
ZhichengChen ff8db8ce9e
fix(i18n): update Chinese translation of json apis and ajax (#38863)
* fix(i18n): update Chinese translation of  json apis and ajax

* address comments

Co-authored-by: Zhicheng Chen <chenzhicheng@dayuwuxian.com>
Co-authored-by: S1ngS1ng <liuxing0514@gmail.com>
2020-09-07 13:48:38 +05:30
ZhichengChen 3b7b64feb3
fix(i18n): update Chinese translation of jquery (#38579)
Co-authored-by: Zhicheng Chen <chenzhicheng@dayuwuxian.com>
Co-authored-by: S1ngS1ng <liuxing0514@gmail.com>
2020-09-07 13:47:51 +05:30
ZhichengChen 0b2be70c9a
fix(i18n): update Chinese translation of bootstrap (#38560)
Co-authored-by: Zhicheng Chen <chenzhicheng@dayuwuxian.com>
2020-09-07 13:47:39 +05:30
ZhichengChen 193d13e7ba
fix(i18n): update Chinese translation of JavaScript Algorithms and Da… (#38494)
Co-authored-by: Zhicheng Chen <chenzhicheng@dayuwuxian.com>
Co-authored-by: S1ngS1ng <liuxing0514@gmail.com>
2020-09-07 13:47:22 +05:30
ZhichengChen b378f110ca
fix(i18n): update Chinese translation of redux (#38825) 2020-09-07 13:46:17 +05:30
ZhichengChen 91c9fc6cd5
fix(i18n): update Chinese translation of front end libraries projects (#38826) 2020-09-07 13:45:49 +05:30
ZhichengChen 424cb619c1
fix(i18n): update Chinese translation of data visualization projects (#38864) 2020-09-07 13:45:31 +05:30
ZhichengChen 88ae7a5df8
fix(i18n): update Chinese translation of react and redux (#38786)
Co-authored-by: Zhicheng Chen <chenzhicheng@dayuwuxian.com>
2020-09-07 13:41:48 +05:30
ZhichengChen 087946adc1
fix(i18n): update Chinese translation of sass (#38595)
Co-authored-by: Zhicheng Chen <chenzhicheng@dayuwuxian.com>
2020-09-07 13:41:08 +05:30
ZhichengChen 653396706e
feat(i18n):Chinese intermediate algorithm scripting (#38442)
Co-authored-by: ZhichengChen <chenzhicheng@dayuwuxian.com>
2020-09-07 13:40:29 +05:30
ZhichengChen 2db889099d
fix(i18n): update Chinese translation of debugging (#38045)
Co-authored-by: Zhicheng Chen <chenzhicheng@dayuwuxian.com>
2020-09-07 13:39:54 +05:30
ZhichengChen 5a72d44482
fix(i18n): update Chinese translation of basic node and express (#38889) 2020-09-07 11:10:31 +05:30
Mrugesh Mohapatra c23c4ef8e4
fix: negative sentiment → neutral language (#39522)
The existing terminology carries negative sentiment that can be
interpreted in a racial or sense. Updating the name to have no
potential for such a connection.

Co-authored-by: Justin Rogers <justrog@gmail.com>
2020-09-07 11:04:44 +05:30
Kristofer Koishigawa b93785be5d
fix(learn): update example image URL (#39530)
Update example URL in "Add Images to Your Website" challenge to point to example image on https://freecatphotoapp.com.
2020-09-05 10:27:27 -07:00
PSN221B 3425dadb46
Use JQuery to solve Catastrophic Backtracking with regex (#39112)
* Use JQuery to solve Catastrophic Backtracking with regex

* fix: improve regex for last test

* fix: improved the other tests with regex

* fix: change regex to allow spaces

Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-04 16:06:57 -05:00
Shaun Hamilton e3cfe80f88
fix(curriculum): advanced node express changes for new boilerplate (#39080)
* fix: add tests and steps

* add necessary changes

* edit for new boilerplate

* fix: adjust content for boilerplate merge

* add 4 passing 1 failing socketio

* fix: add socketio changes

* fix: update wording and http test

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>

* fix: replace glitch remix urls with repl.it urls

* integrate steps between lessons 4 and 5

* add mongodb altas link

* edit test to not require db deletion

* correct register routing and formatting

* fix typos and formatting

* fix: typos, standardize spacing, and remove unnecessary hr elements

* fix: add/update links

Add or update Gist solution links at the bottom of each challenge. Also add a missing link/text to the top of one of the challenges.

* fix: remove Repl.it/boilerplate repo links from all but first challenge

* fix: add target='_blank' to links in challenges

* add note about PIP browser issues

* move PIP note to end of instructions

Co-authored-by: Kristofer Koishigawa <scissorsneedfoodtoo@gmail.com>
2020-09-04 08:50:03 -05:00
Ezekiel Oladejo 4165135380
Update serialization-of-a-user-object.english.md (#39518) 2020-09-03 23:53:31 -07:00
Gianpaolo Macario a3856a5fd7
Fix typo in title (#39492)
* Fix typo in title

* fix: typo in meta and filename

* fix: it

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-03 17:16:12 -07:00
Oliver Eyton-Williams bd68b70f3d
Feat: hide blocks not challenges (#39504)
* fix: remove isHidden flag from frontmatter

* fix: add isUpcomingChange

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* feat: hide blocks not challenges

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2020-09-03 15:07:40 -07:00
AnonymousRepositoryStuff 6b081c7e7b
Update unclear instructions on an FCC CSS Grid challenge in English #39433 (#39506)
* Unclear instructions on an FCC CSS Grid challenge #39433

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/use-grid-area-without-creating-an-areas-template.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/use-grid-area-without-creating-an-areas-template.english.md

Co-authored-by: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-09-03 13:58:59 -07:00
Beau Carnes 5ce8abc131
fix: data analysis links (#39499)
* fix: data analysis links

* fix: add rel attributes to all links in data analysis with python section

* fix: combine rel properties into one attribute

* fix: change single quotes to double

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-03 09:48:42 -07:00
Colin Nielsen 807244c81a
fix: update formatting, add image + solution (#38907)
* fix: update formatting, add image + solution

* fix: change img src and add suggestions

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-03 10:49:51 -05:00
Ty Mick b45e6ecae0
Add previously written methods to challenge seed in "Remove an Element from a Max Heap" (#38834)
* Add previous methods to challenge seed

* fix: add suggested changes

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-09-03 10:40:23 -05:00
Haile Lagi 77bf5630f0
fix(learn): update helmet.js instructions for specific versioning (#39194)
* fix(client): update middleware names of helmet.js tests

* Revert "fix(client): update middleware names of helmet.js tests"

This reverts commit 86d3bb2de8.

* fix: set helmet to v3.21.3

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-03 15:58:28 +01:00
Ishu Singhal 56469d1c5c
fix(learn): update tests to allow more valid solutions (#39054)
* fix(curriculum): updated tests: fixed #39049

It won't pass something like this now:

const myConcat = () => {};
console.log(3);

* fix: add suggested change

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-03 15:28:35 +01:00
Tom 6ce2db7bb2
feat(learn): add word frequency challenge to rosetta section (#39424)
* feat(learn): add word frequency challenge to rosetta section

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/word-frequency.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/word-frequency.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/word-frequency.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/word-frequency.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/word-frequency.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/word-frequency.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: tests

* fix: revert challenge so it can have multiple solutions

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/word-frequency.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-03 06:30:57 -07:00
skaparate f97c847e29
fix(learn): formatting bug preventing tests to pass (#39045)
* implemented object validation

* fix: formatting bug preventing tests to pass

* implemented object validation

* fix: formatting bug preventing tests to pass

* integrated changes again

* added suggested changes

* fix: refine instructions

* fix: revert some bad instructions and change album to albumTitle

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-03 12:34:12 +01:00
Aadhar Agarwal 81479ffd40
fix: add tests for metric-imperial-converter (infosec) (#37891)
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <2397860h@student.gla.ac.uk>
2020-09-03 14:39:01 +05:30
Shaun Hamilton 223c2dc205
fix: convert async tests to synchronous (#39478)
* fix: convert async tests to sync

* fix: correct formatting changed by prettier
2020-09-02 19:24:22 -05:00
Anonyma 8edca2efc5
fix(curriculum): add instructions to clarify use of model.createMany (#38026)
* Update create-many-records-with-model.create.english.md

The previous instructions were causing confusion:
https://www.freecodecamp.org/forum/t/mongodb-and-mongoose-create-many-records-with-model-create/208546
https://github.com/freeCodeCamp/freeCodeCamp/issues/36447

* Added clearer instructions

* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-many-records-with-model.create.english.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-many-records-with-model.create.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-many-records-with-model.create.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-03 00:01:48 +01:00
Ty Mick 57c7003119
fix(curriculum): fix typography in "Set a Domain and a Range on a Scale" (#39259)
* Change spaced hyphen to em dash

* Update curriculum/challenges/english/04-data-visualization/data-visualization-with-d3/set-a-domain-and-a-range-on-a-scale.english.md

* Update curriculum/challenges/english/04-data-visualization/data-visualization-with-d3/set-a-domain-and-a-range-on-a-scale.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-02 19:33:17 +01:00
g4rry420 9a4ab36fa4
Changed Regex of 3rd textString (#38944)
* changes the regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Changed the Regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Changed the Regex of 3rd textString 

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Changed the Regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Chamged the Regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* Changed the Regex of 3rd textString

I changes the regex of 3rd textString so that it can accept h2 as a selector instead of class.

* fix: regex tests and instructions

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/import-a-google-font.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* fix: add suggested change

* revert non-english changes

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <2397860h@student.gla.ac.uk>
2020-09-02 11:21:52 -07:00
bhagerty 046137891e
fix(learn): clarify how object names are associated with destructured fields (#39485)
* Clarify how object names are associated with destructured fields

* fix: make description more concise

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-pass-an-object-as-a-functions-parameters.english.md

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-09-02 19:06:27 +01:00
bhagerty db15a44160
fix(learn): clarify instructions to remove confusion (#39479)
* Clarify instructions to remove confusion

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/accessing-object-properties-with-variables.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-09-02 18:41:59 +01:00
Tom e48664af2a
fix(learn): font size multiple headings exercise (#39511)
* fix: use regex to capture font-size of h6 element, as minimum font-size of browsers may influence outcome

* fix: add suggested changes

Co-authored-by: Ashraf Nazar <ashraf.caspian@gmail.com>
2020-09-02 18:11:23 +01:00
Tom 9cd4b93601
fix(learn): getter setter instructions (#39512)
* Update use-getters-and-setters-to-control-access-to-an-object.english.md

* fix: revert changes, keep example

Co-authored-by: Daniel Sing <danielsingsong@gmail.com>
2020-09-02 18:07:17 +01:00
Shaun Hamilton 9ed2a554a7
fix(curriculum): changed test to use regex (#38770)
* changed test to use regex

* added width has to be spelt correctly

* added second width assertion

* add case insensitive flag

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: allow compilable CSS to pass

* add allowance of final property without semicolon

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-02 11:59:16 -05:00
Ashlee Crusco 3836ce08e3
fix(learn): add for and id attributes to label and input (#39019)
* add value and id attributes

* revert prettier format changes

* fix whitespace changes

* Revert "fix whitespace changes"

This reverts commit 9da78e58ce474b0f4a7cf076574e23961a6d3734.

* fix typo

* fix: conflict I forgot to resolve

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-02 15:19:47 +01:00
Joshua Pelealu a050de56bb
Fix: Running Test with a comment fails test on Understand The immediately invoked function expression iife (#39347)
* Update Regex to test if it's an IIFE instead of checking for a parenthases at the end.

* Second Test will now pass the test

* Escape One Parenthese

* Update Regex to be more structured

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Missing regex ending literal

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-01 18:48:32 -05:00
Mayank Chauhan e7718e5c3f
fix(learn): improved tests for validating incrementer function (#39385)
* Update avoid-mutations-and-side-effects-using-functional-programming.english.md

* Update avoid-mutations-and-side-effects-using-functional-programming.english.md

* Update avoid-mutations-and-side-effects-using-functional-programming.english.md

* fix typo in avoid-mutations-and-side-effects-using-functional-programming.english.md
2020-09-01 08:44:24 -07:00
Ashraf Nazar 70f1ebd2fc
fix(curriculum): regex to target html elements using jQuery to captur… (#38649)
* fix(curriculum): regex to target html elements using jQuery to capture white spaces

* replace whitespace before test

* fix linting issue with single quotes

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-08-31 20:24:43 -05:00
CheongJY a294021d53
fix: remove whitespace before testing (#39420)
* Proposed change to remove whitespace for issue #39370

Issue #39370: whitespace fails the 3rd test with test comparing to a no whitespace example.
Proposed: remove all whitespace in between tags(or literally all whitespaces) before comparing it with the no whitespace example

* Update render-state-in-the-user-interface.english.md

* Updated proposed change to remove whitespace 

An update to previously proposed change due to failed test of 'unexpected token \'<\'' was thrown'

* Update curriculum/challenges/english/03-front-end-libraries/react/render-state-in-the-user-interface.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* fix: linting issue

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-09-01 01:15:22 +01:00
Hassaan Pasha b0f85de311
fix (curriculum): Adding regex to disregard any whitespaces in the basic-css challenge (#38330)
* fix (curriculum): Adding regex to account for any whitespace that may be added to the code

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/use-attribute-selectors-to-style-elements.english.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-08-31 15:16:24 -07:00
Pyi Theim Kyaw faf426bb40
PR ready fix(learn) (#39208) 2020-08-31 15:31:30 -05:00
Beau Carnes f334734e98
feat: split JS challenge into two (#39044)
* feat: split JS challenge into two

* fix/change-to-not-use-untaught-assignments

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-08-31 19:44:56 +01:00
Kristofer Koishigawa 8e3f740127
fix: update take home project links (#39444)
* fix: update take home project links and update mentions of Glitch with Repl.it

* fix: clean up text, fix typos, and remove deploy to Heroku text

* fix: update nightlife coordination app description text

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: update GH link text based on suggestion

* fix: update links to the fCC forum

* fix: update nightlife coordination app url

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: change http to https

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-08-31 10:32:22 -07:00
Yasmin Yazdi cf82a2b33e
fix global flag fail in Regex by resetting last Index (#39457)
* fixing global flag fail by resetting last index. Issue #37890

* fixed syntax error

* making requested changes
2020-08-31 16:59:42 +05:30
Ashraf Nazar 71051fef50
fix(Curriculum): make sure the nested input element in the form is th… (#38480)
* fix(Curriculum): make sure the nested input element in the form is the existing element given in the editor

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: use backticks to avoid linting error

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
2020-08-30 22:50:46 -07:00
Ty Mick 474ae28d72
Fix number of noun (#38833)
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-08-30 22:15:58 -07:00
Quinn 29ab6c32ec
minor <code> tag fixes (#39046) 2020-08-30 23:12:04 -05:00
Shaun Hamilton fe3f0b2ac4
fix: remove quotation marks from code tag text (#38316) 2020-08-30 22:53:09 -05:00
Carlos Diaz e0a062a3e7
Changes order of padding, border, margin in introductory sentence. (#39414) 2020-08-30 22:28:42 -05:00
tomki1 9c3de2df24
added test to assert h1 is before h2 (#39040) 2020-08-30 22:13:30 -05:00
law27 b88c8ab351
Update use-the-s-tag-to-strikethrough-text.english.md (#38515)
Alphabet word is not wrapped inside double quotes

Co-authored-by: LawranceMichaelite <40236169+LawranceMichaelite@users.noreply.github.com>
2020-08-30 22:08:51 -05:00
Charles Ross 3db5bd7067
Update import-a-google-font.english.md (#38839)
Changed optional plural to possessive.
2020-08-30 22:07:46 -05:00
Ieahleen ed6246b91a
update description of "Nest an anchor element in a paragraph" as discussed in #38507 (#38524)
* remove parenthesis from description

As discussed in #38507 , I'm removing the phrase in parenthesis

* more succint description

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-08-30 22:01:40 -05:00