Commit Graph

481 Commits (926ddea5b038a90f4dc2a38cebe77bebf964634a)

Author SHA1 Message Date
Randell Dawson a6afaf1eb6 fix(curriculum) - added new tests to prevent invalid solutions in the Remove Elements from a Linked List by Index challenge (#36168)
* fix: added new tests to prevent invalid solutions

* fix: corrected tests and added solution

* fix: added linked word

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added by one

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: removed duplicate code

* fix: changed verbiage

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added extra line to avoid linting errors
2019-06-20 13:34:08 -04:00
Stan Choi a13d116aab fix(learn): Added solution for invert binary tree data structures challenge (#35922)
* fix: add solution for invert binary tree

* Fixed errors

* Used 2 spaces per request

* deleted images

* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update guide/english/certifications/coding-interview-prep/data-structures/invert-a-binary-tree/index.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: added extra line to avoid linting errors
2019-06-20 13:28:37 -04:00
Andrew Zaw 6f4a9ed721 Reorganized instruction text on multiple challenges (#35912)
* Reorganized instruction text on multiple challenges

* Fixed spaces

* Fixed spaces again

* Update curriculum/challenges/english/08-coding-interview-prep/data-structures/add-elements-at-a-specific-index-in-a-linked-list.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/data-structures/find-the-minimum-and-maximum-height-of-a-binary-search-tree.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: added code tags
2019-06-20 13:16:31 -04:00
Daniel Simeonov 81d7127a5d Added solution for English/Data-Visualization/Hover-tod3-element (#36220)
* Added solution for English/Data-Visualization/Hover-tod3-element

* Added full solution for Data-Visualization-D3/Hover-effect-to-d3-element

* fix: added extra line to prevent linting errors
2019-06-20 09:49:47 -07:00
Stan Choi 204ece1c70 fix: Add Solution in Curriculum/Challenges/English/08/CodingInterviewProblems/DataStructures/CREATE_LINKED_LIST_CLASS.md (#35819)
* fix: add solution create linked list class

* fix: added extra line to avoid linting error

* fix: renamed some variables
2019-06-20 10:11:26 -05:00
Tina Wang f203273e3a Solutions for sorting algorithm challenges in Coding Interview Prep/Algorithms (#35905)
* added bubbleSort solution

* added insertionSort

* fixed spacing in bubbleSort

* added selectionSort

* added a test

* Fixed a reference to the array with the wrong array name in the solution

* fix: added extra lines to avoid linting errors

* fix: added comments back into seed
2019-06-20 10:03:31 -05:00
Oliver Eyton-Williams 2024e238fa feat(curriculum): Add basic recursion lesson (#36200)
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-06-19 23:50:44 +05:30
leodaher 0be75e4b39 feat(curriculum): Add fetch challenge to the current curriculum. (#36033)
* Add fetch challenge for the current curriculum
2019-06-18 00:19:33 +02:00
Michał Kozłowski 8b40da02a3 multiple ternary operator challenge - add note about code readability (#36269)
* fix multiple ternary operator challenge

* Fix a typo in multiple ternary operator challenger

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Fix a typo in multiple ternary operator challenge #2

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-15 19:06:56 +01:00
adamthahir acbc07e0ff Fixed typo addressed in #36225 (#36227)
* Fixed typo addressed in #36225

* Updated as per discussion.
2019-06-15 13:02:01 +07:00
Mahesh Jaganiya 72aaddfc12 Improve Regex (#36078)
* Updated assert.match() to assert.equal()
2019-06-11 10:43:08 +02:00
anthonykyi 97f6b73a0e Added Binary Search Tree Challenge (#35907)
* Added Binary Search Tree Challenge

* fix yaml, fix solutions, fix tests

* Fixed recommended fixes
2019-06-10 23:35:21 -04:00
RIHANE ZAKARIA d86951f9c1 Added solutions for 3 challenges in English / data-structures (#35825)
* Solution for add-elements-at-a-specific-index-in-a-linked-list.english.md

* Solution check-if-an-element-is-present-in-a-binary-search-tree.english.md

* Solution for remove-elements-from-a-linked-list-by-index.english.md

* change indent level to 2 space for each level

* change indent level to 2 space

* change indent level to 2 space

* delete unnecessary new lines

* keep the same seed format , and delete unnecessary new lines

* delete unnecessary new lines

* fix: added review suggestions

* fix: Added link and code tags
2019-06-10 18:17:11 -04:00
Ugur Yilmaz 2a18b1a308 Consistency Update for label and input elements for last lessons (#36192)
* Updated to reflect the relationship between label and input elements

* Updated to reflect the relationship between label and input elements
2019-06-09 20:47:50 +01:00
Weibin Luo 8cb540fe85 fix: use lowercase for 'article' tag (#36222) 2019-06-09 07:47:09 -07:00
Oliver Eyton-Williams 43fa451a38 fix(curriculum): Change wording to talk about inheritance not cascade (#36110) 2019-06-08 19:09:00 -07:00
Kristofer Koishigawa 8f633299ef fix(challenges): Replace camper leaderboard project (#35763) 2019-06-09 05:23:28 +05:30
Siddhant Shekhar c1d3817732 fix : replaced test cases' string to make more sense (#36170) 2019-06-06 15:53:31 -07:00
Fabricio Asfora Lira 2da9d631ef fix: update "Note" formatting in "Remove Elements from a Linked List" challenge (#36173)
* fix: update note format

* fix: moved note to same line
2019-06-06 14:27:58 -05:00
Courtney Landau f70bcce463 spelling and grammar fixes (#36061)
* spelling and grammar fixes

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/advanced-node-and-express/send-and-display-chat-messages.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-06-04 16:22:23 -04:00
Randell Dawson 5a06b71ac4 fix: modified tests text (#36169) 2019-06-04 16:14:52 -04:00
Randell Dawson da610150ad fix(curriculum): added new test and corrected existing solution for Remove Elements from a Linked List challenge (#36121)
* fix: added new test and corrected solution

* fix: corrected test

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: corrected test

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: allow last element to be removed

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-04 14:55:50 -04:00
Val Lipat 6feda1badb Improve capitalization (#36166) 2019-06-04 07:52:52 -07:00
Randell Dawson 0303da3677 fix(curriculum): Convert blockquote elements to triple backtick syntax for Coding Interview Prep (#35998)
* fix: converted blockquotes

* fix: reverted several code blocks to blockquotes
2019-06-04 08:07:22 +01:00
Oliver Eyton-Williams 6745009490 fix(curriculum): Add more valid triples to the test (#35870) 2019-05-26 14:02:20 -07:00
Natalie Cardot db1b435775 Fix spelling (#36111)
"hachedEgg" -> "hatchedEgg"
2019-05-22 17:42:44 -05:00
Varun 3a4402434b fix(curriculum): Update challenge instructions (#36104) 2019-05-21 15:07:50 -07:00
Natalie Cardot 545b8a6f34 Modify if statement (#36088)
* Modify if statement

Change the solution so an empty string is returned when num is less than 1 rather than less than 0 for consistency with instructions.

* Add test 

New test checks that if num is 0, an empty string is returned

* Fix test 

Fixing errors in newly proposed test that checks that empty string is returned when num is 0

* Modify intermediate solution

Changing if statement in intermediate solution to check whether num is less than 1 rather than less than 0. (Also adding curly brackets to that solutions if/else statements.)

* fix: removed unnecessary assert message arguments
2019-05-20 21:08:20 -04:00
Natalie Cardot 39c43dbe8a Alter instructions (#36099)
Removing the word "below" since the object's properties are shown to the right of, not below, the challenge description/instructions.
2019-05-20 19:11:17 -04:00
Ahmad Abdolsaheb 8b4fb5a452 fix: imgur to s3 for various files without conflict (#36057) 2019-05-20 23:58:20 +05:30
Tom 21118bc26a fix/regex-lower-number-of-matches (#36004)
* fix/regex-lower-number-of-matches

* fix/update-guide

* fix/convert-blockquote-to-backticks
2019-05-17 23:53:00 +01:00
Mahesh Jaganiya e877d9c7d5 Semantic versioning required (#36074)
Node build fails for "1.2"
2019-05-17 09:07:16 -07:00
Randell Dawson 05f73ca409 fix(curriculum): Convert blockquote elements to triple backtick syntax for JavaScript Algorithms and Data Structures (#35992)
* fix: convert js algorithms and data structures

* fix: revert some blocks back to blockquote

* fix: reverted comparison code block to blockquotes

* fix: change js to json

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: convert various section to triple backticks

* fix: Make the formatting consistent for comparisons
2019-05-17 08:20:30 -05:00
Randell Dawson 4b4762716c fix(curriculum): Rewrote the Write Higher-Order Arrow Functions challenge and moved to Functional Programming section (#35954)
* fix: reworded and moved challenge

* fix: removed extra line

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix; removed extra line

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: reworded sentence

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-15 11:12:17 -05:00
Kyle Cheung 937dc23b5d fixed typos in custom css-variable challenge #36038 (#36041)
* fixed typos in custom css-variable challenge

* fix: Remove extra line
2019-05-14 20:31:03 +07:00
Randell Dawson dd6011b2cc fix(curriculum): Convert blockquote elements to triple backtick syntax for Data Visualization (#35995)
* fix: convert data visualization

* fix: reverted to blockquote

* fix: changed js to json

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: cleaned up code

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-05-14 07:04:05 -05:00
Randell Dawson 933350c148 fix(curriculum): Convert blockquote elements to triple backtick syntax for Front End Libraries (#35994)
* fix: converted blockquotes for react/redux

* fix: converted blockquotes for sass

* fix: changed jsx to js

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: changed jsx to js

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-05-14 07:01:32 -05:00
Randell Dawson 4dbd496b49 fix(curriculum): Convert blockquote elements to triple backtick syntax for Apis And Microservices (#35996)
* fix: converted blockquotes

* fix: revert to blockquote

* fix: changed js to http

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: reverted back to blockquote

* fix: reverted back to blockquote

* fix: reverted back to blockquote
2019-05-14 07:00:06 -05:00
Randell Dawson 46411ca1cd fix(curriculum): Convert blockquote elements to triple backtick syntax for Information Security And Quality Assurance (#35997)
* fix: converted blockquotes

* fix: added extra line before triple backtick syntax

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: corrected misc issues

* fix: properly closed em element

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-05-14 06:58:09 -05:00
Randell Dawson df8659ab8c fix(curriculum): Convert blockquote elements to triple backtick syntax for Responsive Web Design (#35993)
* fix: converted blockquotes to code fences
2019-05-14 10:11:58 +02:00
Matt Schlosser 08c4807b09 Added missing `</code>` in test text string (#36040) 2019-05-14 10:06:55 +02:00
Huyen Nguyen 791e589c93 Remove tag characters (#36037) 2019-05-14 00:14:16 +05:30
Courtney 860cc14894 fix to spelling error "instantiated" (#36032)
* fix to spelling error

* Update curriculum/challenges/english/06-information-security-and-quality-assurance/advanced-node-and-express/set-up-the-environment.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-13 10:00:07 -05:00
Tom fc547999fd fix/record-collection (#36002)
* fix/record-collection

* fix/remove-old-assert-messages

* fix/attempt-to-fix-build-error

* fix/attempt-to-fix-build-error

* fix/change-verbiage-and-tidy-up

* fix/remove-brackets-in-regex
2019-05-12 23:45:18 -04:00
Randell Dawson 48884f3a4a fix: changed to h4 > s in selector (#36023) 2019-05-11 19:09:08 -05:00
Randell Dawson 7437145bb4 fix: improved existing tests (#35801) 2019-05-09 09:01:50 -04:00
Yoelvis Jiménez fdb49ba89a Fix "ReferenceError: url is not defined" in challenge (#35415)
* Fix "ReferenceError: url is not defined" in challenge

I fix the challenge because issue #14002 
- The `url` variable is set to external resource `https://jsonplaceholder.typicode.com/posts`
- I replaced .textContent instead of .innerHTML (better practice)
- Checking for HTTP status of 201 instead of 200
All these suggestions by @HarplingeTom and "approved" by  @QuincyLarson. See the issue comments.
I test the code locally in my computer and this works 👍 
I modified and verify the tests according the new assessment.

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md

Minor typo: `<code>` to `</code>`

Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/post-data-with-the-javascript-xmlhttprequest-method.english.md

new declared as const

Co-Authored-By: yoelvisj <43357527+yoelvisj@users.noreply.github.com>
2019-05-08 20:07:36 -05:00
duytrinhvn 534824e232 Fix spelling error (#35925)
* Fix spelling error

* fix: changed be conformed to conform
2019-05-08 19:54:32 -05:00
Kyle Scheuerlein 3b5fbe3edb Improve formatting of Challenge Seed (#35854) 2019-05-08 18:32:01 -05:00
Deanna Tran 338d7ee8a7 Change "rest operator" to say "rest parameter" in challenges and guide (#35496)
* change es6 challenges rest operator to param

* fix rest parameter typos

* change rest operator to parameter in guide

* fix casing

* change rest operator to rest parameter in guide

* change rest operator to rest parameter in curriculum

* remove extra whitespace

* remove whitespaces

* remove whitespace

* fix: removed arabic file

* fix: removed chinese file
2019-05-08 16:30:24 +02:00