Commit Graph

905 Commits (94dee083aa607a9dd63dd423720f1addcc8c6510)

Author SHA1 Message Date
Ty Mick 2b3bd5c52d
Improve formatting and clarity in "Subset" (#38814)
* Improve formatting and clarity in "Subset"

* Change method name to isSubsetOf

Co-authored-by: Eric Leung <eric@erictleung.com>

* Change method name to isSubsetOf

Co-authored-by: Eric Leung <eric@erictleung.com>

* Fix method name in tests

* Fix variable name aIsSubsetOfB

* Fix method name in solution

Co-authored-by: Eric Leung <eric@erictleung.com>
2020-05-18 17:24:54 +02:00
Ty Mick aad173fbc9
fix(curriculum): "Set Class" description formatting 2020-05-18 16:39:02 +02:00
Shaun Hamilton 9ad4c98ecb
fix(curriculum): added test to allow any order solution (#38771)
* added test to allow any order solution

* add removeJSComments for tests
2020-05-18 16:02:03 +02:00
Anthony Zeng 51f0d703f1
fix(learn): Fixed test issue in HashTable exercise (#38441)
* fixed issue where test for removal from hash table was passing even if method implementation is incorrect
2020-05-18 15:39:55 +02:00
Ashraf Nazar e10a046f8a
fix(curriculum): use example in Modifying an Object Within a Nested Object challenge (#38468)
* fix: use example in modifying an object within a nested object exercise to explain how to do so

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-05-15 16:41:40 -05:00
anastasiasoenjoto f035a5c433
feat(learn): add fizzbuzz - RosettaCode challenges (#38610)
* create fizzbuzz challenge

* add lesson to meta file

* update testString

* fixed changes
2020-05-11 07:40:44 -05:00
Daksh Goyal 209d41fcdd
Fixes a Typo in Project Euler Problem 70 (#38782)
* Fixed a Typo in Eulers Problem 70

Line 15 should say "Find the value of <var>n</var>, 1 < <var>n</var> < 10**7, for which φ(<var>n</var>) is a permutation of <var>n</var> and the ratio <var>n</var>/φ(<var>n</var>) produces a minimum." instead of Find the value of <var>n</var>, 1 < <var>n</var> < 107, for which φ(<var>n</var>) is a permutation of <var>n</var> and the ratio <var>n</var>/φ(<var>n</var>) produces a minimum.

* Updated the Markdown 

Fixes the markdown to display proper superscript rather than just using ** to denote a superscript
2020-05-11 07:35:16 -05:00
Oliver Eyton-Williams 5e56a9a938
Feat(curriculum): scss not sass (#38764) 2020-05-09 20:01:18 +05:30
Kristofer Koishigawa b017ce192c
fix: dotall flag not supported in firefox (#38762)
Addresses https://github.com/freeCodeCamp/freeCodeCamp/pull/38546#issuecomment-625611675 where it's pointed out that Firefox doesn't support the /s regex flag yet. This workaround matches anything that's not blank.
2020-05-08 19:27:32 +02:00
anastasiasoenjoto e616197f9a
fix(learn): Made Changes to Instructions in BFS/DFS exercise (#38500)
* changes to bfs instructions

* added description on visual representation

* Added to the animation description

* Added information about stacks in the description

* Edited description for clarity

* Edited small details for grammar and clarity

* Apply suggested wording and typo fixes

Co-authored-by: Eric Leung <eric@erictleung.com>

* Add typo fixes to BFS challenge

Co-authored-by: Kyla Yujiri <27860923+kylayujiri@users.noreply.github.com>
Co-authored-by: Eric Leung <eric@erictleung.com>
2020-05-07 19:41:20 -05:00
Eric Elli f757840624
fix(learn): add test to return early pattern (#38751)
* add: test to return early pattern

Currently no test for a = 0 or b = 0. This results in if(a<=0 || b<= 0) also being a valid solution

* fix: typo in test text

* fix: update return early pattern test

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-05-07 14:37:48 -05:00
Rostyslav Ugryniuk 8a858b470c
Fix: largestPrimeFactor function, Add: largestPrimeFactor(8) test (#38756)
* Fix `largestPrimeFactor(8)` result
* Improve `largestPrimeFactor` performance
* Add `largestPrimeFactor(8)` test
2020-05-07 13:31:59 -05:00
Shaun Hamilton b1de8ee4f8
fix(curriculum): change project codepen links (#38746) 2020-05-06 19:53:27 +05:30
anastasiasoenjoto f529104348 removed line breaks, fixed typos and wording of instructions 2020-05-06 18:24:39 +09:00
anastasiasoenjoto bfd9a6bcbc add self describing numbers to meta.json 2020-05-06 18:24:39 +09:00
anastasiasoenjoto 7981d40a13 create self-describing numbers lesson 2020-05-06 18:24:39 +09:00
Jeremy Fiel d69c0592ec revise regex for test "Use the correct ExpressJS method..." 2020-05-06 13:39:00 +09:00
Hassaan Pasha c5a087f8b7 fix (curriculum): corrected the valyue of the decrypted message 2020-05-05 19:00:48 +09:00
Bhanu Pratap Singh Rathore 1fc55513a4
feat(interview-prep): Converting and Transfering Rosetta problems (#38624)
* feat(interview-prep): Converting and Transfering Rosetta problems

* feat(interview-prep): Meta fix

* fix: adjusted descriptions and some test cases

* fix: Descriptions fixed

Co-authored-by: Kris Koishigawa <scissorsneedfoodtoo@gmail.com>
2020-05-05 18:52:32 +09:00
Twaha Rahman c0e2b65864
Wrapped all the test results with quotation (#38706) 2020-05-02 09:25:55 -05:00
Michael Schneider 1f2b66a432
feat: edit 2nd test description for clarity (#38661)
current description logically fits, yet fails this solution: myVar = ++myVar;
2020-05-02 08:27:52 -05:00
Farjad Fazli fd85f57376
fix(learn): fixed typo "in the left" should be "at the left" (#38651)
* Fixed typo "in the left" should be "at the left"

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-equality-operator.english.md

Co-Authored-By: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-05-02 08:17:11 -05:00
Joel Duran 7035516483
fix: typo in 'Build JavaScript Objects' (#38690) 2020-04-30 17:41:55 +05:30
Oliver Eyton-Williams f2f5dbc4b8
fix(curriculum): improve declaration tests (#38546) 2020-04-29 16:39:48 +05:30
Sagar Kharabe 18ca64ed4e
Update solution for use-breadth-first-search-in-a-binary-search-tree.english.md (#38221)
* Update use-breadth-first-search-in-a-binary-search-tree.english.md

* Update curriculum/challenges/english/08-coding-interview-prep/data-structures/use-breadth-first-search-in-a-binary-search-tree.english.md

Committed suggested changes

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* add debugging function to solution

Ensured seed code and solution matched-up.

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-04-28 17:36:02 -05:00
Ashraf Nazar 46e0748af3
fix(curriculum): ensure algorithm does not include the Array method `… (#38520)
* fix(curriculum): replace comments with empty strings in merge-sort challenge

* Update curriculum/challenges/english/08-coding-interview-prep/algorithms/implement-merge-sort.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-04-27 07:28:37 -05:00
Gabriel Majeri 9230db42ee
fix(learn): update currency name in cash register challenge (#38637) 2020-04-26 17:38:22 +05:30
Kimon a3b54d34cb
Differentiate between test & match (#38498)
* Differentiate between test & match

I noticed that nowhere was there a mention that .match() and .test() pass in and are applied to opposite objects.  This would've saved me a few minutes of searching during later challenges that assume this is understood.

* Add in .match & .test difference after example

* fix: add spaces to stop lint errors

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-04-25 08:35:46 -05:00
yitzhak-bloy 73b712ba75
Adding a test in problem-14-Longest-collatz-sequence.english.md (#38401)
* Adding a test in problem-14-Longest-collatz-sequence.english.md

Adding a test in problem-14-Longest-collatz-sequence.english.md

* fix(curriculum): use more efficient algorithm

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-04-24 06:37:20 -05:00
Prayag 17be165d66
Add solution d3challenges (#38222)
* added solutions to data visualization with D3

* Update add-a-tooltip-to-a-d3-element.english.md

* Update add-attributes-to-the-circle-elements.english.md

* Update add-axes-to-a-visualization.english.md

* Update add-document-elements-with-d3.english.md

* Update add-inline-styling-to-elements.english.md

* Update add-labels-to-scatter-plot-circles.english.md

* Update change-styles-based-on-data.english.md

* Update change-the-color-of-an-svg-element.english.md

* Update change-the-presentation-of-a-bar-chart.english.md

* Update create-a-bar-for-each-data-point-in-the-set.english.md

* Update create-a-linear-scale-with-d3.english.md

* Update create-a-scatterplot-with-svg-circles.english.md

* Update display-shapes-with-svg.english.md

* Update dynamically-change-the-height-of-each-bar.english.md

* Update dynamically-set-the-coordinates-for-each-bar.english.md

* Update invert-svg-elements.english.md

* Update learn-about-svg-in-d3.english.md

* Update select-a-group-of-elements-with-d3.english.md

* Update set-a-domain-and-a-range-on-a-scale.english.md

* Update style-d3-labels.english.md

* Update work-with-dynamic-data-in-d3.english.md

* Update use-a-pre-defined-scale-to-place-elements.english.md

* Update use-dynamic-scales.english.md

* Update use-the-d3.max-and-d3.min-functions-to-find-minimum-and-maximum-values-in-a-dataset.english.md

* Update work-with-data-in-d3.english.md
2020-04-24 06:34:53 -05:00
Jeremy Fiel 1ee03344ef
fix: update reference to Pug version for Set up a Template Engine challenge (#38572)
* update reference to Pug version, relates to {freeCodeCamp/boilerplate-advancednode/pull/9}
2020-04-23 22:09:20 +02:00
Ashraf Nazar c2558b3816
fix(Curriculum): ensure code that includes and is not equal to the fl… (#38497)
* fix(Curriculum): ensure code that includes and is not equal to the flat or flatMap methods do not fail the test suite

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/steamroller.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update steamroller.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-04-23 14:59:58 -05:00
Keith Warter 56f6d4654c
fix(learn): update solutions in interview-prep challenges (#38430)
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-04-23 02:14:50 +05:30
Ashraf Nazar 3a82e9f857
fix: add more examples on how to set key-value pairs (#38472)
* fix(Curriculum): update examples on how to set key-value pairs

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-key-value-pairs-to-javascript-objects.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-key-value-pairs-to-javascript-objects.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update add-key-value-pairs-to-javascript-objects.english.md

* Update add-key-value-pairs-to-javascript-objects.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-04-22 11:20:30 -05:00
Shaun Hamilton 17585b63f8
added const to test string (#38583) 2020-04-21 09:12:53 +02:00
Bhanu Pratap Singh Rathore 1204c72657
feat(interview-prep): Converting and Transferring Rosetta problems (#38371)
* feat(interview-prep): Converting and Transferring Rosetta problems
2020-04-21 13:20:40 +09:00
piouson 2b60f3e61e
fixed arrow function with no curly braces failing IIFE test (#38544)
* fixed arrow function with no curly braces failing IIFE test

* added iife 2nd test fix and 3 new solutions
2020-04-20 11:04:28 +02:00
Shaun Hamilton d739a0cc5d
fix(curriculum): change debugging console lesson (#38554)
* changed lesson to match behaviour

* Update wording for debugging

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update wording from suggestion

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* all suggestions with note

* fix: replaced code tags with backticks for markdown

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Ashraf Nazar <ashraf.caspian@gmail.com>

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-04-18 16:31:41 +05:30
Beau Carnes 756f33775e
fix(learn): update video challenge (#38564)
* fix(learn): update video challenge

* fix: update scrimba URL

Co-authored-by: Mrugesh Mohapatra <me@raisedadead.com>
2020-04-18 16:16:31 +05:30
Ashraf Nazar 99c2f0d4f5
fix(curriculum): allow hex triplets for red and green colors to pass tests (#38523) 2020-04-12 17:15:31 +03:00
Iván Franco 1d87dd82e3
updated english file (#38482) 2020-04-11 22:52:54 -05:00
kundan kumar 19c514b702
Fix/functional programming challange (#38516)
* Improved readbility of FP challage

* replace the with a

* corrected gramatical mistake
2020-04-11 21:20:44 -05:00
Tom 84edc07076
fix: remove unneeded assert text (#38453) 2020-03-30 18:23:18 +02:00
Agata Stawarz 02f5609c99
Remove double slashes in Strip control codes challenge (#38466)
* Remove double slashes in Strip control codes challenge

* Remove unnecessary message argument from assertions

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-03-30 17:23:02 +02:00
Randell Dawson a5818506f0
fix(curriculum): remove setup code not needed anymore from Testing Objects for Properties challenge (#38454)
* fix: remove setup code

* fix: remove call to function
2020-03-28 02:25:04 +12:00
Sohaib 740d57d962
fix (learn): fixed spelling mistake in authentication-strategies.md (#38460) 2020-03-27 06:23:28 -07:00
Keith Warter 3ee1c39e41
Adding a solution for reversing a DoubleLinkedList. (#38427) 2020-03-26 21:01:49 -07:00
Enock Kasaadha 06d97ac813
fix(curriculum/learn): moved the comment one line below. (#38422)
moved the comment ` //add code above this line` in the text editor of [this challenge](https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/es6/use--to-import-everything-from-a-file) one line below so that it makes meaning.
2020-03-26 20:01:58 -05:00
Joseph Crandal f142eed6ef
Fix pig latin challenge description (#38018)
* Fix pig latin challenge description

Added statement for beginning with consonants and if a vowel does not begin with a vowel.

* fix: update description/instructions

* fix:  removed extra line break

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix:  removed extra line break

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-26 23:38:07 +01:00
Randell Dawson 1fdb691996
fix(learn): updated tests and deleted old sample code (#38450) 2020-03-26 23:12:18 +05:30
Hassaan Pasha 4fbce07792
fix: improve test regex to validate disallowed methods that can be bypassed by prototype reassignments and/or otherwise (#38214)
* fix: improve test regex to validate disallowed methods that can be bypassed by prototype reassignments and/or otherwise

* fix: fixing regex pattern
2020-03-26 08:13:34 -07:00
Relsig bb7a50e341
Enable newlines in Authentication with Socket.IO, test 3 (#37862)
* newlines in Authentication with Socket.IO, test 3

Both my original formatting and glitch's "format this file" button add a newline between "io.use("  and  "passport.authorize"
".+" catches one or more of anything that isn't a newline.
"[^]+" catches one or more of anything including newlines. 
This change updates the test accordingly so people who use glitch's formatting don't get left searching for assistance

* less permissive match to prevent shenanigans

Won't work with comments still.

* fix my own silliness
2020-03-26 08:09:34 -05:00
Arthur 7ad220d1ac
fix: add tests for exercise tracker (#37696)
* fix: add tests for exercise tracker
2020-03-26 10:39:06 +01:00
Randell Dawson e0e6334628
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 3 of 4 (#38264)
* fix: remove example code from challenge seed

* fix: remove declaration from solution

* fix: added sum variable back in

* fix: reverted description back to original version

* fix: added examples to description section

* fix: added complete sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: corrected typo

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: reverted to original desc with formatted code

* fix: removed unnecessary code example from description section

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: failiing test on iterate through array with for loop

* fix: changed to Only change this line

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
Co-authored-by: moT01 <tmondloch01@gmail.com>
2020-03-25 16:07:13 +01:00
Randell Dawson 50f15886b8
fix(curriculum): Strip comments from user code for Use Destructuring Assignment to Extract Values from Objects challenge (#38213)
* fix: strip user code to improve tests

* fix: removed closing section tag messing up tests
2020-03-25 13:28:17 +01:00
Kalyanasundaram 8b0cbd6f83
Modify tests for testing objects for properties challenge (#38414)
* Stronger test cases for testing objects for properties

Change function signature to take in a custom object to be tested

* YML formatting mistake

* Yaml no space in string

* Small one more fix - most likely final

* REmove double space in return

* Update instruction Section
2020-03-24 22:09:57 -07:00
Randell Dawson 1f2a93b646
fix: added additional test for altText (#38395) 2020-03-23 07:02:34 -05:00
Keith Warter 022bbdd1b0
Adding a solution for searching within a linked list for future students (#38326)
* Adding a solution for future students

* fix: added new tests and correctied existing tests

* Adding isEmpty method as well

* Update curriculum/challenges/english/08-coding-interview-prep/data-structures/search-within-a-linked-list.english.md

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-03-21 09:30:14 -05:00
Vincent Shury 6920634e6c
TYPO-FIX JS-regex-match-non-whitespace-characters (#38407)
Added Markdown to correctly display second test
2020-03-20 21:13:48 -07:00
Sanket Kogekar f25d035e9d
add: solution to project euler problem 23 md file (#38369) 2020-03-18 16:37:26 -07:00
Hassaan Pasha a282c24bf4
fix (curriculum): added console output checks for the inheritance challenge (#38360)
Co-authored-by: Hassaan Pasha <hassaan.pasha@teamo.io>
2020-03-14 21:55:21 -07:00
Sanket Kogekar 705cc32579
add: solution to project euler problem 22 md file (#38263)
* add: solution to project euler 22 md file

* Copied the array instead of using it directly

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-13 14:31:13 -07:00
Shivam saini 4ef78f7f7d
Update use-recursion-to-create-a-countdown.english.md (#38366) 2020-03-13 16:05:59 +01:00
Randell Dawson cc190aba99 fix: removed assert message arguments 2020-03-12 20:46:46 +09:00
Bhanu Pratap Singh 72bc067e6b feat(interview-prep): Regenerated IDs 2020-03-12 20:46:46 +09:00
Bhanu Pratap Singh ec0a5e0b6f feat(interview-prep): Updated descriptions and corrected syntax 2020-03-12 20:46:46 +09:00
unknown e4a6f5563f feat(interview-prep): Converting and transferring Rosetta problems 2020-03-12 20:46:46 +09:00
Randell Dawson fde8c05a20
fix(curriculum): strip comments from CSS in testString to fix bug caught by tests (#38351)
* fix: strip-comments-from-css

* fix: added challenge referenced in issue

* fix: added call to function removeCssComments

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-11 08:56:34 -05:00
Hassaan Pasha 8c435c8b75
fix (curriculum): changed the index to 0 for the fibonacci sequence challenge (#38331) 2020-03-10 13:43:41 +03:00
Ashraf Nazar a2d31afe81
fix: Update test in Redux challenge to accomodate backticks (#38345) 2020-03-10 12:15:50 +03:00
Randell Dawson c401fc7f83
fix(curriculum): removed solution required comment from 6 challenges (#38339)
* fix: removed solution required comments

* fix: fixed two more challenge soltuions with solution required comment

* fix: remove debugging code

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-09 13:58:46 +01:00
Randell Dawson 9252f96566
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 4 of 4 (#38267)
* fix: consolidate comments


Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-03-08 15:46:28 +01:00
Shivam dbf3815fc7
added:solution for Coding Interview Prep/Data Structures-Create a Map Data Structure (#38337)
* add: solution to Data Structures-Create a Map Data Structure

* Proper usage of -hasOwnProperty

removed unnecessary returns
2020-03-07 22:07:40 -08:00
Hassaan Pasha 3a47c5411f
fix (curriculum): made the order of the required code to be re… (#38320)
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-03-06 12:44:39 +05:30
Tom 17a55c6e18
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 1 of 4 (#38258)
* fix: consolidate/remove comments

* fix: remove => from comment

* fix: reverted changes to add same changes to another PR

* fix: removed 'the' from sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: removed 'the' from the sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-04 13:08:54 -06:00
Randell Dawson 6a7a7e6d7d
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 2 of 4 (#38259) 2020-03-03 10:18:30 +03:00
Senipah 012e5c848b
reword instruction referring to 3d array (#38272) 2020-02-29 22:35:53 -08:00
Ashraf Nazar 181ac1e8ad
fix: Update test for wrapping strong tag around text to include periods at the end (#38305) 2020-02-29 01:02:39 -05:00
Oliver Eyton-Williams 2d7b1255cc
fix: add missing .english extensions (#38298) 2020-02-28 07:19:22 -08:00
Kristofer Koishigawa 6cfd0fc503
fix: improve Project Euler descriptions, challenge seeds, and test cases (#38016)
* fix: improve Project Euler descriptions and test case

Improve formatting of Project Euler test descriptions. Also add poker hands array and new test case for problem 54

* feat: add typeof tests and gave functions proper names for first 100 challenges

* fix: continue fixing test descriptions and adding "before test" sections

* fix: address review comments

* fix: adjust grids in 18 and 67 and fix some text that reference files rather than the given arrays

* fix: implement bug fixes and improvements from review

* fix: remove console.log statements from seed and solution
2020-02-28 06:39:47 -06:00
Randell Dawson 41718abf76
fix(learn): consolidate comments for responsive web design cert (#38256)
Related to PR #38040

This PR is an attempt to consolidate/remove as many comments in the challenge seed code in the Responsive Web Design certification challenges, to be able to create a small translation lookup object for translating the English comments to other languages.
2020-02-27 20:50:46 +05:30
Harsh Savergaonkar c21c9f0acb
Added meaning of ones in adjacency matrices (#37048)
* Added meaning of ones in the matrix

* Apply suggestions from code review

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: add slash to avoid markdown lint error

Co-authored-by: mrugesh <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-27 06:54:11 -06:00
Sanket Kogekar 1a87f1f7c0
add: solution to project euler problem 20 (#38257)
* add: solution to project euler problem 20

* Update curriculum/challenges/english/08-coding-interview-prep/project-euler/problem-20-factorial-digit-sum.english.md

Accidentally added last line. Calling function is unnecessary in solution.

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* right place for starting braces

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* moved starting brace to previous line.

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-02-26 14:22:40 -05:00
Prakash Kumar c9d8c2a73c
fix(learn): typo in Serialization of a User Object (#38262) 2020-02-26 15:07:32 +05:30
Vincent Shury b49b9f3e3c
Typo whitespace fix in access-multi-dimensional-arrays-with-indexes.english.md (#38247)
* Update access-multi-dimensional-arrays-with-indexes.english.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-24 17:02:53 +01:00
Randell Dawson 78156a65f0
fix(curriculum): Added test to Return a Sorted Array Without Changing the Original Array challenge to validate new array is returned (#38105)
* fix: added test to validate new array is returned

* fix: changed text to reflect changed test

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-24 15:30:48 +01:00
Tom a09ffadd5a
fix: responsive image challenge (#37934)
* fix: responve image challenge

* fix: bad solution

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-20 22:53:30 +05:30
Oliver Eyton-Williams b0f1fa4b96
fix: make recursion challenge more intuitive (#37399) 2020-02-20 21:36:33 +05:30
Igor Snitkin dc7092ecd1
(fix learn): Update description to accommodate tests (#38224) 2020-02-19 00:13:34 +05:30
lasjorg 9a5ae756ac
fix(challenge): check inline style for color (#38211)
* fix(challenge): check inline style for color

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/change-the-color-of-text.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-02-18 23:38:16 +05:30
Oliver Eyton-Williams f84173866a
fix: make frankenSplice tests more robust (#38225) 2020-02-18 21:24:24 +05:30
Prakash Kumar c730f4aef4
Update hash-and-compare-passwords-synchronously.english.md (#38226) 2020-02-18 09:28:38 +01:00
Prayag 701bbc2ae9
added solution to d3 challenge add-labels-to-d3-elements (#38208) 2020-02-13 20:59:16 +05:30
kundan kumar 971c62ab53
fix : Unclear test output use-array.map-to-dynamically-render-… (#38191) 2020-02-13 02:41:36 +05:30
Hassaan Pasha 2f951f0dff
fix: edited the duplicate test guideline to mirror the actual… (#38199) 2020-02-12 20:47:24 +05:30
srdubya 3fd336d3e9
fix(learn): correcting Hash Table Lookup Efficiency (#38130)
A hash table provide a lookup of O(1), not O(n).
2020-02-12 12:27:47 +05:30
Hassaan Pasha 0498e27902
fix: added white space checks including newlines to ensure pro… (#38166)
* fix: added white space checks including newlines to ensure proper validation of trim method

* fix: Addressing comments
2020-02-12 12:17:54 +05:30
Ashraf Nazar 5feabd762c
fix: Add tests to check lazy matching is applied and that the string "h1" is not matched (#38193) 2020-02-11 10:17:51 -06:00
Hassaan Pasha 80ba943ca3
fix: fixed regex for validating newlines in for loops (#38180) 2020-02-09 18:43:43 -06:00
Josh Soref 004b99bf8f chore: fix typos in spelling (#38100)
* spelling: accidentally

* spelling: announce

* spelling: assembly

* spelling: avoid

* spelling: backend

* spelling: because

* spelling: claimed

* spelling: candidate

* spelling: certification

* spelling: certified

* spelling: challenge

* spelling: circular

* spelling: it isn't

* spelling: coins

* spelling: combination

* spelling: compliant

* spelling: containers

* spelling: concise

* spelling: deprecated

* spelling: development

* spelling: donor

* spelling: error

* spelling: everything

* spelling: exceed

* spelling: exist

* spelling: falsy

* spelling: faulty

* spelling: forward

* spelling: handle

* spelling: indicates

* spelling: initial

* spelling: integers

* spelling: issealed

* spelling: javascript

* spelling: length

* spelling: maximum

* spelling: minimum

* spelling: mutable

* spelling: notifier

* spelling: coordinate

* spelling: passport

* spelling: perform

* spelling: permuter

* spelling: placeholder

* spelling: progressively

* spelling: semantic

* spelling: submission

* spelling: submit

* spelling: translations

* spelling: turquoise

* spelling: visualization

* spelling: without

* spelling: registration

* spelling: representation
2020-02-08 23:59:10 +05:30