Commit Graph

558 Commits (98bf5d72de61e9aa9e479e95b9a61031bdd8f7cc)

Author SHA1 Message Date
Dario-DC 1bba1b15e7
fix(curriculum): inaccuracy in dna pairing challenge (#46647)
fix inaccuracy in dna pairing challenge
2022-06-24 17:20:58 +02:00
Ilenia 59abda3ff2
fix(curriculum, i18n): solve issues in crowdin comments (#46597) 2022-06-21 19:53:13 +05:30
Ivan Pavičić 258e9d0130
fix(curriculum): var keyword to global-scope-and-functions (#46553)
fix(curriculum): var to global-scope-and-functions

Added the `var` keyword in global-scope-and-functions challenge instructions to avoid confusion
2022-06-18 16:34:51 -07:00
Muhammed Mustafa e474d4cd17
chore(curriculum): Front End catagories links standardized (#46418) 2022-06-13 20:18:23 -05:00
sidemt 6d7b49ffe0
fix(curriculum): remove reference to Mad Libs (#46490) 2022-06-13 20:56:38 +02:00
Muhammed Mustafa 5282994ad8
Chore(curriculum): removing copywriten wiki content (#46436)
* remove mad-labs link

* changed similar to wiki text in legacy JS

* let's go Sam got my back here as well

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>

Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2022-06-10 08:54:51 -05:00
Bill Cheng 8397129aaa
fix(curriculum): Add test output to not change strings assigned to variables (#46353) 2022-06-05 10:51:36 -05:00
Titi 14bf77d3b8
chore: removed unneeded check for semicolon 2022-06-04 11:09:55 -05:00
L4rryFisherman 0562a41781
fix(curriculum): increase readability of the introduction (#46300)
* fix(curriculum): increase readability of the introduction

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/generate-an-array-of-all-object-keys-with-object.keys.md

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
2022-06-03 16:15:25 -05:00
L4rryFisherman 3d143b6aaa
fix(curriculum): clarify that 'g flag' signifies 'global flag' (#46277)
* Update find-more-than-the-first-match.md

* fix(curriculum): clarify that 'g flag' signifies 'global search flag'
2022-06-02 20:05:04 +02:00
Muhammed Mustafa e15889a53e
fix(curriculum): external orbital link in legacy JSA (#46266)
* fix(curriculum): external orbital link in legacy JSA

* Shaun for the rescue

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-06-01 07:53:44 -07:00
DanielRosa74 49d963b28b
fix(curriculum): Typo on line 24 (#46175)
Changed 0 for 9
2022-05-27 18:22:53 +05:30
Muhammed Mustafa d38a6d3e2e
fix(curriculum): external roman numeral links in JS projects (#46171)
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
2022-05-27 16:31:28 +05:30
Muhammed Mustafa bfae58d2c0
fix(curriculum): external ROT13 link in JS projects (#46169) 2022-05-27 10:54:07 +02:00
Muhammed Mustafa 924fd04760
fix(curriculum): external golf wiki link in JS (#46170) 2022-05-27 10:51:40 +02:00
Muhammed Mustafa 864f4a199a
fix(curriculum): removed link in JS basic-JavaScript (#46143)
* fix(curriculum): removed link in JS basic-javascript

* removed JSON and its example
2022-05-26 16:36:21 +02:00
Muhammed Mustafa 5b4dc4ab6d
fix(curriculum): external Mad Libs link in JS steps (#46157) 2022-05-26 12:43:20 +05:30
Muhammed Mustafa 93f32b45e2
fix(curriculum): external card counting link in JS (#46158) 2022-05-26 12:42:39 +05:30
Muhammed Mustafa f2592999f3
fix(curriculum): external floating link in JS (#46159)
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
2022-05-26 12:41:58 +05:30
Muhammed Mustafa 9f73059c03
fix(curriculum): external wiki link in JS A&DS (#46144)
* fix(curriculum): external wiki link in JS A&DS

* reorder the phrases
2022-05-25 10:50:19 -07:00
Muhammed Mustafa ddc55af8de
fix(curriculum): external link in words blank JS (#46145) 2022-05-26 00:14:37 +07:00
Benjamin Lu 2da688fbfe
fix(curriculum): add switch statement spaces for consistency (#46141)
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
2022-05-25 22:37:00 +05:30
Naomi Carrigan fe71a9cf25
feat: new js cert (#45873)
* chore: move files

* wip: i have no idea what i am doing

* feat: finish up the logic

* chore: use order from randy sheet

* chore: standardise titles

* feat: fix layout for new js projects

* fix: utils test

* fix: challenge tests

* fix: ignore show new curriculum on non-english tests

* chore: help category????

* fix: if these tests would fail locally that'd be great

* chore: duplicate ids
2022-05-16 11:53:45 +02:00
Luke Harrison e4c6883a20
fix(curriculum): updated wording on understanding uninitialized variables (#45860)
* updated wording on understanding uninitialized variables

* updated wording for case b to match case a

* updated case c to match the wording of both case a and b
2022-05-05 19:05:30 +02:00
Karen Lowe ccce74ed6a
fix(curriculum): typo lets -> let's (#45867)
Co-authored-by: Karen Lowe <klowe@ancestry.com>
2022-05-05 11:42:28 +02:00
apvarghese19 84b4b2e7c2
fix(curriculum): allow spaces before opening parenthesis in .log call (#45748)
Co-authored-by: Andrew Varghese <andvarg@umich.edu>
2022-04-25 14:47:46 +01:00
Naomi Archibong 4ff9c2a6fc
feat: update wording for string length (#45602) 2022-04-15 08:13:42 -07:00
Oliver Eyton-Williams 4cc20172c5
fix: fallback to english challenges (#45635)
* fix: fallback to english challenges

All challenges will use the english version if a translated file is not
available.  SHOW_NEW_CURRICULUM still gates what's shown in the client.

* refactor: use closures to simplify createChallenge

* refactor: remove messy destructure

* refactor: add meta via helper

* fix: fallback to [] for meta.required

* fix: repair challenge.block

* refactor: use CONST_CASE for meta + challenge dirs

* fix: catch empty superblocks immediately

* fix: clean up path.resolves

* fix: invalid syntax in JS project steps

* fix: default to english comments and relax tests

Instead of always throwing errors when a comment is not translated, the
tests now warn while SHOW_UPCOMING_CHANGES is true, so that tests will
pass while we're developing and allow translators time to work.

They still throw when SHOW_UPCOMING_CHANGES is false to catch issues
in production

* test: update createCommentMap test

* refactor: delete stale comment

* refactor: clarify validate with explanatory consts

* feat: throw if audited cert falls back to english

* fix: stop testing upcoming localized curriculum
2022-04-15 09:17:49 -05:00
JuumanBeing c92a71e11e
fix(curriculum): include note about counting spaces by .length property (#45641)
Added a sentence to bring attention to the fact that the JS string .length property counts space characters.
2022-04-09 12:27:50 +02:00
Lenin Kennedy a6d2660c7c
fix(curriculum): remove style note (#45625) 2022-04-05 13:49:27 -06:00
Radi Totev b2c05d3c79
fix(curriculum): add removing element to the mutation test (#45581) 2022-04-05 15:59:46 +02:00
Suph 405675261d
fix(curriculum): clear up confusion of array index (#45576) 2022-03-30 20:45:20 +02:00
Radi Totev 0a3690572c
fix: failing challenge test because of commented out code (#45492)
id: 587d7b87367417b2b2512b43
title: Use Arrow Functions to Write Concise Anonymous Functions
forumTopicId: 301211
dashedName: use-arrow-functions-to-write-concise-anonymous-functions

User code tests fail when seed code is left and commented out.
2022-03-29 08:36:13 -07:00
Radi Totev 4d620dea1a
fix(curriculum): allow spaces before brackets (#45494)
* chore(curriculum): update regex in use-braket-notation-* tests

Update regex used in tests, so that tests are more forgiving and spaces tolerant.

* Allow for spaces within brackets
2022-03-22 13:52:13 +01:00
Naomi Carrigan d781c63fdf
chore: resolve flagged Crowdin issues (#45442)
* chore: resolve bengali issues

* chore: resolve french issues

* chore: resolve hebrew issues

* chore: resolve persian issues

* chore: resolve portuguese brazilian issues

* chore: resolve russian issues

* chore: resolve spanish issues

* chore: resolve japanese issues
2022-03-19 13:26:57 +05:30
Anjum Iqbal aa7c58f7e5
fix(curriculum): add missing quotation marks (#45460) 2022-03-18 18:28:42 +01:00
Kai Wei Mo ce5b9b8aba
fix(curriculum): augment test for adding tracks property (#45424)
* Only English

* Consitent quotation marks
2022-03-17 19:13:16 +00:00
Naomi Carrigan dab600b4b1
chore: refactor the everything be true challenge (#45433) 2022-03-16 08:29:46 -07:00
HenMoshe d3304276ca
fix(curriculum) : Make tests stricter for challenge "Decrement a number with javascript" (#45242)
* Make tests stricter for challenge "Decrement a number with javascript" #44648

* Update decrement-a-number-with-javascript.md
2022-03-09 22:47:02 -06:00
Naomi Carrigan 1c65d5d34a
fix(curriculum): remove callback thereby stripping js comments (#45133)
* fix: strip js comments

* fix: revert helper export, better test approach

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-02-24 16:29:56 +05:30
HenMoshe ea416b6dc2
fix(curriculum): add result of comparison expression evaluation to the inline comment (#45224)
* Add result of comparison expression evaluation in the inline comment #45183

* Apply suggestions from code review

thanks!

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-02-23 18:58:42 +01:00
zelf0 3668422083
fix: add divider to stand in line challenge in basic javascript section (#45180)
* Fix: Update grammar in PR documnetation

* fix: add divider to stand in line challenge in basic javascript section

* Undo change outside of scope
2022-02-21 22:44:27 +05:30
Poonkuzhali 6f628e6133
fix(curriculum): add test case to check country code (#45100)
* Added new test case to argument optional challenge

* Added new test case to telephone num js challenge
2022-02-18 10:09:51 -08:00
Jagruti Tiwari 9b7d7ba716
fix(curriculum): inconsistancy on const Naming cases (#45149) 2022-02-17 11:35:16 -08:00
Madhu Sudhan Reddy Vinta 92778f1b2f
Bugfix in typeof lesson in Javascript debugging (#45118)
* Local scope and functions: Make the example less confusing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/local-scope-and-functions.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

* Fix bug in typeof lesson in debugging javascript

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/use-typeof-to-check-the-type-of-a-variable.md

Co-authored-by: Ilenia <nethleen@gmail.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
Co-authored-by: Ilenia <nethleen@gmail.com>
2022-02-16 20:14:12 +01:00
Madhu Sudhan Reddy Vinta 0a895dad47
fix(curriculum): make example less confusing (#45088)
* Local scope and functions: Make the example less confusing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/local-scope-and-functions.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-02-11 12:08:46 -08:00
Poonkuzhali f4077cab7f
feat: added new test case to argument optional challenge (#45076) 2022-02-10 17:17:07 -06:00
Vaibhav 9ffc7b4711
fix(curriculum): add two edge test cases to the sorted union problem (#44860)
* fix: fixed solution of sorted union

* fix: improved solution of sorted union problem
2022-02-02 19:28:31 +01:00
Aakash Pal 1c56d4cdda
fix: remove double space (#44837)
* fix: typo in javascript-algorithms-and-data-structures > object-oriented-programming > understand-own-properties

* revert all the files with translations

* fix last commit error and remove changes from translated files
2022-01-19 22:19:43 +00:00
Nicholas Carrigan (he/him) 8954449625
feat: refactor the refactor challenge (#44770) 2022-01-17 09:57:15 +01:00