* fix: use calculated space for test
* fix: reworded comment
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix: changed After Test to Before Test
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
* fix(curriculum): add full, working solution for accessibility challenge.
This commit replaces a JavaScript only solution where a full, working
solution should have been written.
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
Co-Authored-By: rimij405 <effendiian@gmail.com>
* fix(challenge): update text to give an explanation of wrapping
* fix(challenge): simplify challenge text
* fix(challenge): update challenge text add solution
* fix(challenge): remove line breaks
* fix(challenge): make second instruction more clear
* fix: solution added and broken test updated.
* fix: Change test to equality and finish solution
* Update use-css-selectors-to-style-elements.english.md
* Update link-to-external-pages-with-anchor-elements.english.md
If you write "`anchor` element" instead of "`a` element", you should also write "`hyperreference` attribute", instead of "`href` attribute".
Suggestion: write "`a` (_anchor_) element", or "anchor (`a`) element", to communicate the element name explicitly and gloss it at the same time.
The `<code>` sections should be valid code as far as possible.
* Change md to html
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
* Revert "Don't mark up 'anchor' as code"
This reverts commit 50c6a3a7c9.
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
* fix: clarify how to create multiple box shadows
* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/add-a-box-shadow-to-a-card-like-element.english.md
<code> tags added to 'color' property in order to make it look more consistent with the other propertes of 'box-shadow'.
Co-Authored-By: BA1RY <shashank.bairy04@gmail.com>
* fix: Test fails with comments
* fix: Account for last line of code
* fix: false positive for padding clockwise notation
* fix: false positive for commented blue-box class
* fix: use same assertion as #35342
* fix: update Solution section
* fix: update last test for margin/padding challenges
* fix(challenge): allow new line in linear-gradient formatting
* fix(challenge): update test with suggested changes
* fix(challenge): update test to use computed style
* fix: added test case for empty li elements
* fix: added error message in test case of empty li elements.
* fix: corrected error in test case.
* fix: added valid working solution
* fix: migrated test case to challenge: create-an-ordered-list (working solution included)
* fix: adjusted condition for empty li elements and fixed typo.
* fixed typo with instructions and preview
Instructions stated that grid-template-columns was set to repeat(auto-fill, minmax(60px, 1fr)); but it was not in .container or .container2
Changed .container2 to already include this as I believe was intended, leaving camper to change .container on their own
Fixes#18034
* Update curriculum/challenges/english/01-responsive-web-design/css-grid/create-flexible-layouts-using-auto-fill.english.md
suggested change by @thecodingaviator
Co-Authored-By: bannon-tanner <bannon.n.tanner@gmail.com>
* possible fix for solution
* apply my suggestioned changes
* Make property names monospace
Property names as monospace would be more fitting to this challenge.
* Add default value for align-items
According to the standard, the default value for align-items, if it is not specified, is stretch.
Source: https://www.w3schools.com/cssref/css3_pr_align-items.asp
* Add monospace font for code elements
These elements need to be in a monospace font.
* fix: update color hex values and description of orange
* fix: Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/learn-about-tertiary-colors.english.md
Co-Authored-By: beaucarnes <beaucarnes@gmail.com>
* fix: add test that no color names are used
* ADD: transform affects DIV child contents
After spending some time figuring out how to prevent text in a div being skewed as well as the div, I think it is worth mentioning that applying a transform to a div element will also affect elements contained inside of it. Perhaps the transform challenge pages could include how to negate the effects of the transform on child elements of divs.
* Fix: moved my commit to Description
Moved my commit text into the Description section as suggested.
* Fix: Changed </div> to </code>
Changed the closing </div> tag to </code> as suggested.
* Fix: Changed markdown ** to <strong>
As advised on a previous pull request, I have removed the markdown ** ** and replaced it with HTML <strong></strong>.
* fix: challenge for basic html and html5 - test
* Delete use-if-and-else-to-add-logic-to-your-styles.english.md
* fix: Resolving merge conflict
* fix: basic-html-and html5 challenge - test
* modified wording to be more clear
wording on challenge instructions may have been unclear to some campers
changes "your" to "the" existing <code>a</code> element to make it more clear
* fix: removed change not needed
I am brand new to FCC and contributing on Github. I read the guide from FCC on best contributing practices, but this is all still very overwhelming to me. If I did something incorrectly in my first attempt at a pull request, please let me know.
* Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.english.md
* Use standard link for guide URLs
* fix: corrected guideUrl
* fix: corrected guideUrl again
* solution to Challenge ID:bad87fee1348bd9aedd08835
solution to Challenge ID:bad87fee1348bd9aedd08835 - Check Radio Buttons and Checkboxes by Default
* fix: solution
Eliminated the line (<code>rotate()</code> works the same way that <code>skewX()</code> and <code>skewY()</code> do).
It is incorrect. SkewX and SkewY do not work the same as rotate, perhaps in the sense that they take an argument ranging from 0 to 360deg, but they do not have the same effect.
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* Update change-the-color-of-text.english.md
* fix: corrected solution section syntax
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* fix: corrected solution section syntax
* I have updated the solution for this file.
I have added the expected output of the challenge seed code.
* Update add-a-submit-button-to-a-form.english.md
Placed solution in ```html tags
* Update add-a-submit-button-to-a-form.english.md
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* Update create-a-text-field.english.md
* fix: change language tag and remove wrong comment
* Sample solution for the file
I have updated the sample solution for the challenge seed code.
* Update add-images-to-your-website.english.md
formatted ```html tags
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.
Co-authored-by: Paul Gamble <pgamble@gmail.com>
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.
If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX
Co-authored-by: Paul Gamble <pgamble@gmail.com>
* Sample solution for the challenge seed code
I have updated the sample solution for the challenge seed code.
* Update headline-with-the-h2-element.english.md
Removed //solution required
Co-authored-by: Paul Gamble <pgamble@gmail.com>
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [x] My pull request targets the `master` branch of freeCodeCamp.
- [x] None of my changes are plagiarized from another source without proper attribution.
- [x] My article does not contain shortened URLs or affiliate links.
<!--If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.-->
Closes #XXXXX
Added a solution. Please let me know if this is submitted incorrectly or in the wrong location.
<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->
- [X] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [X] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [X] My pull request targets the `master` branch of freeCodeCamp.
- [X] None of my changes are plagiarized from another source without proper attribution.
- [X] My article does not contain shortened URLs or affiliate links.
If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX
Thank you for your pull request.
I am closing this pull request. Please add links and other details to the challenge’s corresponding guide article instead.
If you think I’m wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding.
@MP7373
* Added missing space
* Added missing period in add-borders-around-your-elements.md
* Added missing space in adjust-the-padding-of-an-element.english.md
I was doing this challenge and noticed that there wasn't a space after "transform:scale(2)" in the description which is inconsistent with the other challenges so I changed it to "transform: scale(2)"
* Clarification of the declaration order overriding
Previous text was talking about an override but it may also confuse readers that the override was done in the order of the listing of class names inside the h1.
I also added an extra case to better clarify the situation.
* Small change mentioning the order of declaration
Missed an order of declaration emphasis on my previous commit, adding it on this one.
* User Flow: Information, Articles, Youtube update
Explanation on what is User Flow with youtube videos and articles for reference and/or resource.
* Update of UX Design article
Update the article with more information and more links to articles and books.
* Product Design: Info, Articles, Youtube update
Explanation on what is Product Design with youtube videos and articles for reference and/or resource.
* Update description of Retina Display
As reported in issue #18129, there is a lack of explanation on what a retina display is and some users find it difficult to understand what they are doing exactly, so I added a short explanation on what a High-Resolution Display is and what a Retina Display is.
Randell Dawson
Huyen Nguyen
RIHANE ZAKARIA
Ian Effendi
Manish Giri
Catalina
Tom
Astrid
Beau Carnes
Paul Gamble
Aditi Joshi
Kyle Scheuerlein
lasjorg
Roberto Ruccia
Lipis
Oliver Eyton-Williams
Jean Jordaan
rupali317
Shashank Bairy R
NITIN BISHT
Gökhan Gurbetoğlu
Nathan Lakritz
Greg Brewton
Ron Sogueco
Vedrana_R
Dana Ottaviani
Bannon Tanner
nik
Alan Nguy
kevindelsh
The Coding Aviator
Chad
Lee
Randell Dawson
Riyaad Azad
Nelson Wu
Melkisedek Hamakali
Almaz Kunpeissov
Leo
Eunice Brackett
Dovid Majowka
Zach
Anas Salam
gokulsg
Howard T. Chiam
JustinBen-Tzioni
SGokul1
Cryotechnic
Naveen
Tammy
Brittany Sarenpa
Timur
Nelson Sandoval
Oleksii Pudlo
Zach Carroll
Casey Bennington
lucielchoi707
Quincy Larson
Luane
Kristofer Koishigawa
Ismael Casimpan
Lxsthorne
Anuj Jindal
Martin Payne
Lauren Van Sloun
Dennis Wolfers
Valeriy
Prakhar Yadav
c-stu
MackenzieThomasDevelopment
Martin
Bouncey
Jared