Commit Graph

433 Commits (a1a1978457b3eabcfab254b43a970ddec1b4483e)

Author SHA1 Message Date
Alister N. Mada a1a1978457 Fix IE compatibility issue for Font Size challenge 2016-02-02 19:59:09 +07:00
Quincy Larson 23aa1db530 Merge pull request #6562 from SaintPeter/fix/restore-es-translations
Restore Prior Spanish Translations to basic-javascript.json
2016-02-02 00:16:39 -08:00
Mrugesh Mohapatra 509ae8a6c5 Add Instructions Clarification to Using Objects for Lookups
This commit adds clarification to the Instructions.
Tested locally.
2016-02-02 02:17:56 +05:30
BKinahan a7869cf072 Changed 'will gives' to 'will give'
Corrected typo for challenge Generate Random Whole Numbers with Javascript, 'will gives' to 'will give'.
2016-02-01 11:24:19 +00:00
Berkeley Martinez dde01feca3 Merge pull request #6550 from QuincyLarson/fix/sample-watermark-certs
update sample certificate images and fix a couple other onboarding as…
2016-01-31 23:13:05 -08:00
Eric Leung cbcdb8df4f Clarify escape literal quotes instructions
- Change example quote to valid JavaScript
- Add example of what you will get if you print said example quote
- Place emphasis on "if" in the instructions so that it'll hopefully be clear
  you do not actually need to print it
2016-01-31 01:39:47 -08:00
Mrugesh Mohapatra a1d5bcce5e Add additional test cases to Roman Numeral
This commit adds additional test case to the Roman Numeral challenge.

It was possible to pass the tests with incorrect code, as seen in the
issue discussion.

Tested locally.

closes #6616
2016-01-31 11:53:52 +05:30
Rex Schrader ee2b7e5ef9 Merge pull request #6581 from raisedadead/fix/comparison-with-the-greater-than-or-equal-to-operator
Fix the test case for Comparison with operators
2016-01-30 11:35:53 -08:00
Rex Schrader 6292867132 Merge pull request #6583 from raisedadead/fix/undefined-is-not-explained
Add a hint to Return Early Pattern for Functions
2016-01-30 11:32:07 -08:00
Mrugesh Mohapatra 6761aa4aef Fix the test case for Comparison with operators
This commit fixes the test case with change to assert in one case,
and change to the test case message in another case.

I intentionally, changed the assert for one case and message for other

Tested locally.
2016-01-30 11:45:40 +05:30
Mrugesh Mohapatra 6af0f0f448 Add a hint to Return Early Pattern for Functions
This commit adds a hint as disccussed in the issue, to clarify,
the difference between `undefined` and `"undefined"`.

Tested locally.
2016-01-30 11:34:11 +05:30
Hallaathrad 7726989f9a Fix for "Multiple Identical Options in Switch Statements"
Corrects typo "ommitted".
Closes #6593
2016-01-29 22:58:29 -05:00
Rex Schrader 39b8ee0c97 Merge pull request #6567 from raisedadead/fix/introducing-javascript-object-notation-json
Fix the release year for Billy Joel - Piano Man
2016-01-29 09:26:52 -08:00
Mrugesh Mohapatra 2376c545ec Fix test case in Comparisons with the Logical And Operator
This fixes the test case to do the correct assert as per the message.

tested locally.
2016-01-29 13:55:59 +00:00
Mrugesh Mohapatra 74528cc98b Fix the release year for Billy Joel - Piano Man
This fixes the release year as mentioned in the issue.
Hope the fans will forgive us!

Tested locally.
closes #6561
2016-01-29 07:42:48 +00:00
SaintPeter dac587cb67 Restore Prior Spanish Translations to basic-javascript.json
Tested Locally

Please review, @vtamara
2016-01-28 20:07:34 -08:00
Rex Schrader ba78a4988a Merge pull request #6549 from robjloranger/fix/set-font-size-of-element
Fix for set the font size of an element
2016-01-28 18:47:37 -08:00
robjloranger e292de8cff fixed typo on test 1 555)555-5555 2016-01-28 12:25:34 -08:00
Rex Schrader 8da05a4b82 Merge pull request #6536 from AkiraLaine/edit/remove-terminology
removed depreciated terminology from certificate challenges
2016-01-28 10:59:17 -08:00
Rex Schrader 495022aebe Merge pull request #6529 from robjloranger/fix/all-greaterthan-quotes
Fix for greater than + less than quotes
2016-01-28 10:20:48 -08:00
Rex Schrader 9e65238886 Merge pull request #6535 from alistermada/fix/test-comparison-equality-operator
Fix test for Comparison with the Equality Operator
2016-01-28 10:16:42 -08:00
robjloranger 62d37763fa this fixes false positives and clears up instructions
trying out similar test to change the font family of an element

tried to better clarify instructions
2016-01-28 09:44:52 -08:00
Quincy Larson 14c6ae83ad update sample certificate images and fix a couple other onboarding assets to jive with new color scheme 2016-01-28 09:34:59 -08:00
Akira Laine 65d9398faf removed depreciated terminology from certificate challenges
made some edits

corrected backend certificate text
2016-01-28 19:10:33 +11:00
Alister N. Mada ce38b2931e Fix test for Comparison with the Equality Operator 2016-01-28 11:15:52 +07:00
robjloranger 3a2fb76fa0 fixing regex asserts
Changed all regex test to accept option single/double quotes around digits in comparrisons.
Used ('|\")*

Mistakenly had strict comparisons changed, reverted those.

fixed typo

one last typo

how did i miss so many errors

last error i hope

..last .. one ..
2016-01-28 03:15:13 +00:00
Timothy Cyrus c4c8fc8417 Update json-apis-and-ajax.json
Replace Multiple Line's of `<code>` blocks with `<blockquote>` to improve formatting
2016-01-27 21:58:56 -05:00
Berkeley Martinez 080d7e84a7 [HOTFIX] Fix step index type 2016-01-27 12:13:46 -08:00
Rex Schrader f487270d23 Merge pull request #6467 from tahmid-ul/fix/improve-assignment-with-a-returned-value
Assignment with a Returned Value - Improved Challenge Seed
2016-01-27 10:58:27 -08:00
Rex Schrader e4cf49807b Merge pull request #6455 from alistermada/fix/more-tests-basic-javascript
Add more tests for Basic JavaScript challenges
2016-01-27 10:55:59 -08:00
Tim Hordern 399cbdd3ce Adds spaces in CSS selectors for a consistent style 2016-01-26 23:22:21 -05:00
Logan Tegman 8c0c61a4b4 Merge pull request #6303 from dooglus/fix/allow_2_lorem_ipsum_words
Fix validation for "Fill in the Blank with Placeholder Text"
2016-01-26 19:54:44 -08:00
Tahmid ul karim f2adce323e Improved Challenge Seed
Assignment with a Returned Value .
2016-01-26 21:36:55 +06:00
Eric Leung c0dfcb1b39 Adds spaces between paragraphs
Tested locally. Closes #6374
2016-01-26 07:36:55 -08:00
Alister N. Mada 5a253e6027 Remove extra spaces from Basic Javascript challenge description 2016-01-26 17:24:21 +07:00
Alister N. Mada 5a1bbd158e Add more tests for Basic JavaScript challenges 2016-01-26 16:37:26 +07:00
Jason Jiang f9e81a13f3 Correct the array description of Chunky Monkey
The array required from the Chunky Monkey challenge is two-dimensional, not multidimensional.
The change has been made in both English and Spanish.
2016-01-26 15:28:53 +13:00
Rex Schrader cc05dfed22 Merge pull request #6445 from alistermada/fix/css-add-test-class-selector
Adds test for class selector in Prioritize One Style Over Another
2016-01-25 18:09:24 -08:00
Alister N. Mada 29d5b41b7e Adds test for class selector in Prioritize One Style Over Another 2016-01-26 08:27:17 +07:00
Alister N. Mada 146eb52345 Add more test cases for Make Object Properties Private 2016-01-26 06:31:30 +07:00
Rex Schrader e108861efa Merge pull request #6437 from raisedadead/fix/change-instruction-accesing-nested-objects-in-json
Fix the instruction text in the Accessing Nested objects challenge
2016-01-25 11:53:24 -08:00
Rex Schrader 2c0d6a4fa8 Merge pull request #6439 from alistermada/fix/html-css-tests
Fixes HMTL tests that don't accept classes in different order
2016-01-25 11:07:21 -08:00
Rex Schrader 97aaac1bc2 Merge pull request #6438 from Endi1/fix/class-issue-#6426
Fixes CSS test that didn't accept spaces between `color` and `:`
2016-01-25 10:58:20 -08:00
Tahmid ul karim 3c9cf77f38 Removed double quotes
closes #5825
2016-01-25 21:19:59 +06:00
Alister N. Mada b21d4020a5 Fix HTML tests that don't accept classes in different order 2016-01-25 19:46:40 +07:00
Endi Sukaj 8ee975a82d Fix for issue #6426
This is a fix for #6426
2016-01-25 13:25:12 +01:00
Mrugesh Mohapatra 8894ccd588 Fix the instruction text in the Accessing Nested objects challenge
This commit fixes the instruction text in the challenge to
`Use bracket notation for properties with a space in their name.`
from
`Only use object notation for properties with a space in their name.`
I have removed the extra `Only` on purpose for sake of grammar.

closes #6422
2016-01-25 12:13:50 +00:00
Arsen Melikyan 2c8952f9b3 Merge pull request #6415 from erictleung/fix/extra-spacing-in-editor
Remove unnecessary spaces in the editor
2016-01-25 11:11:25 +04:00
Arsen Melikyan 3a94ec2262 Merge pull request #6417 from erictleung/fix/add-open-new-tab-in-links
Added "target='_blank'" to links missing them
2016-01-25 11:09:56 +04:00
Eric Leung 2394fcc961 Added "target='_blank'" to links missing them 2016-01-24 12:46:30 -08:00