Commit Graph

313 Commits (a1a1978457b3eabcfab254b43a970ddec1b4483e)

Author SHA1 Message Date
Quincy Larson 23aa1db530 Merge pull request #6562 from SaintPeter/fix/restore-es-translations
Restore Prior Spanish Translations to basic-javascript.json
2016-02-02 00:16:39 -08:00
Mrugesh Mohapatra 509ae8a6c5 Add Instructions Clarification to Using Objects for Lookups
This commit adds clarification to the Instructions.
Tested locally.
2016-02-02 02:17:56 +05:30
BKinahan a7869cf072 Changed 'will gives' to 'will give'
Corrected typo for challenge Generate Random Whole Numbers with Javascript, 'will gives' to 'will give'.
2016-02-01 11:24:19 +00:00
Eric Leung cbcdb8df4f Clarify escape literal quotes instructions
- Change example quote to valid JavaScript
- Add example of what you will get if you print said example quote
- Place emphasis on "if" in the instructions so that it'll hopefully be clear
  you do not actually need to print it
2016-01-31 01:39:47 -08:00
Rex Schrader ee2b7e5ef9 Merge pull request #6581 from raisedadead/fix/comparison-with-the-greater-than-or-equal-to-operator
Fix the test case for Comparison with operators
2016-01-30 11:35:53 -08:00
Rex Schrader 6292867132 Merge pull request #6583 from raisedadead/fix/undefined-is-not-explained
Add a hint to Return Early Pattern for Functions
2016-01-30 11:32:07 -08:00
Mrugesh Mohapatra 6761aa4aef Fix the test case for Comparison with operators
This commit fixes the test case with change to assert in one case,
and change to the test case message in another case.

I intentionally, changed the assert for one case and message for other

Tested locally.
2016-01-30 11:45:40 +05:30
Mrugesh Mohapatra 6af0f0f448 Add a hint to Return Early Pattern for Functions
This commit adds a hint as disccussed in the issue, to clarify,
the difference between `undefined` and `"undefined"`.

Tested locally.
2016-01-30 11:34:11 +05:30
Hallaathrad 7726989f9a Fix for "Multiple Identical Options in Switch Statements"
Corrects typo "ommitted".
Closes #6593
2016-01-29 22:58:29 -05:00
Rex Schrader 39b8ee0c97 Merge pull request #6567 from raisedadead/fix/introducing-javascript-object-notation-json
Fix the release year for Billy Joel - Piano Man
2016-01-29 09:26:52 -08:00
Mrugesh Mohapatra 2376c545ec Fix test case in Comparisons with the Logical And Operator
This fixes the test case to do the correct assert as per the message.

tested locally.
2016-01-29 13:55:59 +00:00
Mrugesh Mohapatra 74528cc98b Fix the release year for Billy Joel - Piano Man
This fixes the release year as mentioned in the issue.
Hope the fans will forgive us!

Tested locally.
closes #6561
2016-01-29 07:42:48 +00:00
SaintPeter dac587cb67 Restore Prior Spanish Translations to basic-javascript.json
Tested Locally

Please review, @vtamara
2016-01-28 20:07:34 -08:00
Rex Schrader 495022aebe Merge pull request #6529 from robjloranger/fix/all-greaterthan-quotes
Fix for greater than + less than quotes
2016-01-28 10:20:48 -08:00
Alister N. Mada ce38b2931e Fix test for Comparison with the Equality Operator 2016-01-28 11:15:52 +07:00
robjloranger 3a2fb76fa0 fixing regex asserts
Changed all regex test to accept option single/double quotes around digits in comparrisons.
Used ('|\")*

Mistakenly had strict comparisons changed, reverted those.

fixed typo

one last typo

how did i miss so many errors

last error i hope

..last .. one ..
2016-01-28 03:15:13 +00:00
Rex Schrader f487270d23 Merge pull request #6467 from tahmid-ul/fix/improve-assignment-with-a-returned-value
Assignment with a Returned Value - Improved Challenge Seed
2016-01-27 10:58:27 -08:00
Rex Schrader e4cf49807b Merge pull request #6455 from alistermada/fix/more-tests-basic-javascript
Add more tests for Basic JavaScript challenges
2016-01-27 10:55:59 -08:00
Tahmid ul karim f2adce323e Improved Challenge Seed
Assignment with a Returned Value .
2016-01-26 21:36:55 +06:00
Eric Leung c0dfcb1b39 Adds spaces between paragraphs
Tested locally. Closes #6374
2016-01-26 07:36:55 -08:00
Alister N. Mada 5a253e6027 Remove extra spaces from Basic Javascript challenge description 2016-01-26 17:24:21 +07:00
Alister N. Mada 5a1bbd158e Add more tests for Basic JavaScript challenges 2016-01-26 16:37:26 +07:00
Rex Schrader e108861efa Merge pull request #6437 from raisedadead/fix/change-instruction-accesing-nested-objects-in-json
Fix the instruction text in the Accessing Nested objects challenge
2016-01-25 11:53:24 -08:00
Tahmid ul karim 3c9cf77f38 Removed double quotes
closes #5825
2016-01-25 21:19:59 +06:00
Mrugesh Mohapatra 8894ccd588 Fix the instruction text in the Accessing Nested objects challenge
This commit fixes the instruction text in the challenge to
`Use bracket notation for properties with a space in their name.`
from
`Only use object notation for properties with a space in their name.`
I have removed the extra `Only` on purpose for sake of grammar.

closes #6422
2016-01-25 12:13:50 +00:00
Arsen Melikyan 2c8952f9b3 Merge pull request #6415 from erictleung/fix/extra-spacing-in-editor
Remove unnecessary spaces in the editor
2016-01-25 11:11:25 +04:00
Arsen Melikyan 3a94ec2262 Merge pull request #6417 from erictleung/fix/add-open-new-tab-in-links
Added "target='_blank'" to links missing them
2016-01-25 11:09:56 +04:00
Eric Leung 2394fcc961 Added "target='_blank'" to links missing them 2016-01-24 12:46:30 -08:00
Eric Leung d6250452db Remove extra word of 'use' in range challenge 2016-01-24 12:24:41 -08:00
Eric Leung 09085a04a9 Remove unnecessary spaces in the editor 2016-01-24 12:19:26 -08:00
Tahmid ul karim dee07e7980 fixed an issue #6380 .... basic-javascript.json
added 'or' in between greater than equal to.
2016-01-23 01:43:22 +06:00
greyhammer bf4edcd0e6 fixed typo in seed/challenges/01-front-end-development-certification/basic-javascript.json, removed extra , at the end of the array 2016-01-22 08:16:38 -06:00
Eric Leung 52da4a599e Remove extra parenthesis in unshift challenge 2016-01-21 22:17:05 -08:00
Arsen Melikyan 60e0c8d3c9 Merge pull request #6337 from SaintPeter/fix/record-collection-description
Update Record Collection with Bracket Notation Note
2016-01-21 22:02:35 +04:00
Rex Schrader feb466e109 Merge pull request #6357 from ChristianLapinig/fix/basic_js-comparison_eqaulity_operator-correct_instructions
Grammar fix for Comparison with the Equality Operator
2016-01-21 08:56:33 -08:00
Rex Schrader 6dee7b0e28 Update Record Collection with Bracket Notation Note 2016-01-21 08:53:59 -08:00
Christian Lapinig 026745c22b Correct grammar for instructions 2016-01-20 23:23:57 -08:00
SaintPeter 0c40a0599e Normalize Challenges for COM1000 2016-01-20 15:45:32 -08:00
Rex Schrader 92712c6e94 Merge pull request #6341 from erictleung/fix/clarify-instructions-for-dot-operator
Clarify instructions for dot operator challenge
2016-01-20 12:42:26 -08:00
Eric Leung b20914ae44 Clarify instructions for dot operator challenge 2016-01-19 23:36:36 -08:00
Eric Leung 55a6ec68d3 Be more specific on what decimal number is needed 2016-01-19 21:15:28 -08:00
Rex Schrader 0bf884e55a Merge pull request #6316 from raisedadead/fix/remove-typeof-error-basic-javascript
Remove unnecessary parentheses around the typeof
2016-01-19 12:56:08 -08:00
Mrugesh Mohapatra feddce4c3b Remove unnecessary parentheses around the typeof
This commit:
    * removes unnecessary parentheses around the typeof
    * certain cases were ignored, to prevent a test case failure for example as in:
       - assert(typeof(runSlots($(\".slot\"))[0]) ...

This PR is an additional fix in relation to code review comments on FreeCodeCamp/FreeCodeCamp#6181
2016-01-19 14:17:43 +00:00
Alister N. Mada 4122ca41ef Fix inconsistent font sizes in challenge descriptions 2016-01-19 16:41:53 +07:00
Rex Schrader 53bd841f9f Merge pull request #6300 from joshuahenson/fix/default-switch-challenge
Correct typo on default switch challenge
2016-01-18 21:13:38 -08:00
Derek Keith 510af2810b Remove code blocks within blockquotes.
This removes code blocks within blockquotes on the following challenges:

- Access MultiDimensional Arrays With Indexes
- Understand String Immutability

closes #6283
2016-01-18 21:33:07 -07:00
Joshua Henson cb34bd232e Correct typo on default switch challenge 2016-01-18 20:02:16 -08:00
Arsen Melikyan 7b5d04b78c Merge pull request #6274 from erictleung/fix/myStr-in-code-tags
Add code tags to myStr in instructions
2016-01-18 10:03:15 +04:00
Eric Leung bcb7717b0e Add code tags to myStr in instructions 2016-01-17 21:56:12 -08:00
Eric Leung 5ee869ef49 Clarify instructions and remove code tag from test 2016-01-17 21:45:56 -08:00