Commit Graph

1240 Commits (a91444d3d428e04534f4ae6aa0994092fd5c5adf)

Author SHA1 Message Date
gikf a91444d3d4
fix: correct function call in test description (#40944) 2021-02-20 12:03:33 +05:30
Kelvin Sánchez f08174b5b1
fix(learn): Remove unnecessary inline code tag in challenge (#41177)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-19 09:44:50 +05:30
Kelvin Sánchez fad168b465
fix(learn): fix some code tags, capitalization and punctuation in challenge (#41161)
* fix some code tags, capitalization and punctuation

Note: The reserved word in JavaScript is "boolean", so I think it is appropriate to use it like this inside the code tags.

* Remove code tags and capitalize first letter

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* capitalize letter and replace slash

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:45:12 -07:00
Kelvin Sánchez 2c1280af65
fix(learn): Improve the clarity on a challenge sentence (#41154)
* Improve the clarity on a challenge sentence

* add string type and remove double quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-18 08:29:31 -07:00
gikf 762775889e
fix: rework Project Euler - Problem 57 (#40926)
* fix: rework challenge to use argument in function

* fix: add solution

* fix: correct variable name
2021-02-17 11:58:18 -08:00
Kelvin Sánchez 1fe1371b16
add missing inline-code block (#41153) 2021-02-17 11:24:53 -08:00
Joshua Pelealu 10aee18748
Remove broken twitter links (#41152) 2021-02-17 12:03:57 -07:00
Kelvin Sánchez b45406ec9d
fix(learn): Remove repeated definition tag in challenge (#41151) 2021-02-17 23:01:42 +05:30
Joshua Pelealu c15c27f474
fix(learn): Added another test to check for invalid characters (#41144) 2021-02-17 21:16:07 +05:30
fots 2a2657d36c
fix: update regex for Convert JSON Data to HTML (#41134)
* fix: updated solution for Convert JSON Data to HTML

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/04-data-visualization/json-apis-and-ajax/convert-json-data-to-html.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-02-16 16:27:47 +00:00
Nicholas Carrigan (he/him) 21c7abf584
fix(learn): update challenge for crowdin (#41089) 2021-02-16 19:47:40 +05:30
Supritha ee6764519d
REMOVED comments (#41048)
* Added comments

Fixes freeCodeCamp/freeCodeCamp#40903

* remove comments
2021-02-11 09:13:38 -07:00
Kristofer Koishigawa c9de726d6a
feat: move Repl.it links to first challenge in backend projects (#40803) 2021-02-11 14:09:59 +05:30
gikf 6ae3735979
fix: correct tests descriptions (#40945) 2021-02-10 17:12:12 +05:30
ehsabd 9f219f3f2b
fix(learn): Fix the public assets folder confusion by giving it its own folder (#40802)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-10 17:11:40 +05:30
Kim Leung 082b269dce
fix(learn): backslashes in description & hint text (#40801)
Correct example code in description and last hints text to match the last assertion test's actual and expected inputs.  The string input with a single backslash throws an unterminated string constant error (single backslash starts a regex).  No change to last assertion test as it was written correctly with a double backslash and passing as expected.
2021-02-10 17:10:51 +05:30
Lucas Sorenson f8aa6c04e2
fix(learn): update seed code for D3.js challenge (#40699)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Lucas Sorenson <lsorenson@sunsh1n3.com>
2021-02-10 17:06:19 +05:30
Ismail Tlemçani 0f8449788c
feat(learn): add tests to use a callback function in the sort method (#40847) 2021-02-10 17:05:23 +05:30
Tom 959fe8323a
fix(learn): mongoose set up instructions (#40909)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-10 17:04:16 +05:30
Tom 51f6077f7b
fix(learn): regex-criminal-in-hunt-challenge (#40901)
* fix: regex-criminal-in-hunt-challenge

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/find-one-or-more-criminals-in-a-hunt.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-08 06:10:59 -08:00
Jean-Baptiste LARRIVIERE 1c539d07c3
fix(curriculum): remove mention of null from challenge (#40942)
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-02-08 13:17:32 +05:30
Tom 15227a0148
fix(curriculum): helmet install and csp lessons (#40904) 2021-02-06 16:36:40 +00:00
Randell Dawson 167f93df76
fix(learn): Add inline code blocks to for i18n (#40921) 2021-02-05 14:16:19 +05:30
Shaun Hamilton 1a9b791f29
update(curriculum): explicitise use-the-env-file (#40898)
* update(curriculum): explicitise use-the-env-file

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-04 19:43:18 +01:00
Nicholas Carrigan (he/him) 12658d33fc
fix(i18n, learn): more crowdin fixes (#40905) 2021-02-04 13:34:44 +05:30
Tom 30c923b73d
fix(curriculum): helmet hide-powered-by description (#40900)
* fix: remove option that isn't usable in new version of helmet

* fix: make text instructional
2021-02-03 23:13:02 +00:00
Keith c21b2a9707
fix(learn): corrected typo (#40902)
Fixed typo at the end of the 4th paragraph. Changed "Others options include:" to "Other options include:".
2021-02-03 15:11:44 -08:00
Guilherme Dias Simões ddf495c335
Fix 'wrap' and 'wrap-reverse' definitions. (#40766)
The definitions for the options 'wrap' and 'wrap-reverse' were slightly wrong as can be seen by applying them to the challenge.
2021-02-03 13:01:43 -06:00
gikf 313b345611
fix: correct Rosetta Code Knight's tour solution (#40830)
* fix: correct answers in tests and descriptions

* fix: replace sample solution for correct one

* fix: missing space

* fix: improve sample solution performance
2021-02-03 12:43:29 -06:00
Nicholas Carrigan (he/him) b0bd3f5549
fix(learn): abstract comments from code (#40869) 2021-02-03 22:28:33 +05:30
Nicholas Carrigan (he/him) 4d48fb5ce7
fix(learn, i18n): crowdin issues (#40884)
Resolves a couple of issues with Crowdin parsing.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>
2021-02-02 14:08:32 -07:00
Oliver Eyton-Williams 66b684807c chore: migrate certs from .markdown to .yml 2021-02-02 09:51:02 +05:30
Nicholas Carrigan (he/him) 427444c757
chore(learn): audit files for crowdin (#40838)
* chore(learn): audit files for crowdin

Audits the challenge text in the Responsive Web Design superblock to
account for words/phrases that should not be translated because they
refer to code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove quotes from code

Removes instances of quoted code blocks, or code blocked quotes.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: additional uncaught quote-codes

Thanks Oliver :)

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: so many quotes

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: missing punctuation

Noted in a Crowdin comment.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: remove more quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-01 12:56:07 -07:00
Luis H. Ball Jr 8d60aad97b
feat(curriculum): add extension tests for css-flexbox curriculum modules (#40473)
* feat(curriculum): add extension tests for css-flexbox curriculum modules

* apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* fix: reorder tests

Moves the test that asserts the presence of the follow button to the
top of the order.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-02-01 07:57:36 -08:00
Kim Leung a37d5f5817
fix(learn): add output type verbiage (#40589)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-01 19:41:15 +05:30
Nicholas Carrigan (he/him) 18e821bcd3
fix: remove clunky sentence (#40751) 2021-02-01 19:22:39 +05:30
Hernando Guzmán f63ca27e6a
Fix: corrected the typo (#40837)
Updated run-functional-tests-using-a-headless-browser.md to correct the typo
2021-02-01 06:52:11 -07:00
Randell Dawson 22f017caa2
fix(learn): replace single bactick with <code> tag for Crowdin (#40774) 2021-02-01 19:09:13 +05:30
Kai-Chin Huang 5503b54f85
fix(learn): update the return Object.values & solution (#40451) 2021-02-01 13:12:54 +05:30
Evan Boehs 8c22432b17
fix(learn): add period for readability (#40836) 2021-01-31 13:57:46 +05:30
Hernando Guzmán 3394a654bd
fix(learn): Correct syntax in the code example (#40811)
Closes #40810
2021-01-27 11:03:22 -08:00
gikf d41630ee19
fix(learn): clarify test description for Use Rest Parameter with Function Parameter (#40725)
* fix: clarify test description

* fix: improve wording regarding rest parameters syntax

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: improve with better sounding wording

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-24 08:30:13 -08:00
Mainak Debnath d5ad87d915
fix(learn): put test cases under --seed-- and remove them from the solution (#40755)
* fix: put test cases under --seed--

* fix: put test cases under --seed--
2021-01-21 18:26:06 -08:00
Shaun Hamilton ce3a20e552
fix(learn): change requirements for positive and negative lookaheads (#40570) 2021-01-21 15:35:19 -06:00
Lasse Jørgensen f2b1d7b147
fix(challenge): Assert arrays contain expected values (#40693) 2021-01-21 10:52:52 -08:00
Ilenia a38922536c
Adding language to code fences and pre to console logs (#40603)
* added languages to prismjs

* added language to code fences for python for everybody

* multiline pre to python for everybody questions

* multiline pre for data analysis with python

* multiline pre in numpy questions

* single line pre for python for everybody

* single line pre for data analysis with python

* single line pre for numpy

* Revert "multiline pre in numpy questions"

This reverts commit af1a02cdd3.

* fix unneded escaping

commit suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Revert "single line pre for numpy"

This reverts commit 5f90981108.

* revert changes to snippet that have a language

* one last code fence to pre

* Revert "fix unneded escaping
"

This reverts commit 64c84a9213.

* Revert "single line pre for data analysis with python"

This reverts commit 3bccaff753.

* Revert "single line pre for python for everybody"

This reverts commit 03a5379062.

* remove unnecessary escape

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
2021-01-21 12:12:42 -06:00
Nicholas Carrigan (he/him) 8e62a243bb
fix(learn): Update demo links (#40575)
* fix(learn): Replace demo projects

Replaces the Heroku demo project links with the
.rocks demo projects that @moT01 provided.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(learn): Use correct endpoint

Corrects the API endpoint for the image search
project.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: user stories to align with project + backticks

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2021-01-21 11:09:35 -06:00
Durbatuluk1701 0a7aa59d51
fix(learn): Convert response testcase regex handles any variable name (#40568)
* Update convert response to JSON testcase

Testcase previously required that variable be named exactly "response". Changes will allow variable of any name to be used.
Example: res can now be used and tests still pass.

* Forgot the \ in front of )
2021-01-21 08:54:24 -08:00
matias-miller 8a9f3319c6
fix(learn): Fixed typos in count-backwards-with-a-for-loop.md (#40478)
* Spelling change in count-backwards-with-a-for-loop

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-01-21 08:44:10 -08:00
Mukesh Gurpude a5dceb3e7e
Fixed error when changing the default order of css properties (#40525)
* Bug with psoitioning

Fixed bug with positioning of background-color` property for Selector `.heart::after`

* Trying new changes

* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/create-a-more-complex-shape-using-css-and-html.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Tests passing

Check the regex matching at [Regex101](https://regex101.com/r/GU18ds/4)

* fixed typo

* applied suggestions

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-01-21 10:17:16 -06:00